Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove usage of raw event coordinates for touch slop calculation

Browse Source 
- This change was added in ag/3737691 for 2 button mode which is now
  removed from the system, using the raw coordinates is problematic
  since they depend on device orientation

Bug: 231636998
Test: Enable 3 button, rotate to landscape and verify unpinning works
Change-Id: I3f942a00570d516a7642182ff1412b17cd5464ff
This commit is contained in:
Winson Chung
2022-05-11 18:49:29 +00:00
parent 827c5557cd
commit 0c4b89a6fe
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/SystemUI/src/com/android/systemui/navigationbar/buttons/KeyButtonView.java
View File

@@ -273,9 +273,8 @@ public class KeyButtonView extends ImageView implements ButtonInterface {
mLongClicked = false;
setPressed(true);
// Use raw X and Y to detect gestures in case a parent changes the x and y values
mTouchDownX = (int) ev.getRawX();
mTouchDownY = (int) ev.getRawY();
mTouchDownX = (int) ev.getX();
mTouchDownY = (int) ev.getY();
if (mCode != KEYCODE_UNKNOWN) {
sendEvent(KeyEvent.ACTION_DOWN, 0, mDownTime);
} else {
@@ -289,8 +288,8 @@ public class KeyButtonView extends ImageView implements ButtonInterface {
postDelayed(mCheckLongPress, ViewConfiguration.getLongPressTimeout());
break;
case MotionEvent.ACTION_MOVE:
x = (int)ev.getRawX();
y = (int)ev.getRawY();
x = (int) ev.getX();
y = (int) ev.getY();
float slop = QuickStepContract.getQuickStepTouchSlopPx(getContext());
if (Math.abs(x - mTouchDownX) > slop || Math.abs(y - mTouchDownY) > slop) {