Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Midi: Use exceptionCode instead of transactionError

Browse Source 
Use of binder::Status exceptionCode is more reliable than
transactionError, especially when calling a Java service.

Test: builds
Bug: 175361278
Change-Id: Iaafb1007f07c7abc22985f0d63f23a0358d6b194
This commit is contained in:
Andy Hung
2020-12-10 21:56:01 -08:00
parent 7db7b68b9d
commit 0a8c907f68
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
media/native/midi/amidi.cpp
View File

@@ -131,7 +131,7 @@ static media_status_t AMIDI_getDeviceInfo(const AMidiDevice *device,
MidiDeviceInfo deviceInfo;
Status txResult = device->server->getDeviceInfo(&deviceInfo);
if (!txResult.isOk()) {
ALOGE("AMIDI_getDeviceInfo transaction error: %d", txResult.transactionError());
ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
return AMEDIA_ERROR_UNKNOWN;
}
@@ -253,7 +253,7 @@ static media_status_t AMIDI_openPort(const AMidiDevice *device, int32_t portNumb
? device->server->openOutputPort(portToken, portNumber, &ufd)
: device->server->openInputPort(portToken, portNumber, &ufd);
if (!txResult.isOk()) {
ALOGE("AMIDI_openPort transaction error: %d", txResult.transactionError());
ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
return AMEDIA_ERROR_UNKNOWN;
}
@@ -282,7 +282,7 @@ static void AMIDI_closePort(AMIDI_Port *port) {
Status txResult = port->device->server->closePort(port->binderToken);
if (!txResult.isOk()) {
ALOGE("Transaction error closing MIDI port:%d", txResult.transactionError());
ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
}
delete port;