Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove implicit camera/microphone process capability for BOUND_TOP and BOUND_FOREGROUND_SERVICE state.

Browse Source 
Should migrate toward BIND_INCLUDE_CAPABILITY.

Bug: 150890235
Test: atest cts/tests/app/src/android/app/cts/ActivityManagerProcessStateTest.java#testTopBind
Change-Id: If61aa5f7c94ce0aab89dd0e38608fdba3956d858
This commit is contained in:
Hui Yu
2020-03-05 15:27:32 -08:00
parent 29c8617d36
commit 081b14ccd5
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
services/core/java/com/android/server/am/OomAdjuster.java
View File

@@ -1708,11 +1708,6 @@ public final class OomAdjuster {
// TOP process passes all capabilities to the service.
capability |= PROCESS_CAPABILITY_ALL;
}
} else if (clientProcState
<= PROCESS_STATE_FOREGROUND_SERVICE) {
if (cr.notHasFlag(Context.BIND_INCLUDE_CAPABILITIES)) {
clientProcState = PROCESS_STATE_FOREGROUND_SERVICE;
}
}
} else if ((cr.flags & Context.BIND_IMPORTANT_BACKGROUND) == 0) {
if (clientProcState <
@@ -2036,7 +2031,7 @@ public final class OomAdjuster {
case PROCESS_STATE_TOP:
return PROCESS_CAPABILITY_ALL;
case PROCESS_STATE_BOUND_TOP:
return PROCESS_CAPABILITY_ALL_IMPLICIT;
return PROCESS_CAPABILITY_NONE;
case PROCESS_STATE_FOREGROUND_SERVICE:
if (app.hasForegroundServices()) {
// Capability from FGS are conditional depending on foreground service type in
@@ -2044,10 +2039,12 @@ public final class OomAdjuster {
return PROCESS_CAPABILITY_NONE;
} else {
// process has no FGS, the PROCESS_STATE_FOREGROUND_SERVICE is from client.
// the implicit capability could be removed in the future, client should use
// BIND_INCLUDE_CAPABILITY flag.
return PROCESS_CAPABILITY_ALL_IMPLICIT;
}
case PROCESS_STATE_BOUND_FOREGROUND_SERVICE:
return PROCESS_CAPABILITY_ALL_IMPLICIT;
return PROCESS_CAPABILITY_NONE;
default:
return PROCESS_CAPABILITY_NONE;
}