Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix the premature hiding of notifications while expanding QS.

Browse Source 
This MAY be a fix for an issue where all notifications in the shade disappear, which appears to be caused by getInnerHeight returning the wrong value.  However, I can't repro (or therefore demonstrate the fix works in that case).

Fixes: 188330819
Bug: 191459880
Test: Expand the QS and notice that now the notifications do not disappear.
Change-Id: I21f03dbb162290df540ec23955abe90ee686b696
This commit is contained in:
Jeff DeCew
2021-06-28 20:46:29 -04:00
parent 4e229f4471
commit 053aa62791
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/StackScrollAlgorithm.java
View File

@@ -420,8 +420,9 @@ public class StackScrollAlgorithm {
// When pulsing (incoming notification on AOD), innerHeight is 0; clamp all
// to shelf start, thereby hiding all notifications (except the first one, which we
// later unhide in updatePulsingState)
final int shelfStart = ambientState.getInnerHeight()
- ambientState.getShelf().getIntrinsicHeight();
final int stackBottom = !ambientState.isShadeExpanded() || ambientState.isDozing()
? ambientState.getInnerHeight() : (int) ambientState.getStackHeight();
final int shelfStart = stackBottom - ambientState.getShelf().getIntrinsicHeight();
viewState.yTranslation = Math.min(viewState.yTranslation, shelfStart);
if (viewState.yTranslation >= shelfStart) {
viewState.hidden = !view.isExpandAnimationRunning()