Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

The transformhelper now also transforms gone views

Browse Source 
Because a notification's views could change from GONE
to VISIBLE without notifying the transformhelper, we're
now adding the transformed views even if they are gone
at the resolution time.
This fixes a bug where the Time would fade in / out
properly.

This also fixes another bug where the time could remain
invisible.

Test: add notification group without any header text and observe smooth fading when expanding group
Change-Id: I1d6b0126df1550a71baa2e7729bdf9664b934b02
Fixes: 35127160
This commit is contained in:
Selim Cinek
2017-02-09 18:15:48 -08:00
parent 87ed69bd6b
commit 00708abfe6
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/SystemUI/src/com/android/systemui/statusbar/ViewTransformationHelper.java
View File

@@ -224,9 +224,6 @@ public class ViewTransformationHelper implements TransformableView {
stack.push(viewRoot);
while (!stack.isEmpty()) {
View child = stack.pop();
if (child.getVisibility() == View.GONE) {
continue;
}
Boolean containsView = (Boolean) child.getTag(TAG_CONTAINS_TRANSFORMED_VIEW);
if (containsView == null) {
// This one is unhandled, let's add it to our list.

3
packages/SystemUI/src/com/android/systemui/statusbar/notification/TransformState.java
View File

@@ -69,7 +69,8 @@ public class TransformState {
public void transformViewFrom(TransformState otherState, float transformationAmount) {
mTransformedView.animate().cancel();
if (sameAs(otherState)) {
if (mTransformedView.getVisibility() == View.INVISIBLE) {
if (mTransformedView.getVisibility() == View.INVISIBLE
|| mTransformedView.getAlpha() != 1.0f) {
// We have the same content, lets show ourselves
mTransformedView.setAlpha(1.0f);
mTransformedView.setVisibility(View.VISIBLE);