From 936a90730605ad8fd289de975a37bc0ded1a1eb9 Mon Sep 17 00:00:00 2001
From: Pranav Vashi <neobuddy89@gmail.com>
Date: Mon, 14 Jul 2025 10:38:55 +0700
Subject: [PATCH] build: Ship adb_root only WITH_SU

* TBH - hardly any user uses adb root.
* adb root poses root detection risks.
* Most devices are user or userbuild type.

Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
---
 config/common.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/config/common.mk b/config/common.mk
index a921d592..8c288e1b 100644
--- a/config/common.mk
+++ b/config/common.mk
@@ -269,11 +269,12 @@ PRODUCT_ARTIFACT_PATH_REQUIREMENT_ALLOWED_LIST += \
     system/bin/procmem
 endif
 
+ifneq ($(TARGET_BUILD_VARIANT),user)
+ifeq ($(WITH_SU),true)
 # Root
 PRODUCT_PACKAGES += \
     adb_root
-ifneq ($(TARGET_BUILD_VARIANT),user)
-ifeq ($(WITH_SU),true)
+
 PRODUCT_PACKAGES += \
     su