DO disclosures referring to actions that the admin did not actually take are hidden in the UI, but still show up in the search index. This CL switches the remaining PreferenceControllers from setting visibility to implementing isAvailable() instead. Bug: 32692748 Test: m RunSettingsRoboTests Change-Id: I54360698f28b549b18cdc230e3b9087cf4e9ff4a
92 lines
3.8 KiB
Java
92 lines
3.8 KiB
Java
|
|
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software distributed under the
|
|
* License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the specific language governing
|
|
* permissions and limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.enterprise;
|
|
|
|
import android.content.Context;
|
|
import android.content.Intent;
|
|
import android.support.v7.preference.Preference;
|
|
|
|
import com.android.settings.R;
|
|
import com.android.settings.applications.ApplicationFeatureProvider;
|
|
import com.android.settings.core.DynamicAvailabilityPreferenceController;
|
|
import com.android.settings.core.lifecycle.Lifecycle;
|
|
import com.android.settings.overlay.FeatureFactory;
|
|
|
|
public abstract class AdminGrantedPermissionsPreferenceControllerBase
|
|
extends DynamicAvailabilityPreferenceController {
|
|
|
|
private final String[] mPermissions;
|
|
private final String mPermissionGroup;
|
|
private final ApplicationFeatureProvider mFeatureProvider;
|
|
private final boolean mAsync;
|
|
|
|
public AdminGrantedPermissionsPreferenceControllerBase(Context context, Lifecycle lifecycle,
|
|
boolean async, String[] permissions, String permissionGroup) {
|
|
super(context, lifecycle);
|
|
mPermissions = permissions;
|
|
mPermissionGroup = permissionGroup;
|
|
mFeatureProvider = FeatureFactory.getFactory(context)
|
|
.getApplicationFeatureProvider(context);
|
|
mAsync = async;
|
|
}
|
|
|
|
@Override
|
|
public void updateState(Preference preference) {
|
|
mFeatureProvider.calculateNumberOfAppsWithAdminGrantedPermissions(mPermissions,
|
|
true /* async */,
|
|
(num) -> {
|
|
if (num == 0) {
|
|
preference.setVisible(false);
|
|
} else {
|
|
preference.setVisible(true);
|
|
preference.setSummary(mContext.getResources().getQuantityString(
|
|
R.plurals.enterprise_privacy_number_packages_actionable, num, num));
|
|
}
|
|
});
|
|
}
|
|
|
|
@Override
|
|
public boolean isAvailable() {
|
|
if (mAsync) {
|
|
// When called on the main UI thread, we must not block. Since calculating the number of
|
|
// apps that the admin has granted a given permissions takes a bit of time, we always
|
|
// return true here and determine the pref's actual visibility asynchronously in
|
|
// updateState().
|
|
return true;
|
|
}
|
|
|
|
// When called by the search indexer, we are on a background thread that we can block. Also,
|
|
// changes to the pref's visibility made in updateState() would not be seen by the indexer.
|
|
// We block and return synchronously whether the admin has granted the given permissions to
|
|
// any apps or not.
|
|
final Boolean[] haveAppsWithAdminGrantedPermissions = { null };
|
|
mFeatureProvider.calculateNumberOfAppsWithAdminGrantedPermissions(mPermissions,
|
|
false /* async */, (num) -> haveAppsWithAdminGrantedPermissions[0] = num > 0);
|
|
return haveAppsWithAdminGrantedPermissions[0];
|
|
}
|
|
|
|
@Override
|
|
public boolean handlePreferenceTreeClick(Preference preference) {
|
|
if (!getPreferenceKey().equals(preference.getKey())) {
|
|
return false;
|
|
}
|
|
final Intent intent = new Intent(Intent.ACTION_MANAGE_PERMISSION_APPS)
|
|
.putExtra(Intent.EXTRA_PERMISSION_NAME, mPermissionGroup);
|
|
mContext.startActivity(intent);
|
|
return true;
|
|
}
|
|
}
|