Commit Graph

1104 Commits

Author SHA1 Message Date
josephpv
8f30977859 Update title in Face and Fingerprint settings for private space
Screenshots:
b/335748976#comment9

Bug: 335748976
Test: Manual
Change-Id: I3d99488f33177d4ac4aa2e4bb3c420604460ac72
2024-05-31 01:54:32 +00:00
Jigar Thakkar
176f1a630a Do not request confirmation by default for private space unlocks
Fix face unlock confirmation button behavior to respect "always
require confirmation" setting. Adjust the description of the
confirmation toggle in private space face unlock settings to
reflect this change.
Screenshot: https://screenshot.googleplex.com/4uHfm9Z3ZE56ZaT.png

Bug: 342383195
Test: Tested manually by flashing local build
Change-Id: I0f742839a862fe66cacad9f5704dbe8b0df3a0c2
2024-05-28 17:59:17 +00:00
Treehugger Robot
f91bd7ba24 Merge "Extend SfpsEnrollmentFeature for text updating when progress changes" into main 2024-05-27 15:38:22 +00:00
Wu Ahan
25ce76f667 Extend SfpsEnrollmentFeature for text updating when progress changes
Bug: 341693248
Test: atest SfpsEnrollmentFeatureImplTest
Change-Id: I63576f129f4453d4db088adfaa472df797823514
2024-05-27 03:05:55 +00:00
josephpv
c5611bfbc1 Face and fingerprint unlock strings for private space
Recordings:
b/326399895#comment10

Bug: 326399895
Test: Manual
Change-Id: I9f4449439639c93a10475333a91059f855bce07b
2024-05-24 05:00:44 +00:00
Joshua Mccloskey
dd88792a5b Merge "UDFPS Enrollment Refactor (6/N)" into main 2024-05-23 18:26:10 +00:00
Treehugger Robot
ea47aabe22 Merge "Fixed FaceEnrollIntro crash." into main 2024-05-22 03:21:04 +00:00
Joshua McCloskey
dd8ff53e1b Fixed FaceEnrollIntro crash.
Test: Manual.
Fixes: 339306372
Change-Id: Ib6b98f78b734a531378c1162eb86725995f45799
2024-05-21 22:32:37 +00:00
Joshua Mccloskey
890eecf2e4 Merge "UDFPS Enrollment Refactor (5/N)" into main 2024-05-21 16:59:33 +00:00
Joshua McCloskey
01b4ef5a92 UDFPS Enrollment Refactor (6/N)
Bug fixes

Bug: 297082837

Change-Id: I86013007f089e9c57e1f7406f327c001bc4099b4
2024-05-20 23:35:24 +00:00
Joshua McCloskey
f6849078c5 UDFPS Enrollment Refactor (5/N)
Adding minor touch ups, such as starting the
FingerprintEnrollConfirmation when enrollment has been completed.

Bug: 297082837
Test: atest
Change-Id: I7b3edebb141bdb3e4648f71527d45dc5a0185b60
2024-05-20 23:21:57 +00:00
Joshua Mccloskey
03a0812931 Merge "UDFPS Enrollment Refactor (4/N)" into main 2024-05-20 21:53:16 +00:00
Joshua McCloskey
0336781be0 UDFPS Enrollment Refactor (4/N)
Accessibility + text/dpi change + rotation should be properly handled.
Debug repos were added to make UI developemnt for UDFPS much easier(not
requiring calls to fingerprint manager).

Change-Id: I89900cea0d9e953124781cdf308fb38858de5d16
2024-05-13 22:05:26 +00:00
David Liu
ae68cfca44 Merge "Set noparent to avoid it recursively looks up. Android biometric team should approve all change in this subdirectories." into main am: 7220a11daf am: aa9702134d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3080723

Change-Id: Ia7c3895dd1f4baef3b64c26fa0fa2e46af333c49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 17:29:32 +00:00
David Liu
836e14e665 Set noparent to avoid it recursively looks up. Android biometric team should approve all change in this subdirectories.
Change-Id: Ib5bdc23660cc18af0f57ffdec1dbf582db734a43
2024-05-09 22:15:14 +00:00
Joshua Mccloskey
1b55eb8bfc Merge "Update face & fingerprint pref logic" into main 2024-05-08 18:08:06 +00:00
Joshua McCloskey
3e25356829 Update face & fingerprint pref logic
This change makes it possible for face & fingerprint settings to be
presented to the user only to delete their face/fingerprint if the
feature has been disabled by a device admin.

Bug: 323280069
Test: atest BiometricFaceStatusPreferenceControllerTest
BiometricFingerprintStatusPreferenceControllerTest

Change-Id: I62cab3ddf7cf708d1b0b4da61dc3ffb7052dee84
2024-05-07 18:12:41 +00:00
Joshua Mccloskey
968015c4e6 Merge "Restart fingerprint auth on cancel." into main 2024-04-30 20:51:44 +00:00
Joshua McCloskey
4efd4c16f9 Restart fingerprint auth on cancel.
Test: atest FingerprintSettingsFragmentTest
Fixes: 336572954
Change-Id: Ie64d509caf052271a141e466f5c840e92f5dc119
2024-04-29 22:30:23 +00:00
Treehugger Robot
30ce935274 Merge "Update constants" into main 2024-04-26 23:31:49 +00:00
Jason Chang
7007b1ba3b Merge "Fix Talkback announcement for SFPS enrollment issues" into 24D1-dev am: 58b70959a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26976676

Change-Id: I5e6098952d00ec28c487eaa0e1e2825036de9e19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-24 08:42:45 +00:00
Jason Chang
0c61a9662c Fix Talkback announcement for SFPS enrollment issues
Remove the redundant "enrolled %" string when talkback announcement.

Bug: 324488176

Flag: NONE

Test: manually do SFPS enrolling then hearing the sounds to check.
Change-Id: I00d1f885bca2609cd954817943a1d4f5625a95b3
2024-04-22 13:38:30 +00:00
Diya Bera
d8ad8e17b0 Update constants
Flag: N/A
Test: N/A
Bug: 289548794
Change-Id: Ifcc0592583697efb105167b6c168c40a3299dc54
2024-04-13 16:09:28 -07:00
Vincent Wang
a38a05769a Update string for acquire msg FINGERPRINT_ACQUIRED_IMAGER_DIRTY on
UDFPS devices

Bug: b/330640273
Test: 1. Use tape or water to cover the FP sensor on UDFPS devices
      2. Try to enroll fingerprint
      3. Check the displayed message is correct in enrolling page
Change-Id: I9415e9e58336daa2da6eb4febf1eea7a30d07dc5
2024-04-10 08:21:16 +00:00
Simon Wingrove
cb9da5907d Merge "Use trampoline for FaceEnrollIntroductionInternal" into main 2024-04-08 08:57:37 +00:00
Hao Dong
617c73cd37 Merge "Show "no thanks" button when scroll is not needed." into main 2024-04-04 18:17:35 +00:00
Joseph Vincent
0882f3c105 Merge "Remove "skip lock screen" from private profile face setting" into main 2024-04-04 17:56:54 +00:00
Simon Wingrove
abc6625a31 Use trampoline for FaceEnrollIntroductionInternal
This gives activity embedding logic a chance to notice what taskfragment
the elements should be in, and prevents a bug where the topmost activity
can dissapear under the stack.

Test: Manual
Bug: 324018644
Change-Id: Iea8d367247b13ffe66f4558be49e8060fb7db4c5
2024-04-04 12:43:56 +00:00
josephpv
fecb6062ba Remove "skip lock screen" from private profile face setting
This change removes toggle "skip lock screen" from private profile face
unlock settings page.

screenshot : go/ss/BgucXsP9FRk23SM.png

Bug: 320702155
Test: Manual
Change-Id: Ibcd83edb1a93a4cd4b33c672f32e3b90328060ea
2024-04-04 10:47:41 +00:00
Hao Dong
6cef7bac2d Show "no thanks" button when scroll is not needed.
Test: atest FingerprintEnrollIntroductionTest
Bug: 328019857
Change-Id: Ia9e9be3a5a4c89e1d01e597730da5bfc2a5483ad
2024-04-04 04:59:14 +00:00
Joshua Mccloskey
90552bb255 Merge "Removed period from fp delete dialog." into main 2024-04-02 19:24:08 +00:00
Joshua Mccloskey
398b73a9fb Merge "UDFPS Enrollment refactor (3/N)" into main 2024-04-02 18:20:03 +00:00
Joshua McCloskey
4a499bb9b2 Removed period from fp delete dialog.
Note that this removes the period from english & all translations,
DeleteFingerprintDialog & ConfirmLastDeleteDialog should be the same.

Test: Manual.
Fixes: 331758381
Change-Id: I774375ed575bfdfd3ec181d902a99d918596890c
2024-04-02 18:10:05 +00:00
Joshua McCloskey
ed0098d3aa UDFPS Enrollment refactor (3/N)
Test: manual.
Change-Id: Ic4bf3bd4dc8fe10814c64decf07511db174108f8
2024-04-01 23:11:47 +00:00
Derek Jedral
8802d4c085 Merge "getAuthority using resolveContentProvider" into main 2024-04-01 21:26:41 +00:00
Derek Jedral
9cdb54315e getAuthority using resolveContentProvider
Gets the provider info directly by providing the authority, rather than
getting all providers, and then finding the matching authority. This
should be much more efficient.

Test: local test, confirm entry point still appears
Bug: 316799867
Change-Id: I9b98cff3b8f19a6cab8dd64b433a2b3129546ada
2024-04-01 17:41:01 +00:00
Joshua McCloskey
a811dd67bd UDFPS Enrollment refactor (2/N)
This commit is focused on UI. The guided enrollment, lottie, text
and progress bar should all be working according to the previous
experience.

Test: atest
Bug: 297082837
Change-Id: I9b414053f5eaf7b2bc164dacdddc96ed44fec6cb
2024-03-28 18:55:32 +00:00
Joshua Mccloskey
72abca0a95 Merge "UDFPS Enrollment Refactor (1/N)" into main 2024-03-27 19:07:34 +00:00
Joshua McCloskey
199d75b332 UDFPS Enrollment Refactor (1/N)
This CL creates a few necessary components that are needed to create the
UI

Test: adb shell device_config put biometrics_framework com.android.settings.flags.fingerprint_v2_enrollment true
Bug: 297082837

Change-Id: I17c4f65fdeac4ebf3c19ba69f5928787b5ace52e
2024-03-26 18:13:54 +00:00
Vincent Wang
4e5acef79d Merge "Fix Settings crash after clicking "Add Fingerprint"" into 24D1-dev am: 8cc6c89e4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26681904

Change-Id: I4ccd41db93333e632323dd50e7623aeea5a575c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-26 06:24:01 +00:00
Vincent Wang
d5b1bf7554 Fix Settings crash after clicking "Add Fingerprint"
Bug: b/331136606
Test: 1.Add 1 Fingerprint
      2. adb shell am start -a android.settings.FINGERPRINT_SETTINGS
      3. input correct pin/pattern/password
      4. Click Add Fingerprint cehck if Setting work correctly
Change-Id: I076ed7488729a24aea9b47a843b7785e128f6791
2024-03-26 02:09:28 +00:00
Joseph Vincent
6ec3ac32a5 Merge "To skip face enrollment for PS unlock setup based on intent extra" into main 2024-03-19 13:28:10 +00:00
josephpv
f9bc323633 To skip face enrollment for PS unlock setup based on intent extra
For private space lock setup as part of both PS setup and separate lock
form private space settings we need to show only traditional unlock
factors and Fingerprint but not show Face enrolment even on devices
where Face unlock is supported by hardware.
Once LSKF is enrolled it should be followed by Fingerprint enrollment
flow and after that Face enrollment should not be shown and exit lock
setup flow.

Currently for separate profile lock setup ACTION_SET_NEW_PASSWORD intent
is used in private space setup.
With this intent the options of LSKF+fingerprint+Face is shown in
devices supporting both fingerprint and face hardware. After the LSKF
ennrollment BiometricEnrollActivity is started which continues with
fingerprint and Face enrollment.

With this change we are passing an extra along with the intent to enroll
fingerprint only. Based on the intent extra value if set even if hardware
support exists the lock enrollment for the profile will support only
LSKF and fingerprint enrollment but not start Face enrollment.

User will still have the option to enroll Face from the dedicated settings
entrypoint in private space settings.

Recording link : b/323839067#comment4

Bug: 323839067
Test: Manual, verified option for face enrollment is shown or not shown
based on the intent extra. When extra is not passed the behaviour will be
default.

Change-Id: Idf92084052e02df9ca89f288c618796750e563e6
2024-03-19 11:58:08 +00:00
Vincent Wang
118abc5568 Show calibtation result in FingerprintSettings & EnrollEnrolling
if results are available

Bug: b/326155807
Test: Enroll multiple fingerprints and check if
        calibration isn't triggered.

Change-Id: I006db64f001fb70d2bb294a15a2d3efc77e2da25
Merged-In: I006db64f001fb70d2bb294a15a2d3efc77e2da25
2024-03-19 02:32:58 +00:00
Vincent Wang
1a498d030d Merge "Show calibtation result in FingerprintSettings & EnrollEnrolling if results are available" into main 2024-03-18 14:34:24 +00:00
Vincent Wang
6666bb97b4 Show calibtation result in FingerprintSettings & EnrollEnrolling
if results are available

Bug: b/326155807
Test: Enroll multiple fingerprints and check if
        calibration isn't triggered.

Change-Id: I006db64f001fb70d2bb294a15a2d3efc77e2da25
2024-03-18 09:07:46 +00:00
Treehugger Robot
1b3c21ef1b Merge "Fixed NPE in FingerprintEnrollIntro" into main 2024-03-07 02:24:40 +00:00
Joshua McCloskey
3c57fcde32 Fixed NPE in FingerprintEnrollIntro
Test: atest FingerprintEnrollIntroductionTest
Fixes: 317515741
Change-Id: Icc4e5cd4fbfea6828684ce6c8fc30acaabe5d315
2024-03-07 00:33:49 +00:00
Wu Ahan
c09f75b005 Use correct string res for FaceEnrollIntroduction#getAgreeButtonTextRes
Flag: N/A
Bug: 326386200
Test: manually
Change-Id: I5fa5ad0d2d46ccbeb06b716c5d47fb0881b078ad
2024-02-27 05:36:31 +00:00
Jason Chang
dc5c38c4bf Merge "Fix enrolled face id can't be deleted when changing device rotation then pressing back key" into main 2024-02-23 09:12:35 +00:00