Commit Graph

53990 Commits

Author SHA1 Message Date
alisa.li
fe199d2656 Update state when disabling and enabing develop option
When not support a2dp offload, the a2dp offload preference is shown in grey, but a2dp offload preference will be set enabled when enabing develop option

Bug:295109808
Test: manual
Change-Id: I7e1d073ff9ef6b68b5f1d9faa1dac459a70d7afc
2024-11-07 10:41:57 +00:00
Treehugger Robot
15f88ddc70 Merge "fix crash in setting time zone" into main 2024-11-05 00:31:21 +00:00
hoffc
a9002d157c Fix force close for updating UI after activity destroyed.
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.

Do not call scan callback if network select activity is finishing or destroyed.

Test: build pass and run NetworkSelectSettingsTest unit test pass.

Bug: 372123288
Change-Id: I28307490c75fe04d54dcf1637f33f4b9ba1fe635
2024-10-22 06:25:37 +00:00
Pechetty Sravani (xWF)
0583090e98 Merge "Revert "Fix force close for updating UI after activity destroyed."" into main 2024-10-21 09:49:30 +00:00
Pechetty Sravani (xWF)
bd44c86041 Revert "Fix force close for updating UI after activity destroyed."
This reverts commit 2545f06558.

Reason for revert: DroidMonitor created revert due  to b/374650528.Will be verified through ABTD for standard investigation.

Change-Id: Ifa3f061b7954dc2b5780b768fefb9358c597fdc0
2024-10-21 06:18:31 +00:00
Treehugger Robot
b083196e76 Merge "Fix force close for updating UI after activity destroyed." into main 2024-10-21 04:11:01 +00:00
Jaewan Kim
591d4fd932 Enable Linux terminal app via developer settings
Bug: 369246712
Test: `atest SettingsRoboTests`, try toggle the option, \
  and try search with 'Linux'.
Flag: RELEASE_AVF_SUPPORT_CUSTOM_VM_WITH_PARAVIRTUALIZED_DEVICES
Change-Id: Ibdcf00de04f09fe5b03ba53857904945354ed844
2024-10-16 15:49:12 +00:00
hoffc
2545f06558 Fix force close for updating UI after activity destroyed.
If activity is finishing or destroyed, getting activity context will return null results in settings app force close.

Directly return if network select activity is finishing or destroyed when handling network scan callback.

Bug: 372123288
Change-Id: Ia8c89569761b66da58cafd0140ceda29ac7d678c
2024-10-08 17:29:45 +08:00
Paul Duffin
ad48f03f53 Fully qualify @attr reference to android.R field
Currently, Metalava has some special handling of '@attr ref R.<field>`
references to make sure that they are fully qualified, i.e.
`@attr ref android.R.<field>`. That special handling complicates
Metalava and is blocking some flagged API work so will be removed.
Before that can be done, the existing incorrect documentation needs to
be cleaned up.

This change cleans up those cases in this repo.

Bug: 371997321
Test: Run `m offline-sdk-docs` before and after to make sure that
      there are no differences.
Flag: DOCS_ONLY
Change-Id: Ic97f01b90193d058d65e6d3c6d0a04ce5e55d7c7
2024-10-07 17:10:02 +01:00
Treehugger Robot
9a0ba22e79 Merge "Add a check to ensure that intent data is available before proceeding." into main 2024-09-27 09:54:21 +00:00
Abdelrahman Daim
996afd17a1 Protect the Settings application from potential null pointer exceptions.
Summary: The app bar is not available, causing a null pointer exception.

Test: Successful Build on master branch

Change-Id: I36849606f6587d6e7f004ae21e1a6e6a5206735a
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-25 17:02:37 -07:00
Abdelrahman Daim
3be2314fac Add a check to ensure that intent data is available before proceeding.
Summary: There are instances where intent data is absent, leading to a crash while trying to retrieve the schema. This change adds a null check to prevent attempted access when there's no data.

Test: Successful Build on master branch

Change-Id: Ie83bd3243f2c79102061d3fa43d809b3ef3c6c78
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-24 12:21:22 -07:00
Treehugger Robot
eb2e9e4776 Merge "Fix errorprone issues" into main 2024-09-11 18:08:19 +00:00
Chun-Wei Wang
88bbe8fe1d Merge "Support alternate button" into main 2024-09-09 14:18:11 +00:00
Cole Faust
9b89e3d643 Fix errorprone issues
IgnoredPureGetter, LenientFormatStringValidation, ProtocolBufferOrdinal, and ReturnValueIgnored.
https://errorprone.info/bugpatterns

Bug: 253827323
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: Ib0a0335aa04b36924adcbfecc830b7392c0e5bec
2024-09-06 13:34:50 -07:00
Treehugger Robot
96fcc4903b Merge "bluetooth: Refactor BT Audio Codec list" into main am: 7c9f1454da
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3241342

Change-Id: I87e97131d3361224aa898838bf6c04308d95bd28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-28 07:23:17 +00:00
Jakub Rotkiewicz (xWF)
51cac72d94 Merge "bluetooth: Fix Mono/Stereo selection with new codec list" into main am: c640aeeec9
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3241341

Change-Id: I08cbe0634d9c4926af2d9ac927e81960d966f5bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-27 20:42:02 +00:00
Jakub Rotkiewicz (xWF)
ab1a9a73e9 Merge "bluetooth: remove debug logs guard" into main am: 8b780a831e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3241340

Change-Id: Ied02c723be359d7d2873313a05ea9d6c178cd5e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-27 20:41:40 +00:00
Jakub Rotkiewicz
97b113a660 bluetooth: Refactor BT Audio Codec list
* Show only selectable codecs to the user
* Removed redundant 'abstract' layer
* Disable codec selection when BluetoothA2dp, active device unavailable
  or HD Audio disabled.

Bug: 329809288
Bug: 346490998
Flag: EXEMPT - refactor
Test: atest SettingsRoboTests:com.android.settings.development.bluetooth.BluetoothCodecListPreferenceControllerTest
Merged-In: I56ebfeaf2cfa22ec253db897d7b7e96d1f8eee61
Change-Id: I23714715d9257479f5eac1a172ba1804da7e64e3
2024-08-27 20:15:01 +00:00
Chun-Wei Wang
31ebeb690e Support alternate button
Align the behavior of frp and repair to have them
support the alternate button.

Bug: 339735656
Test: presubmit
Change-Id: Ib785db5ef16a68df4980dee451c6b638692adc5f
2024-08-27 10:16:11 +08:00
Jakub Rotkiewicz
4f441c03a7 bluetooth: Fix Mono/Stereo selection with new codec list
When SBC was selected and user changed Channel mode from Stereo to Mono
the codec type wasn't set properly and the reconfiguration failed.

Bug: 329809288
Flag: EXEMPT - minor refactor
Test: manual - choose SBC and change mode to MONO
Merged-In: If847bab1cc05d8c38a680e87277dd857970b4251
Change-Id: Ie32e3a3aa85f866d504dde7396feacf154a2298b
2024-08-26 11:44:27 +00:00
Jakub Rotkiewicz
1b0d956d08 bluetooth: remove debug logs guard
Bug: 329809288
Flag: EXEMPT - log only
Test: mmm packages/apps/Settings
Merged-In: Ia1626aa6904c90729de518102aedbab226a25692
Change-Id: I1d7c2784d8c81c3c3bfd035c64042553261261f8
2024-08-26 11:43:53 +00:00
SongFerng Wang
f8863ca737 Catch IllegalArgumentException when getting provisioning status am: b781605c1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/28930152

Change-Id: Iab377d3822de137bd5ec8ab7f98d85456218a8cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-22 00:31:44 +00:00
SongFerng Wang
b781605c1e Catch IllegalArgumentException when getting provisioning status
getProvisioningStatusForCapability still need the IllegalArgumentException when the subId is -1.

Bug: 346600036
Test: manual test. Disable sim and the settings did not crash.
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:37e1d258f88c5129035501d6ced1dab6627da102)
Merged-In: Ib5c41ab9214cf34a17ef02864dccffb5371cfe3a
Change-Id: Ib5c41ab9214cf34a17ef02864dccffb5371cfe3a
2024-08-22 00:20:29 +00:00
SongFerng Wang
8761b34cf4 Fix IllegalArgumentException when getProvisioningStatusForCapability am: d67de483b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/28900489

Change-Id: I9e701d326af7239f842611cb0574e18f05a5d34e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-21 08:24:08 +00:00
SongFerng Wang
d67de483b4 Fix IllegalArgumentException when getProvisioningStatusForCapability
The ProvisioningManager.getProvisioningStatusForCapability() throws UnsupportedOperationException when the capability is not supported.

Bug: 346600036
Test: NA
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:370445b773aa7ec69c83904dfdcd2e8f182bb777)
Merged-In: Ib682b336fdfc4c79a8b3e2fa5ccac8fe9c4e7ba1
Change-Id: Ib682b336fdfc4c79a8b3e2fa5ccac8fe9c4e7ba1
2024-08-20 07:51:56 +00:00
Xin Li
fb1de08eff Merge aosp-24Q3-ts-dev
Bug: 358400644
Merged-In: I52b5a62d20ee7df14ecf93c9b0dbbed6f7dc0f0d
Change-Id: If3a7c6d203d73c752c2e354171416e17de747459
2024-08-16 10:15:18 -07:00
Xin Li
0b886fe303 Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future
Bug: 347831320
Merged-In: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
Change-Id: I473577d5983daafb368afa5523bad948499cb9a2
2024-08-14 23:26:30 -07:00
Chaohui Wang
fb27c768af Check ims for isVoImsOptInEnabled
If the device does not have PackageManager.FEATURE_TELEPHONY_IMS,
ProvisioningManager.getProvisioningIntValue() could not be called.

Fix: 346708541
Flag: EXEMPT bug fix
Test: manual - SIM settings
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:aa0d63ce4022fa3ae29b77c299c4dce37d11b338)
Merged-In: I52b5a62d20ee7df14ecf93c9b0dbbed6f7dc0f0d
Change-Id: I52b5a62d20ee7df14ecf93c9b0dbbed6f7dc0f0d
2024-08-12 05:12:10 +00:00
Xin Li
e2d326beeb Merge 24Q3 (ab/AP3A.240905.001) to aosp-main-future
Bug: 347831320
Merged-In: I2489a64804f068a957f9be3f87847d6911b24447
Change-Id: I1885ef34f69ac4eb6e76ac903fcacdebe4139ae1
2024-08-08 11:41:20 -07:00
Les Lee
ae2195c549 wifi: fix ADB URI doesn't work
Using old WifiQrCode parsing for ADB Uri.

Flag: EXEMPT bugfix
Bug: 355088188
Test: Manual test & TH
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:da21128568e29a6c2992b1b38cbb2db9ec36892f)
Merged-In: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
Change-Id: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
2024-07-29 23:56:20 +00:00
Treehugger Robot
5079417396 Merge "Remove unecessary logs" into main am: 5e487ed591
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3191355

Change-Id: Ifa53f9c0acf7e57ee6a2c1e2fad9e094612aea0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-29 02:16:39 +00:00
Treehugger Robot
5e487ed591 Merge "Remove unecessary logs" into main 2024-07-29 01:43:55 +00:00
Treehugger Robot
88f79fe29d Merge "Migrate to onViewCreated in DataSaverSummary" into main am: 04ed8498ee
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3188139

Change-Id: Ib0e4725e3b490e70d9518a2f02c418de2216e638
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-28 21:06:34 +00:00
Treehugger Robot
04ed8498ee Merge "Migrate to onViewCreated in DataSaverSummary" into main 2024-07-28 20:52:34 +00:00
Treehugger Robot
ee6f5cf1ed Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Idcd085b62b69bace7ddfda325b1645b6b89440ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:25:24 +00:00
Treehugger Robot
998787ffa8 Merge "Make adb team OWNERS of all Adb settings" into main 2024-07-26 18:01:59 +00:00
Fabien Sanglard
c7adef9634 Make adb team OWNERS of all Adb settings
Test: NA
Bug: 355088188
Flags: NA
Change-Id: I59c037765940a26509f1d312b4c8c2e0105a3580
2024-07-26 10:57:43 -07:00
yomna
a6149ddf36 Remove searchability of CellularSecuritySettingsFragment
Test: m & manual
Bug: b/335554085
Flag: EXEMPT bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:62004763e1f131085b0e834b6c8b01b563f55b73)
Merged-In: Ia226b0848d70a307b80060049ec24b9714ee476a
Change-Id: Ia226b0848d70a307b80060049ec24b9714ee476a
2024-07-26 02:04:26 +00:00
Haijie Hong
8822907513 Add device to to cached device manager if it's not present
Bug: 346923808
Test: atest BluetoothDeviceDetailsFragmentTest
Flag: EXEMPT minor bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a074f274991f6a172855e0253f49b0a6dd63c758)
Merged-In: Ia4987bc7ec93cb6b54d188922b7232d83d528f2f
Change-Id: Ia4987bc7ec93cb6b54d188922b7232d83d528f2f
2024-07-26 02:04:14 +00:00
Rambo Wang
a07738266b Fix Settings restart during Reset mobile nework settings flow
This CL avoids restarting Settings in the reset mobile flow when phone
process is restarted, by switching the usage of the stable content
provider connection to the unstable client.

The CL also arranges restarting phone process as the last reset
operation in the flow (later than RILD reset) to avoid any reset
operation get impacted by phone process restarting.

Since the permission to protect the TelephonyContentProvider has been
renamed, the CL also renames the requsted permision.

Bug: 347047105
Test: atest ResetNetworkOperationBuilderTest
Test: Reset mobile network feature test
Flag: EXEMPT resource update with minor refactoring
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5ac9d9c8fa0005f787b75052010dcc9935efcb4f)
Merged-In: I7bfa79bc9d7451a4a03269704b0009a3730e287f
Change-Id: I7bfa79bc9d7451a4a03269704b0009a3730e287f
2024-07-26 02:03:55 +00:00
Yuanru Qian
6190b5eb70 Merge "Developer option crashed when Bluetooth feature disabled" into main am: cff856a8bb
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3172099

Change-Id: Idaa295aa767f900acc88da42bc838b7081c69504
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-25 04:29:10 +00:00
Yuanru Qian
cff856a8bb Merge "Developer option crashed when Bluetooth feature disabled" into main 2024-07-25 03:31:43 +00:00
Yuanru Qian
97f922d60c Merge "Remove ex-team members from OWNERS" into main am: 8303a38d10
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3191891

Change-Id: I39c450800b0a3fc08d7cab8e74ff7318f753cbf9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-24 10:27:41 +00:00
Yuanru Qian
3fac9ad21b Remove ex-team members from OWNERS
Change-Id: I025d4963e5b63a28fb0fe36df8a4e1fdd76a9b3d
2024-07-24 09:41:31 +00:00
Pawan Wagh
d519d1fbaa Remove unecessary logs
Test: m Settings
Bug: N/A
Flag: NONE remove logging
Change-Id: Ib1e5923e2f10fdf5fa29bbaa24b74874c18c3045
2024-07-23 22:19:22 +00:00
chayemme
ec6e93f3f4 Developer option crashed when Bluetooth feature disabled
When Bluetooth feature is disabled, crash observed with developer option
is selected

Bug: 352864331
Change-Id: If4239f710847f2e01a3b419e1ce6f783f0522219
2024-07-23 13:05:29 +00:00
Jyotiraditya Panda
4ff23211dd Migrate to onViewCreated in DataSaverSummary
The onActivityCreated method has been deprecated. This change updates
DataSaverSummary to use onViewCreated instead, which is the recommended
method for initializing views after the fragment's view has been created.

Test: manual
Change-Id: I08daa11b557b05441fa4f7ed0019802d991846e3
Signed-off-by: Jyotiraditya Panda <jyotiraditya@aospa.co>
2024-07-22 20:18:08 +05:30
David Anderson
80e709f926 Allow overriding DeviceDiagnosticsPreferenceController.
Allow devices to specify their own flags by overriding this class.
Additionally, fix a missing PackageManager lookup in getIntent().

Bug: 348647186
Test: launch Settings on Pixel and on AOSP
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:287181169485eb30203c7b698b1f8ee618059e29)
Merged-In: I2489a64804f068a957f9be3f87847d6911b24447
Change-Id: I2489a64804f068a957f9be3f87847d6911b24447
2024-07-20 07:05:32 +00:00
SongFerng Wang
bce8fc79e8 Merge "Fix SmartForwardingActivity crash at screen rotation" into main am: 14393a5f06
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2855525

Change-Id: Ieb6ffb8c2f479ffcc30d60440df649618074e420
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-19 05:55:14 +00:00