Commit Graph

942 Commits

Author SHA1 Message Date
Bonian Chen
e2da25108a Merge "[Settings] Avoid crash for VoIP account displayed as default voice" into rvc-dev 2020-05-28 14:59:47 +00:00
SongFerngWang
259e6288c9 EnabledNetworkModePreferenceController Remove AllowedNetworkType
Power manager decision do enable/disable NR by AllowedNetworkType,
and it will effect the PreferredNetworkMode UI. The
PreferredNetworkMode list no 5G item when AllowedNetworkType
disabled.

Bug: 156709797
Test: make RunSettingsRoboTests ROBOTEST_FILTER=\
EnabledNetworkModePreferenceControllerTest  (pass)

Change-Id: I3ab9eca0956c4cce1b79e518942063b681eb96cd
2020-05-28 20:37:51 +08:00
Bonian Chen
ce0f3c66a0 [Settings] Avoid crash for VoIP account displayed as default voice
When displaying VoIP account in Default voice account UI within
mobile network configuration, some null pointer checking need to
applied due to this is no longer a real account bind to SIM card.

Bug: 157334667
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DefaultSubscriptionControllerTest
Change-Id: I3927362676c867ac245f16e1d00ea953b21ec1d4
2020-05-28 18:17:42 +08:00
Bonian Chen
b381ac0bad [Settings] Avoid SIM toggle switch loopback
API provided by SwitchBar widget would lead to callback when
SIM toggle switch operation failure and set UI back.
However, set UI back (rollback the UI) would lead to another
trigger to SIM toggle switch. This would generate endless
events and keep system budy.

To avoid from this callback, a check need to be done prior to UI
take action. Therefore, changing APIs to fit into this concept.

Bug: 155770954
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=MobileNetworkSwitchControllerTest
Change-Id: Iaea1012acdbe449a882ced08b596c64b9f99256f
2020-05-26 21:34:39 +08:00
Paul Hu
37318d03a4 Merge "Forward the ResultReceiver to Tethering Entitlement app" into rvc-dev 2020-05-26 05:47:09 +00:00
paulhu
2efe482d95 Forward the ResultReceiver to Tethering Entitlement app
Bug: 156336264
Test: atest TetherProvisioningActivityTest
Change-Id: I37fcaddd5569223146ff9d6316d97f33312d8d24
2020-05-21 02:33:15 +00:00
SongFerngWang
414f8b8fe6 Add corresponding code for the new NR condition
Bug: 155915216
Test: make RunSettingsRoboTests ROBOTEST_FILTER=\
EnabledNetworkModePreferenceControllerTest (Pass)

Change-Id: I171ea0a8adc621ad5e9dc5cd2090e431b923e775
2020-05-19 12:32:57 +00:00
Bonian Chen
17ad56b3fc [Settings] Avoid from redraw UI when first time onResume
Registration of subscription change lead to redraw.
However, entire UI is newly created where redraw is not required
when fragment first time created.

Therefore, remove first callback from SubscriptionManager to reduce some
time.

Bug: 141833767
Test: manual
Change-Id: I54a58dd8271bb2cd8cd531cc02ff7d64b3e4328c
2020-05-13 18:47:09 +08:00
changbetty
0383d76a5e Add setPackage for PendingIntent in SliceHelper
Bug: 151645867
Bug: 151646375
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiCallingSliceHelperTest
      make RunSettingsRoboTests ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Change-Id: I33c1333f9b5472cdb962b272f6be52a2d2959376
Merged-In: I33c1333f9b5472cdb962b272f6be52a2d2959376
2020-05-12 17:56:48 +08:00
Bonian Chen
bfdf45e565 [Settings] Code reformat
Code reformat.

Bug: 155962136
Test: build pass
Change-Id: Icb56f72af925f2b47cd8867156ca12fc9a6e6347
2020-05-07 19:00:58 +08:00
Bonian Chen
3dec052a06 [Settings] Mobile network not updated based on SIM change
SIM status and configuration change need to update the screen.

Bug: 155520761
Test: manual
Change-Id: I18f0f599b2299b1a93115a00025f0c0dd7ecb450
2020-05-06 19:20:18 +08:00
Bonian Chen
0065f2e460 [Settings] Code refactor
Code refactor.

Bug: 141833767
Test: manual
Change-Id: I3fa9dcc630b7612c1af3300024dee4f8deb6b308
2020-05-05 10:01:09 +00:00
TreeHugger Robot
18490b2dc8 Merge "Enable some settings pages to use paralleled-loading method" into rvc-dev 2020-05-05 09:23:13 +00:00
Bonian Chen
cdab906c45 Merge "[Settings] Refactor for performance" into rvc-dev 2020-05-05 08:34:01 +00:00
Bonian Chen
e017bb84ce Merge "[Settings] Query historical data in background" into rvc-dev 2020-05-05 06:35:39 +00:00
TreeHugger Robot
c2729a517e Merge "There are two same items in manual selection page, remove one item" into rvc-dev 2020-05-05 06:29:14 +00:00
SongFerngWang
abf31a44c8 There are two same items in manual selection page, remove one item
Bug: 155703755
Test: To check UI. PASS
Change-Id: I8c9fb80ab761599abdfd6640410fdccedec444d0
2020-05-05 03:59:15 +00:00
SongFerng Wang
28754bf6a8 Merge "Remove the second network scan." into rvc-dev 2020-05-05 03:20:53 +00:00
Bonian Chen
7ff5f56ea6 Merge "[Settings] Avoid from crash" into rvc-dev 2020-05-05 03:17:50 +00:00
Bonian Chen
fb015a3c24 Merge "[Settings] Adopt TelephonyBasePreferenceController" into rvc-dev 2020-05-05 03:17:18 +00:00
SongFerngWang
b7f98f7667 Remove the second network scan.
Fix: 153427564
Test: make RunSettingsRoboTests ROBOTEST_FILTER=NetworkSelectSettingsTest
(PASS)

Change-Id: If593fc4a4dd463bbc178b4864ad0ba01bb421b09
2020-05-04 22:31:15 +08:00
Bonian Chen
1ab100e936 Merge "[Settings] Code refactor" into rvc-dev 2020-05-04 10:41:47 +00:00
Bonian Chen
068eb89251 Merge "[Settings] Enable access from non-UI thread" into rvc-dev 2020-05-04 10:41:16 +00:00
Bonian Chen
07431066c4 Merge "[Settings] Code refactor for availability session" into rvc-dev 2020-05-04 08:49:21 +00:00
Bonian Chen
7ea8e7ef1e [Settings] Code refactor for availability session
Code refactor for session design of availability status config.

Bug: 141833767
Test: manual
Change-Id: Ia4982bc4036abbcff5ee1a4bba69bdf6f70ad657
2020-05-04 14:35:23 +08:00
Bonian Chen
017cc4e48f [Settings] Crash avoidance
Avoid crash when NullPointer.

Bug: 155248992
Test: manual
Change-Id: I5e4b46dcdf7ff21713b3f77fc9e20f503800b8e2
2020-05-04 14:11:09 +08:00
Bonian Chen
3d62032fed [Settings] Query historical data in background
Move the query of historical data into background thread to avoid from
blocking other query operation in UI thread,

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: I61e414d70136a0025ddd7373a4f34a99acb89510
2020-05-04 11:57:44 +08:00
Bonian Chen
d231727e3b [Settings] Code refactor
Move some work out of constructor of
EnabledNetworkModePreferenceController.
Which could avoid callbacks before init() been invoked.

Bug: 141833767
Test: make RunSettingsRoboTests -j
ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=EnabledNetworkModePreferenceControllerTest
Change-Id: I11f25d130a746c75184a21a8991177b02ad237f0

Change-Id: I6aa58a8d9d15b1524bf03f425e3eae3a0254593e
2020-05-04 11:48:09 +08:00
Bonian Chen
2a7767ee26 [Settings] Adopt TelephonyBasePreferenceController
Adopt TelephonyBasePreferenceController for better support on multi-SIM
environment.

Bug: 143996139
Test: make RunSettingsRoboTests -j
ROBOTEST_FILTER=DefaultSubscriptionControllerTest
Test: make RunSettingsRoboTests -j
ROBOTEST_FILTER=DisableSimFooterPreferenceControllerTest

Change-Id: I8a9c6efa927be1cb4a7ab4ebe816dcad9f20bd70
2020-05-04 11:23:11 +08:00
Bonian Chen
19507e7585 [Settings] Enable access from non-UI thread
To support query from settings intelligent, these listeners need to
support accessing from non-UI thread.

Bug: 149543756
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=ActiveSubsciptionsListenerTest
Change-Id: I768f41f76d0223634be2b728d33fa0cfcc69fe69
2020-05-04 11:07:41 +08:00
Bonian Chen
a9de4477e6 [Settings] Avoid from crash
Avoid from crash when updateState() performed before
displayPreference().

Bug: 141833767
Test: make RunSettingsRoboTests -j
ROBOTEST_FILTER=ApnPreferenceControllerTest

Change-Id: I4008010077c61930487fef01af306ccdfd69e38f
2020-05-04 10:59:58 +08:00
Sunny Shao
6d60248053 Enable some settings pages to use paralleled-loading method
- Here these pages include AppInfoDashboardFragment, ConnectedDeviceDashboardFragment,
  DevelopmentSettingsDashboardFragment, NetworkDashboardFragment, ConfigureNotificationSettings.
- The TimeSpentInAppPreferenceController use the LiveDataController.

Fixes: 135299529
Bug: 137558156
Test: compilation
Change-Id: I455a16536c9966184f1b2bd81d1f1217f3e09f9d
2020-05-04 10:34:23 +08:00
Zoey Chen
e6b7e24a09 Merge "Improve the performance of displaying preference." into rvc-dev 2020-04-29 05:57:12 +00:00
zoey chen
84587b1aa3 Improve the performance of displaying preference.
- Set a variable to record the status then replace getAvailabilityStatus() with it.

Test: manual test, use command to run MobileNetworkSettings and record it.
Bug: 154061428
Change-Id: Ia13a75a3821bb6c17d0dfeffb5043f47b60adf61
2020-04-29 11:21:36 +08:00
Brad Ebinger
e6fae38169 Fix NPE if CarrierConfigManager is not available
Fixes: 155147094
Test: Test: m RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.network.telephony
Change-Id: Iecf3e385a88d18c7578eb520449f4042324e21f5
2020-04-28 11:27:27 -07:00
Yanting Yang
96127fe621 Remove sub-text from slice builder
We would like to remove all sub-text from Settings Search. But slice
view does not support API to configure the sub-text visibility.
Therefore, the only way is to remove the sub-text from slices directly.

Since Settings slices are also invoked by other apps, we can not
directly remove the sub-text.

Finally, we decide to check the caller's uid. If it comes from Settings
Search, we will return the slice without the sub-text.

Bug: 143118037
Test: visual, robotests
Change-Id: Iac72f1683a2c930592634e0599058890d86f669d
2020-04-28 14:15:16 +08:00
Bonian Chen
51433a5ea8 Merge "[Settings] Sync summary of call preference with dialer" into rvc-dev 2020-04-27 09:14:22 +00:00
Bonian Chen
e17e302c9e [Settings] Sync summary of call preference with dialer
Replacing the display of summary part within Settings' calls preference
by VoIP account when configured calling account settings within Dialer.

The click behavior for calls preference remain unchanged, due to this is
the configuration for subscription (instead of for all kinds of
accounts).

Bug: 136277187
Test: manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DefaultSubscriptionControllerTest
Change-Id: Iaa5fa1f3efe7ba2463caa0b450077f885d42b1c8
2020-04-27 08:53:18 +00:00
Bonian Chen
87a4577472 [Settings] Support re-init DataUsageSummaryPreferenceController
Support re-init DataUsageSummaryPreferenceController without
re-constructing it.

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: If72a521c5fbaec8b8902fb80b13d9d0f07c716af
2020-04-24 11:35:44 +08:00
Brad Ebinger
c3d052a48c Merge "Revise strings as per string UX review" into rvc-dev 2020-04-23 15:38:39 +00:00
Bonian Chen
3248d004d3 [Settings] Move some work into background thread
1. Move some work into backgroud thread when query data usage status.
2. Fix test case

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: Ic1496323cd2bbaf794881394565d8d9bb0a89111
2020-04-23 12:55:53 +08:00
Bonian Chen
673251973b Merge "[Settings] Mobile data usage code refactor" into rvc-dev 2020-04-22 14:27:31 +00:00
Tom Hsu
49b82f8532 Merge "Make ApnEditor can show the customized default value on UI." into rvc-dev 2020-04-22 12:16:09 +00:00
tom hsu
fa3c931ab6 Make ApnEditor can show the customized default value on UI.
- Edittext on edittextpreference
 - Summary on edittextpreference

Bug: 142440775
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ApnEditorTest -j
Test: Sanity test pass with customized carrier data
   - data in summary and text of edittext preference correctly correctly
   display on.
Change-Id: I3162de19659df79c5873c730d7d32e4ed998bcbe
2020-04-22 12:15:50 +00:00
Bonian Chen
0fef82fbd1 [Settings] Mobile data usage code refactor
Code refactor

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: Ie1870523ce83e6a1fc56fe9bc4c61708e0e745c4
2020-04-22 18:22:35 +08:00
Bonian Chen
7db5840dfe Merge "[Settings] Mobile data usage code refactor" into rvc-dev 2020-04-22 07:17:22 +00:00
Bonian Chen
af05f6303d Merge "[Settings] To avoid from crash when callback" into rvc-dev 2020-04-22 07:00:12 +00:00
Bonian Chen
6ea4727eb4 [Settings] Mobile data usage code refactor
Code refactor

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: If85207ebe2edb8c547bb6dac0c55bbd146b62361
2020-04-22 13:13:33 +08:00
Zhen Zhang
92340eb89e Merge "Add ethernet tether option into AllInOneTetherSettings" into rvc-dev 2020-04-22 02:52:58 +00:00
Bonian Chen
5bc8aa7961 Merge "[Settings] Code refactor" into rvc-dev 2020-04-21 08:21:28 +00:00