Rambo Wang
f7b8d687bf
Fix Settings app ANR due to blocking IDumpstateDevice IPC call
...
This CL fixes the ANR by moving possible blocking IDumpstateDevice
IPC call from main thread to background thread.
Settings develop options depends on IDumpstateDevice IPC call to
set and get Vendor Verbose Logging feature. The IPC may occasionally
get blocked in system_server which is extremely busy (e.g. during
bugreport generating). This may cause Settings app crashing with ANR.
Bug: 287126040
Bug: 280015761
Test: atest EnableVerboseVendorLoggingPreferenceControllerTest
Test: Verbose Vendor Logging regression
Test: Stress test (heavily trigger on/off during BR generating)
Change-Id: I0b88ef089097930b62dcb1cb7d6fe9990356ab5d
2023-06-16 17:05:10 +00:00
Treehugger Robot
f572bed648
Merge "Remove redundant methods and refactor" into udc-qpr-dev am: 55774422b1 am: 6fb7cb85fd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23634999
Change-Id: I31ff110702752ffcd819e94106a1434963ef6e1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-12 10:37:10 +00:00
Treehugger Robot
6fb7cb85fd
Merge "Remove redundant methods and refactor" into udc-qpr-dev am: 55774422b1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23634999
Change-Id: I33ea753d6fcf8ced79a315652134513b40b0cfb0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-12 09:55:15 +00:00
Treehugger Robot
55774422b1
Merge "Remove redundant methods and refactor" into udc-qpr-dev
2023-06-12 09:05:05 +00:00
Yi-Ling Chuang
f148baa372
Remove redundant methods and refactor
...
Remove the summary method and write the code in AOSP directly instead to
force string consistency. Also refactor a bit after the modification.
Fixes: 276399056
Test: robotests
Change-Id: I76ad740b694363a3cdfb3748e41c840fb678b93d
2023-06-12 16:11:49 +08:00
Avinash Vadlamudi
6793da2403
[Auto Pin Confirmation]: Add talkback capability for Auto-confirm correct PIN checkbox even if it is not in focus am: 01637b556e am: 812ca56cfc am: e01f430341
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601571
Change-Id: Ia1f45b68d6223cab06930e15fc05c3cba6ca8950
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-10 03:25:24 +00:00
Avinash Vadlamudi
9502bd9690
[Auto Pin Confirmation]: Add talkback capability for Auto-confirm correct PIN checkbox even if it is not in focus am: 01637b556e am: 812ca56cfc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601571
Change-Id: I1001a1811c14a4d8002488a8051ae207a6f5477d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-10 02:44:25 +00:00
Avinash Vadlamudi
c4c85c8d89
[Auto Pin Confirmation]: Add talkback capability for Auto-confirm correct PIN checkbox even if it is not in focus am: 01637b556e am: 3730239bd7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601571
Change-Id: I27b0bebd69fe6bdf344f434bae90b655540417ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-10 02:40:55 +00:00
Avinash Vadlamudi
e01f430341
[Auto Pin Confirmation]: Add talkback capability for Auto-confirm correct PIN checkbox even if it is not in focus am: 01637b556e am: 812ca56cfc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601571
Change-Id: I19b29b1a66e7824ee0635630b767667958aebe68
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-10 02:40:52 +00:00
Avinash Vadlamudi
812ca56cfc
[Auto Pin Confirmation]: Add talkback capability for Auto-confirm correct PIN checkbox even if it is not in focus am: 01637b556e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601571
Change-Id: Ib3b5ae9d55f47da3f9a7e5734bd8f6a55ae267f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-10 02:02:34 +00:00
Avinash Vadlamudi
01637b556e
[Auto Pin Confirmation]: Add talkback capability for Auto-confirm correct PIN checkbox even if it is not in focus
...
- set accessibilityLiveRegion as Polite mode to allow talkback to announce the state of checkbox even if is not in focus
Bug: 281950677
Test: Manual test by flashing on device and checking in talkback mode
Change-Id: Ia1066e2df1f40e6c339a4cd63f92acf0858f8f3d
2023-06-10 01:25:18 +00:00
Mady Mellor
0be0c80a7c
Merge "Update the colors for bubbles settings based on new spec" into udc-dev am: 57406435cf am: 0399987aa1 am: f55de6cdd1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23622468
Change-Id: I522e268341ca3b7bab8cab7be5ca736ebaeb3c18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 17:43:43 +00:00
Oli Thompson
1a883223d2
Merge "Fix emergency button not visible on pattern work challenge screen" into udc-dev am: 01b382546e am: e86146d685 am: ca697c000a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23631338
Change-Id: Ic85a04f5844fe373393a0811e07f553f83722827
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 17:42:40 +00:00
Mady Mellor
50cacfcc1e
Merge "Update the colors for bubbles settings based on new spec" into udc-dev am: 57406435cf am: 0399987aa1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23622468
Change-Id: I55c42684f0af8cbcc8550d0b2491b7b132ab490d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 17:03:03 +00:00
Oli Thompson
f35b1be8ac
Merge "Fix emergency button not visible on pattern work challenge screen" into udc-dev am: 01b382546e am: e86146d685
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23631338
Change-Id: I82b44ce36153a64d37629f40dc8c7805c17847a6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 17:02:43 +00:00
Mady Mellor
ebfa483008
Merge "Update the colors for bubbles settings based on new spec" into udc-dev am: 57406435cf am: d219333161
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23622468
Change-Id: I9e9b9fb1e07d65903b7e5482d1068df3fff5b5f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 17:00:25 +00:00
Oli Thompson
e20d5d34f8
Merge "Fix emergency button not visible on pattern work challenge screen" into udc-dev am: 01b382546e am: 03bd83270a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23631338
Change-Id: I8f3631be2dc924fe8cf61278ccc6c2b9547c1629
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 16:59:57 +00:00
Mady Mellor
f55de6cdd1
Merge "Update the colors for bubbles settings based on new spec" into udc-dev am: 57406435cf am: 0399987aa1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23622468
Change-Id: I9b9c6a097b60c2a08c5f69b6b3c02beb73bbeb9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 16:59:18 +00:00
Oli Thompson
ca697c000a
Merge "Fix emergency button not visible on pattern work challenge screen" into udc-dev am: 01b382546e am: e86146d685
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23631338
Change-Id: Ifcde9f0a8fc75fc01909771df880f2b6ee70dab9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 16:58:49 +00:00
Mady Mellor
0399987aa1
Merge "Update the colors for bubbles settings based on new spec" into udc-dev am: 57406435cf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23622468
Change-Id: I9ba9a9b9a7fb9ba79d5b3f28a4627f28937eb7ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 16:17:46 +00:00
Oli Thompson
e86146d685
Merge "Fix emergency button not visible on pattern work challenge screen" into udc-dev am: 01b382546e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23631338
Change-Id: I7aa48065cbc087ff4135a93983e3b32b97dc6204
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 16:16:59 +00:00
Mady Mellor
57406435cf
Merge "Update the colors for bubbles settings based on new spec" into udc-dev
2023-06-09 15:33:30 +00:00
Oli Thompson
01b382546e
Merge "Fix emergency button not visible on pattern work challenge screen" into udc-dev
2023-06-09 15:31:17 +00:00
Oli Thompson
dcce8fa662
Fix emergency button not visible on pattern work challenge screen
...
Hide the subtext for work challenge pattern,so everything fits and
adjust some spacing
Test: btest a.d.g.WorkTelephonyTest#workChallengePatternScreen_whenAllSubscriptionsManaged_hasEmergencyButton -nm
Bug: 283137301
Bug: 286391641
Change-Id: Ia6214b624f8d7328f7445f01a08166b8ab33fdec
2023-06-09 13:06:39 +00:00
Zaiyue Xue
ed66e21cba
Don't load battery entry name and icon in offline job to improve memory usage. am: 65cb6ef230 am: 44fcc61baf am: c19305590c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23629343
Change-Id: I6691f8ac01ec53f8de1fd4b9c69055660a48ce32
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 12:31:34 +00:00
Zaiyue Xue
c19305590c
Don't load battery entry name and icon in offline job to improve memory usage. am: 65cb6ef230 am: 44fcc61baf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23629343
Change-Id: I3364f31694053b7c19b99eb9d305f8b4cb9b225c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 11:43:55 +00:00
Zaiyue Xue
dff1bd58de
Don't load battery entry name and icon in offline job to improve memory usage. am: 65cb6ef230
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23629343
Change-Id: I07e697bb37a2c3655b7e5b6e5177c8d9d9059f71
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 11:01:47 +00:00
Zaiyue Xue
44fcc61baf
Don't load battery entry name and icon in offline job to improve memory usage. am: 65cb6ef230
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23629343
Change-Id: I25d159e01c517f4dbd0670dd1273c5da9b1ab21d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 10:57:14 +00:00
Zaiyue Xue
65cb6ef230
Don't load battery entry name and icon in offline job to improve memory usage.
...
Risk: low, the name and icon will be always loaded again in the UI.
Bug: 280720236
Test: manual
Change-Id: I86f50e953ffd4910acbf9f318e1cc1caa3a7a232
2023-06-09 08:41:51 +00:00
Zoey Chen
943d6e1c9b
Merge "[Panlingual] Set focus to the drag list to avoid the overlapping" into udc-qpr-dev am: 593028ca32 am: db4bede383
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23615216
Change-Id: Ia07c39769f77ed05dab029a8cedf57f1008402ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 06:34:21 +00:00
Treehugger Robot
bae3bf9b63
Merge "Show "Not available" summary when hotspot speed is unavailable" into udc-d1-dev am: a99c52e160 am: 34a254fc0c am: cc4410e536
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601566
Change-Id: Idfc98b457000a4968a47651b35f271e3bc20c3bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 06:33:29 +00:00
Zoey Chen
db4bede383
Merge "[Panlingual] Set focus to the drag list to avoid the overlapping" into udc-qpr-dev am: 593028ca32
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23615216
Change-Id: I73c935ebf704c97e4b38621dd3675e8da42b02d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 06:11:34 +00:00
Zoey Chen
593028ca32
Merge "[Panlingual] Set focus to the drag list to avoid the overlapping" into udc-qpr-dev
2023-06-09 05:57:19 +00:00
Treehugger Robot
cc4410e536
Merge "Show "Not available" summary when hotspot speed is unavailable" into udc-d1-dev am: a99c52e160 am: 34a254fc0c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601566
Change-Id: I1f9fa9e219f1192945824aa4b07c9149e8a2876f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 05:42:42 +00:00
Treehugger Robot
4b44c6632e
Merge "Show "Not available" summary when hotspot speed is unavailable" into udc-d1-dev am: a99c52e160
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601566
Change-Id: I5b91a44f9c947d6686a28cb2acb2c41f58e8fe01
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 05:02:25 +00:00
Treehugger Robot
34a254fc0c
Merge "Show "Not available" summary when hotspot speed is unavailable" into udc-d1-dev am: a99c52e160
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23601566
Change-Id: Iea9c52ce4cfb37e4dc3df58a8117adb6b85e6c3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 04:58:22 +00:00
Treehugger Robot
a99c52e160
Merge "Show "Not available" summary when hotspot speed is unavailable" into udc-d1-dev
2023-06-09 04:29:16 +00:00
SongFerng Wang
fdaa6be161
Merge "When config is changed, update the profile's visibility" into udc-d1-dev am: a210c84eb8 am: 517e3b8bf4 am: 44e364584c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23599970
Change-Id: Ie26100f8c1c57722049360a607bf96ba32bd915f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 04:17:41 +00:00
SongFerng Wang
44e364584c
Merge "When config is changed, update the profile's visibility" into udc-d1-dev am: a210c84eb8 am: 517e3b8bf4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23599970
Change-Id: I0f9cd49f8f557319e1e9d6f087d796923fccfe73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 03:49:18 +00:00
SongFerng Wang
afc0ea3952
Merge "When config is changed, update the profile's visibility" into udc-d1-dev am: a210c84eb8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23599970
Change-Id: I4969b792e002832c372f30e0f5e7694463b569cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 03:08:44 +00:00
SongFerng Wang
517e3b8bf4
Merge "When config is changed, update the profile's visibility" into udc-d1-dev am: a210c84eb8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23599970
Change-Id: Iefea29ab04aedbc0f0f06c1f9da489fd86bf9870
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-09 03:04:47 +00:00
SongFerng Wang
a210c84eb8
Merge "When config is changed, update the profile's visibility" into udc-d1-dev
2023-06-09 02:26:16 +00:00
Mady Mellor
fb1e921bd9
Update the colors for bubbles settings based on new spec
...
Test: manual - get a bubble, go to that apps bubble settings screen,
observe the colors look correct, switch theme and
check again.
Bug: 283951560
Change-Id: I28fa64f8d7b53419a57615bf3da4da7eff049674
2023-06-08 13:23:54 -07:00
Mady Mellor
b1c6a59867
Merge "Fix colors in bubble settings so they're more visible" into udc-dev am: 8a47899369 am: 7605e122ac am: 1c4809812a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23607273
Change-Id: Ia8df9e8f5f38eb131be80bacad294cb7a8353ec7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-08 19:46:35 +00:00
Mady Mellor
e5aa469940
Merge "Fix colors in bubble settings so they're more visible" into udc-dev am: 8a47899369 am: 7605e122ac
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23607273
Change-Id: I616264cebad588f95f8c1756e81bca62927ddbb9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-08 19:07:14 +00:00
Mady Mellor
aabf96a1c3
Merge "Fix colors in bubble settings so they're more visible" into udc-dev am: 8a47899369 am: ee31358597
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23607273
Change-Id: I7e495da8b325296a9e7b1e3beccda822a620e1a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-08 19:03:18 +00:00
Mady Mellor
1c4809812a
Merge "Fix colors in bubble settings so they're more visible" into udc-dev am: 8a47899369 am: 7605e122ac
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23607273
Change-Id: I4a04c727ca345d6a6197747dd1eff28fc6702c77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-08 19:02:37 +00:00
Mady Mellor
7605e122ac
Merge "Fix colors in bubble settings so they're more visible" into udc-dev am: 8a47899369
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23607273
Change-Id: I66d7e691b5472f108303950f4a1a45347febb903
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-08 18:22:45 +00:00
Mady Mellor
8a47899369
Merge "Fix colors in bubble settings so they're more visible" into udc-dev
2023-06-08 17:35:55 +00:00
Mady Mellor
f184678802
Fix colors in bubble settings so they're more visible
...
Test: manual - get a bubble, go to that apps bubble settings screen,
observe the colors look correct, switch theme and
check again.
Bug: 283951560
Change-Id: I361b1c20e293c02b4d604e0b5845a074c31e5103
2023-06-08 09:21:13 -07:00