Commit Graph

2041 Commits

Author SHA1 Message Date
Jacky Wang
db3b6ee073 Simplify settings datastore calls
NO_IFTTT=Code refactor

Bug: 364899400
Flag: EXEMPT test
Test: atest DialPadTonePreferenceTest
Change-Id: Ifb4ab11e07b37952dfb3cc78d25383d563d5749d
2024-10-17 11:33:24 +08:00
Jacky Wang
9b62ec9616 Provide icon for catalyst screens
Bug: 335132588
Flag: EXEMPT N/A
Test: Manual
Change-Id: I520529c3bf4a7db01889d08683f55b0efb21eae4
2024-10-17 07:38:24 +08:00
Treehugger Robot
56dd252385 Merge "Migrate Dial pad tones preference" into main 2024-10-16 12:27:01 +00:00
Mill Chen
898feed16a Migrate Dial pad tones preference
Bug: 364899400
Test: atest DialPadTonePreferenceTest
Flag: com.android.settings.flags.catalyst_sound_screen
Change-Id: I5939a4d41ad61337f38bd5d48a1cb74f14f1e397
2024-10-16 09:25:13 +00:00
Jacky Wang
42d2b08454 Remove isCatalystEnabled check from SoundSettings
Bug: 360015496
Flag: EXEMPT N/A
Test: atest SoundScreenTest
Change-Id: I3b392d009eaaf59ee77a1ea9951a7191fcc521d5
2024-10-16 12:22:42 +08:00
Jacky Wang
d38549d60b [Catalyst] Use hybrid mode for sound screen
Bug: 360015496
Flag: com.android.settings.flags.catalyst_sound_screen
Test: atest SoundScreenTest
Change-Id: Ifd685f8e3a546e8750a593201362540f60a3c031
2024-10-12 16:38:31 +08:00
Mill Chen
29036fd2a9 Sound screen migration
- Add a flag for sound and vibration migration
- Adding skeleton of sound screen

Bug: 360015496
Test: atest SoundScreenTest
Flag: com.android.settings.flags.catalyst_sound_screen
Change-Id: Id3a51663d3c1203be0046d12b312c5b64dc26683
2024-10-11 04:00:17 +00:00
Treehugger Robot
c7be2f126e Merge "Better Support for profiles in "People that can interrupt"" into main 2024-10-07 20:11:09 +00:00
Treehugger Robot
7aabe039f4 Merge "Don't disable "Done" button when it cannot be pressed" into main 2024-10-07 17:27:33 +00:00
Matías Hernández
25d75c0df7 Merge "Don't crash when recreating ZenModeTimePickerFragment" into main 2024-10-07 16:49:20 +00:00
Matías Hernández
73c7ee115b Don't disable "Done" button when it cannot be pressed
Show an error on tap instead. According to a11y guidelines this is preferrable.

Fixes: 369942776
Test: atest ZenModeEditDonePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: Ib5e47a4151c1515e5085a776d538a27c2ef41574
2024-10-07 15:56:21 +00:00
Matías Hernández
504e927168 Better Support for profiles in "People that can interrupt"
* Show contacts from personal and work profile.
* Open personal or work profile Contacts app when choosing settings.
* Skip conversations with no ShortcutInfo (they are returned for a disabled work profile but we cannot show an icon for them).

Fixes: 371513451
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: Id8653a85ee4fd15dfccbecb3ea2d31e615d29f8c
2024-10-07 17:37:37 +02:00
Treehugger Robot
3ef49b9d5f Merge "[CDM][NLS] Check if the NLS service has an intent-filter" into main 2024-10-04 18:24:30 +00:00
Matías Hernández
e5720f43ee Don't crash when recreating ZenModeTimePickerFragment
Instead, just bail out.

Fixes: 369814629
Test: manual, with don't keep activities
Flag: android.app.modes_ui
Change-Id: I893b6363801b3a56bc29999dd801d7c8152cb5e8
2024-10-04 18:58:53 +02:00
Guojing Yuan
7ae59a42eb [CDM][NLS] Check if the NLS service has an intent-filter
Bug: 363248394
Test: CTS
Flag: EXEMPT bugfix
Change-Id: Ib79c219cde8d73a218ceb7911f4552d43e384d8e
2024-10-04 16:52:24 +00:00
Matías Hernández
154a91fc7e Merge "Use TextInputLayout for the name field in the create/rename mode page" into main 2024-10-03 20:45:04 +00:00
Matías Hernández
b234ca21ab Merge "Delete Settings code related to super-obsolete zen onboarding" into main 2024-10-03 17:01:36 +00:00
Julia Reynolds
8c2312d8ab Update dependent logic in modes vis page
If the list isn't visible, we shouldn't allow HUNs to be

Test: ZenModeNotifVisFragmentTest, manual
Fixes: 367222597
Flag: EXEMPT bugfix
Change-Id: I1dc72061dfb99aed8b644c703214b17d62b0532e
2024-10-03 15:28:50 +00:00
Matías Hernández
b1e28233c1 Use TextInputLayout for the name field in the create/rename mode page
In addition to looking nicer, this fixes two accessibility issues ("no hint when text is entered" and "reason for disabled button is unclear").

This requires a bit of theme merging black magic, because TextInputLayout requires a Theme.AppCompat descendant, which the Settings theme isn't.

Fixes: 356398157
Fixes: 370654542
Fixes: 369942776
Test: atest ZenModeEditNamePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I92d8ec044dabc6daed5d755e206120ec7abc143e
2024-10-03 14:14:34 +02:00
Treehugger Robot
2d9dc0521f Merge "Set content description for the "settings" of starred contacts, priority conversations, etc" into main 2024-10-02 00:51:31 +00:00
Matías Hernández
58a110bc48 Set content description for the "settings" of starred contacts, priority conversations, etc
Fixes: 368124250
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: Ib4e8bdd5ea0931db2049925f82696d3a55f35bcb
2024-10-01 18:51:19 +02:00
Treehugger Robot
69e512afbf Merge "Fix a11y readout of the day toggles in Time Schedule of Modes" into main 2024-09-30 17:24:12 +00:00
Matías Hernández
78367de795 Fix a11y readout of the day toggles in Time Schedule of Modes
Content description (full day name) replaces TextOn/TextOff (day name initial), and the state description no longer has the day name. As a result:
* the initial readout changes from "Monday, off, M, Switch" to "Off, Monday, Switch"
* when toggling, the name of the day is no longer repeated, and just "On/Off" is announced.

Fixes: 370360007
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: I57bbd7034e1af2836582720a7f4871a79d6644ab
2024-09-30 17:47:36 +02:00
Yining Liu
41cd514fb3 Notification Minimalism Settings Main Switch
Add a main preference switch for the lockscreen
notification minimalism feature

Bug: 330387368
Bug: 354047572
Flag: com.android.server.notification.notification_minimalism
Test: atest
LockscreenNotificationMinimalismPreferenceControllerTest

Change-Id: I9aa4c51f9e316dd0dd1529d712b5e9486e43453b
2024-09-26 20:58:18 +00:00
Yining Liu
8b6431878a Show the Tangor Unseen Notification Toggle when notification_minimalism is Enabled
Show the Tangor unseen notification toggle in the Notification settings when
notification_minimalism flag is enabled on both phones and large screen devices.

Bug: 330387368
Bug: 354047572
Flag: com.android.server.notification.notification_minimalism
Test: atest ShowOnlyUnseenNotificationsOnLockscreenPreferenceControllerTest
Change-Id: Ic126b7885eb29897b55c4acdc1a2f73b4bc7841e
2024-09-26 20:50:23 +00:00
Matías Hernández
a2e71cc7cb Delete Settings code related to super-obsolete zen onboarding
A notification was shown when upgrading from pre-P to P because default DND settings had changed. The default was later changed back so it was already obsolete at that point. Moreover, it should be impossible to upgrade from pre-P to V in one step.

Bug: 346789065
Test: N/A
Flag: EXEMPT Unflaggable -- removing resources, manifest entries, etc.
Change-Id: I2862211dc9709b741e60beca5fc029cc054745a3
2024-09-26 14:30:23 +02:00
Julia Reynolds
2fe4cb6393 Merge "Make legacy DND pages not searchable" into main 2024-09-24 20:19:17 +00:00
Julia Reynolds
0c5eb711a9 Make legacy DND pages not searchable
Flag: EXEMPT unflaggable
Fixes: 341726633
Test: manual, searching in settings
Change-Id: I592a1775a890711086db1099fb333c1dc1a11e0b
2024-09-24 15:18:16 +00:00
Matías Hernández
a78f2b834c Merge "Don't add the "Events" mode anymore, and delete it if disabled" into main 2024-09-23 12:49:05 +00:00
Treehugger Robot
d1ced23c7f Merge "Support customized summary in Channel Notification" into main 2024-09-23 00:10:43 +00:00
Treehugger Robot
35fafa5ef4 Merge "Fix mode icon sharing in modes list" into main 2024-09-20 15:36:00 +00:00
Matías Hernández
58b04ae7cf Fix mode icon sharing in modes list
Modes sharing the same icon would also share the applied tint (e.g. all with the "active" tint even if only the last one of them is active).

(Although it should never happen, also removed a potential NPE for mode icons without ConstantState).

Fixes: 367131481
Test: manual
Flag: android.app.modes_ui
Change-Id: I56867783310ea57f2e92c866ff0b5b53ac86bf37
2024-09-20 11:47:59 +02:00
yumeichen
4edaf1b804 Support customized summary in Channel Notification
Want to show the vibration name if customised vibration in channel notification is enabled. Therefore, need the summary function could be overrided.

Flag: com.android.server.notification.notification_vibration_in_sound_uri
Test: manual test
Bug: 351975435
Change-Id: I1fcd6deb3f176ef5943da59ae8861136d4a63f79
2024-09-20 08:51:58 +00:00
Matías Hernández
97f06864f8 Don't add the "Events" mode anymore, and delete it if disabled
Fixes: 368227085
Test: atest ZenModeHelperTest
Flag: android.app.modes_ui
Change-Id: Idd5563505ca92463485b433e80f29bf3e0f98d39
2024-09-19 13:51:19 +02:00
Treehugger Robot
2b9e976cbb Merge "Hide the Default Notification Sound if enabling customized vibration" into main 2024-09-19 10:07:01 +00:00
Treehugger Robot
ad856d326f Merge changes from topic "b361144180-PreferenceControllerMixin" into main
* changes:
  Move ListAddMode PrefController key to constructor
  ZenModesListAdd extend BasePreferenceContoller
2024-09-17 17:28:27 +00:00
Alexander Roederer
c6c5c1dfad Move ListAddMode PrefController key to constructor
Passes the key for the ZenModesListAddModePreferenceController into the
constructor, to be supplied from the Fragment.

Flag: android.app.modes_ui
Bug: 361144180
Test: atest ZenModesListAddModePreferenceControllerTest
Change-Id: I23d5c11f8676b9ed2bde807e24f20346444e7963
2024-09-17 16:15:00 +00:00
yumeichen
23bba426b5 Hide the Default Notification Sound if enabling customized vibration
Flag:com.android.server.notification.notification_vibration_in_sound_uri
Test: atest NotificationRingtonePreferenceControllerTest
Bug: 358525376

Change-Id: Ic7517828df746700ceb6e0605a9d32066c7aed50
2024-09-17 14:38:02 +00:00
Alexander Roederer
3791aa5ee9 ZenModesListAdd extend BasePreferenceContoller
Makes ZenModesListAddModePreferenceController extend
BasePreferenceController. This should fix warning statements, and has
the effect of adding "Create your own mode" to the Settings Search menu.

Test: build+flash
Bug: 361144180
Flag: android.app.modes_ui
Change-Id: Ic8675420b831818f658506f36938f38e803cc9aa
2024-09-17 03:20:39 +00:00
Matías Hernández
46744e40f0 Merge "Rename usages of ZenRule.isAutomaticActive() to isActive() in Settings" into main 2024-09-13 17:43:29 +00:00
Julia Reynolds
b8533bad72 Merge "Remove stale TODOs" into main 2024-09-12 15:56:43 +00:00
Treehugger Robot
4b8d2cacd5 Merge "Remove unneeded setttings search info" into main 2024-09-12 15:53:55 +00:00
Julia Reynolds
1b869f2845 Remove stale TODOs
These aren't in scope for the modes_ui release

Test: N/A
Flag: android.app.modes_ui
Bug: 354141067
Change-Id: I28887d766cde2d6a4e18a66a99d1625f80aa0667
2024-09-12 10:31:31 -04:00
Julia Reynolds
fcebcb2735 Remove unneeded setttings search info
Test: chage languages in Settings, search for a mode by name
Bug: 354141067
Flag: android.app.modes_ui

Change-Id: If12d76d268134e415510304278441a53d76af36d
2024-09-12 09:14:11 -04:00
Matías Hernández
5b26a37a7e Rename usages of ZenRule.isAutomaticActive() to isActive() in Settings
Bug: 363193376
Test: N/A, automatic refactor
Flag: EXEMPT automatic refactor
Change-Id: Ice1ceccbe09e6206555b2f2b75bd7ea39d24dfd7
2024-09-11 13:39:43 +00:00
Matías Hernández
c43be041f5 Merge "Support (non-editable) display of DND with a filter != PRIORITY" into main 2024-09-03 18:45:16 +00:00
Matías Hernández
b210f35a76 Prevent "new mode" and "choose schedule" dialogs from being created without a listener
This can happen if the activity is recreated; our approach doesn't support this case very well. With this change, the dialog is not reshown when the activity is recreated, which is not optimal but better than crashing (as it does today). There is no lost work because it's the first choice, and the follow-on steps (icon picker, etc) can be recreated without problems.

Fixes: 359746551
Test: manual, with don't keep activities
Flag: android.app.modes_ui
Change-Id: I84bdeb0007e8c50ec9dd8af61991c7e55ddb8298
2024-09-02 18:29:23 +02:00
Matías Hernández
50c954923f Support (non-editable) display of DND with a filter != PRIORITY
Whenever setInterruptionFilter() is called with NONE or ALARMS, the Do Not Disturb mode now shows the current policy (nothing allowed or alarms/media allowed), instead of the normal PRIORITY policy. This policy is read-only in the UI since it cannot be customized.

This should be, or at least become, pretty rare (with small exceptions, apps targeting V that call setInterruptionFilter() will use an implicit mode instead of changing the global zen mode, plus using these filters is quite nonstandard in itself).

Fixes: 361586248
Test: atest & manual (toggling DND via cmd shell)
Flag: android.app.modes_ui
Change-Id: If2439480235d30aa310ad8925341183b9761784c
2024-08-30 15:03:03 +02:00
Treehugger Robot
e6aaa5c87b Merge "Make ZenIconLoader injectable (in SystemUI)" into main 2024-08-29 22:59:49 +00:00
Yuri Lin
772928694f Merge "Add modes to Settings homepage." into main 2024-08-29 00:56:11 +00:00