Commit Graph

540 Commits

Author SHA1 Message Date
Doris Ling
f2cf2aea37 Remove code that check for dashboard feature.
- remove DashboardFeatureProvider.isEnabled() and all relating code
and tests.

Bug: 35764802
Test: make RunSettingsRoboTests
Change-Id: If7796677abc8904b7436525836d50cdef38e37a4
2017-03-07 11:15:03 -08:00
Nathan Harold
8202c202dd Update references to use PhoneConstantConversion
Bug: 33414487
Change-Id: I391671e38406235da48bddf61a70699974367e33
2017-03-03 10:10:09 -08:00
TreeHugger Robot
05c3333cbd Merge "Ensure DashboardFragment shares pref controlls with search" 2017-03-02 18:56:09 +00:00
Garfield Tan
6d3947e2c1 Merge "Remove DocumentsContract.ACTION_BROWSE." 2017-03-02 00:35:59 +00:00
TreeHugger Robot
afb57ecc35 Merge "Let fragment and indexProvider share prefControllers" 2017-03-01 22:12:35 +00:00
Fan Zhang
c1c708f979 Ensure DashboardFragment shares pref controlls with search
Test: make RunSettingsRoboTests
Change-Id: I48be270d9706539925d00874bae29d46406ac491
Fix: 35812240
2017-03-01 13:29:11 -08:00
Fan Zhang
b00811da64 Let fragment and indexProvider share prefControllers
Bug: 35812240
Test: make RunSettingsRoboTests
Change-Id: Ifd96f935836a52e0a56f170f3cdf9b9ddf7c499a
2017-03-01 12:56:58 -08:00
Daniel Nishi
01a9935528 Merge "Use the new package stats query." 2017-03-01 20:55:01 +00:00
Garfield Tan
2d01be108d Remove DocumentsContract.ACTION_BROWSE.
Test: Code builds and tests pass.
Bug: 35760993
Change-Id: I7e540b71a7be60d250ffec899eb5c08941dc24a8
2017-03-01 12:09:56 -08:00
Daniel Nishi
73a1c2afb3 Use the new package stats query.
This allows us to remove the logic w.r.t. uid merging.

Bug: 35754646
Test: StorageAsyncLoaderTest
Change-Id: I93aff1d55e0e761269c135f0e821ed2067eeda06
2017-02-28 13:30:13 -08:00
Daniel Nishi
b6059a9e98 Use "Music & audio" as the title for the music view.
Change-Id: I33bc5ccf55ee09842368b2fd4a83b9fd492eded0
Fixes: 35713002
Test: Manual
2017-02-28 01:36:22 +00:00
TreeHugger Robot
52c5c54ef8 Merge changes from topic 'build_number_logging'
* changes:
  Log when build number preference is clicked.
  DeviceInfo: move more prefereces in PreferenceController
2017-02-25 01:19:19 +00:00
Fan Zhang
f42377a18e Log when build number preference is clicked.
Optionally also log whether user is in development mode.

Change-Id: I1f5dc2891b2c4fc74f940e3118fb09ee18cc9688
Fix: 34774945
Test: make RunSettingsRoboTests
2017-02-24 15:39:02 -08:00
Fan Zhang
efb8d625a2 DeviceInfo: move more prefereces in PreferenceController
Bug: 34774945
Test: make RunSettingsRoboTests
Change-Id: Ie5e113a6df85bab5be50c947bd7b91cfacdccb7f
2017-02-24 14:34:34 -08:00
Jason Monk
6fca98f905 Switch references to colorError
Test: make
Change-Id: I0ed10d78763642cecc5ba8e8e15a097d51280946
2017-02-24 14:57:31 -05:00
Fan Zhang
69e95c6e75 DeviceInfo: Wrap prefereces in PreferenceController
Bug: 34774945
Test: make RunSettingsRoboTests
Change-Id: I8bf56b436064684f4d2010e6899548249af69fc3
2017-02-23 17:30:34 -08:00
TreeHugger Robot
4bc851b520 Merge "Convert DeviceInfoSettings into a dashboard fragment." 2017-02-23 19:16:22 +00:00
Daniel Nishi
63558780a5 Merge "Add support for user profiles to the Storage Settings." 2017-02-23 18:39:35 +00:00
Fan Zhang
c62e2f033d Convert DeviceInfoSettings into a dashboard fragment.
This is needed to use logging from DashboardFragemnt.
This page is now a mixture of PrefernceController and non-controller
preferences.

Also permanently removed system update preference from xml to simplify
migration

Todo: convert the rest of preference into controller.

Bug: 34774945
Test: make RunSettingsRoboTests
Change-Id: Ie5130ea7377db2ccf2236cdf48e5cc26d1347d7a
2017-02-23 09:42:57 -08:00
Daniel Nishi
e3ac0cd6db Use the upstreamed StorageStatsSource wrapper.
This was upstreamed into SettingsLib when similar wrappers
started showing up in other projects. Settings, however, was
using the non-upstreamed version.

Change-Id: Iffadb75655165d3b64a25fd7b21e5b9765cb40be
Fixes: 35680800
Test: Settings Robotests still pass despite the data swap out.
2017-02-22 17:49:41 -08:00
Daniel Nishi
9f60f42a94 Add support for user profiles to the Storage Settings.
This adds new preferences for each profile (such as the work
profile) and defines a new view for viewing the storage
breakdown for the individual profile. The functionality closely
mimics the presentation on the main view, but without the system-wide
breakdown and without any additional users/profiles.

Bug: 34715777
Test: Settings Robotests

Change-Id: I19d449b648c6566331fd02e45c2e45f8c74ea7e7
2017-02-22 17:33:24 -08:00
Daniel Nishi
b826edb2af Add logging to help debug loader issue.
Sometimes, it looks like the loader is not returning the result
to populate the storage settings view. The current bug reports
have no smoking guns. By adding this debug logging to the build,
the bug reports should hopefully help lead us to where the bug
is originating.

Bug: 35389719
Test: None
Change-Id: Ifa3f69f1fb4669aa72e6ef9c7ccc9d74b9e0fa71
2017-02-21 16:26:10 -08:00
Daniel Nishi
422e7c354d Update the loading of info for the secondary users.
Bug: 34715777, 34225103
Test: Settings Robotest
Change-Id: I32bb15ad8bc866c1fd41728e56faa8b09ae11eb6
2017-02-21 12:08:28 -08:00
Daniel Nishi
dfed8a2acb Add support for visualizing secondary users.
This functionality adds the secondary users to the screen, but
currently does not populate the information for them. Once the
external stats query works, I will add a loader which will
populate this information.

This also does not cover work profiles. Support for that is
forthcoming.

Bug: 34715777, 34225103
Test: Settings Robotest
Change-Id: Ib9b692b214f5ce5d303dfd64516381443d4acebd
2017-02-21 12:07:23 -08:00
TreeHugger Robot
76cf6f9a68 Merge "Fix problem with usb mode summary not updated correctly." 2017-02-18 01:00:00 +00:00
Doris Ling
21711681ea Fix problem with usb mode summary not updated correctly.
In UsbBackend, do not cache the usb state, but re-read it everytime when
we try to get the usb data mode.

Change-Id: I6f2863a59ee8df2c50901a630e3e145714c7dc46
Fix: 34234065
Test: make RunSettingsRoboTests
2017-02-17 15:22:13 -08:00
Daniel Nishi
e0eb1a2e27 Add metric events triggers for new storage actions.
Bug: 35063738
Test: Settings Robotests
Change-Id: I435cb16c492d3777e735266c2d3a2b1930443acb
2017-02-16 13:43:03 -08:00
Fan Zhang
c6ca314c0b Log source with visibility change
- Add a method in VisibilityLoggerMixin to log visible event using
  LogMaker, which allows logging additional FIELD_CONTEXT field.
- In Utils.startFragment, add current page's metricsCategory as an extra
  to next page.
- In next page's onResume(), extract the previous page's metricsCategory
  and send it to VisibilityLoggerMixin.visible()
- Update all caller with additional paramters

Change-Id: I8e1f2597fa465b7d3aa16fa1d21c052a3219694a
Fix: 35359289
Test: RunSettingsRoboTests
2017-02-15 17:17:19 -08:00
Salvador Martinez
2f0bee5032 Replace footer with regular preference
Replaced the "Manage Storage" footer preference
with a regular preference because the footer type
is not meant to be a touch target. This should fix
the bug with not being able to click on specific
parts of the preference.

Test: run settings espresso tests
Bug: 34349518
Change-Id: I36ada2a6a537a68d9fcbe7e10773896225ecc6b2
2017-02-14 14:12:56 -08:00
Fan Zhang
4f9e8d4a14 Update storage setting summary text format.
New format: 38% used - 19.80 GB free

Bug: 34975053
Test: make RunSettingRoboTests
Change-Id: I7c8f5f0fe825eade8167764622c940e8234be6a9
2017-02-09 17:08:34 -08:00
Daniel Nishi
10ec524e61 Merge "Use the "fast track" storage calculation for all categories." 2017-02-08 21:23:02 +00:00
Doris Ling
b2539e010f Fix for null pointer when launching Connected devices.
Check for null usb port before trying to loop through the list.

Change-Id: I37e44fac234fc6e774b8280509fb33e6165ce2dd
Fix: 35102512
Test: make RunSettingsRoboTests
2017-02-07 17:20:21 -08:00
Daniel Nishi
7cec1bc53c Use the "fast track" storage calculation for all categories.
Bug: 34204877
Test: Settings Robo
Change-Id: I4a3e26e6e96e9b697c1019160c053b079076d3a2
2017-02-02 13:02:32 -08:00
Daniel Nishi
0905600b7a Use the fast track calculation for apps.
This replaces the calculation of the apps category
and add in a calculation for the games category using
the faster GID calculation. This should result in app
sizes loading roughly 10 times after.

Bug: 34204877
Test: Settings unit & robo tests
Change-Id: I78044a8d50f695f8c0a7e04183030232a9719260
2017-02-01 14:02:03 -08:00
Daniel Nishi
d1172942ee Merge "Add a music apps view to the Storage Settings." 2017-02-01 21:01:56 +00:00
Daniel Nishi
1db848885d Go to the old storage settings when using non-internal storage.
There are a few things which, currently, can only be done on
the old storage view. We can continue to use the storage
dashboard fragment for the internal storage, but for SD cards
and USB drives it makes sense to show the old view.

Bug: 34623728
Test: Manual
Change-Id: Ibe640decea6486a75034184c8f9f95bf00411553
2017-01-26 15:03:00 -08:00
Daniel Nishi
31027dae93 Add a music apps view to the Storage Settings.
When you tap the Music & Audio preference, it takes you a
hybridized applications view. In this view, there also is
a line item which defines the amount of storage used by
audio files on the device. Using the new storage query, we
can add this information very quickly to the view.

Bug: 33199077
Test: Settings robo tests
Change-Id: If51cba0b3de20805543a39049367eb13613081e7
2017-01-25 11:56:02 -08:00
Daniel Nishi
f68bb3d78f Add an automated test for the null bundle crash.
Bug: 34633464
Test: Settings robotest .
Change-Id: I244e58c3660ea3376dbeb6293da54c99a98e3157
2017-01-25 09:59:25 -08:00
TreeHugger Robot
2965d7505d Merge "Remove getCategoryKey() from DashboardFragment children." 2017-01-25 00:21:24 +00:00
Fan Zhang
7e6df837ee Remove getCategoryKey() from DashboardFragment children.
Use the centralized registry to look up category key instead.

Bug: 32936784
Test: make RunSettingsRoboTests -j40
Change-Id: I0b8c72d70f93e4b5c58871ac90de41f69ad15653
2017-01-24 14:51:15 -08:00
Daniel Nishi
2b25b07a7b Merge "Hook up the Games storage category preference to a games view." 2017-01-24 21:55:31 +00:00
Daniel Nishi
c208eff2f8 Hook up the Games storage category preference to a games view.
This patch adds functionality for the soon-to-be-deprecated games
and the new app categorization.

Bug: 33199077
Test: settings robo
Change-Id: Iae055c6f1b4d1af3f51aba9897c140ae7aac41c9
2017-01-24 09:43:58 -08:00
Daniel Nishi
4d4142b6aa Fix a bug where Settings would crash from search into storage.
If the user entered the StorageDashboardFragment from search,
it would crash due to a precondition check added to the Storage
Manager. Because no volume id was set in the bundle for it to
check, it hits an assert that the volume id is not null causing
Settings to crash.

This sets a sensible default instead of null.

Bug: 34633464
Test: Manual. Entering through search does not crash now.
Change-Id: Ia6cd82929a0813eefcdad279436b9c2fe30b0146
2017-01-24 09:29:38 -08:00
TreeHugger Robot
6596c8ff4e Merge "Launch the Gallery app to manage photos from the Storage screen." 2017-01-17 21:02:57 +00:00
Daniel Nishi
8a2ff52e61 Merge "Update StorageSettings to use StorageDashbordFragment." 2017-01-13 22:06:46 +00:00
Daniel Nishi
f7fc304724 Launch the Gallery app to manage photos from the Storage screen.
This replaces the old behavior of opening the Files app and
matches the latest mocks.

Bug: 33199077
Test: settings robo
Change-Id: Id6451300063fcb3f10c6272c2a2fa49fe1384ac5
2017-01-13 10:44:12 -08:00
Daniel Nishi
a3494347e4 Add ASM enabled/disabled text to the Storage settings.
Bug: 33199077
Test: Settings Robo Tests
Change-Id: I86897c63b584d3c8be171723367a6b4e060684f3
2017-01-12 02:37:12 +00:00
Daniel Nishi
b465005c29 Update the storage summary header.
This changes it to now have a donut graph and reflects the new UI.
Finalized redlines are still pending, so there will be a follow
up patch to get everything aligned as per the mocks.

Bug: 33199077
Test: Settings Robo Tests
Change-Id: Ic12a77bd9be335af14f80886d1ecc24c82940e9b
2017-01-11 12:37:33 -08:00
Daniel Nishi
884809199f Hook up the storage item preferences to actual data.
This uses the same storage query implementation as the previous
iteration of the Storage Settings. In b/32206268, a new API for
querying this information will be added for querying this info.

Once the new API has landed, a future patch will swap out the
impl, but this should work for today.

Bug: 33199077
Test: Settings Robo Tests
Change-Id: I58763e8ee38aabbea533bc614268288e854ff8d4
2017-01-10 17:52:52 -08:00
Daniel Nishi
8cc6f9f718 Add click behavior to the storage item preferences.
This currently imitates the previous implementation behavior.
The new mocks have a new intermediate view for some of these
behaviors, but this view isn't ready yet.
This patch should bring parity for the click functionality
for the storage line item preferences.

Bug: 33199077
Test: Settings Robo Tests

Change-Id: I4f654d30add92e4eec721c36b2801f9af9824e78
2017-01-10 16:46:44 -08:00