Commit Graph

54961 Commits

Author SHA1 Message Date
Treehugger Robot
c7be2f126e Merge "Better Support for profiles in "People that can interrupt"" into main 2024-10-07 20:11:09 +00:00
Treehugger Robot
7aabe039f4 Merge "Don't disable "Done" button when it cannot be pressed" into main 2024-10-07 17:27:33 +00:00
Matías Hernández
25d75c0df7 Merge "Don't crash when recreating ZenModeTimePickerFragment" into main 2024-10-07 16:49:20 +00:00
Matías Hernández
73c7ee115b Don't disable "Done" button when it cannot be pressed
Show an error on tap instead. According to a11y guidelines this is preferrable.

Fixes: 369942776
Test: atest ZenModeEditDonePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: Ib5e47a4151c1515e5085a776d538a27c2ef41574
2024-10-07 15:56:21 +00:00
Matías Hernández
504e927168 Better Support for profiles in "People that can interrupt"
* Show contacts from personal and work profile.
* Open personal or work profile Contacts app when choosing settings.
* Skip conversations with no ShortcutInfo (they are returned for a disabled work profile but we cannot show an icon for them).

Fixes: 371513451
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: Id8653a85ee4fd15dfccbecb3ea2d31e615d29f8c
2024-10-07 17:37:37 +02:00
SongFerng Wang
817cc47b28 Merge "Refactor the getCurrentCarrierNameForDisplay" into main 2024-10-07 09:23:04 +00:00
SongFerng Wang
27d969bb48 Refactor the getCurrentCarrierNameForDisplay
Bug: 370884447
Change-Id: I4abfbd520297e5c000984fcd5b6a2ad4db9a35e9
Test: NA
Flag: EXEMPT bugfix
2024-10-07 07:34:12 +00:00
Treehugger Robot
f82f48a621 Merge "Add log for new error string in WiFi QR code scanning" into main 2024-10-07 07:33:29 +00:00
Treehugger Robot
3ef49b9d5f Merge "[CDM][NLS] Check if the NLS service has an intent-filter" into main 2024-10-04 18:24:30 +00:00
Chun-Ku Lin
b3ebc1968d Merge "[Physical Keyboard][Setting] New pk a11y entry under a11y page" into main 2024-10-04 17:40:21 +00:00
Matías Hernández
e5720f43ee Don't crash when recreating ZenModeTimePickerFragment
Instead, just bail out.

Fixes: 369814629
Test: manual, with don't keep activities
Flag: android.app.modes_ui
Change-Id: I893b6363801b3a56bc29999dd801d7c8152cb5e8
2024-10-04 18:58:53 +02:00
Guojing Yuan
7ae59a42eb [CDM][NLS] Check if the NLS service has an intent-filter
Bug: 363248394
Test: CTS
Flag: EXEMPT bugfix
Change-Id: Ib79c219cde8d73a218ceb7911f4552d43e384d8e
2024-10-04 16:52:24 +00:00
Diya Bera
cb6b37e6d6 Merge "Avoid using MANDATORY_BIOMETRICS bit if flag is not enabled" into main 2024-10-04 15:39:48 +00:00
Diya Bera
aa322bc4f7 Avoid using MANDATORY_BIOMETRICS bit if flag is not enabled
Flag: android.hardware.biometrics.flags.mandatory_biometrics
Bug: 370757426
Test: N/A
Change-Id: I4e2a72a80f68579d60466e859370b6fd93a8cd23
2024-10-04 14:10:24 +00:00
Hakjun Choi
20f3fa9846 Merge "Hide extra information link when it is empty" into main 2024-10-04 13:20:06 +00:00
Weng Su
5644fe1aa7 Add log for new error string in WiFi QR code scanning
Bug: 371506692
Flag: EXEMPT log only update
Test: manual test
Change-Id: I2bc15b0aa0a98a5f8193383decb60308544c810c
2024-10-04 18:27:34 +08:00
Hakjun Choi
c2c2722771 Hide extra information link when it is empty
Extra information may be or may not be provided as this is given from the Carriers, therefore it is needed to hide when there is no given URL string

Bug: 360265682
Flag: EXEMPT bugfix
Test: manually test when extra information is valid and when extra information is empty
      https://b.corp.google.com/issues/360265682#comment2 for UI test
result

Change-Id: Icf7f06e6af8580d0e84382a2598be75e321cf657
2024-10-04 10:17:47 +00:00
shaoweishen
f0b6123acc [Physical Keyboard][Setting] New pk a11y entry under a11y page
Add entry for physical keyboard a11y page under a11y setting

Bug: 345399212
Test: atest SettingsRoboTests
Flag: com.android.settings.keyboard.keyboard_and_touchpad_a11y_new_page_enabled
Change-Id: I0c59c3a9df1b5df5e22349ab3907f767682d6fb9
2024-10-04 09:06:10 +00:00
SongFerng Wang
7c6b213c73 Merge "VideoCalling UI adds the init value" into main 2024-10-04 04:55:46 +00:00
Joseph Vincent
5087754b42 Merge "Show custom unlock title for private profile" into main 2024-10-04 02:24:48 +00:00
Matías Hernández
154a91fc7e Merge "Use TextInputLayout for the name field in the create/rename mode page" into main 2024-10-03 20:45:04 +00:00
Treehugger Robot
6471850a00 Merge "Remove obsolete zen-related entries from CustomSiteMapRegistry" into main 2024-10-03 18:57:00 +00:00
Matías Hernández
c238b3b1cf Remove obsolete zen-related entries from CustomSiteMapRegistry
These pages no longer exist with MODES_UI.

Bug: 346789065
Test: atest CustomSiteMapRegistryTest
Flag: android.app.modes_ui
Change-Id: I254b4eb15a71bf7a6765c1ea7d0cb31c59fe2f0c
2024-10-03 19:46:21 +02:00
Matías Hernández
b234ca21ab Merge "Delete Settings code related to super-obsolete zen onboarding" into main 2024-10-03 17:01:36 +00:00
Treehugger Robot
b589ba5e94 Merge "Update dependent logic in modes vis page" into main 2024-10-03 16:30:28 +00:00
Julia Reynolds
8c2312d8ab Update dependent logic in modes vis page
If the list isn't visible, we shouldn't allow HUNs to be

Test: ZenModeNotifVisFragmentTest, manual
Fixes: 367222597
Flag: EXEMPT bugfix
Change-Id: I1dc72061dfb99aed8b644c703214b17d62b0532e
2024-10-03 15:28:50 +00:00
Tetiana Meronyk
5583281ba4 Merge "Update search index in UserSettings based on allowed user types" into main 2024-10-03 15:27:52 +00:00
songferngwang
8e6bc6f289 VideoCalling UI adds the init value
Bug: 367696228
Test: atest VideoCallingPreferenceControllerTest
Flag: EXEMPT bugfix
Change-Id: I1a1de9e3174a9211be619c96c104607f831b51a2
2024-10-03 14:29:05 +00:00
josephpv
6a333a2ac3 Show custom unlock title for private profile
With this change whenever private space is unlocked and has its own lock
different from device lock, it shows a custom title for PS in the unlock
screen.

Custom title for private profile will be  shown in the auth screen while
authentiation of private lock for the below usecase inside PS settings.
- Auth shown while Delete private space from PS settings
- Switching to device screen lock from a separate private space lock
- Changing the private space lock type(Ex: from pattern to PIN)
- Adding a biometric(face/fingerprint) for private profile

When auth screen with custom title is put to background and the screen
is in the recents list and if private space is locked then the auth
scren with the title is removed from recents list along with the other
settings task.

Bug: 323835257
Test: Manual
Change-Id: Ia0cc0b9bb54a429ebe027dc0937320e7fd23cb81
Flag: android.multiuser.show_custom_unlock_title_inside_private_profile
2024-10-03 12:28:43 +00:00
Matías Hernández
b1e28233c1 Use TextInputLayout for the name field in the create/rename mode page
In addition to looking nicer, this fixes two accessibility issues ("no hint when text is entered" and "reason for disabled button is unclear").

This requires a bit of theme merging black magic, because TextInputLayout requires a Theme.AppCompat descendant, which the Settings theme isn't.

Fixes: 356398157
Fixes: 370654542
Fixes: 369942776
Test: atest ZenModeEditNamePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I92d8ec044dabc6daed5d755e206120ec7abc143e
2024-10-03 14:14:34 +02:00
Tetiana Meronyk
1da65db12f Update search index in UserSettings based on allowed user types
If USER_TYPE_FULL_RESTRICTED is disallowed, addUserPreference is renamed to only mention user. But search results still state default name "Add user or profile". This change updates this entry in the search index.

Bug: 365899560
Test: atest UserSettingsTest#testGetRawDataToIndex_returnAllIndexablePreferences && atest UserSettingsTest#testGetRawDataToIndex_addRestrictedProfileAllowed_addUserTitleIsCorrect && atest UserSettingsTest#testGetRawDataToIndex_addRestrictedProfileDisallowed_addUserTitleIsCorrect
Flag: EXEMPT bugfix_only
Change-Id: I3c26180225491e4916141a3fca9d2e7ab36e8cfc
2024-10-03 12:02:44 +00:00
Edgar Wang
fd84f1203e Merge "Update the layout of AppDataUsagePreference" into main 2024-10-03 01:16:12 +00:00
Treehugger Robot
78153998c7 Merge "Distinguish different errors of wifi QR code" into main 2024-10-02 21:26:00 +00:00
Yufan Cao
73f66eb8f1 Distinguish different errors of wifi QR code
When failure occurs after scanning wifi QR code, only "Check connection
and try again" will show, which is confusing for user to understand the
errors and take next action.

Add more string resources to cover different errors.

Co-authored-by: Yufan Cao <Yufan.Cao@sony.com>

Flag: EXEMPT bugfix
Test: manual test
Bug: 362305039
Change-Id: I85145eb67eecdc3aa06bb7b8a7b3e7f0ffea1f62
2024-10-02 20:23:42 +00:00
Treehugger Robot
2d9dc0521f Merge "Set content description for the "settings" of starred contacts, priority conversations, etc" into main 2024-10-02 00:51:31 +00:00
Matías Hernández
58a110bc48 Set content description for the "settings" of starred contacts, priority conversations, etc
Fixes: 368124250
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: Ib4e8bdd5ea0931db2049925f82696d3a55f35bcb
2024-10-01 18:51:19 +02:00
Treehugger Robot
91c78e7223 Merge "Don't register DndConditionCardController anymore" into main 2024-10-01 03:11:05 +00:00
Riley Jones
b2b9bc2371 Merge "Refactoring A11y shortcut functions in Settings to use GESTURE" into main 2024-09-30 19:38:10 +00:00
Treehugger Robot
69e512afbf Merge "Fix a11y readout of the day toggles in Time Schedule of Modes" into main 2024-09-30 17:24:12 +00:00
Edgar Wang
4dc5a005c8 Update the layout of AppDataUsagePreference
The layout of AppDataUsagePreference including a progressbar, that's not common pattern in SettingsLib.

Bug: 365506467
Bug: 370456736
Change-Id: I28d25724067d85f8d37c3b5273d38055ba7021a6
Test: atest
Flag: EXEMPT bugfix
2024-09-30 16:42:33 +00:00
Matías Hernández
78367de795 Fix a11y readout of the day toggles in Time Schedule of Modes
Content description (full day name) replaces TextOn/TextOff (day name initial), and the state description no longer has the day name. As a result:
* the initial readout changes from "Monday, off, M, Switch" to "Off, Monday, Switch"
* when toggling, the name of the day is no longer repeated, and just "On/Off" is announced.

Fixes: 370360007
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: I57bbd7034e1af2836582720a7f4871a79d6644ab
2024-09-30 17:47:36 +02:00
Jacky Wang
2a10845913 Merge "Add test case for Firmware version and Legal screens" into main 2024-09-30 09:46:16 +00:00
Jacky Wang
2ce3671e3e Add test case for Firmware version and Legal screens
NO_IFTTT=For test only

Bug: 370394101
Flag: EXEMPT Add tests
Test: UT
Change-Id: I1d105e1a54fe0ff6da9d64c54c3c825c87a83b14
2024-09-30 15:41:29 +08:00
Haijie Hong
451dc11ed9 Merge "Add audio category preference in more settings fragment" into main 2024-09-29 12:06:44 +00:00
Treehugger Robot
77a8da1f8d Merge "Create only one media session per audio stream media service." into main 2024-09-29 12:03:17 +00:00
chelseahao
80e1b69aa7 Create only one media session per audio stream media service.
This might cause callback not being cleaned up properly even if the service is destroyed.

Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362140159 369452993
Change-Id: I389735162c1f9e41cea25f63f881c20be4effb60
2024-09-29 18:57:01 +08:00
Haijie Hong
78cce9cd50 Add audio category preference in more settings fragment
BUG: 343317785
Test: local tested
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I427a85159881205805933023020db2db73d729b6
2024-09-29 13:44:33 +08:00
Riley Jones
3d4b0c5440 Refactoring A11y shortcut functions in Settings to use GESTURE
Properly integrating GESTURE into Settings, so that text pertaining to the gesture shortcut are displayed when appropriate.
Heavy refactoring has been done to allow for easier cleanup and expansion

Demo video: https://x20web.corp.google.com/users/jo/jonesriley/splitShortcut/a11ySettingsGestureCompat.mp4

NO_IFTTT=changes do not alter the order of the shortcuts.

Bug: 365570709
Test: atest com.android.settings.accessibility
Flag: android.provider.a11y_standalone_gesture_enabled
Change-Id: If90719763a48e3b8bc35988a1de9a352a766953b
2024-09-28 02:50:09 +00:00
SongFerng Wang
4e05cd99a9 Merge "Hide the enabling mobile data" into main 2024-09-28 00:55:48 +00:00
Tomasz Wasilczyk
c25a0b8f9d Merge "Add support for ApnSetting.TYPE_OEM_PAID and OEM_PRIVATE" into main 2024-09-27 21:35:52 +00:00