Commit Graph

2920 Commits

Author SHA1 Message Date
hoffc
ef2e171b50 Settings: Fix force close for telephony callback exceeding limitation
When sub info changed, new telephony callback will be registered but old telephony callback not un-registered. Finally result in force close for registered telephony callback count exceeding its allowed.

No need to re-registered the telephony callback for one sub if registered.

Bug: 328716180

Change-Id: Ia0c3b311b5b5cc77f061d81ec21250abde2fa9f4
2024-03-21 17:32:13 +08:00
Charlotte Lu
2ed4bfb67a Merge "Provide confirmation if creating new APN is not filled in enough and add a save button." into main 2023-12-14 06:23:01 +00:00
Charlotte Lu
92c0c12ddd Provide confirmation if creating new APN is not filled in enough and add a save button.
Test: Visual Test
Fix: 315112333, 315111729
Change-Id: Ic0044ca03baae138247489715c084980c01ae9b2
2023-12-14 13:40:02 +08:00
Jan Tomljanovic
db1402a4df Always confirm eSim removal.
Test: atest DeleteSimProfilePreferenceControllerTest
Bug: 313604661

Change-Id: I0c43790bf43bedcc2e8075aa7be0b25876c731b4
2023-12-12 15:57:19 +00:00
Hyunho Shin
a2555df74c Merge "Add the condition to show the eSIM convert menu." into main 2023-12-12 06:33:33 +00:00
Chaohui Wang
e96900d1ae Merge "Fix the isEmbeddedSubscriptionVisible logic" into main 2023-12-12 05:21:01 +00:00
Hyunho
036ed3fcee Add the condition to show the eSIM convert menu.
When pSIM converts to eSIM, the new eSIM is downloaded and pSIM is disabled.
However, if the pSIM is in the preferred SIM, a pop-up occurs that says the downloaded eSIM is preferred.
This may cause confusion for users regarding seamless pSIM conversion.
Therefore, change the condition to show the convert menu if there is a pSIM, pSIM conversion is supported, and there is no active eSIM.

Bug: b/314881248
Test: manual done
Change-Id: I10134057a9ae7845ab9fb8b9b8b9f85629d33fa0
2023-12-12 04:56:19 +00:00
SongFerng Wang
e4d761254e Fix the isEmbeddedSubscriptionVisible logic
Bug: 314736037
Change-Id: I10ddafbad1590a660735466c0f6d7e9ed8bffcff
Test: local test
2023-12-12 04:26:43 +00:00
Chaohui Wang
fe2a106d5c Fix cold startup of NetworkProviderCallsSmsController
Network & internet is shown at the very beginning when activity
embedding is enabled.

Fix: 311604902
Test: manual - with TestDPC
Change-Id: Ic27455e34a9ba4b48b8e72fd30d5b8d9e4be7194
2023-12-11 16:29:58 +08:00
SongFerng Wang
dd2cc366a6 Merge "Add condition whether esim is visible or not" into main 2023-12-11 05:52:47 +00:00
SongFerngWang
ec27c60461 Add condition whether esim is visible or not
Bug: 314736037
Test: SubscriptionInfoListViewModelTest pass and build pass
Change-Id: I7dc86ca93691f044d951122c0c669c790b7aef98
2023-12-11 05:47:49 +08:00
Charlotte Lu
18808379ed Merge "Telephony Issue: Apn config mmsc should start with http but is 啊." into main 2023-12-08 04:31:07 +00:00
Charlotte Lu
0a896ff0f6 Telephony Issue: Apn config mmsc should start with http but is 啊.
Test: Visual Test
Fix: 313630772
Change-Id: I46dfabde31f0df7b4b0fd473aff24f9707987114
2023-12-07 14:30:27 +08:00
Hyunho
18bbda7eff Enalbe the convert to eSIM menu
Bug : b/314881248
Test: manual done
Change-Id: Ib320cf3b3fc06ccf46be98f8c7afbe480df3bb79
2023-12-06 03:13:23 +00:00
Chaohui Wang
0664d3cc45 Clean up AllInOneTetherSettings
This project is not on-going.

Clean up to help improve latency.

Bug: 311604902
Test: manual - on Network & internet page
Test: robo test
Change-Id: I6addb92e5587206661d1b64bdc56473a85ba9c9f
2023-11-30 12:27:33 +08:00
Chaohui Wang
880068d23a Avoid ANR of TetherPreferenceController
Off load the following work from main thread,
- Calculate title
- Calculate summery

This also helps improve the latency.

Also migrate to registerTetheringEventCallback() since
TetheringManager.ACTION_TETHER_STATE_CHANGED is deprecated.

Fix: 311848767
Test: manual - on Network & internet page and turn on / off tethering
Test: unit tests
Change-Id: I6ee182b41ef51f691ea31938142be1a41faf5573
2023-11-29 12:06:37 +08:00
Charlotte Lu
4ac2d9c8db Merge "Automatically save on return" into main 2023-11-28 06:21:03 +00:00
Chaohui Wang
34d9392dfd Merge "Clean ProxyPreferenceController" into main 2023-11-28 05:33:12 +00:00
Chaohui Wang
b5da10e797 Clean ProxyPreferenceController
This is a controller without UI.

Bug: 311604902
Test: manual - on Network & internet page
Change-Id: Id88709b5c3f64ef7f6b441260b4b88ce7a9a5847
2023-11-28 11:07:44 +08:00
Weng Su
129ff9b8fe Fine-tune launch time in Network & Internet settings
- Avoid creating WifiPickerTracker if Hotspot network feature is not enabled

Fix: 312905628
Test: unit test
atest -c InternetPreferenceControllerTest

Change-Id: I5818698ce06244aa7660e90a5f2fd372a3a221bf
2023-11-28 06:51:39 +08:00
Charlotte Lu
c776835da5 Automatically save on return
Test: Visual Test
Fix: 313008844
Change-Id: I795807d1984bbd170db3fdc9e54de700ff85ec69
2023-11-27 14:48:15 +08:00
Chaohui Wang
a39905eabd Clean up unused MobilePlanPreferenceController
Which can improve the latency of "Network & internet" page.

Bug: 311604902
Test: manual - on "Network & internet" page
Change-Id: If306e93491402278ede4f20591296765b30bde37
2023-11-24 23:55:14 +08:00
Weng Su
203931d038 Show Hotspot network in Network & internet settings
- Show Hotspot icons

- Show getAlternateSummary instead of original getSummary

Fix: 308187592
Test: unit test
atest -c InternetPreferenceControllerTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a9ea40dc71362b372c5adc89b82dbe2024253688)
Merged-In: I8afe54edebc904c9ec936f5851a33c6c20f13e29
Change-Id: I8afe54edebc904c9ec936f5851a33c6c20f13e29
2023-11-22 09:58:07 +00:00
SongFerng Wang
7126fddfe4 Merge "Renew the API getCallState" into main 2023-11-22 01:47:55 +00:00
Charlotte Lu
41252bc6e6 Merge "Add delete apns" into main 2023-11-21 11:15:16 +00:00
Charlotte Lu
27ce9d95f8 Add delete apns
Test: Visual Test
Fix: 312361022
Change-Id: Idcc58ee6d511462bef857f29afab9fdd7be453d5
2023-11-21 17:15:05 +08:00
Charlotte Lu
3a1252a6d5 APNs missing while numeric is null in add mode.
Test: Visual Test
Fix: 312142091
Change-Id: I2b7d4580dcb3fda08ce8d147ed827ee4383befba
2023-11-21 14:47:15 +08:00
Charlotte Lu
276f30e3b0 APNs missing while numeric is null
Test: Visual Test
Fix: 312142091
Change-Id: I1920e3e2dd534d385d0282295e0c3680051d4728
2023-11-20 11:23:46 +00:00
SongFerng Wang
2d16858c17 Renew the API getCallState
Since the getCallState was marked as @Deprecated, renew this API as the getCallStateForSubscription. 

Bug: 279852410
Test: build pass

Change-Id: I224164a2d1089483d4f63da1651d7e87296e87f4
2023-11-20 10:49:19 +00:00
Chaohui Wang
9e0bd18686 Fix restriction to configure Calls & SMS
Restriction UserManager.DISALLOW_CONFIG_MOBILE_NETWORKS is added.

Fix: 278062379
Test: manual - apply restriction no_config_mobile_networks
Test: unit test
Change-Id: I87bf2269359bbceb989fa10524d55dd7ceb55de1
2023-11-14 09:48:52 +00:00
Chaohui Wang
d8b21d7846 Avoid unnecessary Html.fromHtml()
Check if string contains html tag, before call Html.fromHtml()

Fix: 308681068
Test: atest SubscriptionsPreferenceControllerTest
Test: atest ProviderModelSliceHelperTest NetworkProviderWorkerTest
Test: manual - on Internet page
Change-Id: Id914689f2861a8c997d18afd03ecfdf47b91c631
2023-11-09 11:10:43 +00:00
Quang Luong
9d6cff4665 Merge "Show wifi list progress bar when scanning" into main 2023-11-09 04:51:21 +00:00
Chaohui Wang
32d9280e97 Merge "Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"" into main 2023-11-08 09:05:22 +00:00
Quang Anh Luong
884c5ab9bf Show wifi list progress bar when scanning
Show the progress bar in Internet Settings while we're currently
scanning for networks, and then stop when we receive the results of the
scan.

Bug: 308567866
Test: manually verify progress bar is shown while wifi is scanning
Change-Id: Ice500c69d24f7843b1a6b64c9ac5245b16c7c0db
2023-11-08 17:30:52 +09:00
Chaohui Wang
478ab50c01 Prevent Erase SIM during call
By collecting call state and only enable preference when idle.

Fix: 298893271
Test: manual - on Mobile Settings during call
Test: unit tests
Change-Id: Ifd567a6b68a3efbb0b42bfa0233f7c54eca07ae1
2023-11-08 03:08:56 +00:00
Chaohui Wang
08a1c9876e Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"
8979681a8d

Change-Id: I60edd3aabf49afbe4aa016af780baa68d928bddf
2023-11-07 14:17:15 +00:00
Sebastian Pickl
8979681a8d Revert "Migrate to CompoundButton.OnCheckedChangeListener"
Revert submission 25147565-onSwitchChanged-CompoundButton

Reason for revert: breaking builds 

Bug:309601476

Reverted changes: /q/submissionid:25147565-onSwitchChanged-CompoundButton

Change-Id: Ie746db87d9c642599593aa3d5e5baf6b7ba89c0e
2023-11-07 13:26:36 +00:00
Chaohui Wang
71d1f021af Migrate to CompoundButton.OnCheckedChangeListener
Switch and SwitchCompat are both CompoundButton.

Using CompoundButton in Java will helps migration in the future.

Bug: 306658427
Test: manual - check Settings pages
Change-Id: If2e08a9a9557ec66a3b31ef18cd2e15943098a59
2023-11-07 20:22:27 +08:00
SongFerng Wang
a2b1d8a0a2 Merge "Fix the burst callback issue on the repository" into main am: a23320eedd am: 4362f09737 am: bc4909cafd
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2780887

Change-Id: I009b6ec4bbc2ff46160772f7bd8a773086c5e20b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-07 10:55:00 +00:00
SongFerng Wang
bc4909cafd Merge "Fix the burst callback issue on the repository" into main am: a23320eedd am: 4362f09737
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2780887

Change-Id: I69a30d3d6af7b75177cee4c259786b7acbfdd5cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-07 10:11:00 +00:00
SongFerng Wang
4362f09737 Merge "Fix the burst callback issue on the repository" into main am: a23320eedd
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2780887

Change-Id: Ia0f4f76a704973e123cfe5e4c2d571bbea0c861f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-07 09:41:19 +00:00
SongFerng Wang
a23320eedd Merge "Fix the burst callback issue on the repository" into main 2023-11-07 09:11:06 +00:00
SongFerngWang
5eae90d731 To avoid crash IllegalStateException
Bug: 308855978
Test: [pass]make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest
Change-Id: Ia0a1cbe0326e63b878c3fe7797ca47e25ccc16d4
2023-11-07 16:00:41 +08:00
Chaohui Wang
ddf79703ce Merge "[Spa] Fix State<T> as a parameter of SwitchPreference" into main 2023-11-06 04:19:30 +00:00
Chaohui Wang
eedc7fd52d [Spa] Fix State<T> as a parameter of SwitchPreference
Bug: 292036686
Test: manual - with Settings
Test: unit tests
Change-Id: I003f3b7f29117258da6ae3c48039fb50c2bee95c
2023-11-05 00:09:27 +08:00
Chaohui Wang
9e72afdca4 New MobileDataEnabledFlow
To easily collect the mobile data enabled setting changes.

Bug: 308903704
Test: manual - on DataUsageList
Test: unit tests
Change-Id: I31327f59ac32c1a621e2853e64bd30d7d17e079c
2023-11-03 07:19:26 +08:00
Chaohui Wang
298f65b048 Merge "Finish Mobile Settings if airplane mode is on" into main 2023-11-02 09:06:48 +00:00
Mengjun Leng
1871b8155f Fix the burst callback issue on the repository
Prevents the callback when no sub entities changed to reduce
UI jank, besides, makes both variables mAvailableSubInfoEntityList
and mActiveSubInfoEntityList thread-safe.

Test: Manual
Bug: 279387799

Change-Id: I04f2a780de54e7528be6aeaf62bc8162e499aa97
2023-11-02 07:18:54 +05:30
Chaohui Wang
4ad7c3c2e6 Finish Mobile Settings if airplane mode is on
Fix: 298940648
Fix: 299256852
Fix: 295408616
Test: manual - on Mobile Settings then turn on airplane mode
Test: unit tests
Change-Id: Ifb4a287f7494ecb8b5040dbae7620fedfc316fdc
2023-11-01 18:05:42 +08:00
Charlotte Lu
d8630aa4d9 Merge "Show "add access point" when the user selects add Apn." into main 2023-11-01 09:02:47 +00:00