Commit Graph

3354 Commits

Author SHA1 Message Date
Treehugger Robot
65a0e43a43 Merge "Fix force close in WiFi API test code" into main am: 4f52f40cf9 am: 8871bd5bb6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3534241

Change-Id: I016283e58365cffe98b9746edb0a1a8b98d16533
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-03-19 04:04:54 -07:00
Weng Su
040e2a867a Fixed accessibility issues in Wi-Fi password view in Settings
- Keep the Save button enabled at all times

- Show "*required" or "The password is invalid" to remind the user
  - Show "Password (optional)" to indicate that it can remain unchanged, when modifying Wi-Fi configuration

Bug: 386897596
Bug: 402694144
Flag: EXEMPT bugfix
Test: Manual testing
  atest SettingsUnitTests:AddNetworkFragmentTest
  atest WifiConfigControllerTest \
        WifiConfigController2Test \
        WifiDialogActivityTest
Change-Id: I09b7684674ff376139565fcc196cde8d8d20a864
2025-03-14 21:05:16 +08:00
Weng Su
351e6a94e0 Fixed accessibility issues in Wi-Fi password view for SUW
- Keep the Save button enabled at all times

- Show "*required" or "The password is invalid" to remind the user

Bug: 386897596
Flag: EXEMPT bugfix
Test: Manual testing
  atest WifiConfigControllerTest
Change-Id: I442d2f958efd85f3c92309d0bed7cd3aa9ec9876
2025-03-13 15:40:12 +08:00
hoffc
6bafe1b1c0 Fix force close in WiFi API test code
Enable WiFi network with empty net id, force close will occur.

Add number format exception catch when parsing net id.

Bug: 402260924

Change-Id: I540fdeddc7072e7a9414ac7f9d7aca348d06cd30
2025-03-11 12:28:10 +08:00
Weng Su
e82b0b2eea Update the required or optional styles of EditText in VPN settings
- Follow the Required text indicator in the Google Material 3 guidelines

Bug: 401956268
Flag: EXEMPT refactor
Test: Manual testing
Change-Id: Ifeb1b882b34151ebef18edc32e7f2a3c116921c2
2025-03-10 15:32:42 +08:00
Xin Li
10d930d1cf Merge 25Q1 (ab/BP1A.250305.020) to aosp-main-future
Bug: 385190204
Merged-In: I04f90b42907d07c6111a7b41a531f7717df33672
Change-Id: I58e92a6e45193de820f7432dcb365c41c14d3141
2025-03-06 12:22:41 -08:00
Weng Su
3cdc1a58a7 Fixed accessibility issues in VPN Settings
- Show "(required)" and errors in required fields to alert users

- Show "(optional)" below each optional field

Bug: 386025633
Flag: EXEMPT bugfix
Test: Manual testing
  atest WifiConfigController2Test
Change-Id: Iefbd68e6658af7b073db219b3e04e94805092759
2025-03-06 16:19:47 +08:00
Weng Su
9f943bad9d Validate SSID only on the Submit button
- Avoid to validate the SSID when scanning a QR code

Bug: 399791242
Flag: EXEMPT bugfix
Test: Manual testing
  atest SettingsUnitTests:AddNetworkFragmentTest
Change-Id: I91f010f8708490e397d762c96401569fc13601dd
2025-03-03 10:29:57 +08:00
Weng Su
288a5971d2 Fixed accessibility issues in Wi-Fi SSID view for SUW
- Keep the Save button enabled at all times

- Show "Enter the SSID" to remind the user

Bug: 386897596
Flag: EXEMPT bugfix
Test: Manual testing
  atest WifiDialogActivityTest \
        WifiConfigControllerTest
Change-Id: I577e78c34cbaa0640479adf09a916a526500fe68
2025-02-27 13:14:28 +08:00
Xin Li
5bfde9fbf5 Merge 25Q1 (ab/12770256) to aosp-main-future
Bug: 385190204
Merged-In: Iaee6792d1a27be8fa4b443f783a47a3715b6d3a1
Change-Id: I0ac29cecfec526a38cf4a120b8ef704ee7bc01b3
2025-02-26 11:59:26 -08:00
Owner Cleanup Bot
71eb73374c Merge "[owners] Remove arcwang@google.com from src/com/android/settings/wifi/OWNERS" into main am: 0997a62f67 am: 1ea637ca4b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3503652

Change-Id: I76b8d66fbadbfea1eea66239af526feafb7ddaa3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-21 07:09:39 -08:00
Owner Cleanup Bot
a25b7045e9 [owners] Remove arcwang@google.com from src/com/android/settings/wifi/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.

Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy.  We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain.  It can always be
reverted if needed.

If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.

See the owner's recent review activity for context:
https://android-review.googlesource.com/q/arcwang@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Ib6ec33ee0331fef36c7c048be5b588e275e8de4d
2025-02-20 07:50:43 -08:00
Owner Cleanup Bot
f1c3bfbac3 Merge "[owners] Remove bonianchen@google.com from src/com/android/settings/wifi/calling/OWNERS" into main am: 5c16cc9139 am: a51502b4fc
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3498934

Change-Id: Id4530616d92c5e20b9040e0d8d9dd1ee96b5f14c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-19 07:34:49 -08:00
Treehugger Robot
22e2cd594e Merge "Fixed accessibility issues in Wi-Fi SSID view" into main 2025-02-18 22:38:53 -08:00
Weng Su
d44941bd00 Fixed accessibility issues in Wi-Fi SSID view
- Keep the Save button enabled at all times

- Show "Enter the SSID" to remind the user

Bug: 386897596
Flag: EXEMPT bugfix
Test: Manual testing
  atest SettingsUnitTests:AddNetworkFragmentTest
  atest WifiConfigController2Test
Change-Id: I6cc6b197864511ee2c1c92affc67698b1761f11d
2025-02-19 13:22:26 +08:00
Owner Cleanup Bot
105d03ae8a [owners] Remove bonianchen@google.com from src/com/android/settings/wifi/calling/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.

Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy.  We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain.  It can always be
reverted if needed.

If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.

See the owner's recent review activity for context:
https://android-review.googlesource.com/q/bonianchen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Id0eb15daeefb919819a81e2d583ec3a10a38cb5b
2025-02-18 15:13:06 -08:00
Hakjun Choi
1a53ea7a05 Clean up aconfig flag carrier_enabled_satellite_flag
Bug: 393951373
FLAG: EXEMPT flag clean up
Test: atest NetworkSelectSettingsTest WifiCallingSettingsForSubTest SatelliteSettingsPreferenceControllerTest
Test: manual test in live network
Change-Id: I154e9be8a8c771fafb37af078be7b495f18b6100
2025-02-18 08:41:14 +00:00
Jacky Wang
a2e663dadd [Catalyst] Move PreferenceRestrictionMixin
NO_IFTTT=Catalyst only

Bug: 377600992
Flag: EXEMPT refactor
Test: atest
Change-Id: I3c26a5a56d8fd6e887e4ff4d38d8e8eb97844672
2025-02-11 20:18:43 +08:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
Sunny Shao
e9f0fdcd66 [Catalyst] Implement metrics/tags for Settings Catalyst
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: Ia879883c3f29cd7ac286b431680d66ab52e87db0
2025-02-08 08:37:35 +00:00
Treehugger Robot
a477817f06 Merge "[Catalyst] Implement metrics/tags for "Wi-Fi"" into main 2025-02-07 01:55:53 -08:00
Sunny Shao
476dfa9131 [Catalyst] Implement metrics/tags for "Wi-Fi"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I5c271aca902d74eadb7f8d462c967a31472d0c9f
2025-02-07 07:21:20 +00:00
Sunny Shao
dcc13e91f3 [Catalyst] Implement metrics/tags for "Wi-Fi Calling"
Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I5cd0141639415eee0d230187beb056692cd7694e
2025-02-07 06:48:09 +00:00
SongFerng Wang
f9dc6c821f Merge "Add the missed call of super.onCreateView()" into main 2025-02-05 23:30:06 -08:00
Jacky Wang
ef3b232523 [Catalyst] Add more constants to SettingsContract
Bug: 388061003
Flag: EXEMPT refactor
Test: N/A
Change-Id: I906b345a56fa87909411ef64c73e2696240388ae
2025-02-05 19:02:41 +08:00
SongFerng Wang
01ba868b1e Add the missed call of super.onCreateView()
Bug: 393662651
Change-Id: I7f16fa45f3e32c6e1e78745248258b46836b7cbc
Test: build pass
Flag: EXEMPT bugfix
2025-02-04 22:22:23 -08:00
Jacky Wang
2e265d4a7a [Catalyst] Introduce SettingsContract file
The new file contains all contract constants for external usages (e.g.
slice, external Get/Set API). Also reuse existing constants in
SettingsSlicesContract.

NO_IFTTT=Catalyst only

Bug: 388061003
Flag: EXEMPT refactor
Test: atest
Change-Id: I449b7b6cf82e1e102f2c96a21835191605f09943
2025-02-04 18:24:46 +08:00
Jacky Wang
7a24cd61ac [Catalyst] Migrate WifiCallingScreen to parameterized screen
Bug: 388420844
Bug: 372732219
Flag: com.android.settings.flags.catalyst_wifi_calling
Test: devtool
Change-Id: I322001acc453eae0d69761f7a585c6f33087ef6a
2025-01-23 17:16:41 +08:00
Weng Su
6f2b7e4e4a Update Wi-Fi hotspot log
- Update "allowedChannels" log to avoid confusion by "WifiService: getUsableChannels" log

Bug: 390232242
Flag: EXEMPT log only update
Test: Manual testing
Change-Id: I030220d0fa6c28fe2dea06d1c9e64c6ae87b09a8
2025-01-22 22:11:04 +08:00
Fan Wu
297941ba2f [Catalyst] Remove PreferenceMetadata usages
Classes that implement PersistentPreference don't need to implement PreferenceMetadata

Bug: 388167302
Test: atest and manual
Flag: EXEMPT refactor
NO_IFTTT=refactor

Change-Id: Icf7d5eb4bbd426eb7e8dd562eda3c0a775457a3e
2025-01-16 17:46:28 -08:00
Jacky Wang
5a747c5a14 [Catalyst] Leverage PrimarySwitchPreferenceBinding
NO_IFTTT=Catalyst only

Bug: 335132588
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I3a566d98500bd09526c1f8d34fb7c47e9dff68b7
2025-01-16 17:13:20 +08:00
Fan Wu
4ca85b1e5c [Catalyst] Update DataChangeReason usages to PreferenceChangeReason
Bug: 388677104
Test: atest and manual
Flag: EXEMPT refactor
NO_IFTTT=refactor
Change-Id: I3c1aae3dc10a1c78e1b2b0ead8ffc83da933e174
2025-01-09 20:03:09 -08:00
Weng Su
cd9af665c3 [Catalyst] Add back Wi-Fi switch metrics
- The original Wi-Fi switch metrics is recorded by WifiEnabler.

- Since the design of Catalyst removes WifiEnabler, the metrics needs to be added to Catalyst preference.

NO_IFTTT=Catalyst only

Bug: 388547699
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WifiSwitchPreferenceTest

Change-Id: I8819e8f660784b8b04c7958b65f4792b5d4d0919
2025-01-09 03:37:06 +08:00
Hani Kazmi
57e649ae4e Merge "Revert "Revert "[AAPM] Add advanced protection dialog according ..."" into main 2025-01-03 09:25:46 -08:00
Treehugger Robot
1d0c7054b4 Merge "Add talkback hint to Wi-Fi hotspot preferences" into main 2025-01-02 05:11:03 -08:00
Hani Kazmi
8e28132ba2 Revert "Revert "[AAPM] Add advanced protection dialog according ..."
Revert submission 31078830-revert-30767017-aapm-dialog-api-feedback-TBLFTCNTUN

Reason for revert: Addressed failing test

Reverted changes: /q/submissionid:31078830-revert-30767017-aapm-dialog-api-feedback-TBLFTCNTUN

Change-Id: I3321b4f5baaca9dd270350b9201998ffe0d40473
2025-01-02 05:07:50 -08:00
Treehugger Robot
afb33b5988 Merge "Use AbstractSubscriptionPreferenceController in WifiCallingSettings" into main 2024-12-31 00:14:01 -08:00
tomhsu
55239c6a03 Use AbstractSubscriptionPreferenceController in WifiCallingSettings
Flag: EXEMPT task finished
Fix: 379611883
Test: atest pass
Change-Id: Ic8518ea9f6d5f9004e962e8fb92bc4b4ebc5f313
2024-12-30 16:40:54 +00:00
Treehugger Robot
585d034210 Merge "[Catalyst] Implement get{Read,Write}Permissions for Wifi hotspot" into main 2024-12-29 15:32:44 -08:00
Priyanka Advani (xWF)
47d59ab974 Merge "Revert "[AAPM] Add advanced protection dialog according to API f..."" into main 2024-12-27 14:25:58 -08:00
Sunny Shao
80f8684b9e [Catalyst] Implement get{Read,Write}Permissions for Wifi hotspot
NO_IFTTT=Catalyst migration

Test: Devtool
Fix: 384827196
Flag: com.android.settings.flags.catalyst_tether_settings
Change-Id: I6716b8060754d87a07cd00d0074b800985729459
2024-12-27 20:42:48 +08:00
Jacky Wang
cfcf20c70a [Catalyst] Provide screen key to @ProvidePreferenceScreen
NO_IFTTT=Catalyst only

Bug: 386179791
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: Ie8106ec45a32e4a61826512fc62746c9ffc47d9c
2024-12-27 17:14:27 +08:00
Jacky Wang
c1fb46f717 [Catalyst] Implement get{Read,Write}Permissions for Use Wi-Fi Calling
Bug: 385288187
Flag: com.android.settings.flags.catalyst_wifi_calling
Test: devtool
Change-Id: I28d51248285ee153bdbfe04dd31e137107bef501
2024-12-27 15:44:38 +08:00
Treehugger Robot
0553c76186 Merge "[Catalyst] Implement get{Read,Write}Permissions for Wi-Fi" into main 2024-12-26 21:30:12 -08:00
Jason Chiu
0fe222774d [Catalyst] Implement get{Read,Write}Permissions for Wi-Fi
NO_IFTTT=Catalyst only

Fix: 385268791
Flag: com.android.settings.flags.catalyst_internet_settings
Test: devtool
Change-Id: I136aacd63d079a8d3bfafba3b0aa3fd92bd582a4
2024-12-26 16:02:49 +08:00
Yuchen Sun
0f1c0f3ceb Merge "[Expressive design] Update wifi entry preference padding." into main 2024-12-25 22:43:29 -08:00
Weng Su
955c862de1 Add talkback hint to Wi-Fi hotspot preferences
- Set the title as the edit box hint.

Bug: 385857484
Flag: EXEMPT bugfix
Test: Manual testing
atest -c com.android.settings.wifi.tether.WifiTetherPasswordPreferenceControllerTest \
         WifiTetherSSIDPreferenceControllerTest

Change-Id: Ie7fe1c29d5f45ce47c7f393bf433ed3b2bcacb59
2024-12-25 22:10:31 +08:00
Yuchen
ccf8ae4fa3 [Expressive design] Update wifi entry preference padding.
Bug: 349681531
Flag: EXEMPT migration
Test: visual
Change-Id: I511d2b3e183472a12fdd07a293eda4c04617bc6c
2024-12-25 03:19:55 +00:00
Priyanka Advani (xWF)
2574343b43 Revert "[AAPM] Add advanced protection dialog according to API f..."
Revert submission 30767017-aapm-dialog-api-feedback

Reason for revert: Droidmonitor created revert due to b/384828570. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:30767017-aapm-dialog-api-feedback

Change-Id: Ibf26aca2453f2007370974290f5c16d6b091341e
2024-12-23 13:41:43 -08:00
Chaohui Wang
d830acf625 Send initial status for wifiStateFlow
To make sure this flow is never empty, use unknown as default.

Fix: 383050153
Flag: EXEMPT bug fix
Test: manual - on Network & internet
Test: unit test
Change-Id: Iaa421749ab917ebc651a95ccdf1a4ab1cb9ba112
2024-12-23 11:50:51 +08:00