Commit Graph

476 Commits

Author SHA1 Message Date
tom hsu
8be6d98b1f [Satelllite] Avoid using "add ESIM page"
- When user clicks preference UI, show a dialog to nofity user
   satellite session.

Flag: EXEMPT bug fix
Fix: b/402544816
Test: atest pass
Test: Manual test

Change-Id: Ifeff9368fed906bc56abcc8eb23748a71f79ee4d
2025-03-21 13:48:21 +00:00
Graciela Putri
90cd7eb98c Add LSE App Compat OWNERS for Settings
Flag: EXEMPT adding OWNERS
Fix: 402735141
Test: m
Change-Id: I459bf13bf9ccd067c0ddf067b56ce0e6ecaf4d7d
2025-03-12 07:54:16 -07:00
Graciela Putri
cf0d8cba31 Merge "Remove (experimental) from app aspect ratio settings title" into main 2025-03-11 11:56:04 -07:00
Zoey Chen
4011a8e250 Merge "[Settings] Use Settings flag to keep consistency" into main 2025-03-07 01:45:29 -08:00
Zoey Chen
59cccc6775 [Settings] Use Settings flag to keep consistency
Bug: 401438916
Test: manual
Flag: EXEMPT refactor
Change-Id: Ie7d1bf50c119eb5b5bcea55508c6a8a842bc60ee
2025-03-07 07:49:17 +00:00
Graciela Putri
6ed930462b Remove (experimental) from app aspect ratio settings title
Flag: EXEMPT string change
Fix: 305215544
Test: m
Change-Id: Idbb01ec99014efc40c285212e5e6ef8c91fa8333
2025-03-06 03:36:22 -08:00
Wes Okuhara
79563030fb Settings: Do not show install info for Play Store app
Clicking the "App details" row in the info subpage for the Play Store
app results in a crash. It appears that this app is not considered a
mainline module and has an installer label, but this app is a special
case. Hide the row for the Play Store app.

Bug: 302093631
Test: atest com.android.settings.spa.app.appinfo.AppInstallerInfoPreferenceTest
Flag: EXEMPT bugfix
Change-Id: I291ee3e5dec2075381cb52d041982583cdd04323
2025-03-04 19:05:23 -08:00
Pawan Wagh
e713abaae7 Use userContext instead of context
- update string to remove word 'forced'

Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk
Bug: 389696304
Flag: EXEMPT bug_fix
Change-Id: I79d4ec1afbf44131bd53d786c126c14c163a9207
2025-03-03 22:43:09 +00:00
Treehugger Robot
6e2bddaabd Merge "Stop app when toggling backcompat setting" into main 2025-03-02 16:59:40 -08:00
Pawan Wagh
a63c370eb6 Stop app when toggling backcompat setting
- Add method to stop package
- Backcompat setting takes two launches right now to take effect.
stop application when backcompat setting is toggled.

Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk
Bug: 389696304
Flag: EXEMPT bug_fix
Change-Id: Iadc8030fe34f66e7eaf854513b14aeb78a556308
2025-02-28 01:14:30 +00:00
Chaohui Wang
98a039e8d3 Merge "Mark ComposePreference as NormalPaddingMixin" into main 2025-02-26 19:29:54 -08:00
Sumedh Sen
fe36b334cf Merge "Skip checking if a broadcastreceiver was already registered" into main 2025-02-25 19:03:19 -08:00
Chaohui Wang
a407bb627b Mark ComposePreference as NormalPaddingMixin
Bug: 366336385
Flag: EXEMPT bug fix
Test: manual
Change-Id: I4094c1b040e3427aa28edddc15fd0e8746ff2a80
2025-02-25 19:03:03 -08:00
Julia Reynolds
6191772de7 Merge "Add ability to exclude apps from adjustments" into main 2025-02-25 12:19:23 -08:00
Julia Reynolds
0762b81bcf Add ability to exclude apps from adjustments
Specifically bundling and summarization

Test: BundleManageAppsPreferenceControllerTest
Test: AdjustmentExcludedAppsPreferenceControllerTest
Test: SummarizationManageAppsPreferenceControllerTest
Flag: android.app.nm_summarization
Flag: android.app.notification_classification_ui
Bug: 390415383
Bug: 377697346
Change-Id: Ica4b77212f4660624bfe12be7e6c9c584cd2c812
2025-02-25 07:06:46 -08:00
Chaohui Wang
04c7e27a73 Override isSpaExpressiveEnabled in Settings
Into SettingsSpaEnvironment.

Bug: 386013400
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Test: visual - expressive can enabled for spa in Settings
Change-Id: I5225948c733a57855168a3e633fc4fbd4dd6f89a
2025-02-24 12:08:27 +08:00
tom hsu
2a91e80acc Fix mobile data in Settings is not disable under satellite session
Flag: EXEMPT bug fix
Bug: b/386424636
Test: atest pass
Change-Id: I8d28419f295b172c2929acca5f5896aa4deeb09c
2025-02-21 02:48:55 +00:00
Sumedh Sen
b6b88351b6 Skip checking if a broadcastreceiver was already registered
If AppRestoreButton decides to dispose DisposableBroadcastReceiverAsUser
while recomposition, the broadcast receiver will be unregistered. If
this happens, there will be no visual feedback while restoring the app.
Thus, always render the DisposableBroadcastReceiverAsUser composable at
each recomposition of AppRestoreButton.

Since DisposableBroadcastReceiverAsUser uses `LaunchedEffect`, it wont
register a broadcast receiver at every recomposition.

Bug: 391744608
Test: atest SettingsSpaUnitTests
Flag: EXEMPT. Bug fix only
Change-Id: I420f95da363cf4da1a48150d32aec763c9159a1c
2025-02-05 14:56:38 -08:00
Zoey Chen
b69e2820ea [Settings] Add a flag to control show new App language picker UI or not
Bug: 391519669
Test: manual
Flag: EXEMPT refactor
Change-Id: I75921630b55c21d0b93dc626445f58e6bf1bd043
2025-01-22 00:40:47 -08:00
Chaohui Wang
7e8e683e60 Migrate to AppStorageRepository
Bug: 321861088
Flag: EXEMPT bug fix
Test: manual - on All apps and App info
Test: atest AppStorageSizesControllerTest
Test: atest AppStoragePreferenceTest
Change-Id: I3143de720493cb09854621b115d07e76bebf6699
2025-01-09 16:56:42 +08:00
Chaohui Wang
611c62294a Use BytesFormatter for data usage
Change "480 B" to "480 byte".

And no longer use FormattedDataUsage.

Bug: 321861088
Flag: EXEMPT bug fix
Test: manual - App data usage
Test: unit test
Change-Id: I9ed220e2d5b8fc512d7d28f6fa7faebb37beab83
2025-01-02 18:14:10 -08:00
Adam Bookatz
2a828c6bde Merge "Expand uninstallForAll to Admins" into main 2025-01-02 11:01:50 -08:00
Chaohui Wang
440c3c2779 Reduce Mobile data switch flaky
Set initial value to null, so no animation when the actual value true
is emitted.

Bug: 329584989
Flag: EXEMPT bug fix
Test: manual - on SIMs
Test: unit test
Change-Id: I3eea55115f02e65dcdcc44ccf917f9083622b723
2024-12-31 14:54:54 +08:00
zhibinliu
b2ee5ccf5b Check package name format before using it for SPA nav
Bug: b/372895305
Test: unit test
Flag: EXEMPT bug fix
Change-Id: Ife615c78c48a2d6f5b938c880c9c2128c5551644
2024-12-23 06:41:40 -08:00
Adam Bookatz
49d3e34810 Expand uninstallForAll to Admins
Currently, user 0 can uninstall other users' apps. It really has that
ability by virtue of it being an Admin user. But non-user-0 Admins don't
currently have this ability, so we expand that here. This also allows
this ability on HSUM, where human Admin users aren't user 0.

Bug: 384514936
Test: manual confirmation that overflow appears on HSUM device
Test: atest SettingsSpaUnitTests:com.android.settings.spa.app.appinfo.AppInfoSettingsMoreOptionsTest
Flag: EXEMPT bugfix
Change-Id: I976bb63ecced3c128f8109c63c85067f4a0cdf9b
2024-12-17 13:47:19 -08:00
Yuchen
224c16db50 [Expressive design] Rename ComposeMainSwitchPreference to ComposeGroupSectionPreference.
Bug: 349681531
Flag: EXEMPT migration
Test: visual
Change-Id: I5cf44a951894d56f0a7c5d2794442bfcdebb05d1
2024-12-16 02:42:58 +00:00
Yuchen
2b504a2762 [Expressive design] Remove extra background of MainSwitchPreference.
Bug: 349681531
Flag: EXEMPT bug fix
Test: Visual
Change-Id: Ib3a0e81b0bd1efbe85ce3992d343ae312e610dd3
2024-12-06 05:36:29 +00:00
Treehugger Robot
6b98c4e74b Merge "[SPA] Add biometric authentication for package modification" into main 2024-12-02 15:39:51 +00:00
Shraddha Basantwani
32e388ad31 [SPA] Add biometric authentication for package modification
Add an extra step of Lock Screen for disabling, force-stopping or
uninstalling updates for protected packages

UI Change Details : https://drive.google.com/drive/folders/1w7gKTmCxQ_j-9GQnIpEfF5_gmQ27b8l_?resourcekey=0-brLdN8VfqVPGm2FMwfrmkQ&usp=drive_link
Bug: 352504490, 344865740
Test: atest AppButtonsPreferenceControllerTest PackageInfoPresenterTest
Flag: EXEMPT High Security Bug
Change-Id: I0c494e307b02229d751de118abcc89e4e61a6861
2024-12-02 09:36:05 +00:00
Jacky Wang
36684ec80d [Catalyst] Migrate SIMs entry point
NO_IFTTT=Catalyst only

Bug: 368355368
Flag: com.android.settings.flags.catalyst_network_provider_and_internet_screen
Test: Manual
Change-Id: I2f3526c1ccb50490b955ad5f98c19d9ce2f5f21d
2024-12-02 11:26:37 +08:00
Pawan Wagh
57ca4d313e Add AppInfo setting for page size appcompat
Adding preference which set the page size app compat
for given app.

Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk
Flag: page_size_app_compat_setting
Bug: 371049373
Change-Id: I91d014594e99e174f55010ca57aa19edc2071255
2024-11-27 05:48:12 +00:00
Chaohui Wang
470a4a86af Set InstallUnknownAppsListModel override check
Set switchifBlockedByAdminOverrideCheckedValueTo = false

Since the user actually not allowed to install unknown apps when the
restrictions are enforced, we should display unchecked status.

Fix: 380205192
Flag: EXEMPT bug fix
Test: manual - on Install unknown apps
Change-Id: Ia2b2b6bce8b3b37f153e0c91cbeaf69486501407
2024-11-22 12:10:52 +08:00
Chaohui Wang
a2ccf8979d [expressive design] SimsSection
Bug: 349681531
Flag: EXEMPT bug fix
Test: visual
Change-Id: I2d38ad81ce93d47819fa82d46f1c11a9b8c9271d
2024-11-18 18:45:53 +08:00
Chris Antol
22306eb982 Add Special App Access page for WRITE_SYSTEM_PREFERENCES permission
Bug: 374848822
Flag: com.android.settingslib.flags.write_system_preference_permission_enabled
Flag: com.android.settingslib.flags.settings_catalyst
Test: in-app test
Change-Id: I8116e40108175d2606b0c24655d457c1f04afc35
2024-11-15 01:36:04 +00:00
Treehugger Robot
115f4a804e Merge "[expressive design] Migrate App info page." into main 2024-10-17 09:32:23 +00:00
Yuchen
29a163888f [expressive design] Migrate App info page.
Test: visual
Bug: 360916599
Flag: EXEMPT bug fix
Change-Id: Icd98e1616288606b629cae7f9d9232a6efbfcaf3
2024-10-17 06:02:48 +00:00
mxyyiyi
7bfa060c5f Take as Unrestricted Mode in the UI if current Mode is Unknown.
- Battery usage mode MODE_UNKNOWN is (1) apps in allowlist and (2) app's OP_RUN_ANY_IN_BACKGROUND = MODE_IGNORED.
For this case, mode should be displayed as Unrestricted on UI since it is in allowlist; and should be logged as unknown mode for the potential compatibility issues.

- After Backup & Restore, the MODE_UNKNOWN will be reset to Optimized(Default) Mode on target device.

Bug: 372831500
Test: manual
Test: atest BatteryOptimizeUtilsTest
Test: atest AppOptModeSharedPreferencesUtilsTest
Flag: EXEMPT for simple fix
Change-Id: Ic18e026f71a4a50ffa1711e2ca0782aeb8b33076
2024-10-15 15:53:29 +08:00
Chaohui Wang
bab2edd0ef Fix SpaSearchLandingActivity.isValidCall()
SettingsIntelligence sometimes starts SearchResultTrampoline first,
in this case, SearchResultTrampoline checks if the call is valid, then
SearchResultTrampoline will start this SpaSearchLandingActivity, allow
this use case.

Fix: 370186204
Flag: EXEMPT bug fix
Test: manual - search roaming
Change-Id: Ib6b2c1d3b8754f478a637dda8e9df77a91b24d9e
2024-10-10 06:25:00 +00:00
Chaohui Wang
73fb290969 Check DISALLOW_CONFIG_MOBILE_NETWORKS when search
If disallowed, not show mobile related search results.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search Mobile Settings
Test: atest MobileNetworkSettingsSearchIndexTest
Change-Id: I79b984f41f09dd9612bcd0c9942089756d5d365d
2024-09-23 11:17:55 +08:00
Chaohui Wang
777a179bd6 Create MobileNetworkSummaryRepository
For MobileNetworkSummaryController to use, so it no longer use
MobileNetworkRepository.

Fix: 366097262
Flag: EXEMPT refactor
Test: manual - on Network & internet
Test: atest MobileNetworkSummaryRepositoryTest
Change-Id: I8a9d52af8e230fc407a4339c27f73ef79d512b24
2024-09-18 13:07:50 +08:00
Chaohui Wang
a6db1aabb6 Create SimRepository
Which unifies whether we should sim settings on some related pages.

Before this change, we check SubscriptionUtil.isSimHardwareVisible()
and / or Utils.isWifiOnly().

After this change, we unified logic to,
canChangeSimSettings() =
  packageManager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY) &&
    userManager.isAdminUser

Fix: 365924140
Flag: EXEMPT bug fix
Test: manual - check Network & internet
Test: unit tests
Change-Id: Ibf83237e3d0088f78c96a1b39ee8f1e3a9c756ea
2024-09-12 08:59:26 +00:00
Chaohui Wang
426cbd623d [Safer intents] App Time Spent Preference
Set package com.android.internal.R.string.config_systemWellbeing to the
intent.

Fix: 356117796
Flag: EXEMPT bug fix
Test: manual - on App info
Test: atest AppTimeSpentPreferenceTest
Change-Id: I2af7b53a75fe5c6915dd9781406039822789c18c
2024-09-04 11:18:28 +08:00
Chaohui Wang
f74e90787e Create EuiccRepository
Which also avoid calling from main thread.

Bug: 356684993
Flag: EXEMPT bug fix
Test: manual - on SIMs
Test: atest EuiccRepositoryTest
Change-Id: I0b11b0bd1e8a4b5754781e888fd220fa3080a212
2024-08-29 11:34:19 +08:00
Chaohui Wang
6afa25df8b Encode SpaSearchLandingKey with Base64
To ensure the landing key is the same as the indexing key.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search roaming
Test: unit test
Change-Id: I26ce712feaa83e9e70a3eb39039e5c3527f24cca
2024-08-16 16:00:02 +08:00
Chaohui Wang
874c818b31 Settings search for Vo5G
Also adding keywords support to MobileNetworkSettingsSearchItem.

Fix: 262684662
Flag: EXEMPT bug fix
Test: manual - search vo5g
Change-Id: Ic73b76a2a7b2ef238b167fe3673835298d8939fd
2024-07-31 17:47:21 +08:00
Chaohui Wang
7009c008f9 Fix search for MMS Message
Also display multiple results when there are multiple MMS Message on
different SIMs.

When doing indexing, we not also log sub id as part of the key.
When user clicks the result, using SpaSearchLandingActivity to do the
redirection, set arguments to the fragment.

Fix: 352245817
Flag: EXEMPT bug fix
Test: manual - search mms
Test: unit test
Change-Id: Id47a1151cb418c18f68f97e3be33dcd21c5f5102
2024-07-30 11:34:24 +08:00
Chaohui Wang
7477f4ea9a Show category when search "Mobile data"
The displayed category is "SIMs".

Bug: 346776183
Flag: EXEMPT bug fix
Test: manual - search "Mobile data"
Test: unit test
Change-Id: If3c395281e96603193e7476a9e76d1f9e9213531
2024-07-30 09:48:28 +08:00
Yuchen Sun
028dd20d96 Merge "Clean up slice from spa and move androidx.slice dependency to Settings." into main 2024-07-18 08:26:05 +00:00
Yuchen Sun
93036e2045 Clean up slice from spa and move androidx.slice dependency to Settings.
Test: build successfully
Flag: EXEMPT clean up
Bug: 352442832
Change-Id: Ifc222a91991d4924f1cb7b5c1e7fd90968bfed26
2024-07-18 08:25:48 +00:00
Chaohui Wang
fb0583404f Always set cross sim calling
By CrossSimCallingViewModel, in SIMs and per SIM settings page.
To ensure the status is always right, including the case after the
onboarding set up finished.

Fix: 347882381
Fix: 348529996
Flag: EXEMPT bug fix
Test: manual - turn on / off "Automatic data switching" on SIMs
Test: manual - turn off "Automatic data switching" during onboarding
Change-Id: Icc2eacb67850fa7b3aa0fe310cd09a0e0147912b
2024-07-16 17:46:23 +08:00