Commit Graph

670 Commits

Author SHA1 Message Date
jasonwshsu
1a1ae82460 Modify flow in ToggleFeaturePreferenceFragment
* Show edit shortcut dialog should belong to the basic feature, so move
them back to ToggleFeaturePreferenceFragment
* Add test cases for UserShortcutType to prepare to further refactor

Bug: 158540780
Test: atest ToggleFeaturePreferenceFragmentTest
Change-Id: Ia84bea5581f85d199f395b2065652ce69738abbf
2020-09-26 04:30:04 +00:00
Peter_Liang
d43fcdaf49 Fix the Real Time Text option was shown in accessibility settings under active Fi.
Root cause:
Only using and querying the dialer intent can't be represented for supporting RTT.

Next action:
Add one checker for carrier config.

Bug: 159242323
Test: manual test for AT&T, Google Fi, chunghwa sim
& make RunSettingsRoboTests ROBOTEST_FILTER=RTTSettingPreferenceControllerTest

Change-Id: I8e85b9fdfc658ea6855a4041691efdbfd07c62d6
2020-09-18 17:57:30 +08:00
jasonwshsu
2d5fb75aca Add magnification switch shortcut dialog.
* show dialog when triple-tap users want to use magnify window mode

Bug: 146473544
Test: manual
Change-Id: I6915c165e8da59c6ec7557147192c7a1e9e19cf3
2020-08-24 10:15:25 +00:00
jasonwshsu
7b11b33518 Fix 'Settings' entry is disappear from 'Magnification'
Bug: 165787919
Test: manual
Change-Id: I11a0c2ad7898d40caa5ad76a43f430ead82c3b80
2020-08-20 17:43:36 +00:00
PETER LIANG
f92160da4a Merge changes from topic "color_correction_b_148785841"
* changes:
  Fix the screen will move by itself when enabled Color correction.
  Refine and migrate the functions that related to update preference into the specific lifecycle.
2020-08-19 07:51:41 +00:00
Peter_Liang
896e18012d Fix the screen will move by itself when enabled Color correction.
Root Cause:
Using the listener to update the UI dynamically might have some time delay.

Solution:
Refactor to another implementation and avoid using the listener to update it.

Additional condition:
Add height restriction in preference to avoid the palette view to cover whole screen.

Bug: 148785841
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PaletteListPreferenceTest
Change-Id: I6a854e16321b3426e2f8ff65c6404036d55caed4
2020-08-19 11:59:59 +08:00
jasonwshsu
62dc1b6364 Fix checkbox in magnification mode dialog does not have ripple effect
* Move onClickListener to LinearLayout since checkbox has null background in xml
* Rewrite setTextAreasClickListener logic to fit the need: at least one
checkbox need to be checked, and to let talkback announce disabled when
view is really in disabled state.

Bug: 164343865
Test: manual test
Change-Id: Ia5a831febc41f01858908cbdc365cf9a6a1282e3
2020-08-17 17:27:49 +08:00
jasonwshsu
c2dd8ff32a Update the formal image for magnification
* full_screen and window_screen image

Fix: 146019459
Test: manual test
Change-Id: I53dc9200f3c1460f9a1691fd72e55f1b6fac8c96
2020-08-13 17:55:46 +08:00
Peter_Liang
6a893a54b6 Refine and migrate the functions that related to update preference into the specific lifecycle.
Goal:
Avoid the screen to be scrolled or moved by itself after changing theme.

Bug: 148785841
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ToggleFeaturePreferenceFragment
&& make RunSettingsRoboTests ROBOTEST_FILTER=ToggleScreenMagnificationPreferenceFragmentTest

Change-Id: I35a41a920194d6de01b635ce4c8461df2635ce1a
2020-08-13 15:04:12 +08:00
TreeHugger Robot
3c8f93a6a5 Merge "Update inclusive language for Accessibility Settings" 2020-08-12 02:28:23 +00:00
PETER LIANG
946dafab93 Merge "Fix the screen scrolling down after enabling dark theme." 2020-08-10 03:56:44 +00:00
Peter_Liang
2387212823 Fix the screen scrolling down after enabling dark theme.
Root Cause:
Dynamically update preferences behind onCreate lifecycle.

Solution:
Move it to previous lifecycle.

Bug: 139877200
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilitySettingsTest
Change-Id: I1638a8b2d48369ec1ea0b996fbed09233c5e3649
2020-08-06 21:22:19 +08:00
Edgar Wang
dd032d3734 Update inclusive language for Accessibility Settings
Update language to comply with Android's inclusive language guidance
See https://source.android.com/setup/contribute/respectful-code for reference

Bug: 161896447
Test: robotest & manual
Change-Id: I67032d4beb7c8ae6b5a3271ea75ca38be4351484
2020-08-06 14:51:19 +08:00
Edgar Wang
21f8cb3a44 Refactor Reset options Settings
Update language to comply with Android's inclusive language guidance
See https://source.android.com/setup/contribute/respectful-code for reference

Bug: 161896447
Test: robotest & manual
Change-Id: I94969f6903d047b9bc41b1e8c14096c92c460b38
2020-08-04 23:33:50 +08:00
Minche Li
08e2fec40d Merge "Supports triple-tap shortcut for window magnification" 2020-06-29 17:05:02 +00:00
mincheli
f670261028 Supports triple-tap shortcut for window magnification
Window magnification mode shows triple-tap shortcut.

Bug: 157861708
Test: make RunSettingsRoboTests
Change-Id: I88c7a26e476d3cc5f85fa1b3f267ef3f1453ae38
2020-06-18 16:41:02 +08:00
Peter_Liang
34a873884d Fix the dark theme obscures the center marker of audio balance slider.
Root Cause:
The color of center marker is wrong.

Next:
The color of center marker is white when dark theme is enabled; Otherwise, it's black.

Bug: 159028208
Test: manual test & make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarPreferenceTest & make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarTest
Change-Id: Id2d548778d1275709448f4c009a8469216950d8c
2020-06-17 08:30:55 +00:00
mincheli
8af733e95d Removes magnification enable preference
Magnification enable preference is obsoleted and should be removed
because magnification button is applied in system UI recently.

Bug: 146473544
Test: make RunSettingsRoboTests
Change-Id: I24542cdfa68eec2cc0c9fb1a633b3ccdd3f9546d
2020-06-04 05:53:24 +00:00
jasonwshsu
b137e7a6e5 Change to use CaseMap.toTitle in shortcut type summary to handle different locale.
Bug: 153850193
Test: manual test
Change-Id: I6b4583d0b42a0019dfae9442536f6ed752ccc409
2020-05-18 13:27:46 +08:00
jasonwshsu
6a36ffb786 Change caption summary to get the whole translated string directly. am: 2282386c99 am: a5a7f0390f am: 95ba1a893e am: 6c69fc7530
Change-Id: If4a9d3eaaa99532f0a927d32291436903a270ae9
2020-05-18 03:31:36 +00:00
jasonwshsu
2282386c99 Change caption summary to get the whole translated string directly.
Bug: 154076977
Test: manual test
Change-Id: I9ddf1d52c1632c203713466dd9cf7b15de018a4d
2020-05-18 00:39:25 +08:00
PETER LIANG
a111ff6a26 Merge "Add the content description for accessibility tutorial pages." into rvc-dev am: 618ea90bbf am: 41dbddeac3 am: 3bf218e6fc am: 7832a0d715
Change-Id: I984174cf718a84207c54a7dce264c330ac1d5288
2020-05-16 16:27:54 +00:00
PETER LIANG
618ea90bbf Merge "Add the content description for accessibility tutorial pages." into rvc-dev 2020-05-16 15:26:58 +00:00
TreeHugger Robot
5993000b7b Merge "Avoid launching activity-based feature to force stop exist actiivty and recreate it." into rvc-dev am: 45910eec3f am: ceb23bb736 am: d89a58f00f am: 9a26cc3405
Change-Id: I288f9d43f76552b1c50744c6834d5bf20a0be41f
2020-05-16 02:32:22 +00:00
TreeHugger Robot
45910eec3f Merge "Avoid launching activity-based feature to force stop exist actiivty and recreate it." into rvc-dev 2020-05-16 01:09:07 +00:00
Peter_Liang
606479bc81 Add the content description for accessibility tutorial pages.
Bug: 155833961
Test: manual test & robo test
Change-Id: Iec86a6478706dcf6ce224046e8439a3d3b68144a
2020-05-15 13:34:36 +08:00
Peter_Liang
2add394b47 Refine the banner view for accessibility features.
1. Replace the video with the gif for Magnification.
2. Replace the static image with the gif for Color Inversion.

Bug: 153293657
Bug: 155946967
Test: manual test & robo test
Change-Id: Ic51c0ec45c10a7fd2b9f1ffb63865ebc764846ba
2020-05-14 21:00:05 +08:00
menghanli
efabdcc7d6 Avoid launching activity-based feature to force stop exist actiivty and
recreate it.

Root cause: FLAG_ACTIVITY_CLEAR_TASK would cause the exist activity are finished and new one items to be started. It causes Live Transcribe main activity goes onStart call of new activity is followed by onStop call of old activity, which cause the mic stopping.

Solution: Remmove the FLAG_ACTIVITY_CLEAR_TASK.

Bug: 156455425
Test: Manual test
Change-Id: I86778577ff37d7f14b28e5eca3087fa9cf5cb2c1
2020-05-14 09:29:04 +08:00
PETER LIANG
c178bae7af Merge "Add the settings content observer for shortcut preference." into rvc-dev am: 31e6002ee8 am: 380e0dc235 am: 58779cd226 am: 15d94daf38
Change-Id: I1f69480ee004d48fba57344959c39445be7717d8
2020-05-13 09:33:42 +00:00
Peter_Liang
b3d5df4989 Add the settings content observer for shortcut preference.
Root cause:
Didn't update the UI when settings value chagned.

Next:
Add the settings content observer.

Bug: 155837154
Test: manual test & Robo test & atest
Change-Id: I7be952a3a8824d00d3903d4a69beb8f992d638a1
2020-05-13 14:43:20 +08:00
TreeHugger Robot
3068fefc41 Merge "Revert "Add the settings content observer for shortcut preference."" into rvc-dev am: 9ae5b47aee am: 546c130e8d am: f37eaffefc am: aaf5e96718
Change-Id: I24e5a98e21353250b54e56ef3fe4dd62928b3b5e
2020-05-13 06:12:47 +00:00
TreeHugger Robot
9ae5b47aee Merge "Revert "Add the settings content observer for shortcut preference."" into rvc-dev 2020-05-13 05:05:08 +00:00
Edgar Wang
7e70ef64d4 Revert "Add the settings content observer for shortcut preference."
This reverts commit 785af0c15a.

Bug: 155837154

Reason for revert: robolectric test fail at com.android.settings.accessibility.ToggleFeaturePreferenceFragmentTest

Change-Id: If8e5681b044171ad6941307489526cc3834f66b2
2020-05-13 03:45:39 +00:00
Jason Hsu
c5a930af64 Merge "Fix the issue that title of Color inversion page is wrong" into rvc-dev am: 394f925729 am: bea0e029a4 am: 6a9fe5c9a5 am: 08a5acc608
Change-Id: Ia0cfff2a45c00fa7d9d14edbe3c38888d4e463db
2020-05-12 19:14:40 +00:00
Jason Hsu
394f925729 Merge "Fix the issue that title of Color inversion page is wrong" into rvc-dev 2020-05-12 18:04:49 +00:00
jasonwshsu
112cd4d6d1 Fix the issue that title of Color inversion page is wrong
* Title need to be set from getPreferenceScreenResId(), recover the xml file.

Bug: 156201719
Test: manual test
Change-Id: Ib8b79c320c6a48b1dd679738ddc7022ccaeaed86
2020-05-12 23:35:11 +08:00
PETER LIANG
5cca393b3b Merge "Add the settings content observer for shortcut preference." into rvc-dev am: a85f5dc80b am: 99f1a37582 am: a0953560f8 am: 7fcf167362
Change-Id: I7df7b79bc75d61130bf45bdf3763c10d8933115f
2020-05-12 12:34:47 +00:00
PETER LIANG
a85f5dc80b Merge "Add the settings content observer for shortcut preference." into rvc-dev 2020-05-12 11:29:11 +00:00
Peter_Liang
785af0c15a Add the settings content observer for shortcut preference.
Root cause:
Didn't update the UI when settings value chagned.

Next:
Add the settings content observer.

Bug: 155837154
Test: manual test
Change-Id: Icee0bb50f88987ea6c8a0be59bd936628a32ca1e
2020-05-12 14:15:54 +08:00
PETER LIANG
12de1247e9 Merge "Fix that the inconsistent accessibility content pages under Setup Wizard." into rvc-dev am: 7a31f2da60 am: 7057155390 am: 9e6ec39c81 am: e2c729fdd6
Change-Id: Ifa1e61789868d42bb808042f80538361b902f7ea
2020-05-11 08:41:16 +00:00
Peter_Liang
0cba2fe133 Fix that the inconsistent accessibility content pages under Setup Wizard.
Root cause:
Exist the inconsistent conditions.

Next:
1. Move all the condition related to description to the back fragment to determine whether to show the footer preference or not.
2. Add extras relate to animated image.

Bug: 156180932
Test: manual test
Change-Id: I56d4ead6c5121637a2da2e074ef9bff2a8146732
2020-05-11 11:22:36 +08:00
Jason Hsu
b6c5e63063 Merge "Change to use ComponentName instead of String in log." into rvc-dev am: 7af9c771bd am: 8ae30cb5bb am: 60151efc7f am: aab23d6a0e
Change-Id: I64a3c5edf04e04d983bc1d508cd41abecf64d754
2020-05-09 16:48:03 +00:00
Jason Hsu
7af9c771bd Merge "Change to use ComponentName instead of String in log." into rvc-dev 2020-05-09 15:55:07 +00:00
jasonwshsu
d2572c3295 Change to use ComponentName instead of String in log.
* align framework log to use the same format in ag/11250012

Bug: 151285965
Test: manual test
Change-Id: Ia76e3d88c116ffa37fb022aed2866acc0f315bd9
2020-05-09 22:18:18 +08:00
PETER LIANG
7bf1f61f94 Merge "Refines the animated image to fit the screen display." into rvc-dev am: dd1e66c199 am: e324e709b7 am: 168c541b9c am: b3fe365e49
Change-Id: I0d6e0332891f44f0dbaddf14a30a221c8c65fe0f
2020-05-07 17:19:02 +00:00
Peter_Liang
a87a7009b0 Refines the animated image to fit the screen display.
Root cause:
The width and height of animated image are wrap_content. It causes the gif or drawable which are non-transparent background to have a little weird display under dark mode.

Next:
1. Revise the width from wrap_content to match_parent, and add the fit center scale type.
2. Correct the function usage

Bug: 155946967
Test: manual test
Change-Id: I7470efb945a2b3bedb695e1b6f34475c6f190f9d
2020-05-07 08:06:20 +00:00
TreeHugger Robot
c8c6d9d9f6 Merge "Fix the tutorial title is inconsistent with the description under Talkback." into rvc-dev am: cb8be1de6f am: 3510f88fee am: eb70670e94 am: aadc3f4d35
Change-Id: Ie069fff86cd1ec1ece739ec80af24f31d8bd5120
2020-05-06 18:41:26 +00:00
Peter_Liang
02606e31fd Fix the tutorial title is inconsistent with the description under Talkback.
Root cause: wrong condition.

Next: Remove the condition related to touch explore.

Bug: 155829440
Test: manual test
Change-Id: I85a01979d9dcc4bc87f9a54661119f79e94ea791
2020-05-06 15:21:30 +08:00
TreeHugger Robot
dd16153416 Merge "Replace banner video with static image for Color Inversion." into rvc-dev am: 2e4e4ed1fd am: 3308f6b52d am: 04ce41bf31 am: 7369ab018c
Change-Id: Id6488bc6259e44e267ed882674b79f6aa3165746
2020-05-05 14:02:43 +00:00
Peter_Liang
5b957476be Replace banner video with static image for Color Inversion.
Bug: 152466128
Test: manual test
Change-Id: I859052385930b01929cad8dbf231d212a9507453
2020-05-05 19:46:08 +08:00