Commit Graph

38389 Commits

Author SHA1 Message Date
Weng Su
9cce69a6e8 Merge "[Provider model] Revise the Internet Panel title sub-text" into sc-dev am: 72dd0830e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14622867

Change-Id: I479bfacdfb839d46276bc3a5d8b44916ed2ed9c8
2021-05-21 08:25:29 +00:00
TreeHugger Robot
fecce407a2 Merge "Fix talkback doesn't speak subtext info" into sc-dev am: 10e732bd59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14663077

Change-Id: If5ca8490581c8e9d369daa37efdc94755359f590
2021-05-21 08:25:22 +00:00
Weng Su
72dd0830e1 Merge "[Provider model] Revise the Internet Panel title sub-text" into sc-dev 2021-05-21 08:14:07 +00:00
TreeHugger Robot
10e732bd59 Merge "Fix talkback doesn't speak subtext info" into sc-dev 2021-05-21 08:08:44 +00:00
Edgar Wang
600d023892 Make preference title align after icon
- Running service should use app preference layout.
- RestrictedDropdownPreference should use preference layout.
- Tweek Storage item icon padding
- Wifi calling should use Prefernce
- In Open by default page, if there is no vierfied link, we should
  hide the checkbox.

Bug: 186069482
Test: manual
Change-Id: Icc186ad79fc2bcf7ecd9c1ebba747bdad2d9b9ad
Merged-In: Icc186ad79fc2bcf7ecd9c1ebba747bdad2d9b9ad
2021-05-21 07:21:59 +00:00
Arc Wang
7bfd089e52 Merge "Shows "This device" for default internal storage" into sc-dev am: 8b5913ba18
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14609996

Change-Id: I88d314009c86279bfb164a8d75bd48f3c9a2f1dd
2021-05-21 06:33:46 +00:00
Arc Wang
8b5913ba18 Merge "Shows "This device" for default internal storage" into sc-dev 2021-05-21 06:23:02 +00:00
Yanting Yang
d62082027d Introduce InteractionJankMonitor into Settings
Detects the jank of page scrolling which is implemented by
InstrumentedPreferenceFragment.

Bug: 187306869
Test: verify with Perfetto

Change-Id: Icaa557d1b47a12374298f044e2f9568281589f64
2021-05-21 04:32:55 +00:00
alexylli
e6c11957b8 [Settings] Adjusts the result code to cancel when complete redaction interstitial setting
This change can make redaction interstitial can be setup repeatedly in anything else page.

Test: manual
Bug: 185430009
Change-Id: I7ed459ca3017286ab01bc8274704dd01fc50391d
2021-05-21 03:53:15 +00:00
TreeHugger Robot
181b40ba47 Merge "Refactor some transition codes." into sc-dev am: 8c1c7b63a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14660513

Change-Id: I254f5266556d0fa498f37a99c5ab6dbf56fa806c
2021-05-21 02:44:26 +00:00
TreeHugger Robot
8c1c7b63a7 Merge "Refactor some transition codes." into sc-dev 2021-05-21 02:33:46 +00:00
Kevin Chyn
a2e9d4d129 Merge changes I5989a67e,I30a77bd6 into sc-dev am: c24caeb4f8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14649896

Change-Id: I2c69e4d981e2d883b38fd44c9ffea183cc8aff71
2021-05-21 00:54:57 +00:00
Kevin Chyn
c24caeb4f8 Merge changes I5989a67e,I30a77bd6 into sc-dev
* changes:
  Announce UDPFS enrollment percentage
  Update UDFPS fingerprint enrollment
2021-05-21 00:39:16 +00:00
Chen Xu
34eae091e4 integrate config_disable_all_cb_messages to settings
In R we introduced a new config (also part of GMS requirement) mainly
for disable emergency alerts on devices which does not support
messaging or voices e.g, data only tablets. If the config is set to
true, framework should not forward any messages to users and hide
emergency alert from settings menu as well.

Bug: 176557108
Test: Manual
Change-Id: I2705839255a8450aa80a1a503a973207fd895a33
2021-05-20 23:43:52 +00:00
TreeHugger Robot
3ab34361e1 Merge "Add a11y announcement" into sc-dev am: c96c5c68d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14602029

Change-Id: Ic18dc2a102171fa30a257dd92e73b3dc305a9353
2021-05-20 21:52:46 +00:00
TreeHugger Robot
c96c5c68d9 Merge "Add a11y announcement" into sc-dev 2021-05-20 21:36:45 +00:00
Kevin Chyn
e25713054a Announce UDPFS enrollment percentage
Bug: 187460696
Test: manual
Change-Id: I5989a67e1fa1ed078677a69b2d841d5f1f1ee691
2021-05-20 11:13:02 -07:00
Kevin Chyn
869e996874 Update UDFPS fingerprint enrollment
1) Update UDFPS FindSensor to more of an EDU flow
2) Update UDFPS enrolling page to announce strings properly

Bug: 187460696
Test: manual
Change-Id: I30a77bd6bba911afb82e158d5e9f35b644ec880d
2021-05-20 11:12:37 -07:00
YUKAI HUNG
b40290c78a Merge "Add usage percentage and battery level into app relative metric" into sc-dev am: 572ab5b321
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14660514

Change-Id: I9cac182487a41800d2aea1e2219f822af74d059f
2021-05-20 14:04:39 +00:00
YUKAI HUNG
572ab5b321 Merge "Add usage percentage and battery level into app relative metric" into sc-dev 2021-05-20 13:58:01 +00:00
Tsung-Mao Fang
a51c9988c5 Fix talkback doesn't speak subtext info
In the original design, we only set title description for
view holder, this is wrong. It causes talkback can't
speak subtext info.

Currently, we set the title content description in the title
view directly, so talkback can say the title and subtext now
when talkback focus on an app view.

Test: Talkback speaks full information for an app entry
Fix: 177873163
Change-Id: I94996d596a85cc2813ed1b10cdd4ed2bee62f4a9
2021-05-20 13:45:38 +00:00
Tsung-Mao Fang
3720ae21b0 Fix the color of dot wrongly in device admin page
In this cl, we migrate origin files/method from framework into settings app.
So, we can control layout and drawble without impacting other app.

And we only remove to set a tint color in app_permission_item.xml.
Currently, it won't tint color for dot now.

Test: See the screen and dot's color is correct.
Fix: 188188444
Change-Id: I18054b47ba07e7864e7c238f2bec5fbe1d3feeea
2021-05-20 20:21:56 +08:00
ykhung
646c1a2e5a Add usage percentage and battery level into app relative metric
Reference the table from PM requested:
https://docs.google.com/spreadsheets/d/1TC_6MLVMvOS0p1ic0wPfQ-19AOuY8Kc8FUJdqaQSM4I/edit?ts=6098b296#gid=0

Bug: 188505537
Test: make SettingsRoboTests
Change-Id: Ia31ada9438f120fe6f29b59b67dc4de6636c11e1
2021-05-20 20:03:22 +08:00
Yi-Ling Chuang
81226a2431 Refactor some transition codes.
- Make the transition logic simpler in SettingsBaseActivity.
- Remove the redundant transition code in SettingsActivity.

Bug: 177479937
Test: rebuild and click on pages.
Change-Id: I65cae59d4eae99e3b9c324c9b6ce89f2349aaf8b
2021-05-20 16:20:28 +08:00
Menghan Li
d38832aae3 Merge "Apply color extraction for vision settings" into sc-dev am: 5e92366f83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14646255

Change-Id: Ibcde4fec51aa7ed6baeaee4c24def526927fb921
2021-05-20 07:30:32 +00:00
Menghan Li
5e92366f83 Merge "Apply color extraction for vision settings" into sc-dev 2021-05-20 07:10:04 +00:00
Jason Chiu
f67554f114 Merge "Skip indexing dynamic and injected raw data when page search is disabled" into sc-dev am: be9f37cfad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14542663

Change-Id: Ibad1115dd927decbb9ef758327cef42af189c1a0
2021-05-20 06:49:45 +00:00
Jason Chiu
be9f37cfad Merge "Skip indexing dynamic and injected raw data when page search is disabled" into sc-dev 2021-05-20 06:40:03 +00:00
Jason Chiu
1ee1911104 Skip indexing dynamic and injected raw data when page search is disabled
Test: robotest
Fixes: 188059978
Change-Id: I99c86ee12c7696123df26c47cfed8c3ddfbdf353
2021-05-20 06:34:08 +00:00
Menghan Li
1e39465e45 Merge "Fix glifLayout is not align the preference in SuW" into sc-dev am: ceed5d817b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14639274

Change-Id: Ie0bcaefca198f90138a8da406f1d2fc00861d883
2021-05-20 06:25:33 +00:00
Menghan Li
ceed5d817b Merge "Fix glifLayout is not align the preference in SuW" into sc-dev 2021-05-20 06:13:05 +00:00
TreeHugger Robot
f154e231f9 Merge "(2/n) Stop user from enabling OHM setting if user is using 3-button mode" into sc-dev am: 2cc1c91601
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14235150

Change-Id: I3161025c6c61529213cf99b38306ca287f657a51
2021-05-20 04:22:06 +00:00
TreeHugger Robot
2cc1c91601 Merge "(2/n) Stop user from enabling OHM setting if user is using 3-button mode" into sc-dev 2021-05-20 03:54:57 +00:00
menghanli
b9fefba02a Apply color extraction for vision settings
Bug: 183713013
Test: Run initBCTestEnv_S.sh and apply different color
Change-Id: I2420a6af0f0f975396003e4c5531701bfb8373f4
2021-05-20 11:48:22 +08:00
Yu-Han Yang
791b6fadc7 Fix footer issues
1. setContentDescription for "learn more"
2. set searchable="false"

Bug: 187471260
Bug: 188490701
Test: on device
Change-Id: Iaa6907fdf2b6c47cbc1386a88a08ac31f3676367
2021-05-19 18:01:25 -07:00
Weng Su
6eb27a6d0a [DO NOT MERGE] Modify Wi-Fi details settings to restricted style
- Show restricted text in guest mode

- Screenshot:
  https://screenshot.googleplex.com/6nYcmazMM46TxaB

Bug: 177573895
Test: manual test
make RunSettingsRoboTests \
       ROBOTEST_FILTER=WifiNetworkDetailsFragmentTest

Change-Id: I5f857b2079e0f550e4be601d27dd54dac56b2f57
(cherry picked from commit d4cec9b628)
2021-05-20 00:01:47 +00:00
Hugh Chen
cdf9a1509b RESTRICT AUTOMERGE Fix unable to send file via OPP
Bluetooth app will indicate BluetoothOppReceiver to receive
device picker intent. But for fix the security issue we
removed the setClassName() method in ag/14111132 to avoid attack.
It causes BluetoothOppReceiver cannot receive the intent.

This CL will compare to calling package name with launch package name.
If they are not equal, the setClassName() will not invoke.

Bug: 186490534
Bug: 179386960
Bug: 179386068

Test: make RunSettingsRoboTests -j56
Change-Id: Ia51528f2a44ab73edbc86899ca0846d3262fe1f0
(cherry picked from commit bb5be240c0)
(cherry picked from commit c556938807)
2021-05-20 00:01:42 +00:00
Hugh Chen
f1d1bb7816 RESTRICT AUTOMERGE Fix bluetooth settings will broadcast to anywhere when some cases
BluetoothPermissionActivity and DevicePickerFragment will send
broadcast to return the result to calling apps. As this broadcast
intent is from Settings with uid 1000, it will be sent to any
protected BroadcastReceivers in the device. It can make an attacker
send broadcast to protected BroadcastReceivers like factory reset intent
(android/com.android.server.MasterClearReceiver) via
BluetoothPermissionActivity or DevicePickerFragment.

This CL will not allow to set package name and class name to avoid
the attacker.

Bug: 179386960
Bug: 179386068
Test: make -j42 RunSettingsRoboTests and use test apk to manually test
to verify factory reset not started and no system UI notification.

Change-Id: Id27a78091ab578077853b8fbb97a4422cff0a158
(cherry picked from commit 8adedc6249)
(cherry picked from commit e21d06f6ee)
2021-05-20 00:01:37 +00:00
Jakub Pawlowski
42be5cfa10 Prevent drawing on top of DevicePickerActivity
Bug: 182584940
Change-Id: I8b27b397bce1708a42b96b1b647c64e23142c468
(cherry picked from commit 68f799a4c6)
2021-05-20 00:01:33 +00:00
Tsung-Mao Fang
4493d84ab2 Prevent HTML Injection on the Device Admin request screen
The root issue is that CharSequence is an interface.
String implements that interface, however, Spanned class
too which is a rich text format that can store HTML code.

The solution is enforce to use String type which won't include
any HTML function.

Test: Rebuilt apk and see the string without HTML style.
Bug: 179042963
Change-Id: I53b460b12da918e022d2f2934f114d205dbaadb0
Merged-In: I53b460b12da918e022d2f2934f114d205dbaadb0
(cherry picked from commit 0bf3c98b2f)
(cherry picked from commit 52f9039d5c)
2021-05-20 00:01:26 +00:00
TreeHugger Robot
0925ba9f24 Merge "Setting result earlier than onPause" into sc-dev am: c57c351060
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14637113

Change-Id: I81795d747ae1256aba6526c7a681186fdf551072
2021-05-19 20:28:49 +00:00
TreeHugger Robot
c57c351060 Merge "Setting result earlier than onPause" into sc-dev 2021-05-19 20:11:09 +00:00
Yi Jiang
8aaa9f5549 Defers initialization of preferences.
In Screen Timeout Settings, preferences should not be initialized in
onAttach() because the setting style hasn't been loaded yet. This change
defers the initialiaztion of those preferences so that they appear
correctly.

Test: manually tested.
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.display
Bug: 183909540

Change-Id: I86cfe196549d709ed763faa004fff7b631365b1e
2021-05-19 12:18:23 -07:00
Jack Yu
9c60e581e8 Merge "API Review: Rename CAPABILITY_ALLOWED_NETWORK_TYPES_USED" into sc-dev am: 3616520985
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14554359

Change-Id: Id6cec29f31d94a378bd78c630b5a7d571bba64c7
2021-05-19 16:47:43 +00:00
Jack Yu
3616520985 Merge "API Review: Rename CAPABILITY_ALLOWED_NETWORK_TYPES_USED" into sc-dev 2021-05-19 16:26:18 +00:00
Jason Chang
ecb58cbbc5 (2/n) Stop user from enabling OHM setting if user is using 3-button
mode

Return One-Handed mode getAvailabilityStatus to UNSUPPORTED_ON_DEVICE
when SystemNavigationMode is 3-button.

Bug: 184903678

Test: manual
Test: manual verified on Settings > System > Gesture page
Test: make RunSettingsRoboTests ROBOTEST_FILTER=
      "com.android.settings.gestures
      .OneHandedEnablePreferenceControllerTest"
Test: make RunSettingsRoboTests ROBOTEST_FILTER=
      "com.android.settings.gestures
      .SwipeBottomToNotificationPreferenceControllerTest"
Change-Id: I454dabb5cc267d544732fa5079f3146154d0568c
2021-05-20 00:25:26 +08:00
Antoan Angelov
57d52482cc Merge "Update ActionDisabledByAdminDialogHelper" into sc-dev am: eb45fd3f2a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14441130

Change-Id: I1d2ca81504f78e98d2f27d34ca8b037ffc433719
2021-05-19 14:05:09 +00:00
Antoan Angelov
eb45fd3f2a Merge "Update ActionDisabledByAdminDialogHelper" into sc-dev 2021-05-19 13:50:06 +00:00
ykhung
98aafd8500 Add metric for new battery relative functions for S (1/2) am: a3d3c22a27
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14622866

Change-Id: I81540aec054edadc9d34c6f46337c398a3bb11ba
2021-05-19 12:36:22 +00:00
ykhung
a3d3c22a27 Add metric for new battery relative functions for S (1/2)
Reference the table from PM requested:
https://docs.google.com/spreadsheets/d/1TC_6MLVMvOS0p1ic0wPfQ-19AOuY8Kc8FUJdqaQSM4I/edit?ts=6098b296#gid=0

Bug: 188505537
Test: make SettingsRoboTests
Change-Id: I2a4df9ab900cbeaf9885bb2dbc21ea848920bc81
2021-05-19 12:22:20 +00:00