Bonian Chen
aef94de16e
Merge "[Settings] Avoid from immediate update when UI inactive and SIM absent" into sc-qpr1-dev am: 716e00ec43 am: f9684e04ce
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15712667
Change-Id: I047d6ac1f2fd3304f27bf6ac7d7d006cfe45f4cb
2021-09-16 01:03:12 +00:00
TreeHugger Robot
d093ffa25d
Merge "Fix hold volume keys don't trigger the one handed mode in One-handed mode settings page" into sc-qpr1-dev am: cb1969d46b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15582201
Change-Id: Ice95434bbcfc772e134be2e5bc698ab43fd9fdf1
2021-09-16 00:49:18 +00:00
Bonian Chen
01765967d7
Merge "[Settings] Avoid from immediate update when UI inactive and SIM absent" into sc-qpr1-dev am: 716e00ec43
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15712667
Change-Id: Id0f8fd5e29c31b8a3b1a65ea689e18a91cf0e4b1
2021-09-16 00:49:04 +00:00
Bonian Chen
f9684e04ce
Merge "[Settings] Avoid from immediate update when UI inactive and SIM absent" into sc-qpr1-dev am: 716e00ec43
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15712667
Change-Id: I8cd4b8210b5879a5a69113e6b2e70e2f73e29cd5
2021-09-16 00:49:03 +00:00
TreeHugger Robot
cb1969d46b
Merge "Fix hold volume keys don't trigger the one handed mode in One-handed mode settings page" into sc-qpr1-dev
2021-09-16 00:41:03 +00:00
Bonian Chen
054177416a
Merge "[Settings] Avoid from floating overlay when displaying SIM selection UI" into sc-qpr1-dev am: c6c769cd8a am: e084bbca42
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15712666
Change-Id: I5b12d8ea97ee3d032771fb643a7ced44253824f2
2021-09-16 00:38:42 +00:00
Bonian Chen
716e00ec43
Merge "[Settings] Avoid from immediate update when UI inactive and SIM absent" into sc-qpr1-dev
2021-09-16 00:36:31 +00:00
Bonian Chen
e85d78b14e
Merge "[Settings] Avoid from floating overlay when displaying SIM selection UI" into sc-qpr1-dev am: c6c769cd8a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15712666
Change-Id: I72d0ccacaa8a748d2bc2bf5d0121c560f9541db7
2021-09-16 00:29:47 +00:00
Bonian Chen
e084bbca42
Merge "[Settings] Avoid from floating overlay when displaying SIM selection UI" into sc-qpr1-dev am: c6c769cd8a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15712666
Change-Id: I24583fda6284542e82c85b7c25a35908e03817c1
2021-09-16 00:29:47 +00:00
Bonian Chen
656c965222
[Settings] Avoid from main UI thread blocking on accessing eSIM
...
1. Add timeout on background thread when accessing eSIM
2. Print log for debugging in the future.
Bug: 177843016
Change-Id: I64225af6ce87c98119c7a93c0944ad08d1390137
Test: local
(cherry picked from commit bda8c22267 )
2021-09-16 00:21:31 +00:00
Bonian Chen
c6c769cd8a
Merge "[Settings] Avoid from floating overlay when displaying SIM selection UI" into sc-qpr1-dev
2021-09-16 00:14:25 +00:00
TreeHugger Robot
0a3a7c9703
Merge "Add toggle switch for auto rotate preference in display settings." into sc-qpr1-dev am: 8521fd6e36 am: 2416ad383c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15584663
Change-Id: I3619460fdb88ac5b23f2775aba8e81d10178ba24
2021-09-15 17:03:17 +00:00
TreeHugger Robot
72264775ef
Merge "Add toggle switch for auto rotate preference in display settings." into sc-qpr1-dev am: 8521fd6e36
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15584663
Change-Id: I879ab4caa9e36ff5cd67068b9bb4d11cd7f861df
2021-09-15 16:50:25 +00:00
TreeHugger Robot
2416ad383c
Merge "Add toggle switch for auto rotate preference in display settings." into sc-qpr1-dev am: 8521fd6e36
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15584663
Change-Id: I72218c7a47b7ec4b6574a0b0ea038b62a469cbda
2021-09-15 16:50:25 +00:00
TreeHugger Robot
8521fd6e36
Merge "Add toggle switch for auto rotate preference in display settings." into sc-qpr1-dev
2021-09-15 16:39:14 +00:00
Arc Wang
0db7eacaae
Add android:configChanges for SettingsHomepageActivity am: fdfac783ab
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15777510
Change-Id: I209e5a92a20770bc7ecba9ecfc65385c0d8e7b4e
2021-09-15 10:39:30 +00:00
Arc Wang
16c28e11e2
Extends the criteria width of 2-pane mode am: f6a8f6c8af
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15802167
Change-Id: I6e26542396d6556147dd22e1157c0cf73e18b946
2021-09-15 10:39:28 +00:00
Calvin Pan
e32a2abc16
Disable smart forwarding based on subid
...
Smart forwrading did not specify the subid when disabling feature, which
caused always dsiabled on default subid.
Bug: 194112447
Test: Enable/disable smart forwarding
Change-Id: Id900500f065c32b326ca6dfc39482f913fb9b8ff
2021-09-15 17:57:09 +08:00
Bonian Chen
f23f999e1c
[Settings] Avoid from crash - SystemProp default null
...
Default system properties should not have "null" as default value.
Bug: 177843016
Change-Id: Idc2b3aaafd1094ba3fbfa859c4ad7a597e1b7a99
Test: build pass
(cherry picked from commit d2eda630e2 )
2021-09-15 06:14:55 +00:00
Arc Wang
fdfac783ab
Add android:configChanges for SettingsHomepageActivity
...
When resuming Settings app of large screen devices,
SettingsHomepageActivity will be re-created for
Activity resized. It produces unnecessary Activity
destroy and re-create.
This change prevents SettingsHomepageActivity from
configuration changes for screenSize|screenLayout.
Bug: 198361315
Test: manual
1. Launch Settings app by a Settings shortcut widget.
2. Move Settings app to background.
3. Click Settings shortcut widget again.
Observe if SettingsHomepageActivity re-creates.
Change-Id: I4d71330f6a1760768ba4443e192f66b0a2cbb6bf
2021-09-15 12:13:58 +08:00
Arc Wang
f6a8f6c8af
Extends the criteria width of 2-pane mode
...
Follow UI spec, we extend criteria width from 600dp -> 720dp
Original code checks if there is only one Activity in
Activity stack to decide if it's a deep link intent,
it has problem at configurationChange.
This change checks if the intent is from Settings app
itself to decide if it's a deep link intent.
Bug: 197716926
Bug: 199808997
Test: Build apk and run on the device.
Change-Id: Ide8ef2ccffa87b9ee4fab41ab4f395b00def9bd6
2021-09-15 12:13:49 +08:00
Abel Tesfaye
dc909e2a13
Add toggle switch for auto rotate preference in display settings.
...
Bug: 183471038
Test: locally with flame & crosshatch
Change-Id: Iea4dbdd6df8a53f0fb79b82c97892256ad072c1d
2021-09-15 03:41:45 +00:00
Joe Bolinger
184e77a8d5
Merge "Add string ids to the result bundle for parental consent." into sc-qpr1-dev am: 63786513fc am: 3452769f1e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15759863
Change-Id: I4e798fbebf3266b970fcb3d94c2390833541ba9d
2021-09-14 23:28:11 +00:00
Joe Bolinger
3452769f1e
Merge "Add string ids to the result bundle for parental consent." into sc-qpr1-dev am: 63786513fc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15759863
Change-Id: I3dbb1da09fe9ea625b37cce6ae85262893900e30
2021-09-14 22:23:25 +00:00
Joe Bolinger
5668781507
Merge "Add string ids to the result bundle for parental consent." into sc-qpr1-dev am: 63786513fc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15759863
Change-Id: Ieb86f16d8789c73e734085084a70c64d2bd6b50e
2021-09-14 22:23:24 +00:00
Joe Bolinger
63786513fc
Merge "Add string ids to the result bundle for parental consent." into sc-qpr1-dev
2021-09-14 22:08:23 +00:00
Joe Bolinger
8b3792d65b
Add string ids to the result bundle for parental consent.
...
Bug: 198491515
Test: N/A (builds)
Change-Id: Id120f5f7a7e923f9d3ce7dd38d3e5214296ca219
2021-09-14 19:54:27 +00:00
YUKAI HUNG
bb9225ee74
Merge "Add package name into the metric for enable/disable app user actions" into sc-v2-dev am: 9fdeebf664
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15808964
Change-Id: I5996be56019260a9705c5059650a6232623eb570
2021-09-14 06:43:29 +00:00
YUKAI HUNG
9fdeebf664
Merge "Add package name into the metric for enable/disable app user actions" into sc-v2-dev
2021-09-14 06:33:13 +00:00
ykhung
e12712dd1d
Add package name into the metric for enable/disable app user actions
...
add package name into the metric per @wangkelly request to analyze users behavior in the battery setting relative CUJ:
go/battery-setting-enums
Bug: 199807285
Test: make SettingsRoboTests
Change-Id: Ica6da59b933b0dcff940215d4e537a670bac52cb
2021-09-14 05:02:29 +00:00
TreeHugger Robot
5be7a95a99
Merge "Correct how the injection mechanism starts activities" into sc-v2-dev am: 40e9a8aaaf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15809057
Change-Id: I8752904ce14c7ca84787e260b0bdb1a4aefb047c
2021-09-14 04:14:22 +00:00
TreeHugger Robot
40e9a8aaaf
Merge "Correct how the injection mechanism starts activities" into sc-v2-dev
2021-09-14 04:02:45 +00:00
Pavel Grafov
0e72224c38
Merge "Respect PASSWORD_QUALITY_MANAGED for biometrics" into sc-qpr1-dev am: 1ecc3166f0 am: fc67167c93
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15778274
Change-Id: Ic295385f6cb70c2caecff6679336dd757cde513b
2021-09-13 14:18:44 +00:00
Pavel Grafov
6b3e240d20
Merge "Respect PASSWORD_QUALITY_MANAGED for biometrics" into sc-qpr1-dev am: 1ecc3166f0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15778274
Change-Id: Iaee401d8cc88e9c5a48d5fee445ae44980eacdd1
2021-09-13 14:09:29 +00:00
Pavel Grafov
fc67167c93
Merge "Respect PASSWORD_QUALITY_MANAGED for biometrics" into sc-qpr1-dev am: 1ecc3166f0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15778274
Change-Id: I277765ca0a21a2793558668b3a3f20bccd2f28c4
2021-09-13 14:08:56 +00:00
Pavel Grafov
1ecc3166f0
Merge "Respect PASSWORD_QUALITY_MANAGED for biometrics" into sc-qpr1-dev
2021-09-13 13:52:26 +00:00
Neil Fuller
c90ae857d8
Merge "Swap ownership to mingaleev@" am: f6fe44dc91 am: d2eca211d4 am: 4546286779 am: 51f8f5e6ef
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1824113
Change-Id: If5e9653f8d9cd80f76681e86ab008c17ca560cf1
2021-09-13 11:45:30 +00:00
Neil Fuller
51f8f5e6ef
Merge "Swap ownership to mingaleev@" am: f6fe44dc91 am: d2eca211d4 am: 4546286779
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1824113
Change-Id: I5e14da84bf0eb4d1db411b8ada82de2bbe5cfcb0
2021-09-13 11:38:28 +00:00
Neil Fuller
4546286779
Merge "Swap ownership to mingaleev@" am: f6fe44dc91 am: d2eca211d4
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1824113
Change-Id: I93dfc80658af894e720cec0a2c0e0489ee67c53e
2021-09-13 11:30:54 +00:00
Neil Fuller
d2eca211d4
Merge "Swap ownership to mingaleev@" am: f6fe44dc91
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1824113
Change-Id: I9be5d173953df0a90ee1309feceed35f9240c18c
2021-09-13 11:17:50 +00:00
Pavel Grafov
36120b8a4c
Respect PASSWORD_QUALITY_MANAGED for biometrics
...
Bug: 195488124
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=\
com.android.settings.password.ChooseLockGenericControllerTest
Test: manual with a modified TestDPC
Change-Id: Ifa15877c735bb0f396051af04a4e012a606bf9e1
2021-09-13 11:50:06 +01:00
ykhung
a168e2e0fc
Fix failed tests since presubmit is ignored in ag/15802168 am: 27efa546cf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15809054
Change-Id: I5b0e17f5862f295da35456f691dfcdc32587bcdc
2021-09-11 18:13:37 +00:00
ykhung
27efa546cf
Fix failed tests since presubmit is ignored in ag/15802168
...
Bug: 198553245
Test: make SettingsRoboTests
Change-Id: I91e715a6bfb64419b457812423996365a9464a93
2021-09-12 00:36:43 +08:00
Yi-Ling Chuang
5fc96844e5
Correct how the injection mechanism starts activities
...
Settings Injection used to start activities with
startActivityForResult() and its extension, where there was not result
really being handled. Hence, this CL corrects the way it starts
activities by removing the "ForResult" part.
Fixes: 197704126
Test: robotest and launch Android Auto to see it being launched in
another task.
Change-Id: I259b2555cf62f8966afdf664b337af5f216b3843
2021-09-11 16:48:37 +08:00
ykhung
e44128f021
Fix the icon flash issue cause from the shared drawable icon am: a3b89868f4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15802168
Change-Id: I4b3e87e071a2fec6ace88afe1336be08e77c4075
2021-09-11 00:13:28 +00:00
ykhung
a3b89868f4
Fix the icon flash issue cause from the shared drawable icon
...
different time slot may have the same application entry, we should not make them share the same drawable instance to impact the states, we will use newDrawable() method to create a new one for each application entry
Bug: 198553245
Test: make SettingsRoboTests
Change-Id: I4a321133ba171817fca1ab7ad47b9af8f7450675
2021-09-10 16:50:43 +00:00
Neil Fuller
b46adff0f4
Swap ownership to mingaleev@
...
BUG=189810551
Change-Id: I6304545540947d6695117753309c80b27cf2669a
2021-09-10 12:20:39 +00:00
Bonian Chen
4c3f454c92
Merge "Fix Text of VoLTE setting cannot be updated when SIM state is changed"
2021-09-10 09:46:32 +00:00
ykhung
bb535f4bce
Move allowed list definition in the battery usage to feature provider am: b62cdecc67
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15785737
Change-Id: I01745bccfb5cf44fbdfeedd1db6ad2b88a0c71a2
2021-09-10 05:03:32 +00:00
Ting Yu
638f12a6c8
Fix Text of VoLTE setting cannot be updated when SIM state is changed
...
Text of setting menu for VoLTE should be changed from "VoLTE" to
"4G Calling" if "show_4g_for_lte_data_icon_bool" is true. However, it
is not changed in the following steps.
1. Turn Use SIM off on Mobile Network Setting and close Mobile Network
Setting screen.
2. Open Mobile Network Setting screen again and turn Use SIM on.
Root cause is that the carrier config value is loaded only when SIM's
subid is changed. So, remove checking subId so that the carrier config
value is updated.
Additional fix:
Removed checking #isModeMatched in # onStart because "4G calling"
Setting was grayed out. It needs to listen to call state change
regardless of display status of the preference because Preference may
be switched even after the screen is displayed.
Test: manual
Test: make RunSettingsRoboTests \
ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Bug: 196030198
Change-Id: Ibf4d17aa493f69a3f00e35ae0e9d1419bd9e0d77
Merged-In: Ibf4d17aa493f69a3f00e35ae0e9d1419bd9e0d77
2021-09-10 01:17:26 +00:00