AOSP does not have help URIs configured, so there is no relevant content
to show in the private DNS dialog's help text section, and the preference
controller never sets the content of the help text view. This results in
a random irrelevant message related to Bluetooth audio being shown in
the dialog: "Gray-out means not supported by phone or headset"
This is caused by the private DNS dialog sharing the
preference_widget_dialog_summary snippet with Bluetooth A2DP codec
settings. To fix this issue, we can hide the help text view entirely if
there is no help URI defined.
Change-Id: Ie74a1be347351a6db68412321d0c68f3138fae6b
Signed-off-by: Joey Huab <joey@evolution-x.org>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Before you could only click once to see the full kernel version and if
you wanted it to go back to the short version, you had to exit the fragment.
Now you can click between the two (short and long).
Change-Id: I6f89d6b145d5cc7b9cca6febc3651904b98da80c
Signed-off-by: Joey Huab <joey@evolution-x.org>
patch set 2: view unformatted kernel version on clicking
the formatted kernel version
[ Stallix - Evo X ]
* Adapted for KernelVersionPreferenceController on Pie
Change-Id: I2b211fb72c25cc119f2a464b04821fcef77a8908
Signed-off-by: Arghya Chanda <arghyac35@gmail.com>
Signed-off-by: SagarMakhar <sagarmakhar@gmail.com>
Signed-off-by: Joey Huab <joey@evolution-x.org>
Signed-off-by: AnierinB <anierin@evolution-x.org>
Android security 16.0.0 release 3
* tag 'android-security-16.0.0_r3':
Import translations. DO NOT MERGE ANYWHERE
Backport BT pairing dialog changes
[nfc] Fix string injection in default payment app selector
Add check to prevent privilege escalation from trampoline added in change Ie469c47005afb941f5646a2f790736362c23c697.
Hide sensistive content from locked profiles
Prevent SettingsSliceProvider from accessing unused packages
Ignore face settings extras when called by an external package.
startActivityForResult with earlier new Intent
Hide notification content in history
Use correct API to get calling package name in CredentialStorage
Drop PendingIntent extras from external packages during enrollment.
Do not enable the Content Protection toggle for non-admin users.
Add ComponentName explicitly to make sure arbitary intents aren't launched from Settings.
AppRestrictions - use vetted component
Add battery health tip
Change-Id: Ifbcbfcc5e95e3b69085c9c7f795914ec21b4d0a9
This is a combination of two commits against b/409868905, merged for
backport convenience. It updates the string and button style for the BT
pairing dialog.
Bug: 236134583
Bug: 236134775
Test: local tested
Flag: EXEMPT minor style update
Cherrypick-From: https://googleplex-android-review.googlesource.com/q/commit:22378fd5a1bb2ca8d63f5df4e47c0af218c66a57
Merged-In: Icd9f509b5363b3ec3900738e21486e54d4e66e4b
Change-Id: Icd9f509b5363b3ec3900738e21486e54d4e66e4b
New one seems halfbaked? The UDFPS icon is misaligned when using it and
progress circle is missing.
Change-Id: I19d0a1ff973d79381f0f315469c823afedde9c02
* 'android16-security-release' of https://android.googlesource.com/platform/packages/apps/Settings:
Hide sensistive content from locked profiles
Ignore face settings extras when called by an external package.
startActivityForResult with earlier new Intent
Use correct API to get calling package name in CredentialStorage
Prevent SettingsSliceProvider from accessing unused packages
Hide notification content in history
Do not enable the Content Protection toggle for non-admin users.
Add ComponentName explicitly to make sure arbitary intents aren't launched from Settings.
AppRestrictions - use vetted component
Drop PendingIntent extras from external packages during enrollment.
Change-Id: I2e6b262a366c24202897f3e040825f9e41d31a02
'Start SettingsDumpService after the MobileNetworkRepository is
created' sends the intent every single time the
NetworkDashboardFragment is instantiated (basically every time user
opens the network dashboard in Settings).
SettingsDumpService's lifecycle never finishes, since it's context is
passed to the MobileNetworkRepository for singleton instance creation
which then proceeds to holding a reference to that context thus keeping
the entire service alive along with the application process, which
prevents the static singleton from being garbage collected creating an
indirect retention cycle. All that over time grows into a solid memory
leak.
SettingsDumpService (as well as MobileNetworkRepository instance,
obviously) proceed to dangling until the app process gets eventually
killed by the lmkd (which is unlikely to happen but still was observed
on several devices running stock ROM) or manually terminated by user,
but based on the observation, maximum time of dangling could be
perfectly equal to global system uptime.
This issue still remains all the way up to latest AOSP tags and betas,
although some vendors stock ROMs seem to have sorted it out.
Since we don't really care about dumping mobile network info
(especially in production builds), do the minimum changes required to
remove the dumping feature and avoid future AOSP merge conflicts.
This partially reverts commit d6f3ad9178.
Change-Id: Ifd7ded6cebd5f247cbdeb88035fdeb21cf060412
This is a sed gone wrong.
It was unintentionally changed in 15ca95a31b
which broke functionality.
Change it to a SwitchPreferenceCompat instead of changing it back
to a SwitchPreference, as all the other preferences in the
development section are one as well.
Change-Id: Id276d3b67c103b83ba01a69ff2991246c69efc69
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
mIsInSetupWizard was moved to top of NetworkProviderSetting's onCreate
so it is available for addPreferences().
Change-Id: I9299c3033e96bcd30450ec239f14fb5daa800d63
When help_url_battery_defender is empty, tapping on Learn more button
causes a NPE.
Issue: calyxos#2809
Change-Id: Ib1c52dcff430cae7c4bc0793120ace837f5bf4c7
Stop removing preexisting UID policies when toggling
Background network access / unrestricted data usage.
Fetching the state of policies was not working due to an incorrect use
of Arrays.asList() - if you give it an int array, you just get a list
with that int[] as a single element, so using the contains method with
an int will always return false. This has now all been refactored.
Test: Manual: Open Settings > Network & Internet > Data Saver >
Unrestricted data. Turn it on for something. Go back, and then
return to the page. It should still show as on.
Issue: calyxos#2547
Issue: calyxos#2118
Change-Id2: I671544f6fdf9897484c6265c31c8b3cd29ad4a92
Change-Id: If54d0a0925c5da0f3d519d0a85491ff3b7b62351
... in the same category as Security & privacy
... with an approach that can be reused for other keys in the future
Co-authored-by: AnierinB <anierin@evolution-x.org>
Change-Id: I666ebd7f90c11f1836bac10f7fca38baa5aedf93
On new revamped Settings UX dashboard is missing styling for GMS top
level activities. This is fixed by assigning them respective categories.
Change-Id: I5f18fab2419c8346760c4f6bed6f77e1eac8e059
Signed-off-by: shoya0x00 <shoya0x00@users.noreply.github.com>
Remove DynamicDenylistManager to avoid its conflicting behavior
with our firewall. This stops the resetting of firewall policies
on boot and for other reasons. The user is in control of these
policies and doesn't need them to be unexpectedly reset.
Issue: calyxos#2211
Test: Manual: Turn off Background network access for any app. Then,
in Firewall, turn off another toggle like Wi-Fi. Reboot, and check
the toggles. Background network access and Wi-Fi should still be off.
Change-Id: Ie62ddfa3a893c9adf5d4fd0c8670235a5a51e03f
Fingerprint authentication when screen is off doesn't nativelly
support checking the proximity sensor status to prevent accidental
unlocks. However, some devices implement this feature, so account
for that. The only thing really needed is just to adapt the
descriptions shown to the users.
Change-Id: I635f7b1a2970c0364b6cd22dfe20e69d009a3f91
* Class comment states: "Headless activity that toggles
flashlight state when launched."
* Comment in constructor states:
"The sole purpose of this activity is to provide a place
to index flashlight into Settings search."
* Since it does only the second thing successfully and we
do neither know why we need a useless search result nor
does it serve any purpose, hide it from search results
* We could remove the whole class, but since it's from AOSP
I decided to keep the change footprint minimal
Test: Type "Flashlight" into settings search - result does not
appear anymore
Fixes: https://gitlab.com/LineageOS/issues/android/-/issues/6397
Change-Id: I53541c700e24efd33d386c38a4ea38fb1b8b81d6
Allow toggling AGPS (which in turn disables SUPL) using the existing
AOSP mechanism that was simply never exposed to the user.
Based on the following commits from CodeAurora, modified to
use SwitchPreference and improved strings:
Author: juwei <juwei@codeaurora.org>
Date: Mon May 7 13:31:50 2018 +0800
Settings: Add AGPS setting menu.
Add AGPS setting switch to allow user turn on/off
AGPS function.
Change-Id: If8a20a8293b9f4b12933bc3820b4cd135a938b72
CRs-Fixed: 2169854
Author: hoffc <hoffc@codeaurora.org>
Date: Wed Dec 19 15:56:07 2018 +0800
Settings: Refactor Agps preference controller code
(1) Extract inner class AgpsPreferenceController as one standalone file.
(2) Delete the useless code of reading the SUPL server and port from etc/gps.conf file.
(3) Remove the config item "config_agps_enabled".
Change-Id: I20465aa4375c7fe64bc84f579a39178506b8e211
CRs-Fixed: 2370304
Author: hoffc <hoffc@codeaurora.org>
Date: Tue Jun 1 08:52:31 2021 +0800
Settings: fix NPE caused by missing agps preference definition
No agps preference is defined in location settings, results in NPE when agps controller init
add agps preference definition in location settings
Change-Id: I92e3293bccb90da7b6a1057e2dd83f8aa909d308
CRs-Fixed: 2958241
Issue: calyxos#1490
Co-authored-by: Chirayu Desai <chirayudesai1@gmail.com>
Co-authored-by: Michael Bestas <mkbestas@lineageos.org>
Change-Id: Idea7026f0c954c1f2a056e7b4595a879ef161f5c
Allow devices to provide advanced keyboard settings.
Unfortunatelly this can't be done with existing IA settings,
so use the RemotePreference API to allow the external app
to update the view. The action for this is:
"org.lineageos.settings.device.ADVANCED_KEYBOARD_SETTINGS"
Change-Id: I1c46d3568c4d5bfc78e1cbae033071c7641fdf29
