Commit Graph

29593 Commits

Author SHA1 Message Date
Menghan Li
e4cdbcba62 Merge "Color correction improvement (5/n)" 2020-01-20 11:10:44 +00:00
Goven Liu
f5dc746fa9 Merge "[Wi-Fi] Add Wifitracker mechanism to update the signal icon." 2020-01-20 11:03:12 +00:00
TreeHugger Robot
b2fe109956 Merge "Create a new Open supported links page" 2020-01-20 10:06:31 +00:00
govenliu
7e1018c0d0 [Wi-Fi] Add Wifitracker mechanism to update the signal icon.
Signal icon on the add wifi network feature is constant, didn't change with real signal level.

Bug: 146842198
Test: Add following unit test cases:
      1. withOneSuggestion_uiElementShouldHaveInitLevel() to test init level.
      2. withOneSuggestion_whenScanResultChanged_uiListShouldHaveNewLevel() to test level should updated according to scan result.

Change-Id: I212a825da9455a09a5c7777f87c0a74ec030c890
2020-01-20 17:34:20 +08:00
TreeHugger Robot
3a24382236 Merge "Define ICON_UNAVAILABLE for no icon status" 2020-01-20 09:23:33 +00:00
menghanli
756d819c42 Color correction improvement (5/n)
"Use Color correction" should be replaced by "Correct colors"

Bug: 145968068
Bug: 147988288
Test: make RunSettingsRoboTests2
Change-Id: I90ef36a99b34a82eb9f29f8b79d9aaa8d56441d1
2020-01-20 14:29:30 +08:00
TreeHugger Robot
4c1874dbb6 Merge "Add title and icon in panel header" 2020-01-20 06:00:08 +00:00
timhypeng
0206434667 Define ICON_UNAVAILABLE for no icon status
Bug: 147776885
Test: make -j42 RunSettingsRoboTests
Change-Id: I0fd0e203bb7590955d0caf2679ebc78be68b4e50
2020-01-20 13:57:02 +08:00
timhypeng
adae7475b0 Add title and icon in panel header
- Add getIcon() and getSubTitle() in PanelContent
- Check icon avalibility to decide header layout
- Add test cases

Bug: 147776885
Test: make -j42 RunSettingsRoboTests
Change-Id: Idb51e81359b6037ca9b90965dd9b370fc5e22c84
2020-01-20 13:43:19 +08:00
Rajeev Kumar
840db3034a Merge "Use TetherEnabler in AllInOneTetherSettings to manage master switch" 2020-01-20 05:37:16 +00:00
Zoey Chen
b0e78a94fd Merge "[Settings] To avoid use APIs in IccCard directly, calling APIs through TelephonyManager" 2020-01-19 14:38:35 +00:00
Kevin Chyn
dd94fbff33 Merge "No longer need to cancel authentication from ConfirmDeviceCredentialActivity" 2020-01-18 03:30:22 +00:00
Kevin Chyn
dbdd06ca85 No longer need to cancel authentication from ConfirmDeviceCredentialActivity
CDCA no longer needs to cancel authentication in onPause. Since it
internally invokes BiometricPrompt, and BiometricPrompt's components e.g.
BiometricService and AuthController are aware of the "top-ness" of its
client, this code is redundant.

Fixes: 145991060

Test: Follow comment#3 in the bug above, repeat 10+ times
Test: Set up work profile, set up work profile password. Open work profile
      app, but before entering password, swipe up to go to home screen.
      Authentication is cancelled as expected.

Change-Id: I0b4d7d89cb9801ddbb6e3bd07f71191035cc75ec
2020-01-17 13:29:49 -08:00
Zhen Zhang
02dfed6846 Use TetherEnabler in AllInOneTetherSettings to manage master switch
In AllInOneTetherSettings, we use TetherEnabler to hanle all behavior
related to tethering switch on/off.
In TetherEnbler, add WifiManager.WIFI_AP_STATE_CHANGED_ACTION to cover
all possible tethering state change.
TetherEnablerTest is modified accordingly.

Bug: 147322704
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=TetherEnablerTest
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=AllInOneTetherSettingsTest

Change-Id: I505b3825f79260983fff9d3935ba834ad8f9f690
2020-01-17 11:11:30 -08:00
Sarah Chin
6860eecdcc Merge "Rename references to getLteOnCdmaMode" 2020-01-17 18:34:20 +00:00
Menghan Li
8e3ea9d1cf Merge "Talkback shouldn't speak action for description." 2020-01-17 16:10:29 +00:00
Menghan Li
fa240f6cfc Merge "Support autoclick secondary action (1/n)" 2020-01-17 14:13:47 +00:00
TreeHugger Robot
8caac569be Merge "Fix broken links in @ChangeId javadoc." 2020-01-17 12:49:49 +00:00
Mathew Inwood
5800245d1b Fix broken links in @ChangeId javadoc.
We will soon have javadoc generated from the doc comments on all
@ChangeId annotated constants. Since the link target referred to
here is a @hide constant, it cannot be resolved as part of DAC doc
generation. Replace it with {@code} specifying the constants value
instead.

Bug: 144927670
Test: In follow up CLs
Change-Id: I9947e722dca228705190e8f2c49e47104c04dea6
2020-01-17 11:22:52 +00:00
ChenJean
7afc1fa6fb Support autoclick secondary action (1/n)
Added radio button preference and control to handle user update value.

Bug: 146019277
Test: Manual
Change-Id: Ie9136f942eec43fc378e7f39d8c2eb7534c531c9
2020-01-17 10:31:07 +00:00
Goven Liu
4fa11dcb93 Merge "[Wi-Fi] Refactor add wifi networks feature to use WifiNetworkSuggestion." 2020-01-17 08:14:53 +00:00
menghanli
097472fc4a Talkback shouldn't speak action for description.
Fix for Select-To-Speak, Talkback, and Magify app.

Bug: 147793421
Bug: 147709365
Bug: 147708796
Test: Manual test
Change-Id: Id7b62c96df869cbd35f2ffbb442b0a4eb7e0393d
2020-01-17 16:10:21 +08:00
TreeHugger Robot
4a70204f51 Merge "Accessibility shortcut secondary action - fix permission dialog did not pop up" 2020-01-17 07:44:02 +00:00
Yanting Yang
62fe52f292 Merge "Add bond state checking into BluetoothDevicesSlice" 2020-01-17 04:19:28 +00:00
Betty Chang
af2e3afb04 Merge "[Mainline] Copy the findBestComponent method from EuiccConnector to Settings" 2020-01-17 03:27:32 +00:00
tim peng
26d39236c6 Merge "Unable to set Bluetooth configuration at the first time" 2020-01-17 02:48:54 +00:00
TreeHugger Robot
846f739465 Merge "Support accessibility shortcut secondary action (8/n)" 2020-01-17 01:10:53 +00:00
Sarah Chin
de616afce0 Rename references to getLteOnCdmaMode
Use @SystemApi TelephonyManager#isGlobalModeEnabled()

Test: build
Bug: 147335742
Change-Id: Ie1b01a97cf163d68e4a5529f1718a9a782d44bb0
2020-01-16 12:38:59 -08:00
Bonian Chen
66349e21c3 Merge "[Mainline] Use @SystemApi constants in SmsManager instead of in SmsUsageMonitor" 2020-01-16 20:13:37 +00:00
Bonian Chen
f121495e69 Merge "[Settings] Remove Phone hidden constants access" 2020-01-16 20:12:27 +00:00
Menghan Li
f70d04ea0a Merge "Create palette preview for color correction (2/n)." 2020-01-16 15:12:26 +00:00
TreeHugger Robot
5f964f1886 Merge "Remove settings_work_profile feature flag" 2020-01-16 15:10:17 +00:00
menghanli
5d0f336fec Support accessibility shortcut secondary action (8/n)
Integrate with the multiple shortcut selections and change the behavior as below:
- Get the shortcut type from system provider or shared_prefs if this is first time to use.
- Update the shared_prefs for what user seen.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests2
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityUtilTest
Change-Id: I58aeb960e2c4aa0bc2432be34c1372c0de89117a
2020-01-16 22:57:11 +08:00
SongFerng Wang
5f4fadb949 Merge "Mainline: removed legacy UI for network selection mode." 2020-01-16 14:27:25 +00:00
TreeHugger Robot
bc6bd74228 Merge "Color correction improvement (4/n)" 2020-01-16 14:24:46 +00:00
TreeHugger Robot
7fd5b23da4 Merge "Accessibility shortcut secondary action - fix magnification triple tap logic" 2020-01-16 14:22:55 +00:00
jasonwshsu
c602ceb5ea Accessibility shortcut secondary action - fix permission dialog did not pop up
- Need to set EXTRA_CHECKED after shortcutPreference's checkbox is unchecked

Bug: 142530063
Test: manual
Change-Id: I7f1ea5a9d4b12ac958ac8a074cf7a267faddb4ad
2020-01-16 21:18:21 +08:00
TreeHugger Robot
244afa02d2 Merge "Revert "Settings search - Navigate user to exact page"" 2020-01-16 13:06:24 +00:00
Bonian Chen
4ecff2c833 [Settings] Remove Phone hidden constants access
Remove access to:
1. Phone.CDMA_SUBSCRIPTION_UNKNOWN
2. Phone.PREFERRED_NT_MODE
3. Phone.PREFERRED_CDMA_SUBSCRIPTION

Bug: 147794713
Test: manual
Change-Id: I18c2fa70a47fa7fb082a974dbd5acd61cf9f9c38
2020-01-16 13:05:33 +00:00
changbetty
bbc757e01a [Mainline] Copy the findBestComponent method from EuiccConnector to Settings
Make a copy of EuiccConnector#findBestComponent() into local method findEuiccService().

Bug: 147275124
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ApplicationFeatureProviderImplTest
Change-Id: Ie81569d940fc354053469570e1506b1954d9f24d
2020-01-16 20:46:06 +08:00
TreeHugger Robot
81d194ed7a Merge "Make contextual card count configurable." 2020-01-16 11:21:38 +00:00
SongFerngWang
affe5406a6 Mainline: removed legacy UI for network selection mode.
This cl base on ag/10098777. Now inserted inactive pSIM
will be included in Telephony's get available and
get selectable subInfo list so that logic is no longer
needed.

Bug: 147128878
Test: build pass
Change-Id: I1a0f431f05268d29afce145c3eb720594cfc57a3
2020-01-16 10:55:46 +00:00
Yanting Yang
9589041e1c Add bond state checking into BluetoothDevicesSlice
Make the Bluetooth device connected checking to be consistent with
BluetoothDeviceUpdater. Because it's more safe to check the bond state
and connected state together to handle abnoraml status from Bluetooth.

Fixes: 147351883
Test: visual, robotests
Change-Id: I4e34b73f16b44972fbb7273a5e13be1f3096835e
2020-01-16 18:38:14 +08:00
jasonwshsu
620aec5f8c Accessibility shortcut secondary action - fix magnification triple tap logic
- triple tap in settings is boolean status, not string.

Bug: 142530063
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: Ieec9879f7ef55b694245c6f9143575ba933855e5
2020-01-16 18:21:48 +08:00
Sunny Shao
6b032f4e2d Create a new Open supported links page
- Add a new OpenSupportedLinks fragment
- Add a new AppHeaderPreferenceController
- Add a new AppOpenSupportedLinksPreferenceController

Fixes: 143185713
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.applications
Change-Id: I6568950b7b918378baaa80e2ca0d596913620928
2020-01-16 18:18:14 +08:00
menghanli
35931974eb Create palette preview for color correction (2/n).
Limit the preview measure for one time to avoid unnecessary
measure and draw performance.

Bug: 145968068
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PaletteListViewTest
Test: make RunSettingsRoboTests2
Change-Id: Ib8ea13e511351c71babcbd1376817cea3a47cac4
2020-01-16 17:55:52 +08:00
Yi-Ling Chuang
72da4a81f4 Make contextual card count configurable.
Decide how many card we should show at once on the homepage based on the
value in Settings Global for more flexibility. Fall back to the default
value if there is nothing set up.

Bug: 138754406
Test: robotests
Change-Id: I8d31d98eafb636a5e72af76ffec7e3dae0be3cbc
2020-01-16 16:20:56 +08:00
Jason Hsu
565b1f031a Merge "Accessibility shortcut secondary action - correct invisible type fragment checkbox logic" 2020-01-16 07:52:07 +00:00
timhypeng
9a8ec96e48 Unable to set Bluetooth configuration at the first time
- initial configuration value
- add test case

Bug: 147634692
Test: make -j50 RunSettingsRoboTests
Change-Id: If55036d358d664bcbcb816a38f18019c62976d38
2020-01-16 14:37:28 +08:00
Edgar Wang
e19ee9a01f Revert "Settings search - Navigate user to exact page"
This reverts commit 08f2a58459.

Reason for revert: design changed, we decide to take the user to
the entry after clicking on a search result.
It's opposite with what we did, so we revert related CL first.

Test: robotest

Change-Id: Iadb9a94a7ef7838be34a54499e2d934d6396c336
2020-01-16 14:07:38 +08:00