Commit Graph

36491 Commits

Author SHA1 Message Date
Julia Reynolds
5ad98383d5 Merge "Add conversation onboarding" into rvc-dev 2020-04-23 17:16:58 +00:00
Brad Ebinger
a79f10ad09 Merge "Revise strings as per string UX review" into rvc-dev am: c3d052a48c
Change-Id: I68257982f4d35460d6d071b9b271cf317b2b2f80
2020-04-23 16:56:51 +00:00
Brad Ebinger
54c8a3842b Merge "Revise strings as per string UX review" into rvc-dev am: c3d052a48c am: d73fd30545 am: a62927963a am: 15801febee
Change-Id: I7029c358b769253c6cdd625b3d13c301b4f1602d
2020-04-23 16:43:26 +00:00
Brad Ebinger
a62927963a Merge "Revise strings as per string UX review" into rvc-dev am: c3d052a48c am: d73fd30545
Change-Id: I399188dd397d2f4a536594b4c49f8a0b6dad0d6b
2020-04-23 16:18:58 +00:00
Brad Ebinger
d73fd30545 Merge "Revise strings as per string UX review" into rvc-dev am: c3d052a48c
Change-Id: I26b56d053b1504a9061c765fe7504603f8394fe1
2020-04-23 15:57:03 +00:00
Jason Chang
8c42720803 Fixed One-Handed preference item’s second line should show on/off
status in Settings > System > Gesture > One-Handed.

To override getSummary() method to display on/off status in
One-Handed preference item’s second line.

Bug: 154600203

Test: manual
Change-Id: Ic9a5b74fbca041a08e712d5529b66e672f0c74ab
2020-04-23 23:54:05 +08:00
Brad Ebinger
c3d052a48c Merge "Revise strings as per string UX review" into rvc-dev 2020-04-23 15:38:39 +00:00
Menghan Li
fb4e0f68f6 Merge "Fix Auto click (dwell timing) the checked option isn't the same as the option before upgrading the OS" into rvc-dev am: 6f9f91b67b am: 9e155131e7 am: 6df7977c9a am: c58cc5094c
Change-Id: Ib433cfcab4803c5c889ada6f9efe1353a181fd54
2020-04-23 15:03:04 +00:00
Menghan Li
6df7977c9a Merge "Fix Auto click (dwell timing) the checked option isn't the same as the option before upgrading the OS" into rvc-dev am: 6f9f91b67b am: 9e155131e7
Change-Id: I44b78776440f845c65d09fbaa3fc37a1e5c389e0
2020-04-23 14:31:10 +00:00
Menghan Li
a719a22e55 Merge "Fix Auto click (dwell timing) the checked option isn't the same as the option before upgrading the OS" into rvc-dev am: 6f9f91b67b
Change-Id: I502f9a76d177f5314eb986bb33efb6beccfcd809
2020-04-23 14:09:55 +00:00
Menghan Li
9e155131e7 Merge "Fix Auto click (dwell timing) the checked option isn't the same as the option before upgrading the OS" into rvc-dev am: 6f9f91b67b
Change-Id: I6a888383300fa9b79e4bf5382996a8cd5552f4a8
2020-04-23 14:09:46 +00:00
Menghan Li
6f9f91b67b Merge "Fix Auto click (dwell timing) the checked option isn't the same as the option before upgrading the OS" into rvc-dev 2020-04-23 13:57:45 +00:00
PETER LIANG
516516f1e9 Merge changes from topic "tutorial_improvement" into rvc-dev am: b6bf10ebbc am: 15d20efe43 am: 636d68059e am: fbe9b33c73
Change-Id: I8711cc5c75a05d7865b22e411648debe3adda41e
2020-04-23 13:28:37 +00:00
PETER LIANG
636d68059e Merge changes from topic "tutorial_improvement" into rvc-dev am: b6bf10ebbc am: 15d20efe43
Change-Id: I428a0bbc42ebd562e9ade929160114735ca13995
2020-04-23 13:00:12 +00:00
PETER LIANG
99d4e3210d Merge changes from topic "tutorial_improvement" into rvc-dev am: b6bf10ebbc
Change-Id: Ie89050239048e7e6bc83a258b0e90547d87a7fb7
2020-04-23 12:48:25 +00:00
PETER LIANG
15d20efe43 Merge changes from topic "tutorial_improvement" into rvc-dev am: b6bf10ebbc
Change-Id: I9c6d550f6267d80aa7bd22894b81d4dade1f9189
2020-04-23 12:48:15 +00:00
Bonian Chen
1521d35635 Merge "[Settings] Fix CellDataPreferenceTest" into rvc-dev am: ef2e319347 am: ec80b6da3a am: 9e63bd4867 am: 0de3ee1267
Change-Id: Id459a4b929774a7b08361686ac13ce7bbdc48924
2020-04-23 12:44:01 +00:00
PETER LIANG
b6bf10ebbc Merge changes from topic "tutorial_improvement" into rvc-dev
* changes:
  Tutorial improvement for Accessibility shortcut (3/n).
  Tutorial improvement for Accessibility shortcut (2/n).
  Tutorial improvement for Accessibility shortcut (1/n).
2020-04-23 12:37:15 +00:00
Bonian Chen
9e63bd4867 Merge "[Settings] Fix CellDataPreferenceTest" into rvc-dev am: ef2e319347 am: ec80b6da3a
Change-Id: I3bf7d787dd6887d6fbfb5fa9e5ff213eea25ada5
2020-04-23 12:19:18 +00:00
Bonian Chen
e02ffc7b7d Merge "[Settings] Fix CellDataPreferenceTest" into rvc-dev am: ef2e319347
Change-Id: Iae36b68fa837883091f293d6f72577d02f6cc5ea
2020-04-23 12:06:37 +00:00
Bonian Chen
ec80b6da3a Merge "[Settings] Fix CellDataPreferenceTest" into rvc-dev am: ef2e319347
Change-Id: Ibc821f8fba3f23ad6326012f4def600a1b81336e
2020-04-23 12:06:26 +00:00
Bonian Chen
bc10c00149 [Settings] Support the display of data usage when SIM inactive
SIM can be inactive but remain existed within slot.
Therefore, change the design here.

Bug: 143996139
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I24ec529b120b2801f7b9089b07d32bdd1038883f
2020-04-23 19:53:46 +08:00
Bonian Chen
29e37ceaa1 [Settings] Fix CellDataPreferenceTest
Fix CellDataPreferenceTest

Bug: 154562715
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=CellDataPreferenceTest
Change-Id: Ia0ee0f5cd802ca9b6827bddcaf189c619d268074
2020-04-23 17:51:14 +08:00
menghanli
771163f0d3 Fix Auto click (dwell timing) the checked option isn't the same as the option before upgrading the OS
Root cause:
After OS upgrade to R, the original logic only check SP key but does not consider the setting enabled key to cause it cannot not show correctly.

Next:
1) accessibility_autoclick_enabled=1 but does not have SP key, customize layout is checked and show the right value
2) accessibility_autoclick_enabled=1 and have SP key, show according items is checked
3) accessibility_autoclick_enabled=0, off button is checked

Bug: 151123423
Test: local test
Change-Id: I9ebcbb35ee0071dbf8c969d0a70ea6293f4c6edb
2020-04-23 09:22:01 +00:00
Bonian Chen
822a79efb8 Merge "[Settings] Move some work into background thread" into rvc-dev am: 7585e6ac1f am: d68d156a80 am: 243ea793ce am: 48a36f7af8
Change-Id: I88a745f929dafe080c1dd2b6d3624eb8684b11f4
2020-04-23 09:14:27 +00:00
Bonian Chen
c4ba970fa7 Merge "[Settings] Code refactor for data usage" into rvc-dev am: abdeadf85d am: 148972e154 am: ab6bc3568a am: 192ddb88c3
Change-Id: Iccc3c77e6e61f32d93f1b4e91d6daeb819db0345
2020-04-23 09:14:17 +00:00
Bonian Chen
243ea793ce Merge "[Settings] Move some work into background thread" into rvc-dev am: 7585e6ac1f am: d68d156a80
Change-Id: I386a83acb788e7af9ad998c1fe71a6c16e5f6b98
2020-04-23 08:46:58 +00:00
Bonian Chen
ab6bc3568a Merge "[Settings] Code refactor for data usage" into rvc-dev am: abdeadf85d am: 148972e154
Change-Id: I1c97425137a09da0190ba9242c47f156877cd145
2020-04-23 08:46:48 +00:00
Bonian Chen
fc8b5badb7 Merge "[Settings] Move some work into background thread" into rvc-dev am: 7585e6ac1f
Change-Id: I55c7ab8682b82b5e93e6a77796c420070cc5f7e3
2020-04-23 08:34:42 +00:00
Bonian Chen
d68d156a80 Merge "[Settings] Move some work into background thread" into rvc-dev am: 7585e6ac1f
Change-Id: Iecc4b7665ebc977aa0e1fea33ab80fc5b0ba7d7f
2020-04-23 08:34:36 +00:00
Bonian Chen
4738a05f1f Merge "[Settings] Code refactor for data usage" into rvc-dev am: abdeadf85d
Change-Id: I5b86c28d5ca4ad2f6d24c18752809cef699d6674
2020-04-23 08:34:34 +00:00
Bonian Chen
148972e154 Merge "[Settings] Code refactor for data usage" into rvc-dev am: abdeadf85d
Change-Id: Id0749b00f602a6033aa67c5714fd32c4a3f70858
2020-04-23 08:34:22 +00:00
Bonian Chen
7585e6ac1f Merge "[Settings] Move some work into background thread" into rvc-dev 2020-04-23 08:22:32 +00:00
Bonian Chen
abdeadf85d Merge "[Settings] Code refactor for data usage" into rvc-dev 2020-04-23 08:22:00 +00:00
Arc Wang
c6c4d036da [Wi-Fi] Add IMSI privacy protection warning summary
If a SIM based Wi-Fi network is not provided with IMSI
protection, Wi-Fi detail UI shows the warning summary if
the Wi-Fi network is connected.

Bug: 148283447
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiSecondSummaryController2Test
      make RunSettingsRoboTests ROBOTEST_FILTER=LinkifySummaryPreferenceTest

Change-Id: I689a75d2f0a2ae6196b2ed5985b8ff141fbac8b4
2020-04-23 14:50:18 +08:00
Bonian Chen
cdb8a6f520 Merge "[Settings] Code Refactor" into rvc-dev am: 921ed942c0 am: c2ea9a1fa4 am: 861947c155 am: 342f4168c0
Change-Id: Id34b7448c35721ebd3374d849c25d2e1db3fc29e
2020-04-23 06:47:38 +00:00
Bonian Chen
861947c155 Merge "[Settings] Code Refactor" into rvc-dev am: 921ed942c0 am: c2ea9a1fa4
Change-Id: I2653470ad59cc3b69811e0838bf7ddf660ab9ff9
2020-04-23 06:14:44 +00:00
Bonian Chen
c2ea9a1fa4 Merge "[Settings] Code Refactor" into rvc-dev am: 921ed942c0
Change-Id: I7722ae2f971b68cca02d6fb0ed6dc64668857a5e
2020-04-23 06:01:53 +00:00
Bonian Chen
0a7fefde75 Merge "[Settings] Code Refactor" into rvc-dev am: 921ed942c0
Change-Id: Id2158b59998fba83f424c25ab99f3c85a1e80f6e
2020-04-23 06:01:37 +00:00
Bonian Chen
921ed942c0 Merge "[Settings] Code Refactor" into rvc-dev 2020-04-23 05:47:10 +00:00
Bonian Chen
a73cb31f63 [Settings] Fix DataUsageSummaryTest
Fix DataUsageSummaryTest

Bug: 154563784
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryTest
Change-Id: I32f8fc00f01a335950e863d5c9801ee9af0a3f5d
2020-04-23 13:43:27 +08:00
Bonian Chen
3248d004d3 [Settings] Move some work into background thread
1. Move some work into backgroud thread when query data usage status.
2. Fix test case

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: Ic1496323cd2bbaf794881394565d8d9bb0a89111
2020-04-23 12:55:53 +08:00
Peter_Liang
8cbb44d6f6 Tutorial improvement for Accessibility shortcut (3/n).
Add test cases for tutorial pages.

Bug: 148989018
Bug: 134640159
Test: manual test & run RoboTests
Change-Id: I9bb29f6e61e331c3f9a2408a1eebc3d5e9e16000
2020-04-23 12:18:26 +08:00
Peter_Liang
72aa60ae95 Tutorial improvement for Accessibility shortcut (2/n).
Update UI widgets to meet the new design.

Bug: 148989018
Test: manual test
Change-Id: Ife42995af193db6746135d29f6fa1ad452d265a6
2020-04-23 12:18:26 +08:00
Peter_Liang
cfe3e454ac Tutorial improvement for Accessibility shortcut (1/n).
Because can't save the value into setting keys for the service before version R, and in order to let tutorial dialog can get the consistent value, using alternative that each fragment with shortcut to must implement the new abstract method.

Bug: 148989018
Test: manual test
Change-Id: Iba2a7daa70eb00f0bba37317c9355531fbb77628
2020-04-23 12:18:23 +08:00
Bonian Chen
048d9fe19e [Settings] Code Refactor
Code refactor to provide the capability of method override

Bug: 141833767
Test: manual
Change-Id: I79647a7ff79f1f722bcfdf8190590df61bb3510a
2020-04-23 04:11:55 +00:00
menghanli
8a27603600 Fix formats and internationalization of the string "0.6 seconds" in sk language
Root cause: The OTHER quantity does not require special treatment of the given quantity
Next: Using few quantity for the language requires special treatment of "small" numbers (as with  numbers ending 2, 3, or 4)

Bug: 154085511
Test: Change language to Slovensko to check the UI
Change-Id: I9143d9504cf8f9c5ccf17160e0dc0943fa10d31d
2020-04-23 11:30:17 +08:00
Bonian Chen
761a13700f [Settings] Code refactor for data usage
Code refactor

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I22b323bae0b18cca26c62d047fdb504c012518b5
2020-04-23 11:01:34 +08:00
Julia Reynolds
2980f78e36 Add conversation onboarding
Test: atest
Fixes: 150791002
Change-Id: I51c27300acb8e18b28b5b5e5bf0d2623c65af909
2020-04-22 16:51:34 -04:00
Bonian Chen
04903fb6ab Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 673251973b am: ea4fc4af4c am: 57637f19c9 am: 73526ad9b7
Change-Id: I1cae350f4058b6ad21af83d40554c2bf883924b3
2020-04-22 15:23:39 +00:00