Commit Graph

77 Commits

Author SHA1 Message Date
LuK1337
736da0ca6c Settings: Make SIM toggle unchangable when not supported
Fixes: https://gitlab.com/LineageOS/issues/android/-/issues/8290
Change-Id: I2e566c24969708c31f607af2baad88b388bda74d
2025-08-28 13:38:18 +03:00
tom hsu
8be6d98b1f [Satelllite] Avoid using "add ESIM page"
- When user clicks preference UI, show a dialog to nofity user
   satellite session.

Flag: EXEMPT bug fix
Fix: b/402544816
Test: atest pass
Test: Manual test

Change-Id: Ifeff9368fed906bc56abcc8eb23748a71f79ee4d
2025-03-21 13:48:21 +00:00
tom hsu
2a91e80acc Fix mobile data in Settings is not disable under satellite session
Flag: EXEMPT bug fix
Bug: b/386424636
Test: atest pass
Change-Id: I8d28419f295b172c2929acca5f5896aa4deeb09c
2025-02-21 02:48:55 +00:00
Chaohui Wang
440c3c2779 Reduce Mobile data switch flaky
Set initial value to null, so no animation when the actual value true
is emitted.

Bug: 329584989
Flag: EXEMPT bug fix
Test: manual - on SIMs
Test: unit test
Change-Id: I3eea55115f02e65dcdcc44ccf917f9083622b723
2024-12-31 14:54:54 +08:00
Jacky Wang
36684ec80d [Catalyst] Migrate SIMs entry point
NO_IFTTT=Catalyst only

Bug: 368355368
Flag: com.android.settings.flags.catalyst_network_provider_and_internet_screen
Test: Manual
Change-Id: I2f3526c1ccb50490b955ad5f98c19d9ce2f5f21d
2024-12-02 11:26:37 +08:00
Chaohui Wang
a2ccf8979d [expressive design] SimsSection
Bug: 349681531
Flag: EXEMPT bug fix
Test: visual
Change-Id: I2d38ad81ce93d47819fa82d46f1c11a9b8c9271d
2024-11-18 18:45:53 +08:00
Chaohui Wang
73fb290969 Check DISALLOW_CONFIG_MOBILE_NETWORKS when search
If disallowed, not show mobile related search results.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search Mobile Settings
Test: atest MobileNetworkSettingsSearchIndexTest
Change-Id: I79b984f41f09dd9612bcd0c9942089756d5d365d
2024-09-23 11:17:55 +08:00
Chaohui Wang
777a179bd6 Create MobileNetworkSummaryRepository
For MobileNetworkSummaryController to use, so it no longer use
MobileNetworkRepository.

Fix: 366097262
Flag: EXEMPT refactor
Test: manual - on Network & internet
Test: atest MobileNetworkSummaryRepositoryTest
Change-Id: I8a9d52af8e230fc407a4339c27f73ef79d512b24
2024-09-18 13:07:50 +08:00
Chaohui Wang
a6db1aabb6 Create SimRepository
Which unifies whether we should sim settings on some related pages.

Before this change, we check SubscriptionUtil.isSimHardwareVisible()
and / or Utils.isWifiOnly().

After this change, we unified logic to,
canChangeSimSettings() =
  packageManager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY) &&
    userManager.isAdminUser

Fix: 365924140
Flag: EXEMPT bug fix
Test: manual - check Network & internet
Test: unit tests
Change-Id: Ibf83237e3d0088f78c96a1b39ee8f1e3a9c756ea
2024-09-12 08:59:26 +00:00
Chaohui Wang
f74e90787e Create EuiccRepository
Which also avoid calling from main thread.

Bug: 356684993
Flag: EXEMPT bug fix
Test: manual - on SIMs
Test: atest EuiccRepositoryTest
Change-Id: I0b11b0bd1e8a4b5754781e888fd220fa3080a212
2024-08-29 11:34:19 +08:00
Chaohui Wang
7477f4ea9a Show category when search "Mobile data"
The displayed category is "SIMs".

Bug: 346776183
Flag: EXEMPT bug fix
Test: manual - search "Mobile data"
Test: unit test
Change-Id: If3c395281e96603193e7476a9e76d1f9e9213531
2024-07-30 09:48:28 +08:00
Chaohui Wang
fb0583404f Always set cross sim calling
By CrossSimCallingViewModel, in SIMs and per SIM settings page.
To ensure the status is always right, including the case after the
onboarding set up finished.

Fix: 347882381
Fix: 348529996
Flag: EXEMPT bug fix
Test: manual - turn on / off "Automatic data switching" on SIMs
Test: manual - turn off "Automatic data switching" during onboarding
Change-Id: Icc2eacb67850fa7b3aa0fe310cd09a0e0147912b
2024-07-16 17:46:23 +08:00
Chaohui Wang
cacc9a88b2 Revert^2 "Support search "Mobile data""
This reverts commit 979de75952.

Reason for revert: Failed CarDeveloperOptions tests fixed.

Change-Id: Ic0bdf47ab3cb40dbadebb738c0c5842e4e1bf9c8
2024-07-15 02:03:06 +00:00
Pechetty Sravani
979de75952 Revert "Support search "Mobile data""
This reverts commit 50d9e342e8.

Reason for revert: Droidmonitor created revert due to b/352668970. Will be verifying through ABTD before submission.

Change-Id: I5e0c48830425c51963b7669b75979cb8b67e770c
2024-07-12 07:40:28 +00:00
Chaohui Wang
50d9e342e8 Support search "Mobile data"
- Added SpaSearchRepository to index the SPA search data.
- Added SpaSearchLandingActivity, which can only be called by SI.

Fix: 346776183
Flag: EXEMPT bug fix
Test: manual - search "Mobile data"
Test: unit test
Change-Id: Icaff41fe085edd371fd75bc8101dd52028f90da5
2024-07-12 03:52:03 +00:00
songferngwang
1892d20ce8 Add condition for askEveryTime of SMS at Primary Sim
Using the config_sms_ask_every_time_support control the askEveryTime

Bug: 349169874
Test: atest PrimarySimRepositoryTest
Flag: EXEMPT bugfix

Change-Id: Ida82ed3a6b5264f8d8c5997584e9fd27f25bf09f
2024-06-28 05:17:38 +00:00
tomhsu
75509bd06b Avoid to change preference UI content from tapping outside of dialog.
Flag: EXEMPT bug fix
Fix: 335763360
Test: atest passed.
Test: Manual test passed.
Change-Id: Iec5e98f74f0009ab2d3bc21bc590229514192f93
2024-06-26 02:38:25 +00:00
Chaohui Wang
ec59cd0c8b Move mobile data logic into MobileDataRepository
Bug: 347224962
Flag: EXEMPT refactor
Test: manual on Mobile Settings
Test: unit
Change-Id: I2b54f9e6c4addafd31d7d96f2a44870cd54fe185
2024-06-20 11:49:06 +08:00
SongFerng Wang
0cc20946c8 Merge "Add metricsCategory for dualsim and apnEdit" into main 2024-06-14 09:25:47 +00:00
songferngwang
d4e467ed4a Add metricsCategory for dualsim and apnEdit
Bug: 347091697
Test: Build pass
Change-Id: I783a45269112d91d79c00af41c0052ba488603d2
2024-06-13 23:00:29 +00:00
Chaohui Wang
2717f70ac0 InternetPreferenceController V2 (3/n)
Add DataSubscriptionRepository, when cellular connection,
show the active subscription name.

Bug: 339884322
Flag: com.android.settings.flags.internet_preference_controller_v2
Test: manual - on Internet
Test: unit test
Change-Id: If2a3e7f8df1b1ed89bc760ec5165182b3e9b64a8
2024-06-12 15:33:38 +08:00
tomhsu
6be77d05cb Avoid to save result of blank input.
- Disable "Save" button if no input or only space chars.

fix: 335763360
Test: Manual test
Test: atest pass
Change-Id: Ied5f98ec0ce7d1f38f626211cb9f465781781cd8
2024-06-06 07:27:04 +00:00
SongFerng Wang
ded1c459b0 Merge "To hide the mobile data when there is no active sim" into main 2024-05-30 10:59:32 +00:00
songferngwang
b48ec2f772 To hide the mobile data when there is no active sim
Bug: 343633243
Test: verified the UI
Change-Id: I77055a9c1cdb7e94c0339f4255b4799b7b6e02ac
2024-05-30 09:24:25 +00:00
Chaohui Wang
1bfea5d472 Check if ECBMode when deactivate SIM card
If in ECBMode, start ACTION_SHOW_NOTICE_ECM_BLOCK_OTHERS to show a
dialog instead.

This align with the current airplane mode switch.

Fix: 191943857
Test: adb shell cmd phone emergency-callback-mode
Test: unit test
Change-Id: Icf646cd76990d621121b4367ec0fd02a3880b85c
2024-05-30 16:37:51 +08:00
Tom Hsu
49abe4c03d Merge "Fix when edittext only has space and cause name look like blank" into main 2024-05-29 05:08:07 +00:00
tomhsu
d5556c59e9 Fix when edittext only has space and cause name look like blank
fix: 335763360
Test: Manual test. see b/335763360#comment14
Test: atest passed
Change-Id: I9ebae13039d7b78b7acfea545a89d3096aa82c31
2024-05-29 03:42:35 +00:00
SongFerng Wang
b462f9fa11 Merge "The pages of sim onboarding flow is wrong." into main 2024-05-28 19:58:55 +00:00
songferngwang
98efa51681 The pages of sim onboarding flow is wrong.
Switch from SS mode to DSDS mode, the esim status will use the last
status. It causes the condition of page selection is wrong.

Bug: 342972402
Test: atest SimOnboardingPageProviderTest
Change-Id: I8bb0b5f2802ec24f10467bac179ce54d13a9755e
2024-05-28 08:47:23 +00:00
Chaohui Wang
59a28a244c Setup backup calling for new UI
Backup calling new handles by CrossSimCallingViewModel.
CrossSimCallingViewModel keep monitoring the active SIMs, and setup
backup calling if needed.

Fix: 340444839
Test: manual - SIMs
Test: manual - Mobile Settings
Test: unit test
Change-Id: I0a3451f1e8c3984b2348cf628fb1d91ce7aaecec
2024-05-27 15:16:33 +08:00
Chaohui Wang
881c19480a Fix isSubscriptionEnabledFlow crash
When INVALID_SUBSCRIPTION_ID.

Fix: 338014486
Test: unit test
Change-Id: I97b5f005fb99473c2712f9643704a35cfaeecfac
2024-05-13 11:25:46 +08:00
Chaohui Wang
8c507e871b Catch exception in telephonyRepository.isDataEnabledFlow
And migrate BillingCycleRepository to use it.

Fix: 339197552
Test: manual - on data usage
Test: unit test
Change-Id: Ieac295f37fdbf75d184d66ea11f170652af3ec5f
2024-05-09 15:49:26 +00:00
songferngwang
d3c336a58f To correct the DDS when the user turn on mobile data
If there is only one sim and the DDS is -1, when the user turns
on the mobile data, the settings should correct the dds and set the
mobile data on.

Bug: 339382631
Test: Verify UI
Change-Id: Ib0304dc1370a0d76310da2ce6ce0de12bfb275d8
2024-05-08 11:50:31 +00:00
SongFerng Wang
ceda48c70c Merge "Add the OtherSection for NetworkCellularGroupProvider" into main 2024-05-07 04:58:28 +00:00
songferngwang
8b2305acd4 Add the OtherSection for NetworkCellularGroupProvider
Bug: 338914255
Test: Verified the SIMs UI
Change-Id: I49d5e4126e43054b5d147de15d35805d1e445c38
2024-05-06 10:16:02 +00:00
Chaohui Wang
5058a7f3b5 Adjust padding on SIM onboarding screens
Fix: 330899892
Test: visual - on Sim Onboarding Page
Change-Id: I2f09d8fc20ad9c51bb5d8c9fae703433a7f87ed8
2024-05-06 03:09:02 +00:00
Chaohui Wang
377a7a3054 Check isActivationChangeableFlow in SimPreference
Fix: 336209156
Test: manual - SimPreference
Change-Id: I8745e05dbab9701b9c046137fe76d98880a7b20a
2024-05-01 14:15:36 +00:00
SongFerng Wang
07c7cd6702 Correct the wording of mobile data summary
Bug: 337035270
Change-Id: Idc65508e8d4f68376fdfdba873ad049362445ac2
Test: verify the wording
2024-04-30 07:28:09 +00:00
Treehugger Robot
5ef0fe533e Merge "Prevent blank sim label showing on screen." into main 2024-04-24 05:14:03 +00:00
tomhsu
49e3afc551 Prevent blank sim label showing on screen.
fix: 333642116
Test: Manual test, see b/333642116#14
Change-Id: I776135d8ba609c4ea1fac47cfb765e00f8525497
2024-04-24 05:02:25 +00:00
Chaohui Wang
5ae84662b5 Check isConvertedPsimSubscription in new UI
Bug: 326896614
Test: manual test
Change-Id: I0d3c87a863f58a9e962fb87df5b8001be9edb767
2024-04-22 18:14:20 +08:00
tomhsu
aebb53870c Fixs user input nothing, but save it successfully
- If user inputs nothing, use original sim carrier name instead
 - Add a hint of showing original sim carrier name on edit field.

fix: 333642116
fix: 335763360
Test: Manual test
Test: atest passed
Change-Id: I68fa6bb12c2039899c0a3d0d2aef7f7946b717d1
2024-04-19 05:12:37 +00:00
SongFerng Wang
9a9b22b3ca Merge "Finish the sims page when airplane mode on" into main 2024-04-17 16:44:44 +00:00
songferngwang
f8a48668b0 Finish the sims page when airplane mode on
Bug: 335392575
Test: verify UI
Change-Id: I9d1e4c243e195abe8c917dc83ffed175f7ef74ec
2024-04-17 10:27:46 +00:00
SongFerng Wang
27e947f729 Merge "Set Phone number format as LTR" into main 2024-04-17 08:59:26 +00:00
songferngwang
3219f6da97 Set Phone number format as LTR
Bug: 334339964
Test: verify the phone number format
Change-Id: Ifa5dc394c3d9b8d7565e6200a47b7cb9fb1bba84
2024-04-17 07:10:20 +00:00
SongFerng Wang
15d619f9b4 Merge "Text input in dialog should extend to full width" into main 2024-04-17 06:28:28 +00:00
songferngwang
3daaf1a073 Text input in dialog should extend to full width
Bug: 329710418
Test: verify the UI
Change-Id: I7ff3c390686aa752a42531419ea66eea764e1812
2024-04-16 11:34:24 +00:00
SongFerng Wang
7eaa2b1661 Merge "Add the mobile data into new SIMs page" into main 2024-04-16 08:54:26 +00:00
songferngwang
e471604d32 Add the mobile data into new SIMs page
Bug: 329584989
Test: verify UI.
atest TelephonyRepositoryTest

Change-Id: Ia00ac287ffd0d15ba0c9350b731c3afc1a04b7a0
2024-04-16 07:20:21 +00:00