Commit Graph

1756 Commits

Author SHA1 Message Date
Yuhan Yang
d96bcf8f85 Add revert to left click to autoclick settings page
Screenshot: go/screenshot-4sdpfqk5rf3u23l
UI mock: go/screenshot-vcu7ui2ar9bjrm6

Bug: 388845719
Test: ToggleAutoclickRevertToLeftClickControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I813613f3d920ce6795e6750c440449e78d9b9c37
2025-02-27 17:32:41 +00:00
Angela Wang
03faf6b111 Merge "Filter out non-discoverable scan result in hearing device pairing page" into main 2025-02-26 17:11:05 -08:00
Treehugger Robot
de81197c74 Merge "Migrate SeekBarPreference to SliderPreference for haptics" into main 2025-02-26 13:01:19 -08:00
Angela Wang
5097cbe1ca Filter out non-discoverable scan result in hearing device pairing page
Flag: EXEMPT bugfix
Bug: 381027984
Test: atest HearingDevicePairingFragmentTest
Test: check with real device
Change-Id: I7ab70d5508d71472cbd2d0959bb749599d039058
2025-02-26 03:17:36 +00:00
Ebru Kurnaz
35e725d4eb Merge "Call DisplayDensityUtils from ExternalDisplay settings to adjust display size" into main 2025-02-25 04:55:58 -08:00
Ebru Kurnaz
8054a152b9 Call DisplayDensityUtils from ExternalDisplay settings to adjust display size
Flag: com.android.settings.flags.display_size_connected_display_setting
Test: atest ExternalDisplayPreferenceFragmentTest
Bug: 392853666
Change-Id: Iaa97f461e80a4e749ec3d2b47985a6be4a81a95b
2025-02-25 11:10:19 +00:00
Jack Yu
0b2effb371 Merge "Cleaned up the flag enforce_telephony_feature_mapping_for_public_apis" into main 2025-02-24 17:45:03 -08:00
Yuhan Yang
664df0f4cc Update autoclick shortcut searchable
Add autoclick shortcut to search index when
enable_autoclick_indicator flag is enabled.
Hide it when the flag is off.

Bug: 397719419
Test: atest ToggleAutoclickPreferenceFragmentTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ib6d25067d024ff0dbea64d17d38fc544c615db97
2025-02-21 22:36:53 +00:00
Yuhan Yang
4d52d72337 Only create shortcut preference when no existing shortcut found
Update onCreateView in AccessibilityShortcutPreferenceFragmen
so it only create a new shortcutPreference when no existing
shortcut preference is found.

Bug: 397719419
Test: Manually verified on test devices
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ic4747240cfd3d48fd97c61fd0b15d44f6ba5cf0a
2025-02-21 22:36:53 +00:00
Yuhan Yang
7c467be118 Merge "Add autoclick shortcut to a11y autoclick settings" into main 2025-02-21 11:15:54 -08:00
Daniel Norman
165f4ea76e feat(expressive): Add new magnification banner for expressive design
Fix: 378876803
Flag: EXEMPT custom flagging helpers from Settings and Setup
Test: observe new image; see bug screenshots
Change-Id: I3654563352e223af1a0d679318da45da2b4bc8be
2025-02-20 16:00:04 -08:00
Treehugger Robot
69c4f2dff0 Merge "Make ColorAndMotionFragment fully in Catalyst" into main 2025-02-20 12:39:07 -08:00
Riley Jones
e6b7908366 Merge "Revert "Left & Right buttons for Display size & text preview"" into main 2025-02-20 12:38:24 -08:00
Daniel Norman
b1691756e2 Revert "Left & Right buttons for Display size & text preview"
This reverts commit 30e63f6178.

Reason for revert: Can cause crash for some users?

Change-Id: I4b4e71157b668bbf4320a610ad14ddd10f2eade3
2025-02-20 11:26:35 -08:00
Yuhan Yang
0516a06a02 Add autoclick shortcut to a11y autoclick settings
Add a shortcut row that toggles floating icon and pops edit
shortcut type dialog.

Screencast:
 - autoclick indicator flag on:
   go/njiwntmwmjuwnzu2ote1mnw2m2nhmzflzi0znq
 - autoclick indicator flag off:
   go/screenshot-anpqrzv6ewplyjs

Bug: 397719419
Test: Manually verified on test devices
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I5f0b51adfaea5c3f8b077af07f34f61d78cb34ac
2025-02-20 18:19:23 +00:00
Yongshun Liu
67c5db13ff Merge "a11y: Clean up magnification mode controller and fix lint errors" into main 2025-02-18 17:28:49 -08:00
Yongshun Liu
b8ee801dfd a11y: Clean up magnification mode controller and fix lint errors
This cleans up the magnification mode controller and related code. It
also fixes most of the lint errors in the files.

NO_IFTTT=linter not working

Bug: b/388335935
Flag: EXEMPT refactor
Test: com.android.settings.accessibility.ToggleScreenMagnificationPreferenceFragmentTest & com.android.settings.accessibility.MagnificationModePreferenceControllerTest
Change-Id: I368128c3c71285a9511a7831e1d01232e7536d2f
2025-02-18 23:02:08 +00:00
Jack Yu
a38de2654d Cleaned up the flag enforce_telephony_feature_mapping_for_public_apis
Cleaned up the 24Q3 flag enforce_telephony_feature_mapping_for_public_apis

Test: Basic telephony functionality tests
Test: atest FrameworksTelephonyTests
Bug: 297989574
Flag: EXEMPT flag cleanup
Change-Id: Iefb9a02eebe06fb42a23d645e6be034c94508487
2025-02-18 13:32:36 -08:00
Menghan Li
972e7a320c Merge changes from topics "A11yFeedback", "AccessibilityFeedbackFeatureProvider" into main
* changes:
  feat(A11yFeedback): Pixel overlay to expose the feedback bucket ID
  feat(A11yFeedback): Add feedback entry for Accessibility page
  feat(A11yFeedback): Add FeedbackManager for Accessibility page
2025-02-16 19:45:09 -08:00
Chun-Ku Lin
0f84b652cc Make ColorAndMotionFragment fully in Catalyst
Bug: 392190782
Test: manual (verify the navigation and the search still works the same)
Test: atest
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion

Change-Id: I7717390c70246503aec545991fd9a40be5152373
2025-02-17 03:01:36 +00:00
Menghan Li
6b916e6f29 feat(A11yFeedback): Pixel overlay to expose the feedback bucket ID
This change introduces a feature provider for Pixel overlays, allowing
customization of the feedback bucket ID on Android.

Bug: 393980229
Test: Manual testing for Pixel and non-Pixel overlay in real device
Test: atest AccessibilitySettingsTest
            FeedbackManagerTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: Ieeb1dba4de5c13a275e66781621cbfcca7219a5e
2025-02-14 03:01:41 +00:00
Menghan Li
c86e2f3472 feat(A11yFeedback): Add feedback entry for Accessibility page
This entry point allows users to access in the action bar.
Visibility is controlled by the aconfig and FeedbackManager#isAvailable

Bug: 393981463
Test: atest AccessibilitySettingsTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I8c219b8220b5839121d14959fe526e6200afeecb
2025-02-14 03:01:13 +00:00
Daniel Norman
afb62eba9c Merge "Left & Right buttons for Display size & text preview" into main 2025-02-13 12:53:05 -08:00
Menghan Li
267251aae3 feat(A11yFeedback): Add FeedbackManager for Accessibility page
This change introduces a new FeedbackManager class to identify and
determine the availability of user feedback. This API will be used
to check if feedback is available for a user to provide.

Bug: 393980229
Test: atest FeedbackManagerTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I577aa626c18f5c449dc3970d1324cc4940d20639
2025-02-13 09:08:07 +00:00
Jason Hsu
29557d6017 Merge "Show intro and footer string according to the device's supported status" into main 2025-02-11 23:44:01 -08:00
Riley Jones
30e63f6178 Left & Right buttons for Display size & text preview
Test: manually open page and verify buttons work
Bug: 386906497
Flag: EXEMPT small internal change dependant on xml
Change-Id: I49ecf2940be897725a0864cf898655837a3e2399
2025-02-11 23:45:08 +00:00
Treehugger Robot
bc93bb60aa Merge "We no longer need to monitor the shortcut changes on this screen" into main 2025-02-11 11:31:56 -08:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
jasonwshsu
9cfc96d948 Show intro and footer string according to the device's supported status
Bug: 390078046
Bug: 386121967
Test: atest HearingAidHelperTest HearingDeviceFooterPreferenceControllerTest HearingDeviceIntroPreferenceControllerTest BluetoothDetailsHearingDeviceSettingsControllerTest
Flag: EXEMPT bugfix
Change-Id: I564cdb80cd14f4d2d8e882b64db939449c6936b7
Signed-off-by: Jie Wang <jie.x.wang@sony.com>
Signed-off-by: Jason Hsu <jasonwshsu@google.com>
2025-02-11 17:26:37 +08:00
Treehugger Robot
50e464f3da Merge "[Catalyst] Implement metrics/tags for Settings Catalyst" into main 2025-02-09 16:55:47 -08:00
Sunny Shao
5700104b92 [Catalyst] Implement metrics/tags for "Remove Animation"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I2891c31de419294324e8c7e17cd191a370cfa305
2025-02-08 08:57:30 +00:00
Sunny Shao
e9f0fdcd66 [Catalyst] Implement metrics/tags for Settings Catalyst
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: Ia879883c3f29cd7ac286b431680d66ab52e87db0
2025-02-08 08:37:35 +00:00
Yuhan Yang
c3f467dd71 Add summary for autoclick cursor size row
Screencast: go/screencast-njm3ndi4njm4ntixnzuznnw3nmy5m2fkms00ng

Bug: 390460480
Test: ToggleAutoclickCustomSeekbarControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I951be8da3e10f2a3ba0c6ff6e88a8a059db0f1ed
2025-02-07 21:06:12 +00:00
Yuhan Yang
7630d396a6 Add Autoclick cursor area size settings dialog
Replace Autoclick sliderbar with an alert dialog
and radio group to match the new UI requirement.

Screenshot:
 - Click area column:
   go/screenshot-5AfdF7FGghsdiXk
 - Alert dialog:
   go/screenshot-4dgtojcc6lvjtyy

Bug: 390460480
Test: ToggleAutoclickCustomSeekbarControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ic79f8833e69dde8d8eb3e945e5acd551d2ee9ff5
2025-02-07 19:58:53 +00:00
Treehugger Robot
b5299b17d9 Merge "fix(high contrast text): Uses a new string resource for the settings action." into main 2025-02-04 16:24:08 -08:00
Daniel Norman
f6b3ccd074 fix(high contrast text): Uses a new string resource for the settings action.
The old string has all non-English translations without format
placeholders, which will fail to build the string on those
languages until translations are added.

Bug: 384791485
Flag: com.android.graphics.hwui.flags.high_contrast_text_small_text_rect
Change-Id: I4565610908d463c05576d5c5d0b083f76802cc9e
2025-02-04 15:26:24 -08:00
Riley Jones
a1e47ef860 Merge "Update strings again for refreshed High Contrast Text" into main 2025-02-04 15:17:23 -08:00
Jean Chen
c1163a15d6 Merge "Increment TeX counters for the HCT migration about notification dismissed." into main 2025-02-03 22:44:09 -08:00
chenjean
2028e7b4b4 Increment TeX counters for the HCT migration about notification dismissed.
Bug: 391672253
Flag: com.android.graphics.hwui.flags.high_contrast_text_small_text_rect
Test: Ensure dismissing a notification from open settings does not trigger multiple counter increments
Change-Id: I6ddccd40427cf2364d3fb5df4efaa0b16db26133
2025-02-04 07:55:54 +08:00
Riley Jones
36d59c85b7 Merge "Adjust A11y Shortcut settings to use lowercase shortcut names." into main 2025-02-03 14:51:18 -08:00
Daniel Norman
6d0a04a171 Update strings again for refreshed High Contrast Text
Deletes the old string resource and uses a new resource because the old
translated strings do not have formatting placeholders. Eventually the
old translated strings will be automatically deleted and the new string
with placeholder will be translated.

Also uses placeholders for referencing other strings so that
we guarantee that the strings are consistent across this notification
and the actual preference in Settings.

Bug: 384791485
Test: see bug screenshots
Flag: com.android.graphics.hwui.flags.high_contrast_text_small_text_rect
Change-Id: I89a9ee4b3755b20f4e090df5b4cccb7ce47a961c
2025-02-03 20:00:09 +00:00
Daniel Norman
07af74a52e Adjust A11y Shortcut settings to use lowercase shortcut names.
Per go/android-naming these strings should be lowercase when
used in the middle of a sentence because they are generic
descriptive names and not branded names.

Bug: none
Change-Id: I0508a5cbdba20a1bd2d6db66e0e7183845e503ad
Test: build & install & check string
Flag: EXEMPT low risk bugfix
2025-01-31 16:10:44 -08:00
Fiona Campbell
fc94995307 Make Extra Dim Setting as percentage of device
- Extra dim setting now operates in percentage of the device's
  capabilities
- ie "100" now means the maximum possible dimming on the current device,
  if restored to another device, this means the max possible dimming on
  that device as well.

Bug: 337351445
Flag: EXEMPT bugfix
Test: atest DisplayServiceTests
Test: atest ReduceBrightColorsIntensityPreferenceControllerTest
Change-Id: I98d0d7af562fdfb2b921746e0e5654bad47b440b
2025-01-30 15:47:27 +00:00
Riley Jones
6e12194015 Merge "Disabling elements on the A11y Shortcut setting subpage" into main 2025-01-28 13:24:42 -08:00
Treehugger Robot
61e7f37b22 Merge "Unrestrict granted ECM setting for A11Y" into main 2025-01-24 18:12:10 -08:00
Chun-Ku Lin
f95b9b2623 We no longer need to monitor the shortcut changes on this screen
**Why remove the monitor?**
We started monitor the shortcut changes on this screen because we would
show the status of the shortcut as part of the summary of the
preference. However, the summary is too wordy, and we decided just show
the On/Off state of color correction/inversion. With that change, we
forgot to clean up unnecessaroy monitor on the shortcut status on this
screen.

Bug: 392190782
Test: manual
Flag: EXEMPT low risk clean up task
Change-Id: Iec6aca509c96237c4abb5c394ac5e7ffd78362eb
2025-01-25 01:33:00 +00:00
Riley Jones
94621548c1 Disabling elements on the A11y Shortcut setting subpage
Elements on the subpage get disabled if there are no enabled shortcut targets for the relevant type.
In the case of A11y button, the items on its fragment become unsearchable when the setting is disabled.

Test: Manually verify conditions described above & in bug
Bug: 349180207
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: Id39e2eda6c9d1de4cdbfcbc22b8a1f443e2822d9
2025-01-24 00:59:25 +00:00
Daniel Norman
7e6cc163d9 Merge "Includes new HCT-Migration-Notification entrypoint in a11y stats logs." into main 2025-01-23 10:08:58 -08:00
Nate Myren
bfedd95083 Unrestrict granted ECM setting for A11Y
Other RestrictedPreference users' behavior is kept the same, for now.

Bug: 390196024
Test: manual
Flag: EXEMPT: minor bugfix
Change-Id: I4efe26d254b44defc15778271d9ff6d7270ec443
2025-01-22 17:05:41 -08:00
Daniel Norman
f362378c03 Merge "Increment TeX counters for the HCT migration notification." into main 2025-01-22 15:55:12 -08:00