Commit Graph

1418 Commits

Author SHA1 Message Date
Angela Wang
4972c58783 New hearing device pairing page: ignore bonded device
The device might still in advertising mode even if it's bonded. We can
just ignore this kind of devices in the scanning result.

Bug: 307890347
Test: manual test
Change-Id: I782cc62edd4fec779f5f55444425b32a77f85e5e
2024-02-07 10:22:24 +00:00
Angela Wang
3ca9ef8edc New hearing device pairing page: check gatt status
Checks the gatt status in `onConnectionStateChange()` and `onServiceDiscovered()` callbacks. Disconnects and removes the gatt from the `mConnectingGattList` if the gatt status is not success in these callbacks.

Bug: 307890347
Test: manual test
Change-Id: Iab09f13b2ff3d33e5c4d6a8710736307c26b17e7
2024-02-07 08:54:41 +00:00
Ahmad Khalil
92fb442d09 Merge "Fix notification vibration demos in settings" into main 2024-02-01 13:59:24 +00:00
Ahmad Khalil
4504f0ace4 Fix notification vibration demos in settings
While in zen mode, notification vibrations are ignored. These vibrations will also be ignored when attempting to demo the vibration intensity in settings.

Adding FLAG_BYPASS_INTERRUPTION_POLICY to the attributes of the vibration preview, to allow it to bypass the interruption policy and demo the vibration intensity as expected.

Fix: 301319836
Test: N/A
Change-Id: I240a896ff8e9516388a0238882db07f9680a184a
2024-01-31 10:45:55 +00:00
Chun-Ku Lin
1d1b9e451f Move the default shortcut types in a separate utility method.
Bug: 322701168
Test: atest
Flag: N/A (Strict mechanical refactors, no behavior change)
Change-Id: I1beb36e5aeeec0f303228b57baf034a000a72b75
2024-01-29 02:17:49 +00:00
Chun-Ku Lin
f9ae13a73d Save the user preferred shortcut on Edit A11yShortcut screen
We saved the user preferred shortcut in the a11y feature's detail page.
Since now the Edit A11yShortcut screen is a standalone screen, we might
want to keep the existing behavior to update the user preferred shortcut
types when the edit screen is shown or when the shortcut settings are
updated.

Bug: 300302098
Test: atest
Test: manual
    - Go to an a11y feature page and open the Edit shortcut screen
    - Remove all selected shortcut option
    - Select volume key shortcut option, and deselect volume key
      shortcut option
    - Go to home page and close the Settings app
    - Go to the same a11y feature page and click on the shortcut toggle
    - Expect the volume key shortcut is turned on
Flag: ACONFIG
com.android.settings.accessibility.edit_shortcuts_in_full_screen
TRUNKFOOD

Change-Id: I2c92ec56d6e45317406f3a4b8ef8f076c398df7f
2024-01-28 00:21:31 +00:00
Riley Jones
317173b7cd Merge "Created a dedicated activity for EditShortcutsPreferenceFragment. This will allow it to be reached via intent." into main 2024-01-25 21:33:33 +00:00
Massimo Carli
4db2698714 Merge "Use custom default font_scale behing flag" into main 2024-01-25 18:06:13 +00:00
Massimo Carli
3770452077 Use custom default font_scale behing flag
When the flag is enabled, we read the default
font scale value from the device_font_scale
property in Settings.

Flag: ACONFIG com.android.window.flags.configurable_font_scale_default DEVELOPMENT
Bug: 316160749
Test: atest SettingsRoboTests:FontSizeDataTest

Change-Id: I03a5ee9a2bd364dca9c75b131832e5f9e868167a
2024-01-25 00:38:39 +00:00
Riley Jones
4e195505b9 Created a dedicated activity for EditShortcutsPreferenceFragment.
This will allow it to be reached via intent.

Test: Send an intent with the ACCESSIBILITY_SHORTCUT_SETTINGS action (make sure the "targets" fragment argument is populated with a string array of shortcut targets)
Flag: None (Change adds definitions but no new behavior)
Bug: 297583708
Change-Id: Ie0dd4918a4f38c04b781308f170b568af30bb238
2024-01-24 02:09:12 +00:00
Treehugger Robot
d9e66ea97b Merge "Wrap subManager creation with createForAllProfiles" into main 2024-01-22 22:45:24 +00:00
Ling Ma
3c633b0ec5 Wrap subManager creation with createForAllProfiles
Since U, a sub can be associated with a particular profile, and thus in V we enforce filtering on the caller and only show the subs that are associated with the caller.
However, in some cases the caller indeed needs to see all subs regardless of its association, e.g. sysUI. Therefore, a param isForAllProfile is added to indicate whether the caller intends to see all subs.

Bug: 296076674
Test: voice call + data browsing
Flag: ACONFIG com.android.internal.telephony.flags.enforce_subscription_user_filter
 DEVELOPMENT
Change-Id: I2980cb3a63ac296568d76c224987bff8a97fe2b2
2024-01-19 20:08:10 +00:00
Angela Wang
dc297afbe3 New hearing device pairing page: fix cannot re-connecting gatt issue
Should clear the `mConnectingGattList` when the gatts in the list are all disconnected in `OnStop()`. Otherwise, we can't re-connecting gatt for these devices after the page enter `onStart()` again.

Bug: 307890347
Test: manual test
Change-Id: I3b9fe05f894548887339011f5757c71e3a40eb5c
2024-01-18 06:52:59 +00:00
Angela Wang
3c71a5ff22 Merge changes from topic "ha-new-pairing" into main
* changes:
  New hearing device pairing page (2/2): MFi devices
  New hearing device pairing page (1/2)
2024-01-16 09:41:37 +00:00
Angela Wang
5cb00f6602 New hearing device pairing page (2/2): MFi devices
Some of the hearing aids support both ASHA + MFi, however, they only
advertise MFi service uuid in advertisement packets.

We can filter the devices with MFi uuid while scanning and then connect
gatt to discover the remote services before pairing to make sure if the
devices are compatible with Android or not. Only devices that support
ASHA/HAP will be shown.

Bug: 307890347
Test: atest HearingDevicePairingFragmentTest
Change-Id: Ie1f4eedddd4c43fad0fcbcd35f436dea5ab06925
2024-01-16 03:55:54 +00:00
Angela Wang
3e9f1ff659 New hearing device pairing page (1/2)
Rewrite a new hearing device pairing page with update UI for "See more
devices".

Bug: 307473972
Test: atest HearingDevicePairingFragmentTest
Test: flip the flag com.android.settings.flags.new_hearing_device_pairing_page && atest HearingAidPairingDialogFragmentTest AddDevicePreferenceControllerTest
Change-Id: Ic60601905e3d0d7d7c5b1ef9733652118a211f1d
2024-01-16 03:49:34 +00:00
Wilson Wu
55a7023af5 Add metrics for keyboard vibration settings
Log the state when keyboard vibration settings changed.

Bug: 289107579
Test: atest KeyboardVibrationTogglePreferenceControllerTest
Change-Id: I96999fe49a86514561c85c5b589a7b90e3c3cb67
2024-01-11 03:36:03 +00:00
Sunny Shao
bee65b4109 Merge "Revert^2 "Nullability Annotations replacement"" into main 2024-01-10 08:35:06 +00:00
Sunny Shao
076ed573eb Revert^2 "Nullability Annotations replacement"
This reverts commit 19d1d3d15d.

Reason for revert: revert it because this is not the root cause.

bug: 316867690
Change-Id: I0f168dbb64044aa720202af7b1040afd4f028c9c
2024-01-10 07:34:01 +00:00
Treehugger Robot
a5e48292a7 Merge "Implemented nested scrolling parent in TextReadingPreviewPager" into main 2024-01-09 01:16:08 +00:00
Chun-Ku Lin
ed3d2f9171 Implemented nested scrolling parent in TextReadingPreviewPager
Flag: N/A
Bug: 317947238
Test: manual

Change-Id: I173881b84d5c5ff81c15a80a4de65fda59f5bf65
2024-01-08 22:07:56 +00:00
joonhunshin
37d4fb736e Data only device(without FEATURE_TELEPHON_CALLING) : Add try/catch to handle UnsupportedOperationException
If the device does not have Telephony feature calling, the some of interfaces in TelephonyManager throw UnsupportedOperationException.

Bug: 297989574
Test: oriole with ATT SIM, boot completed
      APM/data/wifi on/off, browse setting menu
Change-Id: Ifa9092cd8d9a00039e9d93d5fd9fc4dabed633c8
2024-01-05 03:04:14 +00:00
Sunny Shao
946f52b2a1 Merge "Revert "Nullability Annotations replacement"" into main 2023-12-29 03:18:24 +00:00
Sunny Shao
19d1d3d15d Revert "Nullability Annotations replacement"
This reverts commit cf0501e4d7.

Reason for revert: b/317462033, it seems a flaky but revert it first.

Change-Id: Ie1d5e279cca6477fc17d8c27c1ecda8d7a6b2553
2023-12-29 02:28:24 +00:00
Yanting Yang
cf3f89d4fb Merge "Support search index for Accessibility button & gesture" into main 2023-12-22 09:34:11 +00:00
Yanting Yang
6c0f9e68d1 Support search index for Accessibility button & gesture
Bug: 223514494
Test: manual & atest AccessibilityButtonPreferenceControllerTest
Change-Id: I2433e5aaccd8eb92325141246d9b409bb2b97e08
2023-12-22 04:07:36 +00:00
sunnyshao
cf0501e4d7 Nullability Annotations replacement
-- Replace the android.annotation.Nullable / android.annotation.NonNull
   with androidx.annotation.Nullable / androidx.annotation.NonNull

Bug: 316867690
Test: build pass
Change-Id: I0c1da55dfb09ece855151c47e0492d6f46538621
2023-12-20 08:50:09 +08:00
Jason Hsu
cb9870b087 Merge "[HA Audio Output] Change category according to the audio definition" into main 2023-12-15 13:23:46 +00:00
Chun-Ku Lin
b4665e6714 Merge "Apply Setup styles to the a11y edit shortcut full screen." into main 2023-12-14 22:51:31 +00:00
Chun-Ku Lin
d92f17cdf5 Merge "Convert a11y shortcut edit screen to a full screen." into main 2023-12-14 22:19:08 +00:00
Chun-Ku Lin
9d6bf1b784 Apply Setup styles to the a11y edit shortcut full screen.
Bug: 300302098

Test: atest AccessibilitySetupWizardUtilsTest
Test: atest EditShortcutsPreferenceFragmentTest (Unable to make
Robolectric inflate the view of the edit shortcut fragment with the Setup wizard
theme)
Test: manual (Launch the setup wizard and check the screen)

Change-Id: I2995e914d622e9865101ef16e3b280c65371a252
2023-12-14 20:50:45 +00:00
Chun-Ku Lin
64e946c7fa Convert a11y shortcut edit screen to a full screen.
Bug: 300302098

Flag: adb shell device_config put accessibility com.android.settings.accessibility.edit_shortcuts_in_full_screen true

Test: manual
Test: atest com.android.settings.accessibility.shortcuts

Change-Id: I0b5e367fed962ff01036122ce7ff32a8ae47fbc3
2023-12-14 20:50:33 +00:00
Hani Kazmi
7580dac41b Merge "Update existing ECM settings to use new infrastructure" into main 2023-12-12 12:01:17 +00:00
Jean Chen
097d8a891b feat(MultiFingerMultiTap): Update shortcut string to double tap from triple tap
Bug: 315264770
Test: manual
Change-Id: I1130271d06bac71f23a137c83149ee3363a1cc0e
2023-12-08 10:12:43 +08:00
Hani Kazmi
ded1cd59c9 Update existing ECM settings to use new infrastructure
1. Update Notification Listener and A11y settings to call
   RestrictedLockUtilsInternal rather than checking appOp themselves

2. Rename ecm related methods to include Ecm rather than AppOp -
   implementation details are being moved to permissions module and may
   change.

Bug: 297372999
Test: Manually tested on device. Automaated tests to follow
Change-Id: Ie3e16b502993b21a7e34eab0d661f98814b3cfd5
2023-12-07 15:59:52 +00:00
Daniel Norman
0fa75c4e41 Merge "Adds a summary to the (screen) Magnification preference for the main A11y Settings page." into main 2023-12-06 20:22:28 +00:00
Daniel Norman
2edaf7668c Merge changes from topic "b-303511250-cleanup" into main
* changes:
  Use A11yManagerService to check if the A11yService warning is required.
  Minor refactoring to replace duplicated logic with existing methods.
2023-12-06 19:55:21 +00:00
Daniel Norman
01e624c76b Adds a summary to the (screen) Magnification preference for the main A11y Settings page.
This helps differentiate this from other magnification tools.

Reuses (and slightly modifies) the `magnification_feature_summary`
string which was not used by any existing code. This helps ensure
the existing localizations should be close enough, until L10n
translators have time to update based on the new shorter version.

Bug: 303499185
Test: ToggleScreenMagnificationPreferenceFragmentTest
Test: Open Settings > Accessibility, observe summary
Change-Id: If5ee4f937bbd655b425d4767ad8bbcef08dbe345
2023-12-06 01:10:52 +00:00
Tyler Freeman
3fddb64a0d Merge "feat(force invert): add force invert Settings preference in A11y > Color and Motion" into main 2023-12-05 20:36:36 +00:00
Tyler Freeman
e0f10d3fe2 feat(force invert): add force invert Settings preference in A11y > Color and Motion
Bug: 312289375
Test: atest packages/apps/Settings/tests/robotests/src/com/android/settings/accessibility/ColorAndMotionFragmentTest.java
  && atest packages/apps/Settings/tests/robotests/src/com/android/settings/accessibility/ToggleForceInvertPreferenceControllerTest.java
Flag: android.view.accessibility.Flags.forceInvertColor

Change-Id: I2739a1dfecbbddcd240a3113344987ade2b7c717
2023-12-04 14:12:43 -08:00
Daniel Norman
126de9691a Use A11yManagerService to check if the A11yService warning is required.
Bug: 303511250
Test: m RunSettingsRoboTests ROBOTEST_FILTER=ToggleAccessibilityServicePreferenceFragmentTest
Change-Id: Ibef748bd82ba166e377be0611df113ac09d052bc
2023-11-28 01:54:21 +00:00
Daniel Norman
9f6e77a094 Minor refactoring to replace duplicated logic with existing methods.
Bug: 303511250
Test: tested in child change in the topic
Change-Id: I0995ce5fc685257ba69f7e4aa733de74aeb1fde3
2023-11-28 00:07:17 +00:00
jasonwshsu
a9e89031b6 [HA Audio Output] Change category according to the audio definition
Root Cause: According to the audio definition, system sounds are UI touch sounds, unlock sounds, etc., so they are controlled by Media strategy.

Solution: Move system sounds, accessibility sounds, DTMF sounds into Media category. Notification category contains notification sounds only.

Bug: 293251163
Test: manual test
Change-Id: Ied3db95dacbd2c0985bdbfccec5575bb5988fc5b
2023-11-22 06:29:34 +00:00
Treehugger Robot
47a9ea6d33 Merge "Make Color inversion shortcut searchable" into main 2023-11-21 03:01:06 +00:00
Chun-Ku Lin
2d45bcccab Merge "Update strings for stopping accessibility services" into main 2023-11-20 19:46:25 +00:00
Chun-Ku Lin
698458c5cd Update strings for stopping accessibility services
Flag: EXEMPT
Flag exempt reason: low risk changes. Mostly text changes

Test: manual - turn on Talkback and turn off Talkback and see the dialog
Test: atest ToggleAccessibilityServicePreferenceFragmentTest
Bug: 286549065
Change-Id: I90869b5fca0500739f65d0b0ef3331cb728be685
2023-11-20 18:53:32 +00:00
Roy Chou
5d9571bcee Merge "fix(text preference): fix preview block ui broken in SUW" into main 2023-11-20 03:11:29 +00:00
Roy Chou
004238d7f8 fix(text preference): fix preview block ui broken in SUW
As previous cl ag/25185014 we increased the preview block horizontal padding when landscape mode. However, in setup wizard it uses GlifPreferenceLayout so the settings page only has half screen width when landscape mode, so the preview block ui is squished due to limited width. Also, setup wizard package has overlay the paddings to larger than our prevoius adjust. Therefore, we rollback the changes in accessibility_text_reading_preview.xml to get the default padding, then add checker to increase the paddings if needed at runtime.

Bug: 309590083
Test: manually
Test: atest TextReadingPreviewPreferenceTest
Test: atest TextReadingPreferenceFragmentForSetupWizardTest
Change-Id: Ib907f4182eed272b84a4ab6208ea2d8a89ba96c4
2023-11-20 03:10:33 +00:00
Mill Chen
0fa4b503d9 Make Color inversion shortcut searchable
The color inversion shortcut is not searchable because this preference
is dynamically created. In order to make it searchable, we should add
index raw data for this preference.

Fixes: 223514734
Test: manual test
1) Open Settings search
2) Search for shortcut
3) check that the search results have Color inversion shortcut

Change-Id: I354d0c0e63cc12bd5012d7f26a165278a40bcf2d
2023-11-19 15:34:13 +08:00
Chun-Ku Lin
0f2cc34230 Don't show quick settings tooltip if the user is in the Setup Wizard,
since the user can't access the Quick Settings Panel.

Bug: 294560581
Test: manual
- Turn on feature flag: adb shell device_config put accessibility com.android.settings.accessibility.remove_qs_tooltip_in_suw true
- Modify the font scale in SUW, verify the QS tooltip doesn't show up
- Modify the font scale after SUW, verify the QS tooltip shows up
Test: atest SettingsRoboTests:com.android.settings.accessibility

Change-Id: I1d1a4f8f70ea3e1d929952d5c273de1b4cd80503
2023-11-14 23:30:49 +00:00