Commit Graph

31557 Commits

Author SHA1 Message Date
Matías Hernández
7a1039fea4 Merge "Overhaul the message senders screen" into main 2024-08-02 12:43:31 +00:00
Allen Su
4bdb1dbcce Merge "Expand ToA language support" into main 2024-08-02 10:48:30 +00:00
Matías Hernández
a4c99767b7 Overhaul the message senders screen
* Fix combinations of messages=all with other conversation values.
* Correctly display policies with CONVERSATION_SENDERS_ANYONE. An additional checkbox is included, but _only_ if the policy has CONVERSATION_SENDERS_ANYONE when shown.
* Changed updateState() to consider the possible cases one by one. Because multiple policies are mapped to the same checkbox states, the strategy of "checking whether the state matches what the checkbox wants to set" doesn't really work.
* Fix messages summary and circles to support CONVERSATION_SENDERS_ANYONE.
* Added a lot of tests (actually, hopefully ALL OF THEM) covering the user-visible behavior. :)

Fixes: 354658240
Test: atest ZenModesSummaryHelperTest ZenModePrioritySendersPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I727496ca3eb820e4baaab942b61d2e57cdb491fc
2024-08-02 12:36:44 +02:00
josephpv
af87233e1e Show different error screen for PS creation based on error
This contains the change to show a different fragment on private space
creation error based on the error code returned by UserManager.
On private space create error checks for the returned error code and if
PS is not supported on the device showns error screen containing a link to Help
Center atricle to find out more about the reason for profile creation
failure.

ACTION_PRIVATE_SPACE_SETUP_SPACE_ERRORS metric is logged with the error
code on create error else 0 on sucessful space creation.

Recording: b/340130375#comment17

Bug: 340130375
Test: Manual
Flag: android.multiuser.show_different_creation_error_for_unsupported_devices
Change-Id: Ifa0345fb6aad64599009f8aa79d168f57fd35c03
2024-08-02 10:03:12 +00:00
Allen Su
a60a38dd39 Expand ToA language support
Flag: EXEMPT resource only update
Bug: 328697623
Test: manual
Change-Id: Icbc0c986508065a4daf15e9354e0aa4283315fa9
2024-08-02 09:37:45 +00:00
Yuri Lin
cb824ccbd9 Resize & round corners on a placeholder interstitial image
This isn't a real image yet (just draws a diagonal gradient), but should now be roughly ready for inserting the correct drawables based on the mode whenever those are available.

Bug: 332730534
Test: manual, SetupInterstitialActivityTest
Flag: android.app.modes_ui
Change-Id: I45a78950f671a989258a85525a7a8ee0c445a332
2024-08-01 18:44:27 -04:00
Yuri Lin
65548c0e56 Add interstitial for modes that are disabled but not by user
This covers both the case of navigating to the mode page through the mode aggregator menu as well as if an app sends an intent to go to the mode.

The interstitial visuals are not done yet; in particular, the image is just a gray box for now.

Manual tests done:
- visually verifying the interstitial page in both portrait and landscape
- accessing the mode page from modes list, confirming interstitial pops up
- accessing enabled and disabled-by-user mode page from modes list (no interstitial)
- getting to the mode page from intent through an app
- accessing enabled and disabled-by-user mode pages from app intent (no interstitial)
- adjusted display and font size (it looks bad with max display & font size, maybe not much to be done)

Bug: 332730534
Test: manual, ZenModeFragmentTest, SetupInterstitialActivityTest
Flag: android.app.modes_ui
Change-Id: I21f13b0842d5b118a341f7d85e8fcac947ca3a06
2024-08-01 18:44:22 -04:00
Chun-Ku Lin
5460a244be Don't truncate the title in Color Correction options
By default, the SelectorWithWidgetPreference hard coded the maxlines of
the title to be 2 lines. Updating the SelectorWithWidgetPreference to
accept changes on maxlines on title.

Set titleMaxLines as 2147483647 (Integer.MAX_VALUE) as there is no
alternative to clear the maxLines that are already set by the Preference

Bug: 356726764
Test: manually tested the color correction screen in Deutsch
Test: verify the Wifi Hotspot sceurity screen is not affected by this
change (still have 2 as the max lines of the title)
Flag: EXEMPT resource only

Change-Id: I1414b6212b75d3f28bef6aad50a31ea7861d5811
2024-08-01 22:33:11 +00:00
Abdelrahman Awadalla
f2d6fe9e32 Add "Touchpad visualizer" to input developer options
Bug: 286551975
Bug: 350039816
Test: atest TouchpadVisualizerPreferenceControllerTest
Test: Manual testing using
      $ adb shell settings get system touchpad_visualizer
Flag: com.android.hardware.input.touchpad_visualizer

Change-Id: Ic5de704c49aabf1a80d202aa890055f7337d45d4
2024-08-01 13:34:32 +00:00
Chaohui Wang
09fb13fd1c Merge "Settings search for Vo5G" into main 2024-08-01 07:19:08 +00:00
chelseahao
cd6f77d432 [Audiosharing] Change text color.
Bug: 356080864
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Test: atest
Change-Id: Id0882547343cb63149f8a9335b023e9f50649e07
2024-08-01 04:25:43 +00:00
Chun-Ku Lin
b656d7b2c4 Merge "Update color correction red-green options text" into main 2024-08-01 01:43:07 +00:00
Chun-Ku Lin
a5636c1cb9 Update color correction red-green options text
Bug: 354776203
Test: manually (see screenshots in the ticket)
Flag: EXEMPT resource only update
Change-Id: Iffda7f965e046ef5c6493ac5f9eb410e4db96790
2024-07-31 19:51:42 +00:00
Treehugger Robot
e79de39723 Merge "Revert^2 "Tweak Modes layouts and use updated strings to match mocks"" into main 2024-07-31 17:35:10 +00:00
Matías Hernández
4222bed264 Revert^2 "Tweak Modes layouts and use updated strings to match mocks"
This reverts commit 9804955ad5.

Reason for revert: Wrongly reverted; unrelated to the error

Change-Id: I94a2b05589fa80218db184e192f1c4a633ab61b0
2024-07-31 15:45:11 +00:00
ELIYAZ MOMIN
39a56459a5 Merge "Revert "Tweak Modes layouts and use updated strings to match mocks"" into main 2024-07-31 15:40:04 +00:00
Matías Hernández
ff2d85a6fe Merge "Add new icons to the Modes icon picker" into main 2024-07-31 15:06:19 +00:00
ELIYAZ MOMIN
9804955ad5 Revert "Tweak Modes layouts and use updated strings to match mocks"
This reverts commit 0359aaeb47.

Reason for revert: <Potential culprit for b/356564046  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Change-Id: I980838773078d822d20608e5975a26cf8dbed2be
2024-07-31 14:56:30 +00:00
Matías Hernández
0b7a22210a Add new icons to the Modes icon picker
Bug: 333901673
Test: atest IconOptionsProviderImplTest
Flag: android.app.modes_ui
Change-Id: I6fa15fa12238eb9c0d1b93803010349b9092812b
2024-07-31 14:12:37 +02:00
Edgar Wang
790fad6df0 Merge "Use SwitchPreferenceCompat instead of SwitchPreference" into main 2024-07-31 12:10:21 +00:00
Chaohui Wang
874c818b31 Settings search for Vo5G
Also adding keywords support to MobileNetworkSettingsSearchItem.

Fix: 262684662
Flag: EXEMPT bug fix
Test: manual - search vo5g
Change-Id: Ic73b76a2a7b2ef238b167fe3673835298d8939fd
2024-07-31 17:47:21 +08:00
Chaohui Wang
b7f68b4a60 Merge changes from topic "MobileNetworkSettingsSearchIndex" into main
* changes:
  Fix search for MMS Message
  Show category when search "Mobile data"
2024-07-31 09:07:20 +00:00
Matías Hernández
fa494a6d46 Merge "Tweak Modes layouts and use updated strings to match mocks" into main 2024-07-31 07:34:43 +00:00
Edgar Wang
83e43b6e98 Use SwitchPreferenceCompat instead of SwitchPreference
Bug: 356105969
Change-Id: I0770313b9ee560298ea1d2b8938f511c4b36d7d1
Test: manual
Flag: EXEMPT bug fix
2024-07-31 03:03:17 +00:00
Joshua Mccloskey
a2b127bbe8 Merge "Remove face/fignerprint search if not present" into main 2024-07-30 23:02:58 +00:00
Bill Yi
796d9b65b1 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-30 20:51:59 +00:00
Joshua McCloskey
ed59922ca8 Remove face/fignerprint search if not present
Test: Verified manually with a device that if face/fingerprint are not
present they do not show up.
Fixes: 350599580
Flag: EXEMPT bugfix

Change-Id: I6a691d2985e4839336e9c08dfa6c97abe23f43f2
2024-07-30 18:14:41 +00:00
Matías Hernández
0359aaeb47 Tweak Modes layouts and use updated strings to match mocks
Bug: 333682392
Test: mostly manual, also ZenModeTriggerUpdatePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I5bae828a55128f3cb0b07ea0ff21ca196e7564dc
2024-07-30 17:45:38 +00:00
Haijie Hong
2e12b95c45 Merge "Add multi-toggle preference UI for device details page" into main 2024-07-30 09:25:12 +00:00
Chaohui Wang
7009c008f9 Fix search for MMS Message
Also display multiple results when there are multiple MMS Message on
different SIMs.

When doing indexing, we not also log sub id as part of the key.
When user clicks the result, using SpaSearchLandingActivity to do the
redirection, set arguments to the fragment.

Fix: 352245817
Flag: EXEMPT bug fix
Test: manual - search mms
Test: unit test
Change-Id: Id47a1151cb418c18f68f97e3be33dcd21c5f5102
2024-07-30 11:34:24 +08:00
Haijie Hong
cc2114a797 Add multi-toggle preference UI for device details page
BUG: 343317785
Test: atest DeviceSettingRepositoryTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I67e7647fee39e789cc1342943f69e7ddc170d0eb
2024-07-30 10:59:27 +08:00
Bill Yi
0db37a4d5b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I879f0ef0f2c7cb82d851352cf7a75fcbecc5bdc4
2024-07-29 15:18:54 -07:00
Matías Hernández
a463b0af7b Fix a11y issues in the schedule editor
* Don't read start / end time as separate labels.
* Fix content description of day buttons (ToggleButton's stateDescription is textOn/textOff -- which are the same for this particular button, thus it wasn't possible to know whether a day was selected or not).

Fixes: 346396147
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: If73a791cf9bd62cf17e058c81a8051b3e7fd82ea
2024-07-29 18:11:34 +00:00
Alina Zaidi
441a202444 Merge "[dev_option] Update 'Desktop mode on secondary toggle' to be 'Freeform windows on secondary diplay'." into main 2024-07-29 17:49:54 +00:00
Treehugger Robot
8c6cb9a011 Merge "Add setting illustration to notification cooldown" into main 2024-07-27 00:01:09 +00:00
Treehugger Robot
28ce355bf8 Merge "Remove unused resources since A11yServiceWarning is moved to framework" into main 2024-07-26 23:16:09 +00:00
Matías Hernández
e19b8743c8 Merge changes from topic "fix-weird-animation" into main
* changes:
  Fix jiggle when opening custom manual modes
  Allow turning off currently active modes
2024-07-26 20:58:15 +00:00
Chun-Ku Lin
b5e4a01553 Remove unused resources since A11yServiceWarning is moved to framework
Bug: 303511250
Flag: EXEMPT pure cleanup
Test: Build succeed
Test: atest com.android.settings.accessibility
Change-Id: Ic1813b4489be617c006426056abae3876c77a727
2024-07-26 17:56:32 +00:00
Chun-Ku Lin
75db151f96 Merge "[Flag cleanup] edit_shortcuts_in_full_screen is always on now" into main 2024-07-26 17:46:52 +00:00
Matías Hernández
e8306014f0 Fix jiggle when opening custom manual modes
Looks like setting Preference visibility in updateState() is too late to avoid an animation, and isAvailable() should be used instead. This forces us to split ZenModeSetTriggerLinkPreferenceController (which handled the category and its two children) into separate controllers for the category and each child. Although untangling this code was annoying, the result is arguably cleaner, since the two child preferences deal with different things.

Fixes: 355623101
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I5fb1b3cbe424973b852f820ecf948491c050421f
2024-07-26 17:44:53 +00:00
Matías Hernández
a847a03a17 Merge "Add icons for segments in Mode page and (some) subpages" into main 2024-07-26 14:16:33 +00:00
Alina Zaidi
e85695f88c [dev_option] Update 'Desktop mode on secondary toggle' to be
'Freeform windows on secondary diplay'.

Make sure the toggles enables freeform support on devices. This remove
reliance on 'Enable freeform windows suppport' toggle when using this
toggle.

Also update strings for all toggles to just use term 'freeform windows'
instead of 'desktop mode' or 'freeform windowing experiences'.

Two toggles have the same name 'enable freeform windows', but users will
see only one of them at a time.

Test: Added new tests
Bug: 348193756
Bug: 348186127
Flag: EXEMPT minor change
Change-Id: Ic4528618e6902d084c58a6b5ddeb4b92d63386d6
2024-07-26 13:33:23 +00:00
Edgar Wang
74fa4310c8 Merge "Fix Talkback focus on random position when launch Settings homepage" into main 2024-07-26 11:54:50 +00:00
Matías Hernández
6da822d228 Add icons for segments in Mode page and (some) subpages
Fixes: 341996820
Test: manual (only visual changes)
Flag: android.app.modes_ui
Change-Id: I8b8b1cb7cfe610da60b34b32b479b3ffd79a2ac7
2024-07-26 13:50:49 +02:00
Chelsea Hao
3e285680b3 Merge "Change text color for better contrast" into main 2024-07-26 06:46:59 +00:00
Edgar Wang
ec31852c7b Fix Talkback focus on random position when launch Settings homepage
- set default focus on Search

Bug: 350887106
Test: manual
Flag: com.android.settings.flags.homepage_revamp
Change-Id: Iae1f57fd573d9657bbe3c5397c86d35f9ceaf5b0
2024-07-26 06:30:48 +00:00
Yining Liu
a8eda25cca Add setting illustration to notification cooldown
Add setting illustration to notification cooldown (also known
as adaptive notification, notification avalanche).

Fix: 354048938
Flag: com.android.server.notification.polite_notifications
Test: Manual, Settings - Notifications - Notification cooldown
try with both light and dark mode

Change-Id: If8f5d22116f90d151a285dee6423d82e0edea638
2024-07-25 23:30:24 +00:00
Chun-Ku Lin
919019ca56 [Flag cleanup] edit_shortcuts_in_full_screen is always on now
- Cleaned up the code that won't be executed when the flag is on
- Remove unused resources

Bug: 300302098
Test: Manually verify the user can change the shortcut type, and the
changes are saved
Test: atest com.android.settings.accessibility
Flag: EXEMPT removing com.android.settings.accessibility.edit_shortcuts_in_full_screen

Change-Id: I1e32b724ca3da909feda55e20fb1d51dc4680c09
2024-07-25 22:49:02 +00:00
Matías Hernández
246960de0c Update top of modes page
* Show blurb based on mode type.
* Make the icon bigger and highlight it when mode is active.
* Increase spacing between elements.

Also eliminate some code duplication between header of mode page and header of icon picker.

Fixes: 355415875
Test: manual
Flag: android.app.modes_ui
Change-Id: I7e788b9b5920cedb791d1571b19b37e65ece6d0b
2024-07-25 21:28:27 +02:00
Yiyi Shen
e980a145eb Merge "[Audiosharing] Use a11y compliant color for dialog buttons" into main 2024-07-25 10:21:37 +00:00