Commit Graph

7 Commits

Author SHA1 Message Date
Olivier Nshimiye
5e4fad8a4a Prompt user to set device lock before deleting private space from Reset options
New flow: http://shortn/_qLrrqpdfJc

Flag: EXEMPT Bugfix in a low risk scenario
Bug: 363050220
Test: atest ResetOptionsDeletePrivateSpaceControllerTest
Change-Id: I93f55cd94ed2f42d5c19e2686d3edb3920bf750d
2024-09-10 09:06:32 +00:00
josephpv
58050a6f56 Update string in Delete private space dialog
Screenshot : go/ss/BuyAQZLToiv3z3K.png

Bug: 335454847
Test: Manual
Change-Id: I95c8472f494793212d10d8968017780b3739c294
2024-04-18 20:06:51 +00:00
josephpv
4e32375f3d Use canAddPrivateProfile() to enable PS delete from Reset
This change adds canAddPrivateProfile() check to enable/disable
Private space delete controller in Reset options.

Matches the availability to delete private space from reset
options with the conditions used to show the private space entry point.

In Settings Reset options preference to delete private space will be
shown only when private space creation is allowed on the device or if
private space already exists on the device.

Bug: 330396315
Test: ResetOptionsDeletePrivateSpaceControllerTest
Change-Id: I63232556f7927aeb07b73e8732bbb8b1d2423456
2024-04-03 20:39:12 +00:00
josephpv
4cc915ad64 Change icon for Private Space unlocked and setup success toast
Change is made to show customised icon in Toast message shown by using
Toast.makeCustomToastWithIcon()

Screenshots :
go/ss/AcaRQUJQfh79wDw.png
go/ss/5j4oD8xydwX7HTX.png

Bug: 329391204
Bug: 309575523
Test: Manual
Change-Id: I336d7d0419b1de60024e584e943a725662b446a9
2024-03-25 16:53:46 +00:00
josephpv
43c8d3a3f8 Add a preference in reset options to delete private space
This takses care to add an entry point in Settings->System->Reset
options->Delete private space when private space feature is supported on
the device. Entry point appears both when private space exists and also
when private is not created.
On selecting asks for user authentication and on successful
authentication using device lock shows a dialog asking for
confirmation and calls for deletion private space.

Based on this entrypoint it would not be possible to guess if private
space exists on the device.

Recording link : b/329041740#comment3

Bug: 329041740
Test: atest ResetOptionsDeletePrivateSpaceControllerTest and verified
this doesn't give away existence of private space

Change-Id: I9a5b908e7a3f9edaf609cf7e6a87f9842d689ce6
2024-03-21 21:54:52 +00:00
Olivier Nshimiye
0f3799cbad Add an additional flag guard for Private Space implementation
This a layer of flag guarding only for the implementation of Private Space features excluding the APIs. The MVP flag allow_private_profile still guards all the features including the APIs.

Bug: 326060689
Test: Manual - a few verifications that some feeatures are unavailable when this flag is disabled
Test: Run presubmits and verify that nothing breaks
Change-Id: I05f7e2f20c6132b33484bb133ce03a933ece485f
2024-03-04 15:43:24 +00:00
josephpv
e1a2c82db3 Add Private space Delete settings page inside PS settings page
Contains implementation of settings page for Delete private space
controller inside private space settings page.
- On selecting to delete private space displays list of account signed in
to private profile and deletes the private space after authentication.
- Shows a toast message after private space is deleted

- Adds dependency for setupdesgin loading layout to show a loading
  screen while deletion of private space is in progress.

Recording Link : b/318383729
go/ss/4Aq3rmbSGHMHesK.png

Bug: 318383729
Test: atest DeletePrivateSpaceControllerTest

Change-Id: Ia1730915e2469b47823c507f9ef6cd8f63c99baf
2024-01-31 19:29:13 +00:00