Commit Graph

436 Commits

Author SHA1 Message Date
Randy Pfohl
25b8a583bd Remove demo button from animation and move to gesture navigation settings fragment
Flag: NONE N/A

Test: Built and tested flow, video in bug

Bug: 399034564

Change-Id: I9c8386e2d4236ab4f686daff49e0cd088ad5e126
2025-02-28 16:47:36 +00:00
Jacky Wang
041bc113eb Remove MainSwitchPreference.updateStatus
NO_IFTTT=Update API

Bug: 391092187
Flag: EXEMPT library
Test: atest&manual
Change-Id: I6e31857d8ca7084c737fd69f63b33f6a58cf3022
2025-01-21 07:44:43 +08:00
Riley Jones
9e890a93f8 Cleanup qs shortcut flag in OneHandedSettingsUtils
Test: atest OneHandedSettingsUtilsTest
Bug: 367414968
Flag: EXEMPT flag cleanup
Change-Id: Ic906bd025ea9df7c5b083899608be4e1324ae317
2025-01-14 01:29:00 +00:00
Lorenzo Lucena Maguire
0e64487bc3 Support Double Tap Power to open camera via config resource
"Quickly open camera" screen was previously replaced by the "Double
Tap Power Button" screen and accessible only if the
feature flag
android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap
was disabled.

This CL introduces the possibility to set, via a config resource, "Quickly open camera" as the double tap power
gesture screen.

Test: atest DoubleTapPowerSettingsTest
Test: atest DoubleTapPowerPreferenceControllerTest
Test: atest DoubleTapPowerSettingsUtilsTest
Test: manually modified config and verified screen and gesture behavior
change
Flag: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap
Bug: 384794943
Change-Id: I5ab4422da09fa90848c66a41829327494080b5a2

Change-Id: I8e04cac3999a7ed99a611ef084c54bc07a5505dc
2025-01-07 03:59:59 +00:00
Riley Jones
f337bf1fad Cleaning up deprecated QS tooltip code
Flag is rolled out, so tooltips other than font size shouldn't show anymore.
Much code can be removed.

Flag: EXEMPT code cleanup
Test: atest com.android.settings.accessibility
Bug: 367414968
Change-Id: I55084982fee0d0537aade49d36f52e121e24574b
2024-12-10 21:20:15 +00:00
Lorenzo Lucena Maguire
18d0d26395 Create Double Tap Power Illustrations based on target action
Creates illustration for when double tap power gesture is set to open
wallet and preference controller to alternate illustration based on gesture
target action

Android Settings Feature Request: b/380287172

Test: atest DoubleTapPowerIllustrationPreferenceControllerTest
Test: manually verified illustration corresponds to selected target
action
Bug: 381789181
FLAG: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap

Change-Id: Id73a38e09bd72856d46d74f04c0c0d2b3f989929
2024-12-03 23:44:22 +00:00
Lorenzo Lucena Maguire
d3af193384 Support wallet launch in Double Tap Power Gesture Settings
Modify Double Tap Power Gesture Settings screen to be able to set the
gesture to launch the wallet.

If the feature flag is disabled, the
Double Tap Power Gesture Settings screen defaults to the current
screen ("Quickly open camera"), which only provides the option to open the camera upon detecting the
gesture.

If the feature flag is enabled, the Double Tap Power Gesture Settings
screen defaults to the new "Double Tap Power Button" screen, which
provides the option to open the camera, the wallet, or neither upon
detecting the gesture.

Android Settings Feature Request: b/380287172

Bug: 378131008
Test: manual tested screen alternates based on feature flag
Test: atest DoubleTapPowerSettingsTest
Test: atest DoubleTapPowerPreferenceControllerTest
Test: atest DoubleTapPowerToOpenCameraPreferenceControllerTest
FLAG: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap

Change-Id: I1fc05ab3cfee2e86a80a1756655c368aae16747c
2024-12-03 23:44:22 +00:00
Lorenzo Lucena Maguire
406a01dfab Rename Double Tap Power To Open Camera Gesture Xml
Rename double_tap_power_settings.xml to
double_tap_power_to_open_camera_settings.xml

Android Settings Feature Request: b/380287172

Bug: 381554683
Test: atest DoubleTapPowerSettingsTest
Flag: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap
Change-Id: I6ff3c0384602a5f0eeeafcc560e7854af8480f99
2024-12-03 23:44:22 +00:00
Lorenzo Lucena Maguire
75536b091f Refactor DoubleTapPowerPreferenceController
DoubleTapPreferenceController was previously used as the controller for
the "Quickly open camera" entry in the "System > Gestures"  screen and as the controller for
the toggle in the ["System > Gestures > Quickly open camera" screen.

This CL separates the DoubleTapPowerPreferenceController into two new
controllers to handle each case:
- Double Tap Power Preference Controller to control the "Quickly open camera" entry
- Double Tap Power To Open Camera Preference Controller to control the
  gesture's enable/disable toggle.

Android Settings Feature Request: b/380287172

Bug: 381499912
Test: atest DoubleTapPowerPreferenceControllerTest
Test: atest DoubleTapPowerToOpenCameraPreferenceControllerTest
FLAG: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap
Change-Id: I73fc7d97e1e330163858a60a4ba9a63bd9b5574f
2024-12-03 23:44:22 +00:00
Lorenzo Lucena Maguire
235556daeb Create Double Tap Power For Wallet Launch Preference Controller
Create preference controller for radio button to select wallet launch as
target action for Double Tap Power Button gesture.

Android Settings Feature Request: b/380287172

Bug: 379308160
Test: atest DoubleTapPowerForWalletLaunchPreferenceControllerTest
FLAG: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap
Change-Id: Ib1629996401ea88aeec2831a55fdc9f2ad9dcd5e
2024-12-03 23:44:22 +00:00
Lorenzo Lucena Maguire
7e6e2b81c2 Create Double Tap Power Gesture For Camera Preference Controller
Create Preference controller to select camera launch as a target action
for the Double Tap Power Button gesture.

Android Settings Feature Request: b/380287172

Bug: 379309894
Test: atest DoubleTapPowerForCameraLaunchPreferenceControllerTest
FLAG: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap
Change-Id: I3b6b90177293066b04f9f4eb0139f8ac3b3812b0
2024-12-03 23:44:22 +00:00
Lorenzo Lucena Maguire
260f37f849 Create Double Tap Power Gesture Main Switch Preference Controller
Create Preference controller for main switch to enable/disable double
tap power gesture

Android Settings Feature Request: b/380287172

Bug: 378131071
Test: atest DoubleTapPowerMainSwitchPreferenceControllerTest
FLAG: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap
Change-Id: I6205805768d917521b7d9c8ff074678ef5c36a46
2024-12-03 23:44:22 +00:00
Lorenzo Lucena Maguire
c09909489f Create DoubleTapPowerSettingsUtils
Create Utils class to store common methods used by Preference
controllers

Android Settings Feature Request: b/380287172

Bug: 378130789
Test: atest DoubleTapPowerSettingsUtilsTest
FLAG: android.service.quickaccesswallet.launch_wallet_option_on_power_double_tap
Change-Id: I0bd47579bd3c8163e2e48ac572577c72f2aab785
2024-12-03 23:44:22 +00:00
Daniel Norman
5ddd74b917 Fix Settings Search for OneHandedSettings
- Marks top header preference as non-searchable
- Makes shortcut preference searchable

Fix: 353591062
Test: manually confirm above behaviors
Test: atest OneHandedSettingsTest
Flag: com.android.settings.accessibility.fix_a11y_settings_search
Change-Id: I3355f817358cec1d265b89d75229ffc2742efe1c
2024-11-11 00:39:08 +00:00
Riley Jones
be18186757 Merge "Removes the A11y tutorial that displays on change to gesture navigation" into main 2024-10-21 17:59:10 +00:00
Riley Jones
c850dfac26 Removes the A11y tutorial that displays on change to gesture navigation
Switching to gesture navigation puts button mode in FAB,
so there's no longer a need to show a gesture tutorial.

Test: change navigation modes. Verify no tutorial is shown for either option
Flag: android.provider.a11y_standalone_gesture_enabled
Bug: 371027085
Change-Id: I71e33efea3e25d22b0bc41c33b17de11f9ef2d64
2024-10-16 18:58:35 +00:00
Andy Wickham
9f9571a078 Move Contextual Search setting to AOSP.
This only appears if the correpsonding system feature is enabled.

Bug: 353715553
Test: Manual
Flag: EXEMPT moving code from vendor to aosp
Change-Id: Ib19db6345b907500dfe3d53c36700df428c0171e
2024-10-09 18:32:21 +00:00
Daniel Norman
1890c16f90 Populates collection info count for A11y toggle feature pages.
This helps an accessibility service like TalkBack inform the user that
there are items that are skipped when navigating the list because they
are unimportant to accessibility.

Bug: 318607873
Test: atest AccessibilityFragmentUtilsTest
Test: atest ToggleScreenMagnificationPreferenceFragmentTest
Test: Enable TalkBack that supports the collection info count feature,
      open any of the pages from the bug, observe the item count and
      (un)important count are correct.
Flag: com.android.settings.accessibility.toggle_feature_fragment_collection_info
Change-Id: If64c89f2eb2f8301076baa79b9530124c850d2fc
2024-08-27 23:36:19 +00:00
Chun-Ku Lin
3aeabcc2c2 Replace ShortcutType with UserShortcutType to reduce duplicate
declaration.

Bug: 323686675
Test: atest
Flag: N/A. Not able to flag the refactor
Change-Id: If1fbe4236bc53f76f5e1af783932c469fc4c6838
2024-03-30 02:41:30 +00:00
Jason Chiu
1908551cc2 Merge "[Safer intents] System" into main 2024-03-27 02:02:26 +00:00
Chun-Ku Lin
4c9d268fdf Rename AccessibilityGestureNavigationTutorial to AccessibilityShortcutsTutorial
AccessibilityGestureNavigationTutorial is not only for displaying
tutorial for accessibility gesture shortcut. It's used for display the
tutorials for all the selected accessibility shortcuts. Renamed the
class to match it's responsibility.

Bug: N/A
Flag: EXEMPT Strict mechanical refactors
Test: build succeed locally

Change-Id: I1dd212abc660454e77f18f770c2ecc17be320eaa
2024-03-26 01:13:28 +00:00
Jason Chiu
d89fd5942f [Safer intents] System
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: Iaf5466f3acd3293e738f450e0117e180b93d4e1c
2024-03-25 18:08:03 +08:00
Andy Wickham
cc10abe1c2 Merge "Allows for system navigation settings to be added dynamically." into main 2024-03-20 03:00:10 +00:00
Andy Wickham
07109c158a Allows for system navigation settings to be added dynamically.
This allows for controller-backed preferences to be added or
overridden via xml.

Similarly, if the controllers cause all of the preferences for
2 or 3 button nav to be unavailable, we hide the settings button.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: I2371f3173076172489966728ac69c8767570cd56
2024-03-14 20:07:33 +00:00
Randy Pfohl
ea76c296d3 Setting content description when illustration is clickable
Test: Built and tested with other cls in topic and verified talkback works properly.

Flag: None

Bug: 319747547

Change-Id: I37cbcc9bc4c830c73913cdad0734a874bd0eac7c
2024-03-13 21:11:30 +00:00
Chun-Ku Lin
deba8599d8 Reflect QS shortcut changes in a11y pages.
Bug: 314843909

Test: manual (modify qs tiles in QS panel while the a11y page is open,
verify the a11y page reflect the qs changes)
Test: atest com.android.settings.accessibility
Test: atest com.android.settings.accessibility.shortcuts

Flag: ACONFIG android.view.accessibility.a11y_qs_shortcut

Change-Id: Ie5b46459faab902912a214ca131eb5d0b105a7ef
2024-03-12 01:32:00 +00:00
Daniel Norman
6c229865c9 Revert "Replace ShortcutType with UserShortcutType to reduce dup..."
Revert submission 25959129-chunkulin-replace-shortcutTypeConstant

Reason for revert: Reverting refactoring, to land after 24Q2 branches off of main. See b/323463488

Reverted changes: /q/submissionid:25959129-chunkulin-replace-shortcutTypeConstant

Change-Id: I323637727f4b642b3a6c626eae62bdaf0032eaf2
2024-02-03 00:23:15 +00:00
Chun-Ku Lin
c2d7daf645 Replace ShortcutType with UserShortcutType to reduce duplicate
declaration.

Bug: 317424693
Test: atest
Flag: N/A. Not able to flag the refactor
Change-Id: I20aea442cb08f047f98422176058acf4b344d2f1
2024-01-20 05:40:52 +00:00
Sunny Shao
076ed573eb Revert^2 "Nullability Annotations replacement"
This reverts commit 19d1d3d15d.

Reason for revert: revert it because this is not the root cause.

bug: 316867690
Change-Id: I0f168dbb64044aa720202af7b1040afd4f028c9c
2024-01-10 07:34:01 +00:00
Sunny Shao
19d1d3d15d Revert "Nullability Annotations replacement"
This reverts commit cf0501e4d7.

Reason for revert: b/317462033, it seems a flaky but revert it first.

Change-Id: Ie1d5e279cca6477fc17d8c27c1ecda8d7a6b2553
2023-12-29 02:28:24 +00:00
sunnyshao
cf0501e4d7 Nullability Annotations replacement
-- Replace the android.annotation.Nullable / android.annotation.NonNull
   with androidx.annotation.Nullable / androidx.annotation.NonNull

Bug: 316867690
Test: build pass
Change-Id: I0c1da55dfb09ece855151c47e0492d6f46538621
2023-12-20 08:50:09 +08:00
Chaohui Wang
08a1c9876e Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"
8979681a8d

Change-Id: I60edd3aabf49afbe4aa016af780baa68d928bddf
2023-11-07 14:17:15 +00:00
Sebastian Pickl
8979681a8d Revert "Migrate to CompoundButton.OnCheckedChangeListener"
Revert submission 25147565-onSwitchChanged-CompoundButton

Reason for revert: breaking builds 

Bug:309601476

Reverted changes: /q/submissionid:25147565-onSwitchChanged-CompoundButton

Change-Id: Ie746db87d9c642599593aa3d5e5baf6b7ba89c0e
2023-11-07 13:26:36 +00:00
Chaohui Wang
71d1f021af Migrate to CompoundButton.OnCheckedChangeListener
Switch and SwitchCompat are both CompoundButton.

Using CompoundButton in Java will helps migration in the future.

Bug: 306658427
Test: manual - check Settings pages
Change-Id: If2e08a9a9557ec66a3b31ef18cd2e15943098a59
2023-11-07 20:22:27 +08:00
Mill Chen
7e31ff431a Clean up the global action panel
The global actions panel has been renamed to power menu and there is a
new preference for power menu. The legacy perference for global actions
panel is unused. This CL is to remove the preference controller from
Settings.

Bug: 289967656
Test: manual test and robotest
Change-Id: If820f3fa8a188223703ebc6bc68120164108f483
2023-09-27 09:30:27 +08:00
Holly Jiuyu Sun
c2aa51aeae Merge "Update Gesture navigation page to support search." into udc-qpr-dev am: ef6ac74a15 am: 694c9db7f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24452189

Change-Id: I96ee86cee34f30f9f9cb734ba0adc39edf9100f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-23 19:28:17 +00:00
Holly Sun
e23520d520 Update Gesture navigation page to support search.
Make function public to be reused in SettingsGoogle. Add feature flag.

Bug: 294858168
Test: manual
Change-Id: I3c3ba6144303f21ae4f6da3a64e0208ab23a7382
2023-08-22 16:13:36 +00:00
Chaohui Wang
8e2ae547d6 Clean up FeatureFactory.getFeature()
Bug: 286764889
Test: m Settings
Change-Id: I7e472e6b0ca6b7a735c1b92742ddf06c545176fc
2023-08-08 08:41:48 +00:00
Kohsuke Yatoh
5e3cbc3fa6 Merge "Add @SearchIndexable to OneHandedSettings fragment" into main 2023-08-08 04:53:45 +00:00
Kohsuke Yatoh
dd376906de Add @SearchIndexable to OneHandedSettings fragment
Bug: 245267643
Fix: 245267643
Test: Queried "one-handed" and verified "Use one-handed mode" shows up
Change-Id: If752ed3827a9ea86b594c3e4ba5746567e4e43ee
2023-08-07 02:33:16 +00:00
Riley Jones
b4bfea5c54 Expanded accessibility search terms
Items with new keywords:
-Accessibility
-Accessibility Menu
-Autoclick
-Live Caption
-Hearing Aids/Devices
-3-button navigation
-Touch & Hold
-Accessibility Timeout

Bug: 278091482
Test: Build SettingsGoogle, change your system language a few times, then check that the search bar responds to the new terms
Change-Id: Iddaf4f378b63f13141c1c52fbb4daa20f90a5ff8
2023-08-02 17:56:06 +00:00
Chaohui Wang
99457e53a8 Clean up assist gesture from Settings
This one is replaced by "Press & hold power button".

Bug: 287566056
Test: m Settings
Change-Id: Ic9fe8ab29a0b72f1a47f05b18da99ccf68a7f766
2023-06-29 18:17:10 +08:00
Chaohui Wang
16cb921c47 Remove setAssistOnly() from GestureSettings
Fix issue that use(AssistGestureSettingsPreferenceController.class)
could be null.

Bug: 287566056
Test: manually - on System > Gestures page
Change-Id: Ifb78a787c34e2fd0e255a6473b8c514f2788f52e
2023-06-27 16:08:25 +08:00
Chaohui Wang
2e4141e4ab Clean up AwareFeatureProvider from Settings
Bug: 287566056
Test: m Settings
Change-Id: I7f7f57809c55bf8824b427f0d4a232cacdbe88a7
2023-06-25 16:52:34 +08:00
Randy Pfohl
f572cc569e Ensure we launch gesture tutorial as new task
test: built for two pane device and verified it opens full screen
bug: 278918583
Change-Id: Icee33cb4a931e3037eab8e0146eddca55a5fd09d
2023-04-21 16:53:04 +00:00
Pfohl
b094ed8e7d adding new animation to be used when gesture tutorial package is available
test: built and verified animation shows up and is clickable to gesture tutorial menu on handheld devices

bug:248342586
Change-Id: I29a68accf67c4efc6b94058c2702f106edfec0a8
2023-04-07 18:20:15 +00:00
Lifu Tang
caa1b51ef2 Revert "Remove duplicate strings."
Revert submission 19748582-settings_yesno

Reason for revert: Common strings in English could be translated into different strings in other languages.

Reverted changes: /q/submissionid:19748582-settings_yesno

Bug: 272603842
Test: build and open Settings app
Test: atest SettingsRoboTests
Change-Id: Iaad301c5513478fb95e40987ea3ccb4f923d71fa
2023-03-15 22:39:24 +00:00
Edgar Wang
0fd7e6e3e7 Merge "Update lottie illustration for tablet" into tm-qpr-dev am: b5215abde7 am: 366ed57197
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154459

Change-Id: I7ba454aa3a58ec6c8f848ac5d09ea2385fdb3a33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 23:06:50 +00:00
Edgar Wang
2f5f6d4ee6 Update lottie illustration for tablet
Bug: 243889662
Bug: 243889643
Test: visual
Change-Id: Icac10e4401da3d704350aef6ef2723ff92ca34f8
2023-02-01 07:27:18 +00:00
jasonwshsu
ad6351d614 [Hearing device shortcut] Setup shortcut for hearing device
* Hearing aids page need to set restricted mode to DISALLOW_CONFIG_BLUETOOTH, so change AccessibilityShortcutPreferenceFragment to extend RestrictedDashboardFragment
* move ShortcutPreference under the device control category for the 1st order

Bug: 237625815
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityShortcutPreferenceFragmentTest
Change-Id: I13da8d979694aeab76d8a10edf1348c0ee7810f6
2022-12-28 02:35:53 +08:00