Commit Graph

586 Commits

Author SHA1 Message Date
Sparik Hayrapetyan
37c371b1bb Change the message for sequential characters in a password
Change the error message for sequential characters in the password when
the password quality requirement is NUMERIC_COMPLEX or higher. The error
message stays the same in case of PIN.

Screenshots from local testing:
- http://screen/po62FX6aGKoRCU7
- http://screen/BXU6mcJEHMoU4TR
- http://screen/BhCzSDdY83WCQeH

Bug: 299044500
Test: Tested locally, see screenshots
Flag: EXEMPT simple change to an error message

Change-Id: I2e96fef6b5f9a11013fbaa8e231bddc7fa45867f
2024-09-18 11:30:13 +02:00
Treehugger Robot
540ce288ad Merge "(3/N) Biometric error dialog" into main 2024-09-18 00:20:40 +00:00
Diya Bera
8444136cd3 Merge "(1/N) Biometric error dialog" into main 2024-09-17 23:57:50 +00:00
Diya Bera
fc711494b9 (3/N) Biometric error dialog
Add an error dialog to help user recover from biometric error for
for identity check for enrollment, changing LSKF and accessing
biometrics settings

Flag: android.hardware.biometrics.flag.mandatory_biometrics
Bug: 358641110
Bug: 358179610
Test: Manual
Change-Id: Iaf1986d3c1892b6158808bc3ded96145f410dc62
2024-09-17 20:25:01 +00:00
Diya Bera
5335e26b29 (1/N) Biometric error dialog
Add an error dialog to help user recover from biometric error for
identity check feature

Flags: android.hardware.biometrics.flag.mandatory_biometrics
Fixes: 358641110
Fixes: 358179610
Test: atest DevelopmentSettingsDashboardFragmentTest

Change-Id: I6099bc57672b945fa4fa4de98be35bd097403b22
2024-09-17 14:45:51 +00:00
Chun-Wei Wang
32cf2e3a11 Merge "Support alternate button" into main am: 88bbe8fe1d am: 6eccd73996
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3244020

Change-Id: Ia2853f58135f975bf0f6dd687efee52e622eac8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-09 14:34:57 +00:00
Chun-Wei Wang
88bbe8fe1d Merge "Support alternate button" into main 2024-09-09 14:18:11 +00:00
Pavel Grafov
95efbfa8bb Clean up fully rolled out HeadlessSingleUserFixes
Flag was rolled out in Android V.

Bug: 335663055
Test: TH
Flag: EXEMPT flag cleanup
Change-Id: Iaccd1c594f588b40f46e653b83e257f90b048bf4
2024-09-02 16:44:04 +01:00
Priyanka Advani (xWF)
eff79d3365 Revert "Clean up fully rolled out HeadlessSingleUserFixes"
Revert submission 28993807-hdop-cleaup

Reason for revert: Droidmonitor created revert due to b/363275535. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:28993807-hdop-cleaup

Change-Id: I89127e1c6e445adb21dbf96c6bbbec8935bf6296
2024-08-30 19:04:56 +00:00
Pavel Grafov
93c566ef5b Clean up fully rolled out HeadlessSingleUserFixes
Flag was rolled out in Android V.

Bug: 335663055
Test: TH
Flag: EXEMPT flag cleanup
Change-Id: I7de1f400d03662b690f4a77a379994985797a3fe
2024-08-29 17:04:36 +01:00
Chun-Wei Wang
31ebeb690e Support alternate button
Align the behavior of frp and repair to have them
support the alternate button.

Bug: 339735656
Test: presubmit
Change-Id: Ib785db5ef16a68df4980dee451c6b638692adc5f
2024-08-27 10:16:11 +08:00
Treehugger Robot
b3d4b76c69 Merge "Add mandatory biometric prompt to platform surfaces (5/N)" into main 2024-08-15 01:11:42 +00:00
Diya Bera
92ea474b86 Add mandatory biometric prompt to platform surfaces (5/N)
1. For biometric settings, request biometric prompt only after
   successful credential verification and no auth request after
   enrollment

2. Differentiate between mandatory biometrics ineffective error and
   other biometric errors

Flag: android.hardware.biometrics.flags.mandatory_biometrics
Bug: 358176202
Bug: 358179610
Test: atest UtilsTest DevelopmentSettingsDashboardFragmentTest MainClearTest BuildNumberPreferenceControllerTest CombinedBiometricProfileSettingsTest
Change-Id: I778dd5403dd5ab64d8cc39bd88b22c4d39182e94
2024-08-13 04:21:37 +00:00
Hao Dong
f56a1bccba Merge "Set component name only for ConfirmDeviceCredentialActivity." into main 2024-08-10 04:44:08 +00:00
Hao Dong
3d357eedb8 Set component name only for ConfirmDeviceCredentialActivity.
1. Rename setComponentNameForConfirmDeviceCredentialActivity() to
   setRealCallerForConfirmDeviceCredentialActivity()
2. Move the call from BiometricFragment to
   ConfirmDeviceCredentialActivity.

Flag: EXEMPT bugfix
Bug: 339532378
Test: manual test
Change-Id: I762f280def79d428ed9cf119ace5ccc2b6be2560
2024-08-09 11:51:03 -07:00
Joshua Mccloskey
dbbcdd6ebe Merge "Make choose lock screen consistent" into main 2024-08-09 17:16:04 +00:00
Diya Bera
58e3822485 Merge "Do not call credential if authenticators does not allow" into main 2024-08-08 16:37:50 +00:00
Diya Bera
572541c3ab Do not call credential if authenticators does not allow
Flag: android.hardware.biometrics.flags.mandatory_biometrics
Test: N/A
Fixes: 358180327
Change-Id: I236fbcc84502602e6e6fb02615f002e02136202e
2024-08-08 01:50:14 +00:00
Treehugger Robot
1a8c84dfb3 Merge "Fixed remote validation shows SetupRedaction" into main 2024-08-07 17:54:27 +00:00
Joshua McCloskey
1c40c534ba Fixed remote validation shows SetupRedaction
Test: atest ConfirmLockPasswordTest ConfirmLockPatternTest
Fixes:353187344
Flag: EXEMPT bugfix
Change-Id: I03dff2bf27f7134f5372b85901f2866727f9d534
2024-08-07 16:28:45 +00:00
Jason Chang
58bc2e3dca Fix the option to set a different screen lock in the "Set a PIN"
screen is displayed off the screen when the device language is set
to Arabic

To call optButton's MarginLayoutParams setMarginStart() instead of
set leftMargin.

Flag: EXEMPT bugfix

Bug: 355422248

Test: build Forrest ROM and verify the UI
Change-Id: I700b83937ecd8509864fa3c80826de0ba0437ca2
2024-08-05 08:55:10 +00:00
Joshua McCloskey
42e46e0105 Make choose lock screen consistent
Bug: 237347124
Test: CTS Verifier > Security > Set New word Complexity
Flag: EXEMPT bugfix
Change-Id: I9437dbd00c435a9f7712db48d783032583e8d090
2024-07-31 18:12:22 +00:00
Diya Bera
31ec11f0b6 Hide background when identity check auth is requested
Flag: android.hardware.biometrics.flags.mandatory_biometrics
Fixes: 354014097
Test: atest UtilsTest
Change-Id: I3af06fd9dca2bdc306496f1db832e1d1e2bfe8d2
2024-07-25 17:00:05 +00:00
Diya Bera
9bae71c15c Add mandatory biometric prompt to platform surfaces (3/N)
Pass user ids for identity check. This is to make sure that the right
user is requested auth for different profiles.

Flag: android.hardware.biometrics.Flags.MANDATORY_BIOMETRICS
Bug: 339910718
Test: atest UtilsTest
Change-Id: I953b56e9bfd1edd49d080124905d42a23247b7a7
2024-07-23 04:07:08 +00:00
Joshua Mccloskey
ac8ba2ae08 Merge "Show disabled summary for CDC" into main 2024-07-22 17:27:02 +00:00
Joshua Mccloskey
2004df98f1 Merge "Too short error message on CDC is no longer red." into main 2024-07-19 21:38:01 +00:00
Joshua McCloskey
9ce9cb2833 Show disabled summary for CDC
When the admin disabled a pin/pattern/pass, the summary should now
reflect this.

Test: N/A
Fixes: 343213209
Flag: EXEMPT bugfix
Change-Id: I87e6fbefd014e2623948abbf82b452208e8ef58e
2024-07-18 21:28:27 +00:00
Joshua McCloskey
d11b1dc739 Too short error message on CDC is no longer red.
Test: atest ChooseLockPasswordTest
Fixes: 325097409
Flag: none
Change-Id: I09f910eeb28d117f6a5008d64b8d3eb5a1731800
2024-07-17 17:00:29 +00:00
Diya Bera
2348fefd48 Tests - Add mandatory biometric prompt to platform surfaces (1/N)
Tests for ag/27400418

Flag: android.hardware.biometrics.Flags.MANDATORY_BIOMETRICS
Bug: 339910718
Test: atest FingerprintSettingsFragmentTest ChooseLockGenericTest CombinedBiometricProfileSettingsTest

Change-Id: Ief7fca5d0b695d23d490b6302dea11bab6030fce
2024-07-15 22:26:50 +00:00
Treehugger Robot
78beeb1d30 Merge "Gray out admin-disabled screenlock option properly" into main 2024-07-05 01:31:34 +00:00
Rubin Xu
935cea2ca7 Gray out admin-disabled screenlock option properly
Fix an issue where some sceenlock options are disabled
by admins but not showing up as grayed out.

Bug: 288081292
Flag: EXEMPT bug fix
Test: manually with `am start  -a android.app.action.SET_NEW_PASSWORD
  --ez isSetupFlow true --ei android.app.extra.PASSWORD_COMPLEXITY 327680`
Change-Id: I4aab61a052bc2c5146f44d0bfcd8153e3f2cee92
2024-07-03 10:55:47 +00:00
Diya Bera
049de84f2d Add mandatory biometric prompt to platform surfaces (1/N)
1. Face settings
2. Fingerprint settings
3. Change device credential

Flag: android.hardware.biometrics.Flags.MANDATORY_BIOMETRICS
Bug: 339910718
Test: atest UtilsTest

Change-Id: I69778d1733ea9fb312e7c26ae0fa23b6008dde5d
2024-07-01 21:35:19 +00:00
Hao Dong
facbd33839 Fix res not found in ConfirmDeviceCredentialActivity
Bug: 346447223
Test: atest RepairModeUnitTests
Change-Id: I3267c046b0e9eebdd2d0505cd5f2bc04c67c1bd0
2024-06-11 03:54:50 +00:00
Hao Dong
96537caa6d Update to use PromptInfo.setLogo()
Bug: 341697368
Test: Manually verified on the device
Change-Id: Ie350ef4551367ce65b065f38e924f8ff93d16021
2024-06-07 21:41:12 +00:00
Olivier Nshimiye
14d4b41363 Update the biometric unlock logo to Private Space logo
All activities that use biometric login through the CDCA class show a
Settings icon in the prompt. This cl adds a capability for the client of
the CDCA to set icon and icon description as extras to the unlock
intent.

Screenshot: http://shortn/_OpKTYFtddM

Bug: 333528540
Test: Manually verified on the device

Change-Id: Id7b5a3fe575069bef1810769e4f437e717d2d3c6
2024-06-05 10:36:25 +00:00
Jigar Thakkar
176f1a630a Do not request confirmation by default for private space unlocks
Fix face unlock confirmation button behavior to respect "always
require confirmation" setting. Adjust the description of the
confirmation toggle in private space face unlock settings to
reflect this change.
Screenshot: https://screenshot.googleplex.com/4uHfm9Z3ZE56ZaT.png

Bug: 342383195
Test: Tested manually by flashing local build
Change-Id: I0f742839a862fe66cacad9f5704dbe8b0df3a0c2
2024-05-28 17:59:17 +00:00
Xin Li
f0e00b8bf7 Merge Android 24Q2 Release (ab/11526283) to aosp-main-future
Bug: 337098550
Merged-In: I96574a79eba581db95d387f0d9c9fde2e004c41c
Change-Id: Ib9f2c742f8aa72651ef9eca80a716dd94b9041ea
2024-05-23 14:12:07 -07:00
Treehugger Robot
ae230aa12c Merge "Fixed issue with pattern not appearing disabled." into main 2024-05-17 04:38:45 +00:00
Joshua McCloskey
ee5ddeda6f Fixed issue with pattern not appearing disabled.
Test: Verified that the pattern option now appears disabled when
setting up COPE profile
Fixes 288081292

Change-Id: I43992dc4518a47a41e58e7b9cfd47fb22542e749
2024-05-16 19:13:24 +00:00
Hao Dong
76b3bc8a20 Merge "Override package name for logo in ConfirmDeviceCredentialActivity." into main 2024-05-14 01:18:03 +00:00
David Liu
ae68cfca44 Merge "Set noparent to avoid it recursively looks up. Android biometric team should approve all change in this subdirectories." into main am: 7220a11daf am: aa9702134d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3080723

Change-Id: Ia7c3895dd1f4baef3b64c26fa0fa2e46af333c49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 17:29:32 +00:00
Hao Dong
3b9c3cf530 Override package name for logo in ConfirmDeviceCredentialActivity.
Test: TODO
Flag: ACONFIG android.hardware.biometrics.custom_biometric_prompt NEXTFOOD
Bug: 337082634

Change-Id: If0c4851c8c0cb0fae01e9f30d6a6486f2ab2c71f
2024-05-13 15:31:20 +00:00
David Liu
836e14e665 Set noparent to avoid it recursively looks up. Android biometric team should approve all change in this subdirectories.
Change-Id: Ib5bdc23660cc18af0f57ffdec1dbf582db734a43
2024-05-09 22:15:14 +00:00
Oli Thompson
fb08a80955 Correctly unlock storage for work profiles with unified challenge
When turning off quiet mode for work profiles, ACTION_CONFIRM_DEVICE_CREDENTIAL_WITH_USER is fired
to confirm the device/profile PIN in order to decrypt the profile's storage. For work profiles with
unified challenge, we are expected to call LockPatternUtils.verifyTiedProfileChallenge() that
specifically decrypts the work profile's storage using the device PIN. This code flow is only reachable
when mForceVerifyPath is true in ConfirmDeviceCredentialActivity. In
I8b61e7d2df5792cbdb2e12b19e5a5582ea2290b7 a regression was introduced that caused the wong condition
to be used, and as a result work profile with unified challenge is no longer unlocked correctly in
this unlock flow. This bug is normally masked since we cache the unified work profile's password and
don't ask the user for device PINs most of the time. It's only reproducible when turning on work
profile from the keyguard, when we don't use the password cache. Fix this by using the right condition.



Bug: 328640625
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.password
Change-Id: I5eb9379dc140c9803f033beee38fcd63aa9a85c0
2024-04-29 11:13:05 +00:00
Kholoud Mohamed
85c38bc078 Fix incorrect password attempts messaging on headless
Bug: 257276847
Test: manual
Flag: ACONFIG android.app.admin.flags.headless_single_user_fixes DISABLED
Change-Id: I2fb70d99203228ce4ee36f84eb4dfed36fa6fd8c
2024-04-19 12:49:31 +00:00
josephpv
e1acfb3db1 Show customized message for private space while choosing lock
The change adds private profile checks in addition to the exisiting
managed profile check to show customized message while choosing lock for
private profile in Pattern, PIN and Password screens.

Bug: 311343571
Test: Verify lock screen message for private space
Change-Id: Ic8173ff8c1af23fc593390acaff4c67390f99b9c
Merged-In: Ic8173ff8c1af23fc593390acaff4c67390f99b9c
2024-04-02 23:12:43 +00:00
Jigar Thakkar
eb612580d8 Use allowPrivateProfile to guard BiometricFragment changes
The BiometricPrompt API setAllowBackgroundAuthentication is
now guarded by allowPrivateProfile flag. This change ensures the
references to this API are flagged by the same flag, and the uber
private space implementation flag - enablePrivateSpaceFeatures, as
well.

Bug: 312184187
Test: Tested by flashing changes on a test device
Flag: Flags.ALLOW_PRIVATE_PROFILE
Change-Id: Icfdc5a2c2f07177c25fa3d545837052209b76551
2024-03-26 16:02:33 +00:00
Joseph Vincent
6ec3ac32a5 Merge "To skip face enrollment for PS unlock setup based on intent extra" into main 2024-03-19 13:28:10 +00:00
josephpv
f9bc323633 To skip face enrollment for PS unlock setup based on intent extra
For private space lock setup as part of both PS setup and separate lock
form private space settings we need to show only traditional unlock
factors and Fingerprint but not show Face enrolment even on devices
where Face unlock is supported by hardware.
Once LSKF is enrolled it should be followed by Fingerprint enrollment
flow and after that Face enrollment should not be shown and exit lock
setup flow.

Currently for separate profile lock setup ACTION_SET_NEW_PASSWORD intent
is used in private space setup.
With this intent the options of LSKF+fingerprint+Face is shown in
devices supporting both fingerprint and face hardware. After the LSKF
ennrollment BiometricEnrollActivity is started which continues with
fingerprint and Face enrollment.

With this change we are passing an extra along with the intent to enroll
fingerprint only. Based on the intent extra value if set even if hardware
support exists the lock enrollment for the profile will support only
LSKF and fingerprint enrollment but not start Face enrollment.

User will still have the option to enroll Face from the dedicated settings
entrypoint in private space settings.

Recording link : b/323839067#comment4

Bug: 323839067
Test: Manual, verified option for face enrollment is shown or not shown
based on the intent extra. When extra is not passed the behaviour will be
default.

Change-Id: Idf92084052e02df9ca89f288c618796750e563e6
2024-03-19 11:58:08 +00:00
Eran Messeri
47973b88ac Auth-bound keys usability: Update strings
Update the strings for the warning shown to the user when they are about
to remove their screen lock and there are authentication-bound keys
that would be invalidated.

These strings are provided by Android UXW.

Additionally, apply the new string to all types of device lock screen:
Pattern, password and unknown.

Bug: 302109605
Test: Manual, flashed a device and added different types of screen lock.
Change-Id: Ida6f5f16c5aa1671f3f2c1358160b8173a1d1407
2024-03-15 14:55:51 +00:00