Commit Graph

1269 Commits

Author SHA1 Message Date
Lei Yu
b47b99ed38 Add null check when restart batteryinfo loader
Even though we unregister contentObserver in onPause and register
in onResume, callback still be called while fragment is detached.

Anyhow add a null check in settings to stop crash

Fixes: 131905853
Test: RunSettingsRoboTests
Change-Id: I8c0c2c04c3b8d942e0c97cf71a7d3e735a24b467
2019-05-08 11:12:55 -07:00
TreeHugger Robot
d8accd6b6a Merge "Update Battery Saver schedule to add order to seekbar" into qt-dev 2019-05-03 23:56:22 +00:00
Salvador Martinez
bd6045bea9 Update Battery Saver schedule to add order to seekbar
If the first time battery saver warning was the one causing
a change in settings global the radio button picker doesn't update
the preferences correctly and would put the seekbar at the top. This
explicitly adds an order to the seekbar so that if it gets updated
for some reason it will show up at the end again.

Test: atest BatterySaverScheduleSettingsTest
Bug: 131434758
Change-Id: Iebab5d176c8fbdaea078e13a71eff7e21408353b
2019-05-03 10:01:34 -07:00
Salvador Martinez
b056b7dec4 Update battery saver footer to have learn more link
This will allow tapping on the Learn More text to take a user to
the support page for battery saver.

Bug: 129010739
Test: atest BatterySaverSettingsTest
Change-Id: Ifb758ea8c608a4051c093b5d1d43f9a039ab1294
2019-05-02 13:08:52 -07:00
Lei Yu
aa625bd06e Fix a crash in battery settings page
Regression from ag/7161923, in this case we should use onResume/onPause
pair. Also sort the method to fit android lifecycle.

Bug: 131615524
Test: RunSettingsRoboTests
Change-Id: I299032bfeb119dac293039917c6673dd4c0ef4e0
2019-04-29 15:43:57 -07:00
Bookatz
6656609549 TODO about BatteryStats.STATS_SINCE deprecation
Test: None. Just a comment.
Change-Id: Ib60034998e1d4a374934842f6f86c04a13760d12
2019-04-29 14:23:31 -07:00
Lei Yu
30991963e4 Merge "Update color filter for battery saver mode" into qt-dev 2019-04-25 21:42:56 +00:00
Lei Yu
eba850e8d9 Update color filter for battery saver mode
Fixes: 129498556
Test: Manual
Change-Id: I57809c77e488b9828bea50d4c4f410d49912cd4b
2019-04-24 13:47:39 -07:00
Salvador Martinez
415f35b670 Update BatteryUtils to update system battery estimate cache
To try and ensure SysUI and Settings don't show different battery
estimates we have settings always push the estimate to the system
cache which will cause the status bar to update as well.

Test: manually trigger battery broadcasts and observe
Bug: 124030091
Change-Id: I07a17ecf2a42c3022673ad2aca438f8d6e81b41f
2019-04-24 10:35:41 -07:00
TreeHugger Robot
fc48118694 Merge "Fix battery robo test" into qt-dev 2019-04-19 23:13:51 +00:00
Lei Yu
2632f45010 Fix battery robo test
Fixes: 130896701
Test: RunSettingsRoboTests
Change-Id: Iffb7874250335db81181b23f96fe7b50a2dd0062
2019-04-19 13:41:22 -07:00
Salvador Martinez
6a81e41c7c Update battery stuff to use SettingsLib Estimate class
This will make the upcoming consistency Cl easier to implement.

Test: Robotests still pass
Bug: 124030091
Change-Id: Ief4989e2b5f9b83b5c3b93d17f9f9fa12136f3ee
2019-04-19 17:35:23 +00:00
TreeHugger Robot
77c56714ed Merge "Tint battery fix icon" into qt-dev 2019-04-16 16:25:34 +00:00
Raff Tsai
006582b48e Tint battery fix icon
Fixes: 129492004
Test: manual
Change-Id: I161284619bc47e342d78f1507ae291f7c23ad3ff
2019-04-16 17:05:52 +08:00
Lei Yu
9515a685e3 Merge "Hide app usage time in high usage dialog" into qt-dev 2019-04-15 17:54:39 +00:00
Lei Yu
2f90dd784f Hide app usage time in high usage dialog
Also update strings a little bit

Bug: 112285389
Test: Manual
Change-Id: I5c4f3e2de635eb0b880d2d3d5a1550e1af41d931
2019-04-12 22:39:44 +00:00
TreeHugger Robot
4f988c8b29 Merge "Turn off LAYER_TYPE_SOFTWARE on BatteryMeterView" into qt-dev 2019-04-11 19:54:32 +00:00
Evan Laird
3e98ff34d0 Turn off LAYER_TYPE_SOFTWARE on BatteryMeterView
ThemedBatteryDrawable will no longer need it due to drawing more
betterer

Test: battery should look the same
Bug: 129014647
Change-Id: I6706cec2b3c3bfbdc0e0456c58191bc7152783e7
2019-04-11 10:52:14 -04:00
Salvador Martinez
a42fe30fc7 Merge "Update BS warning to follow through on action" into qt-dev 2019-04-10 22:46:10 +00:00
Sean Stout
560b8b8a44 Merge "Add android.settings.VIEW_ADVANCED_POWER_USAGE_DETAIL" into qt-dev 2019-04-10 22:02:41 +00:00
Sean Stout
6441723a31 Add android.settings.VIEW_ADVANCED_POWER_USAGE_DETAIL
This intent action opens the advanced power usage details screen for
a provided application.

Test: adb shell am start -a \
"android.settings.VIEW_ADVANCED_POWER_USAGE_DETAIL" -d \
"package:com.google.android.deskclock" --ez \
"request_ignore_background_restriction" 1
Bug: 129901520

Test: None
Bug: 129901520
Change-Id: Ib19228111c71ef1cfb5888f859a7efcf92a01754
2019-04-09 13:43:28 -07:00
Salvador Martinez
de28bc08f6 Update BS warning to follow through on action
The BS warning only had support for following through when a user
wanted to toggle battery saver. This also makes it so that if
the warning is shown for routines it will finish whatever action
it interrupted once confirmed.

Test: robotests pass, manual verification
Bug: 129696128
Change-Id: I2c34ed678b19d95f3c7d1094ab8f79cc0c23252e
2019-04-09 12:50:11 -07:00
Amin Shaikh
95aeb373fd Fix battery color tint issue.
Added test to verify fix.

Bug: 128354921
Test: m RunSettingsRoboTests
Change-Id: I24cbb966e549eec783912e4e118c00425b971ad0
2019-04-05 23:52:59 +00:00
Lei Yu
e323b40f4e Merge changes Ib80d68d6,I0d57d5b2 into qt-dev
* changes:
  Init PowerWhitelistbackend to stop crash
  Create gitignore for Settings
2019-04-05 17:11:34 +00:00
Amin Shaikh
7b7d6888a2 Add Settings icons needed for theme overlaying.
- Refactor battery icons to remove private attributes to allow them to
be overlayed
- Add drawable icon in settings for back arrow
- Update a few GM2 icons

Bug: 128354921
Test: make; open Settings
Change-Id: I84151a4e7d787381b6c51f02bb45ce5f15fa37a2
2019-04-05 07:54:07 -04:00
Lei Yu
033fe6eec0 Init PowerWhitelistbackend to stop crash
Also update text to "unavailable" to reflect its current status.

Fixes: 129955147
Test: Manual
Change-Id: Ib80d68d6d2b6bc4ced4a72483859e675b7e7e61c
2019-04-04 13:44:45 -07:00
TreeHugger Robot
db1c8a5fed Merge "Update battery saver schedule to show warning" 2019-03-28 04:04:03 +00:00
Salvador Martinez
c4d86b081b Update battery saver schedule to show warning
If a user tries to enable a battery saver schedule we want
to show them the battery saver warning if they haven't seen it.
This CL does that.

Test: robotests pass, manual verification
Bug: 128924009
Change-Id: I683279716ac7700043b1a01f88bdf2ae716eeece
2019-03-27 17:40:23 -07:00
TreeHugger Robot
dedeb2bd18 Merge "Update icons to use tint and vectors" 2019-03-27 02:45:40 +00:00
Salvador Martinez
bd677df009 Update icons to use tint and vectors
A bunch of icons were using PNGs which didn't allow their color
to change when in dark mode. This CL simply adds vector drawables
for all the PNGs and sets the tint to the correct color where needed.

Test: visual inspection, robotests pass
Bug: 126199274
Change-Id: I372d94e374173ab0572dacb03674a40fa14cffb9
2019-03-26 17:41:24 -07:00
Salvador Martinez
d12d722099 Flip the preference for sticky battery saver
Instead of toggled on being to keep battery saver on, the UX
writers would like to make toggled on be turn battery saver off
automatically. Also turns the controller into a
TogglePreferenceController, because those exist apparently.

Test: visual inspection, tests pass
Fixes: 126938839
Change-Id: Iffac536d0b1956d4534ca1b5fa5c6440c4d3a3ff
2019-03-26 11:29:18 -07:00
Salvador Martinez
7fb560af4f Rename battery saver schedule mode apis
The APIs that back these settings got renamed so this CL just
refactors all the calls to use the new names.

Test: robotests still pass
Bug: 126944845
Change-Id: I2975c7c79998823058db2c0ced2e5cf02216a106
2019-03-22 10:02:51 -07:00
Lei Yu
24c3c577c8 Merge "Don't close db for singleton db manager" 2019-03-20 22:15:56 +00:00
jackqdyulei
da7b0d44bc Don't close db for singleton db manager
To fix db bug and application will close it finally.

Bug: 128924561
Test: Build
Change-Id: I172882825612f1d317ae4b634bc4d5899338bed8
2019-03-20 11:02:04 -07:00
Salvador Martinez
cbd35ab0d5 Fix sticky battery saver toggle
It was persisting to settings secure instead of settings global.

Test: robotests pass
Bug: 128929858
Change-Id: I8c5bcc875d71096e70f1a70ec84e85d46c3abe43
2019-03-19 15:20:51 -07:00
TreeHugger Robot
28ad28d4be Merge "Revert "Revert "Change battery tip text""" 2019-03-08 19:15:24 +00:00
Salvador Martinez
790d4a3bd7 Merge "Create preference to allow user to toggle sticky battery saver" 2019-03-08 17:17:25 +00:00
Raff Tsai
deda67b7bf Revert "Revert "Change battery tip text""
This reverts commit 39beb2533f.

Reason for revert: <start to implement>

Fixes: 121042353
Test: adb shell settings put global battery_tip_constants test_low_battery_tip=true
      Then go to Settings -> battery to see the text

Change-Id: I83cc187d5bfda5312410e91ee636373f305ef449
2019-03-09 00:14:29 +08:00
Raff Tsai
476b9050e8 Merge "Revert "Change battery tip text"" 2019-03-08 08:54:34 +00:00
Raff Tsai
39beb2533f Revert "Change battery tip text"
This reverts commit 2441b94c6d.

Reason for revert: <wrong commit>

Change-Id: I373fc065eafc81c26a8eba133255f9377d1d5d7f
2019-03-08 08:51:05 +00:00
TreeHugger Robot
760e6b66d8 Merge "Change battery tip text" 2019-03-08 08:50:02 +00:00
Howard Ro
402336006e Update comment to use statsd.
Test: n/a for comment update.
Change-Id: Ica414449d34085065b16003beddc1b8cbdb1367c
2019-03-07 15:41:03 -08:00
Salvador Martinez
6db5eb6cd0 Create preference to allow user to toggle sticky battery saver
This adds the toggle that makes it so that battery saver turns
off automatically at high battery percentages or not.

Test: robotests
Bug: 112232746
Change-Id: I0df879a43e5390bc671c47e780bbbb466a3e9353
2019-03-07 11:18:40 -08:00
Raff Tsai
2441b94c6d Change battery tip text
Fixes: 121042353
Test: adb shell settings put global battery_tip_constants test_low_battery_tip=true
      Then go to Settings -> battery to see the text
Change-Id: Ie3c4a89ccb7c2724840dc886a502ef919e13a856
2019-03-07 04:50:43 +08:00
TreeHugger Robot
3776476764 Merge "Use ThemedBatteryDrawable in settings" 2019-02-27 06:02:49 +00:00
Evan Laird
35e35622d9 Use ThemedBatteryDrawable in settings
Changed out BatteryMeterDrawable to inherit from ThemedBatteryDrawable
instead of BatteryMeterDrawableBase. Also removed warning text paint
because it seemed unused and simplified the interface.

Bug: 123705805
Test: visual
Change-Id: I30496e3d8881803d9d3d8a316c10387482a8f610
2019-02-26 14:11:58 -05:00
Joe Onorato
a4819527b7 Merge "Add additional anomaly types." am: 64bf0a791e am: e709ac7a4c
am: d3b25ae1f5

Change-Id: I7a45359cb344f0dee4046e556b599e7646c7fd17
2019-02-25 23:10:52 -08:00
Joe Onorato
f51826853b Add additional anomaly types.
Test: Treehugger
Bug: 115540658
Change-Id: I369f5bfadfe10810aa33d4127fb9ce69c9c57e7e
2019-02-25 14:51:10 +00:00
Lei Yu
755a7d5b65 Merge "Update battery summary" 2019-02-15 18:26:56 +00:00
jackqdyulei
ef3b364728 Update battery summary
When it is charging, show "5% - charging"(not only "5%")

Bug: 112013485
Test: RunSettingsRoboTests
Change-Id: If2299cc4929d8fc40d63669b74590fafe39122dc
2019-02-14 19:11:10 -08:00