Commit Graph

52219 Commits

Author SHA1 Message Date
Joonhun Shin
43d6a231e0 Merge "Data only device(without FEATURE_TELEPHON_CALLING) : Add try/catch to handle UnsupportedOperationException" into main 2024-01-08 02:06:46 +00:00
Chaohui Wang
f28d119560 Show "0 B used" when no data usage this cycle
When the latest cycle has no data usage, currently it shows all time
usage without cycle info, which could confuse user.

Change to "0 B used used xxx - xxx" to fix this issue.

Fix: 292346951
Test: manual - on Mobile Settings
Test: unit tests
Change-Id: Ic06fd63a3bc049d70538d0a3cd1fa3d62dbd71d7
2024-01-06 19:05:47 +08:00
Jigar Thakkar
3adb65b84d Disable strong auth for all profiles after successful unlock
The change generalizes the workflow to disable strong auth requirements
for all profiles that require authentication to disable quiet mode,
once a successful unlock has happened through CDCA.
Currently, the call to disable the strong auth requirements is only
being done for work-profile.

Test: Tested locally on device with private space setup with a separate
challenge and tested the strong auth tracker values post this change.
Bug: 312184187

Change-Id: Ib41c51d1df78eea9415d72724b8cc693344e2c26
2024-01-05 15:06:15 +00:00
Piotr Wilczyński
c7de74ac4b Merge "Don't back up Smooth Display if feature flag off" into main 2024-01-05 12:48:32 +00:00
Chaohui Wang
df5c4f69a8 Fix DataUsageSummaryPreferenceController ANR
By off load data loading to background.

Fix: 295260929
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ib2ef19301b1e97af8a7f3861829779c3b70da4a4
2024-01-05 16:07:28 +08:00
SongFerng Wang
8663deec9b Using ACTION_SIM_CARD_STATE_CHANGED to detect simSlotMapping is complete am: e51d8515c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25809891

Change-Id: I0bed6503fbce6204b2da75f6dc25364148f1ce8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-05 07:23:19 +00:00
MiltonWu
2703909793 Refine udfps enrolling icon
Refine fingerprint enrolling icon show/hide logic

Test: Manually test udfps enrolling flow
Bug: 313801674
Flag: NA
Change-Id: I8d10a2048d74efa8b0a5bf025dd81df0a9041274
2024-01-05 06:33:11 +00:00
Treehugger Robot
e8d26737a6 Merge "Reset telephony stack during Reset Mobile Network flow" into main 2024-01-05 04:49:29 +00:00
Rambo Wang
4c384506d5 Reset telephony stack during Reset Mobile Network flow
This CL introduces two more steps to restart Phone process and RILD
during the Reset mobile network flow by the help of the
TelephonyContentProvider which has been used by Pixel Adaptive
Connectivity Services ("SCONE") for a while.

The additional reset options can resolve issues like resources leak
and internal state stuck, effectively recover telephony stack into
fresh state.

The reset options are performed in the background and have no impact
on UX of the reset flow.

Bug: 271921464
Test: ResetNetworkOperationBuilderTest
Test: Feature test with both flag on and off
Change-Id: If09d20d79e908dd43f3f654fb7cca7f713b7f03a
2024-01-05 03:53:21 +00:00
SongFerng Wang
e51d8515c0 Using ACTION_SIM_CARD_STATE_CHANGED to detect simSlotMapping is complete
Sometime modem can't return the GET_SIM_STATUS immediately, so that the settings send the sim switching too early after simSlotMapping.

Bug: 291733084
Change-Id: If547c8b02020bc86c83915334e29945176a4ee9f
Test: tester will test it manually.
(cherry picked from commit ba2a86ad9f)
2024-01-05 03:38:30 +00:00
joonhunshin
37d4fb736e Data only device(without FEATURE_TELEPHON_CALLING) : Add try/catch to handle UnsupportedOperationException
If the device does not have Telephony feature calling, the some of interfaces in TelephonyManager throw UnsupportedOperationException.

Bug: 297989574
Test: oriole with ATT SIM, boot completed
      APM/data/wifi on/off, browse setting menu
Change-Id: Ifa9092cd8d9a00039e9d93d5fd9fc4dabed633c8
2024-01-05 03:04:14 +00:00
Zhen Zhang
22632be393 Rename method name
Renamed checkIfMeteredDataRestricted() to
checkIfMeteredDataUsageUserControllerDisabled() to relect its actual
usage.

Test: built successfully
Bug: 317265503
Change-Id: I76189da1da510067d5a715c5a34b6a18e53544fc
2024-01-04 10:33:52 -06:00
Chaohui Wang
39b23b760c Merge "Migrate NetworkOperatorPreference to Kotlin" into main 2024-01-04 09:00:05 +00:00
David Liu
38ce956b72 Merge "Fixed logging ACTION_SETTINGS_DISABLE_APP with package name" into main 2024-01-04 08:11:02 +00:00
Chaohui Wang
7cbfc40681 Migrate NetworkOperatorPreference to Kotlin
Bug: 293845605
Test: manual - with SIM Settings
Test: unit test
Change-Id: I5c21085a4ec9c2f53f93867813ba298690f161ff
2024-01-04 13:02:31 +08:00
Milton Wu
4f06db7bf8 Merge "Fix calibrator missing during suw page switch" into main 2024-01-04 04:51:56 +00:00
Chaohui Wang
92ae630598 Merge "Fix SIM Settings crash when IllegalArgumentException" into main 2024-01-04 04:51:46 +00:00
Chaohui Wang
3bd2e55b23 Fix SIM Settings crash when IllegalArgumentException
By catch exception.

Fix: 318460644
Test: manual - with SIM Settings
Test: unit test
Change-Id: I99025125b5fe71c6507afc355a881af8948d6a7a
2024-01-04 10:47:48 +08:00
Jason Chiu
2c2dd72ff7 Merge "Support "Add account" search indexing" into main 2024-01-04 02:39:05 +00:00
Jan Tomljanovic
be50a8f6f3 Merge "Require authentication for changing USB preferences." into main 2024-01-03 15:19:21 +00:00
Julia Reynolds
e6c3d18648 Update content description
Test: manual: use TalkBack on conversations screen
Fixes: 317316662
Change-Id: I7c9b0746bf610168e8a3c2bc0d2932082da221a8
2024-01-03 15:00:20 +00:00
Beverly Tai
b996d0a4ea Merge "Add new folding grace period settings strings" into main 2024-01-03 13:48:42 +00:00
Xinyi Mao
df262ad2d6 Merge "Reset the delay time to refresh the periodic job." into main 2024-01-03 09:28:08 +00:00
Allen Su
ef83eeb1db Merge "Remove the xml entry when the system language is removed" into main 2024-01-03 08:29:07 +00:00
mxyyiyi
5ef828930d Reset the delay time to refresh the periodic job.
Bug: 315225261
Test: manual
Change-Id: I5a42a9d2ac11ff5f036eaa85e37682438fceeac2
2024-01-03 15:53:38 +08:00
Allen Su
d8695cbf9b Remove the xml entry when the system language is removed
Bug: 301395074
Test: atest SettingsRoboTests:com.android.settings.localepicker
Change-Id: Ic771cd5146ab954c3da65748bf87cd14d30770b4
2024-01-03 07:27:52 +00:00
Chaohui Wang
ce84bfbc7e Merge "Refactor CellInfoUtil" into main 2024-01-03 07:05:11 +00:00
MiltonWu
bb8be99c5c Fix calibrator missing during suw page switch
Pass previous calibrator uuid to next fingerprint enroll activity

Bug: 318453900
Test: Manully test suw fingerprint flow
Change-Id: Iad1e9e1811f58fa880b8d05a722b7fdf57a814fa
2024-01-03 14:49:23 +08:00
Pajace Chen
6bdfac7cdd Merge "[Shadow] Switch the button for defend battery tips" into main 2024-01-03 06:24:28 +00:00
Chaohui Wang
e3b527a2bf Refactor CellInfoUtil
Unify and simplify the logic, and add unit test.

Bug: 293845605
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I5467b92baa8e47fbd400c7a21fd39fd5ec90ed3a
2024-01-03 13:41:45 +08:00
Julia Reynolds
c12e8be1b7 Remove unneeded code
Because the setting is marked as 'clone to profile'

Test: none/see other cl in topic
Bug: 314320478
Change-Id: I10fe30c4cbb186b9ef5a3a9f583a287b65cebe3e
2024-01-02 13:39:39 -05:00
Piotr Wilczyński
369cfd8ea5 Don't back up Smooth Display if feature flag off
In the previous CL (ag/24838636), we decided to back up Smooth Display and Force Peak Refresh Rate even if the feature flag is off and then just convert the value in DisplayModeDirector based on the state of the feature flag. This was because it wasn't clear how to access the feature flag from the Settings module. This resulted in the feature partially working if the flag is off.

Bug: 313021502
Test: atest DisplayModeDirectorTest
Test: atest ForcePeakRefreshRatePreferenceControllerTest
Test: atest PeakRefreshRatePreferenceControllerTest
Test: atest SettingsBackupAgentTest
Test: atest SettingsBackupTest
Test: atest SettingsValidatorsTest
Change-Id: I3406bc5c5f49fe6102cdfe6934813a9c4073ac6f
2024-01-02 15:06:31 +00:00
Pajace Chen
484f82e776 [Shadow] Switch the button for defend battery tips
Align the button position of defender settings tips with new design

Bug: 299403437
Test: Manual Test
Flag: None
Change-Id: I897d7291bfc21da69b661893368ddf4d6af7b06b
2024-01-02 14:37:36 +00:00
Treehugger Robot
1a564010bf Merge "Inject mocks in RemoteVolumeControllerTest via constructor" into main 2024-01-02 14:03:43 +00:00
Iván Budnik
b02f9f38e4 Inject mocks in RemoteVolumeControllerTest via constructor
This fix avoids the test wrongfully initializing real components before
the tests can modify mockable fields, which causes NPEs.

Bug: 318078730
Test: atest RemoteVolumeGroupControllerTest
Change-Id: I350e3e2e45eadb0f9737ba5d4b45c9f80e3355fb
2024-01-02 13:10:19 +00:00
Vaibhav Devmurari
da30b549be Merge "Add A11Y settings for Bounce keys and Sticky keys" into main 2024-01-02 13:05:59 +00:00
Jan Tomljanovic
b3e3fcb0fb Merge "Add auth challenge for increasing screen timeout." into main 2024-01-02 12:08:38 +00:00
Zaiyue Xue
3b300cbf9f Merge "Fix battery usage chart was unexpectedly cleared" into main 2024-01-02 08:38:38 +00:00
Zaiyue Xue
9c06e522bc Fix battery usage chart was unexpectedly cleared
Bug: 318308397
Fix: 318308397
Test: manual
Change-Id: Ia00c0680a563eaffb3609c1372336a6b9ed7fa17
2024-01-02 11:59:16 +08:00
Pajace Chen
882058de81 [Shadow] Switch the button for defend battery tips
Align the button position of defender settings tips with new design

Bug: 299403437
Test: Manual Test
Flag: None
Change-Id: Ieac9cd34ba2e14581040a87a1eb7382decbe1212
2023-12-31 11:54:11 +00:00
Chaohui Wang
355144675a Fix ANR in WifiCallingPreferenceController.getAvailabilityStatus
Move the following to background thread to avoid block main thread,
- MobileNetworkUtils.isWifiCallingEnabled(mContext, mSubId, null)
- MobileNetworkUtils.buildPhoneAccountConfigureIntent()
- getSummaryForWfcMode()
- Call State

Since WifiCallingPreferenceController no longer calculate availability
in getAvailabilityStatus(), also update the
CallingPreferenceCategoryController accordingly.

Also introduce ImsMmTelRepository for split business logic for easy
testing.

Fix: 292401934
Test: manual - on Mobile Settings
Test: unit test
Change-Id: If92e2c8f6e137e40b83e578294c03c1b917eef8e
2023-12-29 17:16:49 +08:00
Sunny Shao
946f52b2a1 Merge "Revert "Nullability Annotations replacement"" into main 2023-12-29 03:18:24 +00:00
Jason Chiu
01f992a698 Support "Add account" search indexing
Implement a default getRawDataToIndex method of preference controller
base for indexing preference's raw data.

Test: manual, robotest
Fix: 243899250
Change-Id: I3fb4f88c881edcbaa3c5bfc7f78cc2e169b0380f
2023-12-29 10:36:57 +08:00
Sunny Shao
19d1d3d15d Revert "Nullability Annotations replacement"
This reverts commit cf0501e4d7.

Reason for revert: b/317462033, it seems a flaky but revert it first.

Change-Id: Ie1d5e279cca6477fc17d8c27c1ecda8d7a6b2553
2023-12-29 02:28:24 +00:00
Vaibhav Devmurari
315f2546fc Add A11Y settings for Bounce keys and Sticky keys
Test: manual
Bug: 294546335
Change-Id: I943300c31d0c8e142f64f084f4c65e05249a72ec
2023-12-28 21:02:11 +00:00
Beverly
20e48424d9 Add new folding grace period settings strings
Bug: 315219497
Flag: ACONFIG com.android.internal.foldables.flags.fold_grace_period_enabled DEVELOPMENT
Test: manually enable and see new strings (adb root && adb shell setprop
persist.fold_grace_period_enabled true && adb reboot)

Change-Id: Ie278b45e3928e1154f78066e71551fb5cac8a176
2023-12-28 17:24:58 +00:00
Julia Reynolds
2d2fc79edd Merge "Hide spinner options for locked users" into main 2023-12-28 14:59:15 +00:00
Julia Reynolds
2890ac7101 Hide spinner options for locked users
'Most Recent' and 'Most Frequent' depend on usagestats data, which
is only available for unlocked users. Hide them if the user is
currently locked

Test: turn off work profile and view app notification list, primary &
work
Test: turn on work profile and view app notifications list, primary &
work
Fixes: 195092949
Flag: none

Change-Id: Ia87b2b64824dff645286ea8910bcd2c412d070ae
2023-12-28 14:11:27 +00:00
Chaohui Wang
b26ae73c39 Merge changes from topic "AutoSelectPreferenceController" into main
* changes:
  Clean up ServiceStateStatus
  Improve AutoSelectPreferenceController
2023-12-28 10:41:10 +00:00
SongFerng Wang
19dbb00acb Merge "Using carrier config for hiding 3G item at preferred network mode" into main 2023-12-28 09:40:26 +00:00