Commit Graph

1391 Commits

Author SHA1 Message Date
Jason Hsu
cb9870b087 Merge "[HA Audio Output] Change category according to the audio definition" into main 2023-12-15 13:23:46 +00:00
Chun-Ku Lin
b4665e6714 Merge "Apply Setup styles to the a11y edit shortcut full screen." into main 2023-12-14 22:51:31 +00:00
Chun-Ku Lin
d92f17cdf5 Merge "Convert a11y shortcut edit screen to a full screen." into main 2023-12-14 22:19:08 +00:00
Chun-Ku Lin
9d6bf1b784 Apply Setup styles to the a11y edit shortcut full screen.
Bug: 300302098

Test: atest AccessibilitySetupWizardUtilsTest
Test: atest EditShortcutsPreferenceFragmentTest (Unable to make
Robolectric inflate the view of the edit shortcut fragment with the Setup wizard
theme)
Test: manual (Launch the setup wizard and check the screen)

Change-Id: I2995e914d622e9865101ef16e3b280c65371a252
2023-12-14 20:50:45 +00:00
Chun-Ku Lin
64e946c7fa Convert a11y shortcut edit screen to a full screen.
Bug: 300302098

Flag: adb shell device_config put accessibility com.android.settings.accessibility.edit_shortcuts_in_full_screen true

Test: manual
Test: atest com.android.settings.accessibility.shortcuts

Change-Id: I0b5e367fed962ff01036122ce7ff32a8ae47fbc3
2023-12-14 20:50:33 +00:00
Hani Kazmi
7580dac41b Merge "Update existing ECM settings to use new infrastructure" into main 2023-12-12 12:01:17 +00:00
Jean Chen
097d8a891b feat(MultiFingerMultiTap): Update shortcut string to double tap from triple tap
Bug: 315264770
Test: manual
Change-Id: I1130271d06bac71f23a137c83149ee3363a1cc0e
2023-12-08 10:12:43 +08:00
Hani Kazmi
ded1cd59c9 Update existing ECM settings to use new infrastructure
1. Update Notification Listener and A11y settings to call
   RestrictedLockUtilsInternal rather than checking appOp themselves

2. Rename ecm related methods to include Ecm rather than AppOp -
   implementation details are being moved to permissions module and may
   change.

Bug: 297372999
Test: Manually tested on device. Automaated tests to follow
Change-Id: Ie3e16b502993b21a7e34eab0d661f98814b3cfd5
2023-12-07 15:59:52 +00:00
Daniel Norman
0fa75c4e41 Merge "Adds a summary to the (screen) Magnification preference for the main A11y Settings page." into main 2023-12-06 20:22:28 +00:00
Daniel Norman
2edaf7668c Merge changes from topic "b-303511250-cleanup" into main
* changes:
  Use A11yManagerService to check if the A11yService warning is required.
  Minor refactoring to replace duplicated logic with existing methods.
2023-12-06 19:55:21 +00:00
Daniel Norman
01e624c76b Adds a summary to the (screen) Magnification preference for the main A11y Settings page.
This helps differentiate this from other magnification tools.

Reuses (and slightly modifies) the `magnification_feature_summary`
string which was not used by any existing code. This helps ensure
the existing localizations should be close enough, until L10n
translators have time to update based on the new shorter version.

Bug: 303499185
Test: ToggleScreenMagnificationPreferenceFragmentTest
Test: Open Settings > Accessibility, observe summary
Change-Id: If5ee4f937bbd655b425d4767ad8bbcef08dbe345
2023-12-06 01:10:52 +00:00
Tyler Freeman
3fddb64a0d Merge "feat(force invert): add force invert Settings preference in A11y > Color and Motion" into main 2023-12-05 20:36:36 +00:00
Tyler Freeman
e0f10d3fe2 feat(force invert): add force invert Settings preference in A11y > Color and Motion
Bug: 312289375
Test: atest packages/apps/Settings/tests/robotests/src/com/android/settings/accessibility/ColorAndMotionFragmentTest.java
  && atest packages/apps/Settings/tests/robotests/src/com/android/settings/accessibility/ToggleForceInvertPreferenceControllerTest.java
Flag: android.view.accessibility.Flags.forceInvertColor

Change-Id: I2739a1dfecbbddcd240a3113344987ade2b7c717
2023-12-04 14:12:43 -08:00
Daniel Norman
126de9691a Use A11yManagerService to check if the A11yService warning is required.
Bug: 303511250
Test: m RunSettingsRoboTests ROBOTEST_FILTER=ToggleAccessibilityServicePreferenceFragmentTest
Change-Id: Ibef748bd82ba166e377be0611df113ac09d052bc
2023-11-28 01:54:21 +00:00
Daniel Norman
9f6e77a094 Minor refactoring to replace duplicated logic with existing methods.
Bug: 303511250
Test: tested in child change in the topic
Change-Id: I0995ce5fc685257ba69f7e4aa733de74aeb1fde3
2023-11-28 00:07:17 +00:00
jasonwshsu
a9e89031b6 [HA Audio Output] Change category according to the audio definition
Root Cause: According to the audio definition, system sounds are UI touch sounds, unlock sounds, etc., so they are controlled by Media strategy.

Solution: Move system sounds, accessibility sounds, DTMF sounds into Media category. Notification category contains notification sounds only.

Bug: 293251163
Test: manual test
Change-Id: Ied3db95dacbd2c0985bdbfccec5575bb5988fc5b
2023-11-22 06:29:34 +00:00
Treehugger Robot
47a9ea6d33 Merge "Make Color inversion shortcut searchable" into main 2023-11-21 03:01:06 +00:00
Chun-Ku Lin
2d45bcccab Merge "Update strings for stopping accessibility services" into main 2023-11-20 19:46:25 +00:00
Chun-Ku Lin
698458c5cd Update strings for stopping accessibility services
Flag: EXEMPT
Flag exempt reason: low risk changes. Mostly text changes

Test: manual - turn on Talkback and turn off Talkback and see the dialog
Test: atest ToggleAccessibilityServicePreferenceFragmentTest
Bug: 286549065
Change-Id: I90869b5fca0500739f65d0b0ef3331cb728be685
2023-11-20 18:53:32 +00:00
Roy Chou
5d9571bcee Merge "fix(text preference): fix preview block ui broken in SUW" into main 2023-11-20 03:11:29 +00:00
Roy Chou
004238d7f8 fix(text preference): fix preview block ui broken in SUW
As previous cl ag/25185014 we increased the preview block horizontal padding when landscape mode. However, in setup wizard it uses GlifPreferenceLayout so the settings page only has half screen width when landscape mode, so the preview block ui is squished due to limited width. Also, setup wizard package has overlay the paddings to larger than our prevoius adjust. Therefore, we rollback the changes in accessibility_text_reading_preview.xml to get the default padding, then add checker to increase the paddings if needed at runtime.

Bug: 309590083
Test: manually
Test: atest TextReadingPreviewPreferenceTest
Test: atest TextReadingPreferenceFragmentForSetupWizardTest
Change-Id: Ib907f4182eed272b84a4ab6208ea2d8a89ba96c4
2023-11-20 03:10:33 +00:00
Mill Chen
0fa4b503d9 Make Color inversion shortcut searchable
The color inversion shortcut is not searchable because this preference
is dynamically created. In order to make it searchable, we should add
index raw data for this preference.

Fixes: 223514734
Test: manual test
1) Open Settings search
2) Search for shortcut
3) check that the search results have Color inversion shortcut

Change-Id: I354d0c0e63cc12bd5012d7f26a165278a40bcf2d
2023-11-19 15:34:13 +08:00
Chun-Ku Lin
0f2cc34230 Don't show quick settings tooltip if the user is in the Setup Wizard,
since the user can't access the Quick Settings Panel.

Bug: 294560581
Test: manual
- Turn on feature flag: adb shell device_config put accessibility com.android.settings.accessibility.remove_qs_tooltip_in_suw true
- Modify the font scale in SUW, verify the QS tooltip doesn't show up
- Modify the font scale after SUW, verify the QS tooltip shows up
Test: atest SettingsRoboTests:com.android.settings.accessibility

Change-Id: I1d1a4f8f70ea3e1d929952d5c273de1b4cd80503
2023-11-14 23:30:49 +00:00
Daniel Norman
64bfe882c8 Merge changes from topic "b-303511250-dedupe-warning" into main
* changes:
  Tech debt cleanup: Consolidates A11yService warning dialog.
  Includes android.view.accessibility Aconfig flags in Settings.
2023-11-14 18:56:15 +00:00
Angela Wang
c01677b676 Merge "Removes hearing aids settings page flag" into main 2023-11-14 06:47:36 +00:00
Daniel Norman
77db500fcb Tech debt cleanup: Consolidates A11yService warning dialog.
Both frameworks/base and the Settings app define almost-identical copies
of a warning dialog shown when enabling an accessibility service.
The frameworks/base version was used for contexts outside of Settings
(e.g. while editing the volume key shortcut after triggering it with
2+ features already enabled) while the Settings version was used in
the Settings app.

This change replaces version used in Settings with the version defined
in frameworks/base.

The warning dialog's functionality is tested in
AccessibilityServiceWarningTest in frameworks/base.

Feature flag:
`adb shell device_config override accessibility android.view.accessibility.deduplicate_accessibility_warning_dialog true`

Bug: 303511250
Test: atest AccessibilityServiceWarningTest
Test: existing A11ySettings robotests
Change-Id: Iad2f13040d53d82a4afb0353fae3ac355b5548d6
2023-11-10 18:38:53 +00:00
Angela Wang
01f17822c3 Removes hearing aids settings page flag
The hearing aids settings page has successfully rolled out. Cleans up the codes that are related to flag controls.

Bug: 310203155
Test: atest AccessibilityHearingAidPreferenceControllerTest
Test: atest AccessibilityDetailsSettingsFragmentTest
Test: atest BluetoothDetailsHearingDeviceControlsControllerTest
Change-Id: Ib03952f734302cca8519cb1c70ba82601cb75527
2023-11-10 17:06:32 +00:00
Chaohui Wang
08a1c9876e Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"
8979681a8d

Change-Id: I60edd3aabf49afbe4aa016af780baa68d928bddf
2023-11-07 14:17:15 +00:00
Sebastian Pickl
8979681a8d Revert "Migrate to CompoundButton.OnCheckedChangeListener"
Revert submission 25147565-onSwitchChanged-CompoundButton

Reason for revert: breaking builds 

Bug:309601476

Reverted changes: /q/submissionid:25147565-onSwitchChanged-CompoundButton

Change-Id: Ie746db87d9c642599593aa3d5e5baf6b7ba89c0e
2023-11-07 13:26:36 +00:00
Chaohui Wang
71d1f021af Migrate to CompoundButton.OnCheckedChangeListener
Switch and SwitchCompat are both CompoundButton.

Using CompoundButton in Java will helps migration in the future.

Bug: 306658427
Test: manual - check Settings pages
Change-Id: If2e08a9a9557ec66a3b31ef18cd2e15943098a59
2023-11-07 20:22:27 +08:00
Jean Chen
bf18e7967e Merge "Revert^2 "feat(MultiFingerMultiTap): Add tutorial for two finger triple tap"" into main 2023-11-01 00:23:08 +00:00
Jean Chen
6a50a06f76 Revert^2 "feat(MultiFingerMultiTap): Add tutorial for two finger triple tap"
This reverts commit dc9ad88a26.

Reason for revert: The issue be fixed on b/308228560. Our change wasn't the actual culprit. 

Change-Id: Ie023b10d70db680799f30c8bc9346cc65716b550
2023-10-31 08:43:39 +00:00
Daniel Norman
dc9ad88a26 Revert "feat(MultiFingerMultiTap): Add tutorial for two finger triple tap"
This reverts commit 2870455091.

Reason for revert: b/308368520

Change-Id: I512fa574e47585f0005ccc6c3790c0c20a3a4c55
2023-10-30 16:29:19 +00:00
Chaohui Wang
019be1b687 Migrate ShortcutPreference to SwitchCompat
Settings use SwitchCompat instead of Switch in the future, for new
Material 3 UI.

Bug: 306658427
Test: manual - on Accessibility pages
Change-Id: Idf87eb6fcf1a57bd98a6fd0eca3c8c325127ce17
2023-10-28 20:04:31 +08:00
Jean Chen
2870455091 feat(MultiFingerMultiTap): Add tutorial for two finger triple tap
This tutorial is showing when user enabled two finger triple tap shortcut

Bug: 297805269
Test: manual
Test: atest AccessibilityGesturenavigationTutorialTest
Change-Id: Ie56cffe809e801c497d9d55d92a4b55084d496ce
2023-10-27 16:58:48 +08:00
Jean Chen
198ae8901b Merge "feat(MultiFingerMultiTap): Add two-finger triple-tap shortcut on magnification dialog" into main 2023-10-27 03:43:51 +00:00
David Magno
eb2276c01c Customize the text reading preview layouts
Make it possible to customize the available text reading preview
layouts through overlays.

Bug: 307481249
Test: make RunSettingsRoboTests ROBOTEST_FILTER=
"com.android.settings.accessibility.TextReadingPreviewPreferenceTest"
(cherry picked from https://android-review.googlesource.com/q/commit:2a7da9c433f57db9b7b9ad5c54bddb5da81e5693)
Change-Id: I3e55eeb7545a4d5d1f689ab4160e453996b58bdb
2023-10-25 18:37:51 +00:00
Jean Chen
48d73aa3f3 feat(MultiFingerMultiTap): Add two-finger triple-tap shortcut on magnification dialog
The shortcut is separate from single-finger triple-tap. It’s under hardware shortcut and above/outside of Advanced section.

Bug: 297805269
Test: manual
Test: atest ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: Id74cf3e457c04e167f3100d977b6c70c5d601026
2023-10-25 13:30:27 +00:00
Chaohui Wang
c4a3a50d58 Migrate to CompoundButton
Switch and SwitchCompat are both CompoundButton.

Using CompoundButton in Java will helps migration in the future.

Bug: 306658427
Test: manual - on affected pages
Change-Id: I7cdc2601879a85d33f77239e38263320d5a6984e
2023-10-25 14:57:48 +08:00
Daniel Norman
529090ba5d Merge "Adds 'App info' button on accessibility service + activity pages." into main 2023-10-24 21:23:50 +00:00
Chaohui Wang
cfdb3b1f1b Migrate new() to SwitchPreferenceCompat
Bug: 306658427
Test: manual - on Settings pages
Change-Id: I258a8c63d5c46403c6d333a9d2f34c33cb35e27f
2023-10-24 14:05:34 +08:00
Chaohui Wang
15ca95a31b Migrate to TwoStatePreference
SwitchPreference and SwitchPreferenceCompat are both TwoStatePreference.

Using TwoStatePreference in Java will helps migration in the future.

Bug: 306771414
Test: manual - check Settings pages
Change-Id: I84e1d7b09451106797c2b23d127855c6976678ca
2023-10-23 09:28:57 +00:00
Daniel Norman
8946e64f28 Adds 'App info' button on accessibility service + activity pages.
This launches the existing app info page for the a11y feature's owning
package. Features without a valid component (framework features) do not
have this button. This is also not shown in Setup Wizard which does
not support the App Info page.

This helps users find more info about the app that provided an
accessibility feature.

Screenshot: https://screenshot.googleplex.com/B9FXLoomxFjLBv8.png
Flag: accessibility com.android.settings.flags.accessibility_show_app_info_button

Bug: 277378550
Test: atest ToggleFeaturePreferenceFragmentTest (robotest)
Test: Open and interact with the button, ensure it opens the app info
      page for the correct app.
Change-Id: I2041c09077ce5fadc72117dc0c72409dd33ef60b
2023-10-20 21:31:11 +00:00
Chaohui Wang
82a9a9e47d Remove Settings preference_widget_primary_switch
File content same as SettingsLib's preference_widget_primary_switch

Bug: 285231003
Test: m Settings
Change-Id: I4b9f92435ffb5c253241e294c4680025fe0447fc
2023-10-20 12:55:22 +08:00
Wilson Wu
e9eb8e65ce Add keyboard vibration settings
Introduce keyboard vibration preference settings
to control keyboard vibration state.

Bug: 289107579
Test: atest KeyboardVibrationTogglePreferenceControllerTest
Change-Id: I9cc5d53f1b22c460ad2acc7e4a412fefbca586df
2023-10-18 02:50:56 +00:00
Daniel Norman
35265e838f Fix missing declared accessibility PreferenceControllers.
This includes 3 fixes:

Adds missing settings:controller attribute for bold & high-contrast
text preferences.

Separates VibrationSettings into two fragments, one per fragment XML resource.
  Instead of using a conditional to choose the XML resource ID,
  we now use the conditional to choose which fragment to launch.
  This allows both fragment's preference controllers to be inspected
  by CodeInspectionTest#runSliceControllerInXmlInspection.
  Also updates the preference keys which must be unique per XML in order
  to appear in Settings Search.

Adds Magnification preference controllers to exempt-not-in-XML list.
  These controllers are for fragments that are not declared in an XML.
  See ToggleScreenMagnificationPreferenceFragment
        #getPreferenceScreenResId.

Bug: 289967175
Test: atest SettingsRoboTests:com.android.settings.accessibility
Test: atest CodeInspectionTest#runSliceControllerInXmlInspection;
      Observe no errors in the accessibility package.
Test: Open Settings > Accessibility > Vibration & haptics;
      observe vibration intensity page is shown (behavior unchanged).
      Hardcode config_vibration_supported_intensity_levels=1;
      observe vibration page with toggles is shown (behavior unchanged).
Change-Id: I257b5ad390371bedb1623af6289016b06d478707
2023-10-02 18:00:30 +00:00
Chris Göllner
f09a5ce94c Start logging rotation lock history + include caller information
There have been a few reports on foldables where rotation lock suddenly
changed, without user interaction.
Adding these logs will make it easier to debug the issue.

Bug: 289023967
Bug: 289534937
Bug: 279685215
Test: Manually - Change rotation lock and check logs in dumpsys
Change-Id: I2a877e7b47c863871a2c6ba29ce46e63d28c8008
2023-09-25 17:55:06 +01:00
Peter Kalauskas
80e914a263 Enable use_resource_processor for all sysui deps
This will make the build faster

Test: m checkbuild
Bug: 295208392
Change-Id: If75acb6b1c3f204e3686c20cef609f7cfabe15cf
2023-09-21 23:09:39 +00:00
Angela Wang
7a15ecafde Hide pair other ear button after device connected via CSIP
The pair other ear button should disappear after both ears of binaural
hearing aids are connected.

Remove checking if CSIP is enabled since CSIP is always enabled in
pairing stage.

Bug: 296646732
Test: check the UI manually
Change-Id: I804819eef41b5d3754ad0a79d9fc1afc66cef5cc
2023-09-19 04:49:35 +00:00
Angela Wang
175c73b316 Redirect user to original pairing page from pair dialog
After pairing ASHA devices from "Hearing devices", the pair another
dialog will bring user to the "Connected devices" pairing page. We
should redirect user to "Hearing devices" pairing page if user is
pairing their devices from A11y hearing devices page.

Bug: 295713308
Test: atest HearingAidPairingDialogFragmentTest
Test: manually connect an ASHA device and check the redirect page
Change-Id: Ia18e53a85e2b21a17e7a843d8979917c8c468e09
2023-08-24 06:34:42 +00:00