Commit Graph

878 Commits

Author SHA1 Message Date
Eric Biggers
1d48df59e5 Remove FDE support from accessibility settings
With FDE (Full Disk Encryption), secure start-up (i.e. requiring a PIN /
pattern / password to boot the device) was incompatible with
accessibility services.  Thus, the accessibility settings would ask the
user to disable secure start-up when enabling an accessibility service.

Now that FDE support has been removed in favor of FBE (File Based
Encryption), this is no longer necessary.  Remove it.

Bug: 208476087
Change-Id: I5f6e512f223df63e1b4d1c181fc8b3fe683dcd5f
(cherry picked from commit b4060ef65b)
Merged-In: I5f6e512f223df63e1b4d1c181fc8b3fe683dcd5f
2022-03-07 22:18:48 +00:00
TreeHugger Robot
b944d7f110 Merge "Move the text under slider bar to the description under title" into sc-v2-dev am: 0f0e27cf6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16379115

Change-Id: I5cf2e273ae5dda74a8491a85588e795203b73c43
2021-12-10 01:23:35 +00:00
TreeHugger Robot
0f0e27cf6a Merge "Move the text under slider bar to the description under title" into sc-v2-dev 2021-12-10 01:03:24 +00:00
Alex Li
1ed0cd05c0 Merge "[Settings] Remove override the transition to fade during the Suw flow." into sc-v2-dev am: b1a91c9f95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16413592

Change-Id: I9db4d5e802cf658ae12c7141b53b30fb77a1c77c
2021-12-09 11:09:05 +00:00
Sunny Shao
b5bb0e85a1 Move the text under slider bar to the description under title
- Make this change after discussed with UX team.

Fixes: 206737771
Test: manual test
Change-Id: I9517933312d8db400f6d40b4124815ad275014ec
2021-12-09 17:13:26 +08:00
alexylli
2a7069f561 [Settings] Remove override the transition to fade during the Suw flow.
Because Suw side has already override the transition when calling the
font size.

video: https://drive.google.com/file/d/1Lihpj3PFX4-xpg1d3pT3pBqm99noQL-k/view?usp=sharing

Bug: 208374725
Test: manual
Change-Id: Idaa56cdbdc7b9f76fe370ba79130007f7359557c
2021-12-08 17:06:44 +08:00
Ryan Lin
7f704f6c95 Merge "Fix incorrect UI after triple-tap is disabled" into sc-v2-dev am: 2007a57560
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16379103

Change-Id: Icce7853960e621266a8817f22cf88a52fae7a7d5
2021-12-03 10:14:30 +00:00
Ryan Lin
2007a57560 Merge "Fix incorrect UI after triple-tap is disabled" into sc-v2-dev 2021-12-03 09:52:13 +00:00
ryanlwlin
a992b611bf Fix incorrect UI after triple-tap is disabled
The preference summary is not changed after
users disable the triple tap shortcut by the confirm
dialog. It is due to the fact that the fragment doesn't
observe the settings value change.

To fix it, we add the settings key to observe the change.

Bug: 208755360
Test: manual test
Change-Id: Ie5b7fc5e67c5491b53485af0d3d68d1789aeace4
2021-12-03 01:58:25 +00:00
Jason Hsu
8216c769a9 Merge "Align the "Open activity" UI style with usual accessibility service "Use service"" into sc-v2-dev am: 5c90a9c225
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16321718

Change-Id: I56bfde017611f42e38d16488a5fa02f18d2db253
2021-12-02 11:27:03 +00:00
jasonwshsu
a8442468ad Align the "Open activity" UI style with usual accessibility service "Use service"
Root Cause: "Open activity" Preference is not part of the widget SettingsMainSwitchBarPreference, so its UI style did not be inherited.

Solution: "Open activity" has different concept from switch bar, we need to manual set its bacground to comply with the SettingsLib style.

Bug: 207067203
Test: manual test
Change-Id: I66f63f6952e5c4770509febc0e53eca6dc6eedb9
2021-11-23 15:13:39 +08:00
TreeHugger Robot
579723b4b4 Merge "Fix suw display size flicker problem" into sc-v2-dev am: 943d68127c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16234666

Change-Id: Iad78a38a429be9a353176c4fcc529d34ec1023bc
2021-11-17 02:08:45 +00:00
Sunny Shao
d7f302fb4e Fix suw display size flicker problem
- Swipe the preview area will invoke the OnGlobalLayoutListener.
- Sometime it cause a flicker when scroll view scrolling up and
  preivew area swiping.
- It is no need to scroll up if the height of scroll view does not change.

Fixes: 205918748
Test: manual test
Change-Id: I8ed5454d32f0cf2a7bc3bac45c7aa054ce929c4b
2021-11-11 15:20:06 +08:00
Jason Chiu
026b1b5df6 Merge changes from topic "slice-highlight" into sc-v2-dev am: 6821b6be32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16151654

Change-Id: Ib03d41631d8bf961fa3ff3957eb5452411da7792
2021-11-02 02:28:16 +00:00
Jason Chiu
6821b6be32 Merge changes from topic "slice-highlight" into sc-v2-dev
* changes:
  Add highlight menu keys for all toggle pref controllers and custom slices
  Support slice deep links highlighting menu entries
2021-11-02 02:14:09 +00:00
Jason Chiu
2989c50a23 Add highlight menu keys for all toggle pref controllers and custom slices
Bug: 204695404
Test: manual, robotest build pass, unit
Change-Id: Iad2e28ada8ddb766ffa7eff2c8dc581250cbd6f8
2021-11-01 15:00:18 +08:00
TreeHugger Robot
4ef8d14ed7 Merge "Fix alignment issue between Vision Settings and Font/Display" into sc-v2-dev am: 17df1ff01f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16056987

Change-Id: I7b9a5992c671ed304e3ad2cdec7f546d6c77b446
2021-11-01 02:50:16 +00:00
Sunny Shao
d2704ad4ca Fix alignment issue between Vision Settings and Font/Display
- Use the same approach of Vision page to tweak the padding of the header

Fixes: 202897526
Test: make RunSettingsGoogleRoboTests -j ROBOTEST_FILTER=com.android.settings.accessibility.AccessibilityScreenSizeForSetupWizardActivityTest
Change-Id: I06eb5cb3ea6952b2cfdaa71f15757e415b61f5cc
2021-10-23 11:09:18 +08:00
Jason Hsu
33914ed556 Merge "Fix software shortcut in dialog did not update when content change." into sc-v2-dev am: 56e82fe112
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16005288

Change-Id: I9a37e193ad72c639a10ebe10cb0868215b1823c7
2021-10-20 10:21:32 +00:00
jasonwshsu
eba8e8da19 Fix software shortcut in dialog did not update when content change.
Root Cause: Dialog only get updated when clicked the trigger button to show dialog.

Solution: Update the software shortcut content in dialog if needed in onResume() stage.

Bug: 183342594
Test: atest AccessibilityDialogUtilsTest
Change-Id: Ibcd66d6c57f1790f96f234e49f456cbc2c990f64
2021-10-20 16:25:26 +08:00
Menghan Li
6001f86910 Merge "Fix Settings app crashes when clicked on the magnification" into sc-v2-dev am: 6de9b2486f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16044202

Change-Id: I9fdf101e209d7ade30c3da5850ed4499d7fcca3d
2021-10-14 07:32:01 +00:00
menghanli
f9ca092d58 Fix Settings app crashes when clicked on the magnification
1. Apply SetupWizardUtils.getTheme for AOSP / Nexus phone
2. Remove Magnification controller
3. Correct the description of the Talkback and Magnification page

Bug: 202792097
Test: manual test and upload fixed demo on bug
Change-Id: I108af30e3e2530bfabfcbdae03a7139a5b4e7a63
2021-10-13 22:34:27 +00:00
Menghan Li
a6e6cfbee1 Merge "Apply fade transition for font size and display size Suw page" into sc-v2-dev am: 502f53619f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16001288

Change-Id: I349e5f81d0124ae90cc7149424491dcb12b73282
2021-10-12 13:33:20 +00:00
menghanli
71aca3b7a9 Apply fade transition for font size and display size Suw page
- Create font size & screen size controler to simply xml
- Add onPuase animation

Bug: 194447311
Test: atest AccessibilityScreenSizeForSetupWizardActivityTest
Test: atest FontSizePreferenceControllerTest
Test: atest ScreenSizePreferenceControllerTest
Change-Id: I91f3fd4c22aba4f8cd46f6e82e50987544942245
2021-10-12 09:48:16 +08:00
Menghan Li
ebdfd05c67 Merge "Apply GlifPreferenceLayout for accessibility service Setup Wizard two-panel styles" into sc-v2-dev am: 9441d2b289
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15773283

Change-Id: Icfd8f891f85dc2a179770592fc1168eab2a501b0
2021-10-06 11:00:39 +00:00
Menghan Li
9441d2b289 Merge "Apply GlifPreferenceLayout for accessibility service Setup Wizard two-panel styles" into sc-v2-dev 2021-10-06 10:46:37 +00:00
TreeHugger Robot
87895d0893 Merge "Update font/display size pages for support large screen in SuW" into sc-v2-dev am: 9ade901dd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15895175

Change-Id: Iba75d65a5e896774bfa512831412ee47aaf91139
2021-10-06 06:25:04 +00:00
Sunny Shao
f9beef43c9 Update font/display size pages for support large screen in SuW
- Follow the SuW design of the UI guideline.
- Add the footer button for each pages.
- Add a new AccessibilityScreenSizeForSetupWizardActivity for SuW.
- Add suw_font_size_fragment.xml and suw_screen_zoom_fragment.xml
  for each fragment.
- Shorten 50% of the preview height.

Bug: 194447311
Fixes: 199369859
Test: manual test
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.accessibility
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.display
Change-Id: I2685e96d37d542490521ec24cfce490f87cbd88d
2021-10-06 11:41:57 +08:00
menghanli
7e8dd64ee4 Apply GlifPreferenceLayout for accessibility service Setup Wizard two-panel styles
Bug: 194447311
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilitySetupWizardUtilsTest
Change-Id: Icace09d12c0d2a82eb2591a55f6454f320172ec9
2021-10-05 10:09:04 +08:00
PETER LIANG
7260fe0330 Merge "Add the max height restriction into the illustration view." into sc-v2-dev am: 65faee72f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15809052

Change-Id: Id9e4ca6f0c53a8924b75c7c31120d9776f9469de
2021-09-28 05:58:52 +00:00
Peter_Liang
af5f355b35 Add the max height restriction into the illustration view.
Bug: 191721423
Test: manual test
Change-Id: I3829ead500eaf586f6d543855690ee8f0d0913ff
2021-09-24 14:42:53 +08:00
Jason Hsu
da247a3042 Merge "Support ability to add different page id for different accessibility service page in settings." into sc-v2-dev am: 768722fed4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15824482

Change-Id: I8d5053da73433f54491fe9e32f822757d09057ef
2021-09-23 07:12:16 +00:00
Jason Hsu
768722fed4 Merge "Support ability to add different page id for different accessibility service page in settings." into sc-v2-dev 2021-09-23 07:01:58 +00:00
jasonwshsu
3d0f12d043 Support ability to add different page id for different accessibility service page in settings.
Bug: 190344664
Test: build pass
Change-Id: I6cc90b27dcbb5075d13e3c59fe754309182b4d0a
2021-09-22 18:36:46 +08:00
Jason Hsu
22015ac5c5 Merge "Use the correct pageId for the existing accessibility page" into sc-v2-dev am: e9cea6a4aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15785738

Change-Id: Ib0fc4934d24e08086fa8fb50e86c302750d783d4
2021-09-21 10:16:36 +00:00
jasonwshsu
746f4d45f7 Use the correct pageId for the existing accessibility page
* correct page id for "Accessibility timeout" and "Select to Speak"

Bug: 190344664
Test: build pass
Change-Id: I3f6b2c389c1ca77e4d3fca3601915caa7a9dd6f8
2021-09-20 19:29:27 +00:00
Menghan Li
355ae871b5 Merge "Fix null pointer issue of accesibility learn more button click event" into sc-v2-dev am: e8582f9c31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15678258

Change-Id: Ifc595fa8d33e5244b96d28ef17615e1955b20551
2021-09-01 06:28:24 +00:00
menghanli
d665ecb86d Fix null pointer issue of accesibility learn more button click event
Root cause: Some OEMs can not provide valid intent for help & feedback
Solution: Check the intent is vaild before show up the help strings

Bug: 197786797
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityFooterPreferenceControllerTest
Change-Id: I8103730ed48a343f7b72c16647f7e8047aee34b2
2021-08-31 16:35:44 +08:00
PETER LIANG
c3b01abe59 Merge "Correct the position of the marker for audio adjustment." into sc-v2-dev am: 810ab566e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15611717

Change-Id: I75845cabf350a69a15bd1e9b99b1726b0a815bc8
2021-08-30 09:57:30 +00:00
PETER LIANG
810ab566e7 Merge "Correct the position of the marker for audio adjustment." into sc-v2-dev 2021-08-30 09:55:35 +00:00
Peter_Liang
ba297dc396 Correct the position of the marker for audio adjustment.
Root cause: Miss one the layout padding condition for computing the position of the marker.
Solution: add the layout padding condition into.

Bug: 196980036
Test: make RunSettingsRoboTests ROBOTEST_FILTER=BalanceSeekBarTest ROBOTEST_FILTER=BalanceSeekBarPreferenceTest
Change-Id: Id0c6ebbc981d9ef41e7956ffff1fc5b9d4c0e787
2021-08-30 07:16:35 +00:00
Menghan Li
2fa8b94643 Merge "[Material Next] Accessibility gesture tutorial dialog" into sc-v2-dev am: f7db8d7ee4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15501580

Change-Id: Ic1643d4bd000405d45d87dab6fea35402ec5041a
2021-08-20 21:40:35 +00:00
menghanli
5af9c64110 [Material Next] Accessibility gesture tutorial dialog
Problem: The dialog does not follow the Material Next guideline
Proposal:
1. Apply the dynamic color by removing SettingsTutorialDialogWrapperActivity which set extra theme
2. Hanlde the recreate case if shows the dialog directly
3. Update new Illustration in Pixel Lottie asset

Bug: 195980595
Test: Manual test
Change-Id: Ib6267128bbe5522ac8720c15fc2720c9a78f8671
2021-08-18 11:22:08 +08:00
PETER LIANG
976b30afe3 Merge changes I57306532,I1fba7ee1 into sc-v2-dev am: 4cddfd2b00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15478953

Change-Id: I6eee350feacecdb9d4bc83f6e297ac4c374c89e5
2021-08-17 03:12:08 +00:00
Peter_Liang
192dfdec7f Update the instruction images in Accessibility tutorial dialog.
1. Update the material next style.
2. Support for Lottie image.

Bug: 195094388
Test: manual test
Change-Id: I57306532b10e91c927bdc1ef5e115f41bc7a939b
2021-08-16 16:20:01 +08:00
Peter_Liang
c2a04e3820 Update the instruction images in Accessibility edit shortcut dialog.
1. Update the material next style.
2. Support for Lottie image.

Bug: 195094388
Test: manual test
Change-Id: I1fba7ee1d18b53f4c917319d2c0a4a304de0ae43
2021-08-16 15:36:32 +08:00
Jason Hsu
02990f7470 Merge "Update the preview image in 'Accessibility button & gesture' page." into sc-v2-dev am: f38931fd98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15401732

Change-Id: I8e2444b9cb74262298dd290adeaf783198901cb1
2021-08-02 06:30:11 +00:00
jasonwshsu
9ccb9f56ca Update the preview image in 'Accessibility button & gesture' page.
* Put images in drawable/ and drawable-night/

Fix: 193081959
Fix: 193081959
Test: atest AccessibilityButtonPreviewPreferenceControllerTest
Change-Id: If0700e285920686cea6a815877af71fe6652d711
2021-07-29 17:39:17 +08:00
TreeHugger Robot
73aa50eca6 Merge "Update accesibility button to suuport accessibility gesutre" into sc-v2-dev am: bd41311025
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15085892

Change-Id: I2885e26d6ee4f7e323bf4eccd4f3fa27b608ac70
2021-07-22 19:12:07 +00:00
TreeHugger Robot
4978a2ed2f Merge "Add back the shortcut dialog content for accessibility gesture" into sc-v2-dev am: b1bdec314a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15085455

Change-Id: If9e22c7fa4381b0e0f96e193482f65ff6391fb73
2021-07-22 19:12:05 +00:00