Commit Graph

30781 Commits

Author SHA1 Message Date
PETER LIANG
c9be2d385c Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev am: a83a8e29c3
Change-Id: I888e91c98097372c041a073cafffc5fe2df6bab3
2020-04-22 12:02:02 +00:00
PETER LIANG
a83a8e29c3 Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev 2020-04-22 11:42:27 +00:00
Bonian Chen
2538b62bea Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev am: a4efeb7a0a
Change-Id: I66ef842df28850e193ce81756b2b8a75e6bef27c
2020-04-22 10:25:59 +00:00
Bonian Chen
a4efeb7a0a Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev 2020-04-22 10:12:24 +00:00
Bonian Chen
b17c7f9606 Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 7db5840dfe
Change-Id: I4880420c6d6b539662ea2f7e557184058d6c633f
2020-04-22 07:45:43 +00:00
TreeHugger Robot
11f9c5bcf8 Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev am: 766e060c75
Change-Id: I80a5a31ce703e0ed8d42c280eeff23763df65f0c
2020-04-22 07:45:36 +00:00
Bonian Chen
78b9a0c406 Merge "[Settings] To avoid from crash when callback" into rvc-dev am: af05f6303d
Change-Id: Id17529753ddc58ba458c952f455dac8ef4e896ce
2020-04-22 07:44:32 +00:00
Bonian Chen
7db5840dfe Merge "[Settings] Mobile data usage code refactor" into rvc-dev 2020-04-22 07:17:22 +00:00
TreeHugger Robot
766e060c75 Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev 2020-04-22 07:16:42 +00:00
Bonian Chen
af05f6303d Merge "[Settings] To avoid from crash when callback" into rvc-dev 2020-04-22 07:00:12 +00:00
Jason Chiu
2fee6f3d1e Merge "Fix the incorrect title of Panel" into rvc-dev am: 1f91111c3a
Change-Id: I4e7cbf75be6aca6a3573c42c32c27d7338d6b677
2020-04-22 06:46:45 +00:00
Jason Chiu
1f91111c3a Merge "Fix the incorrect title of Panel" into rvc-dev 2020-04-22 06:30:12 +00:00
Jason Chiu
4bbc85eb54 Fix the incorrect title of Panel
Since panel activity is singleInstance, a newer panel will reuse the
same fragment as the previous panel when they are displayed one after
another.

Panel fragment has two kinds of exclusive header layout which shouldn't
be showed at the same time, so we have to reset their visible states
when creating panel content.

Fixes: 154668079
Test: robotest
Change-Id: I701a7cde4b43322fbc63ae1cb74c41dd23b37c0c
2020-04-22 06:29:57 +00:00
Tim Peng
55ce33fbe7 Incorrect checkbox icon in dynamic group panel
-Mutate icon to prevent modifying the original resource

Bug: 154673054
Test: build pass
Change-Id: I0e1a6506cb951f80f316649d27c7728132c05be6
2020-04-22 13:50:46 +08:00
TreeHugger Robot
6bb86dc6ea Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev am: d2291d447e
Change-Id: I03245f81a8e5d9be4d369d8b673791b1940956ce
2020-04-22 05:31:20 +00:00
TreeHugger Robot
d2291d447e Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev 2020-04-22 05:18:34 +00:00
Bonian Chen
6ea4727eb4 [Settings] Mobile data usage code refactor
Code refactor

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: If85207ebe2edb8c547bb6dac0c55bbd146b62361
2020-04-22 13:13:33 +08:00
Bonian Chen
63cf333e34 Merge "[Settings] Fix DataUsageSummaryPreferenceControllerTest" into rvc-dev am: 8f26e88bd9
Change-Id: I6e50d38fe30bc09a2f52fc89b08ad6f955d6de86
2020-04-22 04:40:43 +00:00
Bonian Chen
1a8d501d7d [Settings] Adopt TelephonyBasePreferenceController to data usage
Adopt TelephonyBasePreferenceController in order to better support DSDS.

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I502b93f01b289b72989ad3167131cc0c598b1583
2020-04-22 12:38:11 +08:00
Bonian Chen
8f26e88bd9 Merge "[Settings] Fix DataUsageSummaryPreferenceControllerTest" into rvc-dev 2020-04-22 04:27:43 +00:00
Zhen Zhang
274a4006e1 Merge "Add ethernet tether option into AllInOneTetherSettings" into rvc-dev am: 92340eb89e
Change-Id: Ia473326843cbc08ecdfde45887a9c0618d08d4d1
2020-04-22 03:05:45 +00:00
Zhen Zhang
92340eb89e Merge "Add ethernet tether option into AllInOneTetherSettings" into rvc-dev 2020-04-22 02:52:58 +00:00
Bonian Chen
61b9714a34 [Settings] Fix DataUsageSummaryPreferenceControllerTest
Fix test case of DataUsageSummaryPreferenceControllerTest

Bug: 154562264
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I0b3366c86b0a621b9dda88bbcde6e118d37995b7
2020-04-22 10:39:42 +08:00
tim peng
2cbd7526fc Merge "The volume slider should not show for the unselected device" into rvc-dev am: 24205d4632
Change-Id: I68dcbd00f3a24c568baeb4c28ffd2e14bcb38c5f
2020-04-22 01:18:39 +00:00
tim peng
24205d4632 Merge "The volume slider should not show for the unselected device" into rvc-dev 2020-04-22 01:00:33 +00:00
TreeHugger Robot
8f474aa504 Merge "Notification history a11y fixes" into rvc-dev am: f11da4c787
Change-Id: Id03d0c217ecc9b49e343f65f0f808efc863546dd
2020-04-21 21:36:58 +00:00
TreeHugger Robot
f11da4c787 Merge "Notification history a11y fixes" into rvc-dev 2020-04-21 21:22:44 +00:00
Beverly
4922aa006a Notification history a11y fixes
- When clicking the expand/collapse button to see the posted
notifications from an app in the last 24 hours, refocus accessibility on
the button so the entire button (contentDescription + clickability) are
announced. Previously only the contentDescription update was being
announced.

- Fix local context menu of NotificationHistory elements by calling the
super method in performAccessibilityAction

Test: manual
Fixes: 153396313
Fixes: 153518629
Change-Id: I3d847ec1f2b72dcf411c6c7c7fe2dc061ccfde26
2020-04-21 14:54:45 -04:00
Pavel Grafov
7e9e73f874 Merge "Stop disabling wifi toggle when tethering is restricted" into rvc-dev am: 9341983324
Change-Id: I63178cae69a422737962e49acec2a40551bebd33
2020-04-21 11:25:00 +00:00
Jason Hsu
dc52900d71 Merge "Show default description only if description and html description are empty" into rvc-dev am: 0055a74794
Change-Id: I2b56250fc1d5806498692dcf9ecae1a2fe2ebd98
2020-04-21 11:16:20 +00:00
Yanting Yang
bfe16291a3 Fix breadcrumb of search results provided by Settings
Settings Search need Settings to provide custom site map pairs to
build up full breadcrumb for the search results from Gesture Settings
page.

Bug: 147851992
Bug: 151206664
Test: visual and robotests
Change-Id: I4a61e6da48755184954c2c90834578030ffc2e10
2020-04-21 19:11:45 +08:00
Pavel Grafov
9341983324 Merge "Stop disabling wifi toggle when tethering is restricted" into rvc-dev 2020-04-21 10:40:12 +00:00
TreeHugger Robot
79c9bdb2d0 Merge "[Wi-Fi] Show not show Wi-Fi edit UI for never connected open Wi-Fi networks" into rvc-dev am: 8a80769a7e
Change-Id: I0cbd5dbf8962728e6086240b5d7136f02b48ac17
2020-04-21 09:41:41 +00:00
Jason Hsu
0055a74794 Merge "Show default description only if description and html description are empty" into rvc-dev 2020-04-21 09:41:15 +00:00
TreeHugger Robot
8a80769a7e Merge "[Wi-Fi] Show not show Wi-Fi edit UI for never connected open Wi-Fi networks" into rvc-dev 2020-04-21 09:20:52 +00:00
Tim Peng
e94de7fbb2 The volume slider should not show for the unselected device
-Design changes

Bug: 154555379
Test: Manual test
Change-Id: Icb127867911bc4bba0b77ce374332451b23f1215
2020-04-21 09:10:02 +00:00
Bonian Chen
67ff594c29 Merge "[Settings] Refactor test case DataUsageSummaryPreferenceControllerTest" into rvc-dev am: 6fb4a18ded
Change-Id: I2b7f27f9a9c9e461c8ec64d241a7ccfe062fbc0f
2020-04-21 08:56:44 +00:00
Alex Johnston
cff2c22eb8 Merge "Update Wi-Fi configs restrictions" into rvc-dev am: 56f06c59a1
Change-Id: I5776862d5a425e2137e390c055c714f32dc25fa5
2020-04-21 08:56:36 +00:00
Bonian Chen
6fb4a18ded Merge "[Settings] Refactor test case DataUsageSummaryPreferenceControllerTest" into rvc-dev 2020-04-21 08:48:36 +00:00
Alex Johnston
56f06c59a1 Merge "Update Wi-Fi configs restrictions" into rvc-dev 2020-04-21 08:41:10 +00:00
Bonian Chen
0987923594 Merge "[Settings] Code refactor" into rvc-dev am: 5bc8aa7961
Change-Id: Ibed580769fc846df8d3f6c6d58df8668bff34378
2020-04-21 08:25:04 +00:00
Bonian Chen
5bc8aa7961 Merge "[Settings] Code refactor" into rvc-dev 2020-04-21 08:21:28 +00:00
Bonian Chen
05a2603d55 Merge "[Settings] Support of DSDS API" into rvc-dev am: 57c2df4c7c
Change-Id: I09ceb36bc6c8e73737bdb72c7bcc65080181b7ed
2020-04-21 08:18:04 +00:00
Arc Wang
205b585cf3 [Wi-Fi] Show not show Wi-Fi edit UI for never connected open Wi-Fi networks
When users click a Wi-Fi network and it's
WifiConfiguration.getNetworkSelectionStatus().hasEverConnected()
is false, WifiSettings2 will launch the Wi-Fi edit UI for users
to edit password again.
It's not necessary to show the Wi-Fi edit UI if the Wi-Fi network
is a open network.

Bug: 154548505
Test: manual
      Click a never connected secure Wi-Fi and edit UI shows.
      Click a never connected open Wi-Fi and edit UI does not show.
Change-Id: Ie8489aff001942f92fbfaafd772f84b1b4a09cf4
2020-04-21 16:04:03 +08:00
Bonian Chen
57c2df4c7c Merge "[Settings] Support of DSDS API" into rvc-dev 2020-04-21 07:55:07 +00:00
Bonian Chen
dcef423720 [Settings] Refactor test case DataUsageSummaryPreferenceControllerTest
Refactor test case of DataUsageSummaryPreferenceControllerTest

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: Ieb551a32d87c53cbd0765e19e710f1f0469da9d5
2020-04-21 15:08:27 +08:00
Bonian Chen
0f47147543 [Settings] To avoid from crash when callback
Callback from SubscriptionManager and PhoneStateListner may comes in
under the case of Preference not available.

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
Change-Id: I50b83b4488d272f6482bde5f09b57d59e6fc27a3
2020-04-21 15:02:14 +08:00
Xiangyu/Malcolm Chen
9df4b0ce58 Merge "Define a helper link for 5G limitation in DSDS footer." into rvc-dev am: eb27c7d94a
Change-Id: I1a56d11a7c96f970fe1b0fe929e47f165ac1df29
2020-04-21 07:00:43 +00:00
Bonian Chen
7fdf4b50b1 Merge "[Settings] Avoid from EUICC access blocking main thread" into rvc-dev am: 7606dfd931
Change-Id: Ia7987b7418b430b0ae85b3340f29c2b52689f7eb
2020-04-21 07:00:34 +00:00
Xiangyu/Malcolm Chen
eb27c7d94a Merge "Define a helper link for 5G limitation in DSDS footer." into rvc-dev 2020-04-21 06:47:18 +00:00