Commit Graph

3095 Commits

Author SHA1 Message Date
Samuel Huang
ba03a22317 Avoid SIM card on/off dialog pop-up if satellite is enabled am: f2ed0ec752
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26847152

Change-Id: Ifb4f85972f29370d51a8c6363fa8efd63e6dead5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-11 07:36:48 +00:00
Samuel Huang
f2ed0ec752 Avoid SIM card on/off dialog pop-up if satellite is enabled
In order to support Satellite SOS, device will have two modems, one for TN, one for NTN(satellite).

When device switches to satellite mode, PSS only disables TN eSIM (and not TN PSIM). Since NTN image only supports eSIM, there is no need to disable TN PSIM before switching to NTN image. Somehow device is seeing that TN PSIM is available and is showing the user to enable it. So we need to handle it by not showing this dialog during satellite mode enabled.

Bug: 330585109
Test: atest, manual
Change-Id: I9781b7e1cef8f7f10e7ecdbb23ca729da4d06eba
2024-04-11 05:20:53 +00:00
songferngwang
77c89803ee After rotating the screen, lost the progress bar dialog state
Fix: 333646302
Fix: 333645488
Test: build pass. manually verify the UI
Change-Id: Ib68de902526ccb77bf19cbace4c596b1ecedaea5
2024-04-10 08:22:54 +00:00
tomhsu
6f27b8bca7 Fixs user input nothing, but save it successfully
- If user inputs nothing, do nothing for this action.

fix: 333642116
Test: Manual test
Change-Id: I66213f5d5c47d2b85d3849c95e7cf076e249420e
2024-04-10 06:50:05 +00:00
Tom Hsu
de9a888469 Merge "Listen wifi entry change to make sure UI correct." into main 2024-04-09 09:16:42 +00:00
Treehugger Robot
0f33518068 Merge "Add flag to control Internet preference" into main 2024-04-09 08:22:57 +00:00
tomhsu
91bcc2b594 Listen wifi entry change to make sure UI correct.
Bug: 319905522
Test: make pass.
Test: atest pass.
Change-Id: I0900caf6521bd9a250e85863f48e39668734f1be
2024-04-09 08:05:32 +00:00
Treehugger Robot
d5e69fa0ea Merge "Fix SMS and Calls preference summary displays empty." into main am: 3bfb35c71e am: a72f3f4ecc
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3019410

Change-Id: I5c8ba3dc44ebe526ffd02ffbb0ef3a830a08b7d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-09 04:35:47 +00:00
Rafael Higuera Silva
22b3304bf8 Merge "Add logic to log interaction of RAC warning dialog." into main 2024-04-08 21:23:37 +00:00
Rafael Higuera Silva
ea0453e5f6 Add logic to log interaction of RAC warning dialog.
Bug: 326618987
Test: make, atest EuiccRacConnectivityDialogFragmentTest
Change-Id: Iccec9245da27d525cfb3d74504ab86859e152a6e
2024-04-08 18:27:14 +00:00
Chaohui Wang
bae147bab3 Close ApnSettings when subscription not enabled
Including the case that physical sim is removed.

Fix: 332885481
Test: manual - on ApnSettings
Change-Id: I9bc77f995b6c1e98046a84fafb05f9b61d71ce70
2024-04-07 15:57:53 +08:00
Rafael Higuera Silva
f6e0b08fc6 Merge "Add new warning dialogue when user is Resetting mobile network settings." into 24D1-dev 2024-04-05 23:43:02 +00:00
Rafael Higuera Silva
363535192d Add new warning dialogue when user is Resetting mobile network settings.
If the user is reseting mobile network settings and have all these
conditions:
- No Wi-fi
- Has check to delete all eSIMs
- Has a least one RAC sim carrier
Then show the warning dialogue.

Test: make, manually test, atest SubSettingLauncherTest, atest ResetNetworkTest,  atest SubscriptionUtilTest
Bug: 328649510
Merged-In: I47d9b868b649b259d5e4008ec742317d2cb7cf51
Change-Id: I47d9b868b649b259d5e4008ec742317d2cb7cf51
(cherry picked from commit 147cc19b53)
2024-04-05 21:39:13 +00:00
Rafael Higuera Silva
fd27947e6f Merge "Add logic to log interaction of RAC warning dialog." into main 2024-04-04 22:47:12 +00:00
Rafael Higuera Silva
33f5050526 Add logic to log interaction of RAC warning dialog.
Bug: 326618987
Test: make, atest EuiccRacConnectivityDialogActivityTest
Change-Id: If4e3285b3715e9630d4932d4bf1bcb71e4167cff
2024-04-04 16:45:07 +00:00
David Jacobo
0e9c157c36 Add flag to control Internet preference
This CL adds a flag named config_show_internet_settings so access to
Internet preference can be easily customized as Wi-fi preference was in
the past, this level of customization was lost when Internet preference
was introduced here ag/13053253.

Bug: 271203982
Test: make -j32 Settings
Test: atest -c InternetPreferenceControllerTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0af54a1d3cfa26ba5f23b5d8c74ade2bb582f76f)
Merged-In: Iaf9a18f9389be089304d11bd3206d6917ab85124

Change-Id: Iaf9a18f9389be089304d11bd3206d6917ab85124
2024-04-03 15:46:29 -07:00
Chaohui Wang
51a4bea7d9 Use SpaDialogWindowTypeActivity for WEP dialog
TODO: Set different window type when called from Quick Settings.

Bug: 332643450
Test: am start -n com.android.settings/.network.WepNetworkDialogActivity
Change-Id: Ie888e7cc116234199316b030fb5f35dea6dbb3ac
2024-04-03 15:26:26 +08:00
Hakjun Choi
0c2927a234 Merge "Make satellite more info url carrier configurable" into 24D1-dev am: df0ea6c723
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26684988

Change-Id: I274e82a7cd279625ceb9ddda8442bbaf3d746ffc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-02 23:19:43 +00:00
Hakjun Choi
df0ea6c723 Merge "Make satellite more info url carrier configurable" into 24D1-dev 2024-04-02 23:03:24 +00:00
Rafael Higuera Silva
1bf1b02c31 Merge "Add new warning dialogue when user is Resetting mobile network settings." into main 2024-04-02 16:26:20 +00:00
Treehugger Robot
a9f137842a Merge "Fix MobileNetworkSettings kotlin.UninitializedPropertyAccessException" into main 2024-04-02 12:12:11 +00:00
songferngwang
34cec1389e Fix MobileNetworkSettings kotlin.UninitializedPropertyAccessException
Bug: 332477183
Test: atest MmsMessagePreferenceControllerTest

Change-Id: I849ca0f333f5246d73192ae4180b3f3ce3946d61
2024-04-02 10:18:03 +00:00
Rafael Higuera Silva
147cc19b53 Add new warning dialogue when user is Resetting mobile network settings.
If the user is reseting mobile network settings and have all these
conditions:
- No Wi-fi
- Has check to delete all eSIMs
- Has a least one RAC sim carrier
Then show the warning dialogue.

Test: make, manually test, atest SubSettingLauncherTest, atest ResetNetworkTest,  atest SubscriptionUtilTest
Bug: 328649510
Change-Id: I47d9b868b649b259d5e4008ec742317d2cb7cf51
2024-04-01 23:07:05 +00:00
Treehugger Robot
214646a032 Merge "Add new dialogue when user is going to delete multiple sims where aleast on of them use RAC." into 24D1-dev 2024-04-01 21:56:24 +00:00
hoffc
27255b7a7c Fix SMS and Calls preference summary displays empty.
SMS and Calls preference summary set to summary_placeholder in displayPreference's every call. But displayPreference can be called multiple times, so it may result in SMS and Calls preference summary displays empty when refreshSummary is not explicitly called after displayPreference's last call.

Move the summary placeholder setting to layout xml.

Bug: 331874741
Change-Id: I4c6f34dd813fa9a6d7e2c4df2cac279679ee6960
2024-04-01 14:08:28 +08:00
Chaohui Wang
333c309742 Align PreSelectedTypes with Android U
The Android U pre selected types:
default,mms,supl,dun,hipri,fota,cbs,xcap

Fix: 331875869
Test: manual - on ApnSettings
Test: unit test
Change-Id: I60c9a1a68af1b78825b9f08338b6001f99699414
2024-04-01 11:50:35 +08:00
SongFerng Wang
fd6ae421fd Merge "Add log for setDataEnabledForReason" into main 2024-03-30 15:37:14 +00:00
songferngwang
be3008e09d Add log for setDataEnabledForReason
To know who change the mobile data

Bug: 331843727
Test: NA Adding log only
Change-Id: I3ef5662102761541cd3e0e4662e0acab07c71937
2024-03-29 09:06:34 +00:00
Jason Chiu
0b61e93459 Merge "[Safer intents] Connectivity" into main 2024-03-29 01:11:06 +00:00
Hakjun Choi
3c54876db7 Make satellite more info url carrier configurable
guidance url link are vary per each carrier, therefore makes it carrier configurable

Bug: 330948681
Test: manually test whether URL works as intended on pixel with TMO/SKT SIM
Change-Id: I062b1e9267c6edf3289d85dc58f9ab2d9cff64d8
2024-03-28 23:24:14 +00:00
Hakjun Choi
748e0d5db9 Merge "Add carrier satellite feature flag into filter out logic in Settings" into 24D1-dev am: e479584d52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26720047

Change-Id: Idd987b67733e17de46ec76001cf52bc0cf2bf5e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 20:14:30 +00:00
SongFerng Wang
f1c9cb8fec Merge "Fix the primary sim setup after the psim enabled" into main 2024-03-27 09:00:38 +00:00
Hakjun Choi
7a4d0284cc Add carrier satellite feature flag into filter out logic in Settings
Null object reference exception happend when carrier satellite feature is disabled. whille filtering out satellite plmns from scanned plmns

Bug: 331182758
Test: atest NetworkSelectSettingsTest, manually test with feature enabled/disabled on pixel
Change-Id: I394e86ee9c26efdc9920006e0b8ca015500d5162
2024-03-27 00:23:03 +00:00
songferngwang
b6424f9146 Fix the primary sim setup after the psim enabled
The psim is not loaded, the active subscriptionInfo is not changed

Bug: 329031686
Test: verify 10 times  passed.
Change-Id: Idf70aaac8571af8501becb94689f4ae447e8771d
2024-03-26 16:54:04 +00:00
Jason Chiu
c53a73ef70 [Safer intents] Connectivity
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: I44ff8a789d933f11ba7e68e52055575245276224
2024-03-26 16:44:48 +08:00
SongFerng Wang
bf210b9834 Merge "Replace the bottomsheet with dialog" into main 2024-03-26 03:50:09 +00:00
Chaohui Wang
1ea5a786e2 Set Default APN radio button's size to 48dp
Which is the minimum tap size.

Also set ApnPreference not selectable, since itspPrimary target and
radio button could be selectable, but entire preference itself is not
selectable.

Fix: 330812055
Fix: 330290274
Test: manual - with APNs
Change-Id: I651642e8a275932be6b8bcb365198e5dc1ad92f8
2024-03-25 12:23:33 +00:00
songferngwang
0dbe979994 Replace the bottomsheet with dialog
using the dialog and update the string

Bug: 330097568
Test: verify the UI

Change-Id: I4c9a21fc74e608e08db334053d4e5bfb57abce70
2024-03-25 10:08:40 +00:00
Tom Hsu
2625ca4e7d Merge "Settings: Fix force close for telephony callback exceeding limitation" into main am: 380a136e50 am: bca026c182
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2995004

Change-Id: I2c15c609239927bd2a87da19c99c8f3ee34e9a63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-25 07:14:10 +00:00
Rafael Higuera Silva
496075f1be Add new dialogue when user is going to delete multiple sims where aleast on of them use RAC.
Test: make, manually test, atest com.android.settings.network, atest SubscriptionUtilTest
Bug: 328649505
Change-Id: I0c6fb7b5407179ec6850ece47f486b64759e2d1c
(cherry picked from commit 9ac44b3aae)
2024-03-24 23:46:53 +00:00
Yomna Nasser
fe82ebc310 Merge "Guard CellularSecurityPreferenceController with FEATURE_TELEPHONY" into main 2024-03-22 13:41:59 +00:00
Jonas Larsson
4b2d4ae984 Guard CellularSecurityPreferenceController with FEATURE_TELEPHONY
TelephonyManager is only available if
Packagemanager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY)
returns true. If false we should return UNSUPPORTED_ON_DEVICE.

Bug: 330726177
Test: m & manual
Change-Id: I1c2a1cb1f61b58f448ef207b2391dd9c262f6848
2024-03-21 17:14:56 +00:00
hoffc
ef2e171b50 Settings: Fix force close for telephony callback exceeding limitation
When sub info changed, new telephony callback will be registered but old telephony callback not un-registered. Finally result in force close for registered telephony callback count exceeding its allowed.

No need to re-registered the telephony callback for one sub if registered.

Bug: 328716180

Change-Id: Ia0c3b311b5b5cc77f061d81ec21250abde2fa9f4
2024-03-21 17:32:13 +08:00
Chaohui Wang
54b03da369 Fix readOnlyApnFields not applied
Some enabled not set correctly.

Remove the enabled values, and check readOnlyApnFields directly to fix.

Fix: 330566517
Test: manual with carrier config KEY_READ_ONLY_APN_FIELDS_STRING_ARRAY
Test: unit test
Change-Id: Ifd6d4a0d9a96a900c9d124c9e357562e84bbc6c7
2024-03-21 16:32:38 +08:00
tomhsu
55899976e9 Fix concurrent issue
- Add a thread lock

Fix: 286495550
Test: make pass
Change-Id: I72877551bda18cf93734d270770a0bd53bab465b
2024-03-20 08:29:43 +00:00
Treehugger Robot
937693d538 Merge "Add new Cellular Network Security page" into main 2024-03-19 16:15:32 +00:00
Chaohui Wang
732636cbd5 Merge "Refactor AutomaticDataSwitchingPreference" into main 2024-03-19 11:14:25 +00:00
Chaohui Wang
bfd8a517be Refactor AutomaticDataSwitchingPreference
Split into AutomaticDataSwitchingPreference.kt, and use
isMobileDataPolicyEnabledFlow.

Bug: 329061940
Test: manual - Set Automatic data switching
Test: unit test
Change-Id: I878ed70328307c0a5dba6dfb461ff5a85efbcf88
2024-03-19 14:17:20 +08:00
Chaohui Wang
a3507d535f Fix APN network type not updated
The issue is caused by SettingsDropdownCheckBox's interface is updated,
but ApnNetworkTypeCheckBox not updated.

Update ApnNetworkTypeCheckBox to fix.

Bug: 329547692
Test: manual - update network type
Test: unit test
Change-Id: I4a5a1ad7d9d97960799f5ba0d89b5178ce410b6e
2024-03-19 13:59:11 +08:00
yomna
5599de4fb5 Add new Cellular Network Security page
Test: m & atest CellularSecurityNotificationsDividerControllerTest CellularSecurityNotificationsPreferenceControllerTest CellularSecurityEncryptionDividerControllerTest CellularSecurityPreferenceControllerTest
Bug: b/318428717
Change-Id: I4a6ec5f47beb36bd455e04c2e6c4cea0ba65110f
2024-03-18 21:22:10 +00:00