Check for null activity when the handler receives messages to ensure
that the fragment is still attached to the activity.
Fixes: 31034901
Test: Manual - Manually try to update password, verify it works. Run
monkey test on settings package and verify no crash seen.
Change-Id: I9753729ee64458fa1bc25d78abc946d2563a5067
Bug: 30870531
Removing wifi preferences every time will force update create a new set
of preferences, which leads to higher chance of GC.
Change-Id: Ifea2f63a3b54fa0d5861fb34a348d81e99bcab68
Bug: 30870531
Removing wifi preferences every time will force update create a new set
of preferences, which leads to higher chance of GC.
Change-Id: Ifea2f63a3b54fa0d5861fb34a348d81e99bcab68
An async task was trying to get the context
in an InstrumentedFragment. This could return
null if the context disappears before the new
thread gets to that line. Logging will now
be aborted if context is null to avoid this.
Bug: 31058928
Change-Id: Iae97d389e58a76b0f213a2749415501894ebf649
inflating everything on creation of the screen. This will
improve the speed of opening the screen and refreshing screen upon
commiting change.
Test: Manually tested by interacting with ViewPager and SeekBar.
Bug: 30697309
Change-Id: Ieb2fac95696b8be33fd508f3b75741529b68e946
Top level preferences are handled in onClick. Returning true would
toggle the state of the switcher.
Test: Manually tested App & content access page
Bug: 30909943
Change-Id: I9487044aa67c20c9cb0e9bb9de8911f17e05d808
screen off.
Re-initialize the animation video if necessary when the preference is
visible to the user.
Fixes: 31023261
Test: manual -
1. Go to Settings -> Moves and verify that the animation video are
displayed correctly on load.
2. Press power button to turn screen off, then on again. Verify when
Moves settings resumes, the animation video is displayed correctly.
3. Repeat #2 above but let display time out instead of turning off
screen by power button.
Change-Id: I0ee21d23a4c402b3a8463dca3b36fce67d651993
This change ensures that when the user tries to toggle a sync for a
sync adapter that doesn't have access to an account we show UI for
the user to approve the sync.
bug:28163381
Change-Id: I59802df6614572cf0eaf4b72a177beb111b87b34
- Converted VisibilityLoggerMixin into a LifecyclerObservable so we
don't have to call logger.onResume/onPause manually in most fragments.
- Observable will be useful when we provide logics across all
fragment/activity, eg log lifecycle event latencies.
- Also added new tests for lifecycle component.
Bug: 30681529
Test: RunSettingsRoboTests
Change-Id: Ida39300aeb42f71b2e0bbfaebd0c51dc468cb5e8
The show/hide settings suggestions events are logged every time Settings
is shown. Save the logged events into the state bundle so that when the
fragment is resumed, it does not re-log the suggestions events.
Also move the logging for the show suggestion event to when the suggestion
is loaded, as the suggestions can be empty when the fragment starts.
Change-Id: I644ea0012bad309e59fed0d48171915c955779cc
Fixes: 30108142
Created a new controller for DataUsageInfo and add appropriate
unit tests.
Bug: 30946416
Change-Id: Ida1281a771013fd807242f846edb4f2a9c0ccabb
Test: Robolectric tests with target RunSettingsRoboTests
