Commit Graph

30163 Commits

Author SHA1 Message Date
Raff Tsai
a2e77a0e85 Fix no action in Settings storage
- Pass wrong user id in view holder

Fixes: 149028747
Test: 1. Add new user, and change th new user
      2. Take a camera shot under the new user
      3. go to Settings -> Storage -> photo & video -> Image
      4. Should open file brower

Change-Id: I0af532748ec19f62897911b1bb6ece9b21b844c3
2020-02-12 13:20:19 +08:00
Zhen Zhang
bb3ddcb602 Merge "Fix bug: Add some controllers to AllInOneTetherSettings Lifecycle" 2020-02-12 05:12:53 +00:00
timhypeng
716777d3ad Replace preference with remote media preference group in xml
-remove previous preference controller and its test cases
-update sound setting test case

Bug: 147395289
Test: make -j42 RunSettingsRoboTests
Change-Id: I9e383e11370a13868fdbcb76eafef5aedad895c5
2020-02-12 04:57:18 +00:00
Bonian Chen
d833301c25 Merge "[Settings] Avoid rendering hidden preferences" 2020-02-12 04:30:35 +00:00
TreeHugger Robot
579859082a Merge "Fix a11y issues in notification history" 2020-02-12 04:18:35 +00:00
TreeHugger Robot
9ccbadebab Merge "Rename GameDriver* to GraphicsDriver*." 2020-02-12 02:43:03 +00:00
Thomas Devaux
3f0b74cf84 Merge "Auto-open Captive Portal when user clicks on open network." 2020-02-12 02:37:58 +00:00
Stanley Wang
b53efae0ab Merge "Fix security issue for using mock location without permission." 2020-02-12 02:23:52 +00:00
TreeHugger Robot
5a5ca79af4 Merge "Link PACKAGE_USAGE_STATS with LOADER_USAGE_STATS" 2020-02-12 01:56:31 +00:00
Zhen Zhang
15ec99114d Update summary for WifiTetherDisablePreference accordingly
The summary of this preference is depenent on other two preferences for
USB tether and Bluetooth tether. The summary is updated accordingly.

Bug: 146818850
Test: CodeInspectionTest, WifiTetherDisablePreferenceControllerTest,
manually test.

Change-Id: I366d10a43814ea0d7def466b1976928f17875029
2020-02-11 17:48:21 -08:00
TreeHugger Robot
ff6e341509 Merge "Add remote media slice in volume panel" 2020-02-12 01:34:15 +00:00
Peiyong Lin
4e89f929d7 Rename GameDriver* to GraphicsDriver*.
To make graphics driver selection more generic, rename GameDriver
specific classes to GraphicsDriver.

Bug: b/148626177
Test: make RunSettingsRoboTests ROBOTEST_FILTER=GraphicsDriver
Change-Id: If2780b32e2826bda56de11734736260f916182d0
2020-02-11 16:50:26 -08:00
Yi Jiang
8cbebabad6 Merge "Moves Adaptive Sleep's settings from Settings.System to Settings.Secure" 2020-02-12 00:48:59 +00:00
Thomas Devaux
158d17fef6 Auto-open Captive Portal when user clicks on open network.
Rationale: many users are confused about what to do after tapping the captive
portal network in Settings, and since there is explicit user action to
connect to that network at that point, auto-opening the portal is
natural and makes it simpler.

Bug: 148538768
Test: manually with local AP with Captive Portal and:
> make RunSettingsRoboTests -j40
> atest com.android.server.ConnectivityServiceTest

Change-Id: I29573132cd3e46ff22e6f67bb3678516fabac47d
2020-02-12 00:45:46 +00:00
Zhen Zhang
aef1e8db96 Fix bug: Add some controllers to AllInOneTetherSettings Lifecycle
These controllers are not added to lifecycle as observers, which caused
the preferences are disabled persistently. Adding them explicitly can
fix the issue.

Bug: 149339076
Test: CodeInspectionTest, AllInOneTetherSettingsTest
Change-Id: Ia53e0845ed38f63a9a370488b028966d6a066889
2020-02-11 16:40:43 -08:00
Julia Reynolds
40f5402a32 Fix a11y issues in notification history
- crash at large display sizes/landscape
- no content description for expand buttons
- no call to action on tappable notification rows

Test: manual
Fixes: 149307144
Change-Id: I63f59de66d96a55c48852e4fbf79c87c7826076f
2020-02-12 00:24:09 +00:00
Joshua Imbriani
764e05ddfe Merge "Fixing TTS Settings crash on rotation caused by using deprecated API." 2020-02-12 00:09:29 +00:00
Zhen Zhang
2d7264eb75 Merge "Add tether preferences into AllInOneTetherSettings" 2020-02-11 23:34:55 +00:00
Julia Reynolds
a4798d0d36 Merge "Improve notification history" 2020-02-11 21:54:54 +00:00
TreeHugger Robot
7b036f36e1 Merge "Add a settings for notification history" 2020-02-11 20:50:18 +00:00
Julia Reynolds
24aac215f1 Improve notification history
- An on/off switch
- An on/off UI
- improve headers/dividers/layout
- add counts
- shrink recyclerviews to content

Fixes: 148698132
Bug: 137396965
Test: manual
Change-Id: I0b103769cffa446e32f05a6c5a39a614e024a083
2020-02-11 12:08:20 -05:00
Ben Murdoch
fa92269759 Revert "Revert "Show "Add users from lock screen" dependent on secure lock screen.""
And fix the failing test that caused the revert.

Bug: 148015798
Bug: 149209670
Test: make -j64 RunSettingsRoboTests

This reverts commit 666dacc32a.

Change-Id: I34bb82e621e009ec26c28835f309e7a5b996e9b3
2020-02-11 13:35:45 +00:00
Bonian Chen
1b9bda3b05 [Settings] Avoid rendering hidden preferences
Under dashboards with expand button, preferences are renderred even
not been expanded.
Avoid from rendering un-expanded preference can improve the performance
of dashboard display.

Bug: 141833767
Test: manual
Change-Id: I00c6f827a0b7b7cec6a6fd8c809b94ca1dce88bb
2020-02-11 20:52:31 +08:00
Bonian Chen
19135546a3 [Settings] Data roaming warning only when turn ON
handlePreferenceTreeClick() goes after setChecked() however
configuration may have been altered within setChecked().

Follow same design within MobileDataPreferenceController to fix this
issue. A boolean state will be maintained as the condition when warning
dialog is required when click.

Bug: 148491064
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=RoamingPreferenceControllerTest
Change-Id: I63c4e2149b0e9efa16fd9ee402652c67eb9c5a4d
2020-02-11 20:46:44 +08:00
Tsung-Mao Fang
8c4aacd354 Add a SaftyNet for security vulnerability
When we get an empty or null slice parameter,
we see it as a vulnerability. It will cause
null point exception.

Bug: 122836081
Test: See adb logcat event log
Change-Id: Id5ff11dd18b19184792be466aabb65229f777e81
2020-02-11 17:16:20 +08:00
Bonian Chen
040c548d81 Merge "[Settings] Access ProxySubscriptionManager within DataUsage" 2020-02-11 08:43:49 +00:00
Yanting Yang
f8396c5cc0 RESTRICT AUTOMERGE
Fix NPE of launching Settings with malicious URL

Add SafetyNet logging for tracing.

Fixes: 122836081
Test: visual, robotests
Change-Id: I97430ea0208c570c46a02dd499dfd944d20eb06e
2020-02-11 16:17:08 +08:00
Zhen Zhang
ec966cb7a3 Add tether preferences into AllInOneTetherSettings
These preferences are for user to toggle a specific tethering option,
like USB, BT or WIFI.

Bug: 147323306
Test: CodeInspectionTest, AllInOneTetherSettingsTest, TetherEnablerTest
Change-Id: I1229ffd2dd12b39e9c6e48dc29c6e46ce9ad7634
2020-02-10 23:04:37 -08:00
TreeHugger Robot
181ca05462 Merge "Fix incorrect UI issue of "previously connected devices"" 2020-02-11 06:43:02 +00:00
Stanley Wang
cdf4028142 Fix security issue for using mock location without permission.
Remove mock location apps if developer option is disabled.

Change-Id: Iad32ea336376eeb923f6d4424fd85c2da2bb5128
Bugs: 145136060
Test: manual
2020-02-11 14:33:34 +08:00
Bonian Chen
a1355d5b57 [Settings] Performance tuning for intent ACTION_ENHANCED_4G_LTE_CHANGED
Adjust the ordering of accessing to avoid the rule checks
isVoLteProvisioned() when not required.

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Change-Id: I8604a27d211895a6b33e0f6d0d78f5772912ee01
2020-02-11 13:36:37 +08:00
TreeHugger Robot
bc4981d25f Merge "Pass in active device to all BluetoothA2dp APIs in packages/apps/Settings as null input is no longer supported" 2020-02-11 02:36:51 +00:00
TreeHugger Robot
9368270fe2 Merge "Revert "Show "Add users from lock screen" dependent on secure lock screen."" 2020-02-11 02:07:24 +00:00
Jean Chen
770e121317 Merge "Support autoclick secondary action (3/n)" 2020-02-11 02:06:20 +00:00
Roshan Pius
93f6c463d6 Merge "Settings: Use new API for wifi wakeup feature toggle" 2020-02-11 00:36:17 +00:00
Jon Spivack
666dacc32a Revert "Show "Add users from lock screen" dependent on secure lock screen."
This reverts commit 0149363a39.

Reason for revert: Droidcop: Potential culprit for Bug 149209670- verifying through Forrest before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ia1f1ce35ef5d93664cf665bea86a472376b84aab
2020-02-10 22:11:57 +00:00
Daniel Bright
721467c679 Repoint ACTION_SECRET_CODE + ACTION_SIM_STATE_CHANGED
Bug: 148160428
Test: make, flash
Change-Id: I9404e2c3c816311c7ef3875622fe5cd5a315ec58
2020-02-10 12:59:26 -08:00
Rahul Sabnis
dcedd7d6f5 Pass in active device to all BluetoothA2dp APIs in
packages/apps/Settings as null input is no longer supported

Bug: 147287141
Test: Manual
Change-Id: If43934374914c657080ffd0509f8095d988cc550
2020-02-10 11:16:49 -08:00
Julia Reynolds
28bc10faba Add a settings for notification history
Test: atest
Bug: 137396965
Change-Id: Id575bd8ef34f977200384f95c0244cbbb073e027
2020-02-10 12:04:10 -05:00
Josh Imbriani
e77e22e208 Fixing TTS Settings crash on rotation caused by using deprecated API.
Test: manual - rotated phone while playing TTS
Fix: 145579714

Change-Id: I7232704c92ba8ec34769cf68afe2278e22532d86
2020-02-10 09:00:11 -08:00
Bonian Chen
dcd92af0a1 [Settings] Access ProxySubscriptionManager within DataUsage
Redirect some SubscriptionManager access to ProxySubscriptionManager.
This will reduce some access latency.

Bug: 141833767
Test: manual
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I2cb30dd0570a09543a13ca01cf054ba2d18d70d4
2020-02-10 23:49:53 +08:00
TreeHugger Robot
970d9167d2 Merge "Show "Add users from lock screen" dependent on secure lock screen." 2020-02-10 12:32:12 +00:00
TreeHugger Robot
2db8d1d88f Merge "Tweak summary for permission manager" 2020-02-10 12:13:32 +00:00
TreeHugger Robot
1ffd0fb163 Merge "Fix the overlap problem in the Schedule Rule page" 2020-02-10 11:34:26 +00:00
hughchen
9c9d5235e6 Add null check of MediaDevice
Add null check of MediaDevice to avoid some case it would be null.

Bug: 147856563
Test: manually
Change-Id: I86615bb58ccadb8d7741f612ba18afaa178bde6c
2020-02-10 19:19:54 +08:00
hughchen
76dcfdedf2 Fix incorrect UI issue of "previously connected devices"
This CL before, the bt device still showing on
"previously connected devices" after forgot that bt device.
It because the list of getMostRecentlyConnectedDevices()
will not include BOND_NONE device. We need to remove the
device that not include in list of getMostRecentlyConnectedDevices() .

This CL add removePreferenceIfNecessary() to check the device whether
is contained in getMostRecentlyConnectedDevices(). If not, remove the
preference.

Bug: 149193092
Test: make -j42 RunSettingsRoboTests
Change-Id: I94bedf222b64d9f05dc6f979b79dbc8794c0f97d
2020-02-10 19:16:56 +08:00
Tsung-Mao Fang
70238907dc Tweak summary for permission manager
Summary appends "and more" while the items of permission are larger
than 3.

Change-Id: Ic3c16404237fb0cb81f0ed5d2cbdff32cf23c452
Fix: 136258315
Test: Robo test and visual
2020-02-10 19:15:59 +08:00
Sunny Shao
10400a5654 Fix the overlap problem in the Schedule Rule page
Fixes: 149071676
Test: manual test
Change-Id: I5a090ddf12ad5c4c2f248b487bd55af64dbc2ae4
2020-02-10 18:24:34 +08:00
Narayan Kamath
50487c4595 Merge "Reland: Rework platform version to hide codenames." 2020-02-10 10:01:25 +00:00
TreeHugger Robot
d6f9b89061 Merge "tether setting: Remove dual mode check for band convert" 2020-02-10 09:06:57 +00:00