Commit Graph

3058 Commits

Author SHA1 Message Date
SongFerng Wang
bf210b9834 Merge "Replace the bottomsheet with dialog" into main 2024-03-26 03:50:09 +00:00
Chaohui Wang
1ea5a786e2 Set Default APN radio button's size to 48dp
Which is the minimum tap size.

Also set ApnPreference not selectable, since itspPrimary target and
radio button could be selectable, but entire preference itself is not
selectable.

Fix: 330812055
Fix: 330290274
Test: manual - with APNs
Change-Id: I651642e8a275932be6b8bcb365198e5dc1ad92f8
2024-03-25 12:23:33 +00:00
songferngwang
0dbe979994 Replace the bottomsheet with dialog
using the dialog and update the string

Bug: 330097568
Test: verify the UI

Change-Id: I4c9a21fc74e608e08db334053d4e5bfb57abce70
2024-03-25 10:08:40 +00:00
Tom Hsu
2625ca4e7d Merge "Settings: Fix force close for telephony callback exceeding limitation" into main am: 380a136e50 am: bca026c182
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2995004

Change-Id: I2c15c609239927bd2a87da19c99c8f3ee34e9a63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-25 07:14:10 +00:00
Yomna Nasser
fe82ebc310 Merge "Guard CellularSecurityPreferenceController with FEATURE_TELEPHONY" into main 2024-03-22 13:41:59 +00:00
Jonas Larsson
4b2d4ae984 Guard CellularSecurityPreferenceController with FEATURE_TELEPHONY
TelephonyManager is only available if
Packagemanager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY)
returns true. If false we should return UNSUPPORTED_ON_DEVICE.

Bug: 330726177
Test: m & manual
Change-Id: I1c2a1cb1f61b58f448ef207b2391dd9c262f6848
2024-03-21 17:14:56 +00:00
hoffc
ef2e171b50 Settings: Fix force close for telephony callback exceeding limitation
When sub info changed, new telephony callback will be registered but old telephony callback not un-registered. Finally result in force close for registered telephony callback count exceeding its allowed.

No need to re-registered the telephony callback for one sub if registered.

Bug: 328716180

Change-Id: Ia0c3b311b5b5cc77f061d81ec21250abde2fa9f4
2024-03-21 17:32:13 +08:00
Chaohui Wang
54b03da369 Fix readOnlyApnFields not applied
Some enabled not set correctly.

Remove the enabled values, and check readOnlyApnFields directly to fix.

Fix: 330566517
Test: manual with carrier config KEY_READ_ONLY_APN_FIELDS_STRING_ARRAY
Test: unit test
Change-Id: Ifd6d4a0d9a96a900c9d124c9e357562e84bbc6c7
2024-03-21 16:32:38 +08:00
tomhsu
55899976e9 Fix concurrent issue
- Add a thread lock

Fix: 286495550
Test: make pass
Change-Id: I72877551bda18cf93734d270770a0bd53bab465b
2024-03-20 08:29:43 +00:00
Treehugger Robot
937693d538 Merge "Add new Cellular Network Security page" into main 2024-03-19 16:15:32 +00:00
Chaohui Wang
732636cbd5 Merge "Refactor AutomaticDataSwitchingPreference" into main 2024-03-19 11:14:25 +00:00
Chaohui Wang
bfd8a517be Refactor AutomaticDataSwitchingPreference
Split into AutomaticDataSwitchingPreference.kt, and use
isMobileDataPolicyEnabledFlow.

Bug: 329061940
Test: manual - Set Automatic data switching
Test: unit test
Change-Id: I878ed70328307c0a5dba6dfb461ff5a85efbcf88
2024-03-19 14:17:20 +08:00
Chaohui Wang
a3507d535f Fix APN network type not updated
The issue is caused by SettingsDropdownCheckBox's interface is updated,
but ApnNetworkTypeCheckBox not updated.

Update ApnNetworkTypeCheckBox to fix.

Bug: 329547692
Test: manual - update network type
Test: unit test
Change-Id: I4a5a1ad7d9d97960799f5ba0d89b5178ce410b6e
2024-03-19 13:59:11 +08:00
yomna
5599de4fb5 Add new Cellular Network Security page
Test: m & atest CellularSecurityNotificationsDividerControllerTest CellularSecurityNotificationsPreferenceControllerTest CellularSecurityEncryptionDividerControllerTest CellularSecurityPreferenceControllerTest
Bug: b/318428717
Change-Id: I4a6ec5f47beb36bd455e04c2e6c4cea0ba65110f
2024-03-18 21:22:10 +00:00
Chaohui Wang
d85494bd0c Filter out empty phone number
Prevent flicker.

Bug: 318310357
Test: manual - on SIMs
Test: unit test
Change-Id: Ie44ec8bad58b59368099d0fe3f277c12855f8bd4
2024-03-14 17:42:34 +08:00
Chaohui Wang
4e56c7a273 Get NetworkRegistrationInfo on background thread
To fix ANR.

Fix: 322943652
Test: manual - on Network Selection
Test: unit test
Change-Id: I9cd7137542de007e5be2830b2ba1cbfaff8b2c05
2024-03-14 04:19:04 +00:00
songferngwang
e0b5de28ae Fix the settings crash
When the user select mobile network settings item with subid=-1 in
the search list, then some of objects are not initialized.

Bug: 325956182
Test: atest AutoSelectPreferenceControllerTest
atest MobileNetworkPhoneNumberPreferenceControllerTest
atest MobileNetworkSpnPreferenceControllerTest
atest MobileNetworkImeiPreferenceControllerTest
atest WifiCallingPreferenceControllerTest

Change-Id: I17c24b6f542392f018c65b689862f9735fad4b9f
2024-03-12 19:16:20 +00:00
Treehugger Robot
3c26c93bd5 Merge "Add new dialogue when user is going to delete multiple sims where aleast on of them use RAC." into main 2024-03-12 05:45:06 +00:00
Rafael Higuera Silva
9ac44b3aae Add new dialogue when user is going to delete multiple sims where aleast on of them use RAC.
Test: make, manually test, atest com.android.settings.network, atest SubscriptionUtilTest
Bug: 328649505
Change-Id: I0c6fb7b5407179ec6850ece47f486b64759e2d1c
2024-03-11 23:29:30 +00:00
Treehugger Robot
35b5d41db3 Merge "Fix crash on potentially missing EuiccManager" into main 2024-03-09 03:39:54 +00:00
Tomasz Wasilczyk
b27c9b507b Fix crash on potentially missing EuiccManager
Bug: 310710841
Test: it builds
Change-Id: I9d2c88091a34a4e4e118fd1bd8d95c724c52e77e
2024-03-08 18:41:25 +00:00
Chaohui Wang
25d68d845a Merge "Fix flicker of "App data usage"" into main 2024-03-08 02:54:39 +00:00
Chaohui Wang
186629aad4 Migrate the "Use this SIM" preference
This will fix the toggle flicker issue.

Fix: 262179656
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ided2445034a83a8efc11dc97bab8719686d63712
2024-03-07 17:48:09 +08:00
Chaohui Wang
74fe516e09 Fix flicker of "App data usage"
Use placeholder to hold the place.

Fix: 323466366
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I3c4d9ff6538a79500318869f01f4b88b55bd9475
2024-03-07 15:20:01 +08:00
Chaohui Wang
c038d58bef Merge "Sort the selectable subscription by id" into main 2024-03-07 06:40:34 +00:00
SongFerng Wang
eb80786be3 Merge "Add the mechanism of enable DSDS" into main 2024-03-07 04:33:37 +00:00
Chaohui Wang
ad611366df Sort the selectable subscription by id
To make sure users always see a fixed order.

Bug: 318310357
Test: manual - on SIMs and turn on / off SIM
Change-Id: I2910d83f5b1d04287afca0e3ba91dedbeb588c14
2024-03-07 11:23:25 +08:00
Chaohui Wang
bdfae3a3bf Merge "Create NetworkScanRepository" into main 2024-03-07 02:47:30 +00:00
songferngwang
2b5002ae6a Add the mechanism of enable DSDS
When the user click the "set up" on sim onboarding BottomSheet, settings
enable the DSDS mode and then start the sim onboarding flow

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: build pass and verify the UI flow
Change-Id: Ibd4fc2f482019f02738c3fedef7af7f4ef9b8e50
2024-03-06 23:01:48 +00:00
Chaohui Wang
d48cf866d8 Update the summary when Wi-Fi calling ready
Since the correct summary can only be got after Wi-Fi calling ready.

Fix: 325414275
Test: manual - on Mobile Settings
Change-Id: Ida94fd0a86f2130b9f0dded82fe18efd3ffc0c27
2024-03-06 12:44:22 +08:00
Chaohui Wang
4dbc23ca28 Create NetworkScanRepository
And migrate network scan to flow for better maintenance and prevent ANR.

Fix: 323105271
Test: manual - Choose network
Test: unit test
Change-Id: I5c49d195fc202143c0131ffd78bc3adc168b119c
2024-03-05 21:45:18 +08:00
SongFerng Wang
71c6c3e557 Merge changes I96574a79,I74681222 into main
* changes:
  Fix the testcase failed
  Add the log for SidecarFragment
2024-03-04 12:27:37 +00:00
Charlotte Lu
3b856490e8 Merge "Change WepNetworkDialogActivity exported="true"." into main 2024-03-04 10:15:53 +00:00
songferngwang
0d7d180246 Add the log for SidecarFragment
The system miss the SidecarFragment result, so the settings did not
active the esim.

Bug: 302505660
Test: NA
Change-Id: I746812220fed001eddc7d4aeeaf7aa0b04b86692
2024-03-04 10:10:30 +00:00
Chaohui Wang
c8edb018a4 Create phoneNumberFlow
Bug: 318310357
Test: manual - on Mobile Settings
Change-Id: Ib80b6c510ebd89650557240add23d914934ba6c9
2024-03-04 13:52:18 +08:00
Chaohui Wang
bec4c9573e Create isSubscriptionEnabledFlow
To better display the isEnable checked state.

Bug: 318310357
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ia595e7445650ad67883f1e7c1a0662cb826565ea
2024-03-02 05:01:28 +00:00
Rafael Higuera Silva
be1c70a85e Merge "Add new dialogue and RAC logic." into main 2024-02-29 17:32:46 +00:00
Hakjun Choi
4de688db35 Merge "Apply satellite feature flag to Settings activity" into main 2024-02-29 14:53:16 +00:00
SongFerng Wang
975e761659 Merge "Add the error dialogs" into main 2024-02-29 11:29:51 +00:00
SongFerng Wang
af5bbc5087 Merge "Modify the condition for hide Dds confirmed dialog" into main 2024-02-29 11:27:05 +00:00
songferngwang
a9695c40e7 Add the error dialogs
When system activate the sim faild, then it shows the error dialog

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: manual test, verify the error dialog UI
Change-Id: I90d7aa5d3f3ad36d949a505377466f8cdf63b6b4
2024-02-29 09:18:55 +00:00
Charlotte Lu
823e41ead2 Change WepNetworkDialogActivity exported="true".
Test: Visual Test
Fix: 327310887
Change-Id: Iecc2910eda75f3aad60f4a876b0e1d54d203cd74
2024-02-29 07:51:32 +00:00
songferngwang
b8d87d1add Modify the condition for hide Dds confirmed dialog
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: manual test and verify the UI.
Change-Id: I68df36b457ea7479cd6a561f9c2b3c968e14fe44
2024-02-29 07:07:24 +00:00
Hakjun Choi
b35faf0958 Apply satellite feature flag to Settings activity
Added carrier satellite condition to determine whether satellite settins menu should be exposed or not.
if carrier satellite feature is not enabled, satellite settings menu will not be shown

Bug: 327539253
Test: manual test with feature key disabled / enabled condition on pixel
Change-Id: I1abc84c2c47b48c0137274666da37bede10d2ae6
2024-02-29 06:33:53 +00:00
Chaohui Wang
e6ad7fc215 Fix Bottom Sheet not in dark theme
Bug: 318310357
Test: manual - on Mobile Settings
Change-Id: I539abdbb4a549decd7c24bcc87ec398a51046cf3
2024-02-29 14:12:41 +08:00
SongFerng Wang
f27877d155 Merge changes I0d3c2163,I5602713b,Ica2a26ea into main
* changes:
  Fix PrimarySim show the same sim in the preference list
  Start simOnboarding when active sim > 0
  [SimOnbarding] correct the sim name at the Primary Sim
2024-02-29 03:27:42 +00:00
songferngwang
bb7360b148 Fix PrimarySim show the same sim in the preference list
Bug: 327425969
Test: manual test, verify the UI
Change-Id: I0d3c2163a43a00ec0e4e627b34281e95cc611751
2024-02-28 22:05:35 +00:00
songferngwang
09603308d4 Start simOnboarding when active sim > 0
If active sim = 0, using old way
If active sim > 0, using sim onboarding

Bug: 324353868
Test: manual test
Change-Id: I5602713b5f4fef0625338787ee0682257e12e34f
2024-02-28 21:23:14 +00:00
Rafael Higuera Silva
48fee33ea2 Add new dialogue and RAC logic.
A new dialogue will pop up if the eSIM that is being deleted has carrier
Vodafone DE and does not have wifi connection or connection from another
sim.

Test: make, atest SubscriptionUtilTest and tested manually
Bug: 316419093
Change-Id: I957b67339a0ab651f38984e7d1061a8aff8fe2a1
2024-02-28 19:47:22 +00:00
songferngwang
e83d8b22bc [SimOnbarding] correct the sim name at the Primary Sim
The user can modify the name at Label sim page. The primary sim page
should show the name which is modified by the user.

Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: manual test and verify the UI display the correct name.
Change-Id: Ica2a26ead4ec7d61a59bb3846ea07f278d7a1144
2024-02-28 19:00:39 +00:00