Commit Graph

772 Commits

Author SHA1 Message Date
Jeff Sharkey
ade52ca806 Shift storage wizards over to Glif theme.
This matches new UX best-practices, and allows us to remove some
special one-off hacks.

Test: visual
Bug: 70894690
Change-Id: I2705c731277cae7f19bce78a0a2a023ad0777b83
2017-12-20 13:29:54 -07:00
Jordan Liu
567493a35c Merge "Add signal strength customization" 2017-12-13 18:20:08 +00:00
Matthew Fritze
7d2b4f5fc7 Add PrefController in XML support
Add the ability to define a Preference Controller
in xml using the 'controller' tag.

This is useful for two reasons:
- It allows the controllers to be instantiated via
reflection for Slices and Dashboard fragment
- Removes the requirement that controllers be defined manually
in Fragments

In order to be instantiable, they must have a unified construction
following either:

  ClassName(Context)
  ClassName(Context, String)

Also added a robotest that verifies that all controllers defined
in XML follow the constructor schema, and extend
BasePreferenceController.

Test: robotests
Bug: 67996923
Change-Id: I304b35dc666daebecf0c9e286696f3f2a510704a
2017-12-12 14:21:12 -08:00
Jordan Liu
3040fde446 Add signal strength customization
Also add default behavior in case carrier config bundle is null.

Bug: 69730732
Test: manual and new unit test
Change-Id: Ia38462a7e1b6f2e27ff45d93beef09465a68ae5c
2017-12-12 11:51:32 -08:00
jeffreyhuang
7ef47a9c5d Delete about phone v1 code
Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Ib8f420a86caa1da0165aa5c161eb584a009ed2b9
2017-12-11 10:57:37 -08:00
TreeHugger Robot
256f6fb607 Merge "Update feature flag dashboard UI to display all features" 2017-12-08 05:50:54 +00:00
TreeHugger Robot
546d440931 Merge "Move codes generating html file from xml files to SettingsLib (1/2)" 2017-12-08 00:32:38 +00:00
Fan Zhang
3ba0381567 Update feature flag dashboard UI to display all features
Bug: 36222960
Test: robotests
Change-Id: I1aea8f32df9bd8ae24708374b60d173953a7c266
2017-12-07 16:11:58 -08:00
Jeff Sharkey
e7a9b8bb20 Guide user towards adoption when card is "empty".
When a newly inserted SD card is empty, we'd like to guide the user
towards adopting it.  Similarly, if the card contains personal media
like photos, we'd like to guide the user towards using it as portable
storage.

Do this by quickly hunting around on the card for files under various
well-known directories.  Special logic to ignore bundled "helper"
apps included from the SD card factory.

Test: bit FrameworksCoreTests:android.os.EnvironmentTest
Bug: 69128181
Exempt-From-Owner-Approval: I wrote the original code.
Change-Id: I48323156dd4c3bb125fc9e66e17cc0384fe9c30c
2017-12-06 15:22:42 -07:00
Jaekyun Seok
47f6e54895 Move codes generating html file from xml files to SettingsLib (1/2)
LicenseHtmlGeneratorFromXml, LicenseHtmlLoader and indirecly AsyncLoader
shoud be commonly used by Settings and TvSettings.

So this CL will move them to SettingsLib.

Test: building succeeded and tested on sailfish.
  make ROBOTEST_FILTER=SettingsLicenseActivityTest RunSettingsRoboTests

Change-Id: I12e9169b1d3d313a6c5da0d575a6526327268381
2017-12-07 06:41:30 +09:00
Jeffrey Huang
cad68b3cfa Merge "Display IMEI info when sim is removed" 2017-12-05 18:34:27 +00:00
Jordan Liu
493fbd8df1 Merge "Hide signal strength when told by carrier" am: 9afa720abe am: ed9508f3a6
am: d2b04e92fe

Change-Id: Ie046e5290a3486f01f8cd41c61357b1dc7e418c0
2017-12-05 00:56:27 +00:00
Jordan Liu
ed9508f3a6 Merge "Hide signal strength when told by carrier"
am: 9afa720abe

Change-Id: I64b6eece29d475d8fdbaf8f6d1fb2c62701fd6e4
2017-12-04 23:45:57 +00:00
jeffreyhuang
c8badc7ceb Display IMEI info when sim is removed
Change-Id: I9c6db4481e9b03c8984d350cd54722a3667b6c49
Fixes: 70165342
Test: make RunSettingsRoboTests -j40
2017-12-04 14:33:58 -08:00
Fan Zhang
e0b0e9f902 Refactor help menu stuff into a controller
This is a clean up to action bar menu item pattern, we will use the same
pattern to build search icon on all pages in a later change.

Bug: 68814716
Test: robotests
Change-Id: Iedd3ec263e8ccb63ed75ec7a95b28c00878b1de4
2017-11-29 15:51:04 -08:00
Patrik Bannura
5a84add99f Hide signal strength when told by carrier
Bug: 69730732
Test: Add different values for two carriers in vendor.xml
and see them change when swapping sim card
Depends-On: I155c8f619a451edab85cf6422cef73e8e1686629
Change-Id: I241ddb3c20002db781308d94c6c165b8d13b2474
2017-11-29 12:18:49 +00:00
Jeffrey Huang
07394c9931 Merge "Enable flag for about phone v2" 2017-11-20 18:10:14 +00:00
jeffreyhuang
b025f06a50 Enable flag for about phone v2
Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I0a41fdafadf71e20b76f999005dac66b6a52f570
2017-11-17 10:14:00 -08:00
TreeHugger Robot
268de492c8 Merge "Add test and fix null keys in search providers." 2017-11-16 23:21:51 +00:00
Fan Zhang
7d5c9ace64 Add test and fix null keys in search providers.
- Add keys to some screens.
- Remove dynamic saved network/turst agent from search provider.
- Remove dynamic print services from printsettings.

Bug: 69384409
Test: atest
Change-Id: I62dce27d52585badb2a8953a05084e35dbae2f7d
2017-11-16 12:57:45 -08:00
jeffreyhuang
4e087a3b0d Add search to phone number preference
- implement preference controller mixin

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I907420e49c710427c4cd3ad6fccb2f58f99164ea
2017-11-15 15:35:53 -08:00
Jeffrey Huang
f1b6d629bf Merge changes Ibf5dc65b,I0cea3f76,I0dda78b4
* changes:
  Phone number in about phone v2
  Dynamic preferences for sim status
  Dynamic preferences for IMEI
2017-11-15 18:00:39 +00:00
TreeHugger Robot
9767b45534 Merge "Send context object to FeatureFlagUtils." 2017-11-15 03:43:24 +00:00
Jeffrey Huang
e1ead4d3d0 Merge "Use uname instead of proc/version" 2017-11-14 18:11:07 +00:00
Fan Zhang
06b0d5b564 Send context object to FeatureFlagUtils.
Bug: 36222960
Test: robotests
Change-Id: I9ca2d8c679474e545988f518eaf32acf459abd2c
2017-11-14 09:24:31 -08:00
jeffreyhuang
ba76fbeb3b Phone number in about phone v2
- Introduce preference controller to manage phone number
 - Add new strings for multi sim devices

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Ibf5dc65ba67969b6eeb095b8d202ef8a5faf16ca
2017-11-10 15:40:22 -08:00
jeffreyhuang
34c2387faa Dynamic preferences for sim status
- Support N-sim devices for sim status preference

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I0cea3f765f89c30a6595631ed501ab1c0010b736
2017-11-10 15:40:22 -08:00
jeffreyhuang
3adafdcc83 Dynamic preferences for IMEI
- Support N-sim devices for imei preference

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I0dda78b44e0c64ddd69c9a30e90c49f03b2260f3
2017-11-10 15:40:22 -08:00
jeffreyhuang
0cdd620e62 Use uname instead of proc/version
- Update the displayed kernel version to use uname instead

Change-Id: Iced2540f775c03c273521c8965c2f331267982b2
Fixes: 67006899
Test: Manual with settings app
2017-11-10 14:24:02 -08:00
Jeffrey Huang
49dac3d4ac Merge changes Ie283981d,Ie3f735e4,I6818966f,I4ca93d9b,Iabd46505
* changes:
  Introduce BuildNumberDialogController
  Introduce KernelVersionDialogController
  Introduce BasebandVersionDialogController
  Introduce SecurityPatchLevelDialogController
  Introduce FirmwareVersionDialogController
2017-11-10 18:47:25 +00:00
TreeHugger Robot
29b14a70d5 Merge changes I3ac6506a,I3fc80505
* changes:
  Add intent-filter to SearchResultTrampoline
  Create a feature flag for Search v2.
2017-11-10 02:31:35 +00:00
Fan Zhang
ff4da23a65 Create a feature flag for Search v2.
Also moved all other flags in a common file so we can track them more
easily.

Bug: 68825426
Bug: 64938328
Test: rerun robotests
Change-Id: I3fc805054cb960bedd965b1b907be759df50b95d
2017-11-09 14:57:08 -08:00
Fan Zhang
a72620b67b Use setVisible instead of removePreference everywhere.
Change-Id: I2e8084b23d3cb2c0a31a38c01716fc76236734ea
Fixes: 68956750
Test: robotests
2017-11-09 13:22:36 -08:00
jeffreyhuang
4cbeaf6729 Introduce BuildNumberDialogController
- Create a controller to display data and for the
  build number field in FirmwareVersionDialogFragment

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Ie283981d6e7ed519df1a77fd21158feb37f0efd8
2017-11-09 11:02:04 -08:00
jeffreyhuang
890d3c766c Introduce KernelVersionDialogController
- Create a controller to display data and for the
  kernel version field in FirmwareVersionDialogFragment

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Ie3f735e4559d8b01f67c65a1a46f1f1ad2dcdcd5
2017-11-09 11:02:04 -08:00
jeffreyhuang
633a67c821 Introduce BasebandVersionDialogController
- Create a controller to display data and for the
  baseband version field in FirmwareVersionDialogFragment

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I6818966f43549f41f20a488190e3116322858089
2017-11-09 11:02:04 -08:00
jeffreyhuang
bebb100e0a Introduce SecurityPatchLevelDialogController
- Create a controller to display data and handle user input for the
  security patch level field in FirmwareVersionDialogFragment

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I4ca93d9b0e74a5eaf5746704d46de42f5ae27224
2017-11-09 11:02:04 -08:00
jeffreyhuang
799c777f67 Introduce FirmwareVersionDialogController
- Create a controller to display data and handle user input for the
 Android Version field in FirmwareVersionDialogFragment

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Iabd46505103711451001a9374906188c707be548
2017-11-09 11:02:04 -08:00
Jeff Sharkey
00824b2714 Merge "Abort long-running benchmarks, report progress." 2017-11-07 19:23:21 +00:00
Jeffrey Huang
a414573d62 Merge "Move iccid number to sim status dialog" 2017-11-07 17:58:01 +00:00
Jeff Sharkey
287d31f180 Abort long-running benchmarks, report progress.
A typical storage device finishes the benchmark in under 10 seconds,
but some extremely slow devices can take minutes, resulting in a
confusing UX that looks like we've frozen.  Even worse, we keep
churning through all that I/O even though we know the device will
blow past our user-warning threshold.

So periodically check if we've timed out, and also use that to report
progress up into the Settings UI.

Test: manual
Bug: 62201209, 65639764, 67055204
Exempt-From-Owner-Approval: I wrote the original code.
Change-Id: Idd9d8c181651202d1434af879cff9355478a25c1
2017-11-07 09:52:03 -07:00
jeffreyhuang
5b8202a296 Move iccid number to sim status dialog
- Remove iccid number logic from imei dialog
 - Add iccid number log to sim status dialog

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I087688645169b387b9d65264e2c8b70ca565a44e
2017-11-06 12:38:45 -08:00
jeffreyhuang
3dec170661 Create a dialog for firmware version
- create xml layout files for dialog
 - create some new strings
 - create new FirmwareVersionPreferenceControllerV2
 - create a new dialog fragment for firmware version

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Icc567ff6aa1eedc1ab02c20e0d22529457c33466
2017-11-03 15:17:37 -07:00
TreeHugger Robot
d723394569 Merge "Popup a dialog to display sim status information" 2017-11-03 22:12:43 +00:00
jeffreyhuang
7d7e98a214 Popup a dialog to display sim status information
- Create layout files for the dialog
 - Create a new controller to launch the dialog activity
 - Create a new controller to update the contents of the dialog
 - Deprecate old files that are no longer used in about phone v2

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Iaf4f5e53c83b27f148acb076f38bfeabff41087e
2017-11-02 10:55:18 -07:00
jeffreyhuang
c2f8ab587e Popup a dialog to display user IMEI information
- Add new dialog fragment to show imei information
 - Create layout files for the dialog
 - Create a new controller to launch the dialog activity
 - Create a new controller to update the contents of the dialog
 - Deprecate old files that are no longer used in about phone v2

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: I6d4273726e2271049a0ab69c2375dac0ac393e04
2017-11-01 14:57:10 -07:00
Jeff Sharkey
efe4b48d9b Change storage migration to use quota APIs.
New quota APIs are much faster than trying to measure manually, and
removing this last user of calculateDirectorySize() means we can
remove it once and for all.

(cherry picked from commit fc522c677d)

Bug: 36056324
Test: builds, boots
Merged-In: Icdf774cff520a4b7ca6ec210b34a1c5ff85f8110
Change-Id: Icdf774cff520a4b7ca6ec210b34a1c5ff85f8110
2017-10-31 09:48:11 -07:00
Jeffrey Huang
9d31fa4c8f Merge "Update DeviceModelPreferenceController" 2017-10-25 17:17:08 +00:00
Tony Mantler
d9af0b839d Move SimStatus and ImeiInfo Pref Controllers to SettingsLib
Bug: 67410808
Test: RunSettingsRoboTests
Change-Id: Ib55d2365814b5882f7fcae6bb7f1b62cc3d6ad4e
2017-10-23 15:42:43 -07:00
jeffreyhuang
f6d360ebb5 Update DeviceModelPreferenceController
- Added serial number to the dialog for about phone v2
 - prefixed model to the preference summary for about phone v2

Bug: 36458278
Test: make RunSettingsRoboTests -j40
Change-Id: Ic2950adcecf940ad8c9256688dc70b662ad5f0d6
2017-10-19 16:50:45 -07:00