Commit Graph

832 Commits

Author SHA1 Message Date
Cédric Bellegarde
bcb10b0f4f Settings: Add preference for one shot auto-brightness
Co-authored-by: Eamon Powell <eamonpowell@outlook.com>
Change-Id: I57f11ad4e8fc47b2ff2c771e61920780e359815f
2025-08-28 13:35:08 +03:00
LuK1337
e0f55b467f Settings: Add min refresh rate list preference
Change-Id: Iac1f65ab09717ea55a5b471e094385c77ba894ee
2025-08-28 13:35:08 +03:00
Michael Bestas
8d0f6ba6ac Settings: Add peak refresh rate list preference
* AOSP "Smooth display" setting is just a toggle,
  some devices support multiple refresh rates so
  add support for it with a ListPreference.

Change-Id: I3da3d2b86e61ed3caf9af5770d8bdb4485817b97
2025-08-28 13:35:07 +03:00
Luca Stefani
f13e716b6f Settings: Check if we have any color modes declared in overlay
* Checking for wide gamut support isn't always enough

Change-Id: Ic7257e37f2eca97450eaf0ca1e330de7596352be
2025-06-22 13:00:17 +03:00
Vadym Omelnytskyi
a2d3155609 Revert "Screen Resolution: add space for 4-digit values"
This reverts commit 14050c89f5.

Reason for revert: b/406416297
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:626993cd66a1e2b75cc40445373d22503f73f19e)
Merged-In: Ib683398cf3c3753d2874e4f108c0bb09a9635ab5
Change-Id: Ib683398cf3c3753d2874e4f108c0bb09a9635ab5
2025-04-25 14:06:57 -07:00
Zhibin Liu
32bc5aab59 Merge "Add support to configure state of operator name in status bar [2/2]" into main am: 7c598253ff
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3516771

Change-Id: Icbafc5ffafb3181412e181800505c3d8be6ae5f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-03-24 00:57:43 -07:00
Zhibin Liu
7c598253ff Merge "Add support to configure state of operator name in status bar [2/2]" into main 2025-03-24 00:15:24 -07:00
Marcelo Arteiro
157030dcef Pending Location information added to Dark Theme
Resolved an issue in Settings where sunset/sunrise dark mode failed silently when a location was unavailable. Now, an error dialog is shown, even if location services are enabled, but a specific location is missing.

A footer stating the same issue is now present while the location is pending.

Existing banner that appears when Location is disabled is now being removed once Location is turned on. Previously the UI would refresh only after exiting and returning to the preference view.

Bug: 324548844
Bug: 402025928
Test: atest UiModeManagerServiceTest
Flag: EXEMPT bugfix
Change-Id: I914937185f11a686b453f929728b6329ebd05389
2025-03-20 03:21:45 -07:00
Bharath
7aa330d5ab Add support to configure state of operator name in status bar [2/2]
This keeps the Settings entry under Display Settings for
Operator name in Status bar to be configurable.

Bug: 399826221
Test: atest SettingsRoboTests:com.android.settings.display.ShowOperatorNamePreferenceControllerTest
Change-Id: I6a7777868175e6970f28060a6d74c70f582ca770
2025-03-18 01:57:03 -07:00
Shivangi Dubey
b830e703f3 Integrate refactored device-state auto-rotate setting manager
Added DeviceStateAutoRotateSettingManagerProvider to provide appropriate implementation of DeviceStateAutoRotateSettingManager based on flag.
Integrate DeviceStateAutoRotateSettingManagerImpl to be used when auto-rotate refactor flag is ON.
For more info:go/auto-rotate-refactor
Bug: 394303723
Bug: 394303731
Flag: com.android.window.flags.enable_device_state_auto_rotate_setting_refactor
Test: atest DeviceStateAutoRotateSettingManagerProviderTest

Change-Id: I63494b6548f1f533a9a1979f2b19640c3ad1dc8d
2025-03-17 18:28:02 +00:00
Treehugger Robot
accbe2362a Merge "Screen Resolution: add space for 4-digit values" into main 2025-03-14 13:28:57 -07:00
Vadym Omelnytskyi
14050c89f5 Screen Resolution: add space for 4-digit values
Add logic that composes screen resolution string with non-breaking
spaces. Now setting page will show "1 080 x 1 280" instead of "1080 x
1280"

Test: atest -c <SETTINGS_APP_PATH>/tests/unit/src/com/android/settings/display/ScreenResolutionFragmentTest.java
Test: verified on device
Flag: EXEMPT no API change
Bug: 385895191
Change-Id: I9a4bbd7c20e8c700dee6e997a36d4fda69f4d780
2025-03-14 18:52:45 +00:00
Treehugger Robot
b09e60e9bd Merge "Customize Max Screen Timeout" into main 2025-03-13 20:14:55 -07:00
William Leshner
1a8bf51a04 Merge "Move hub mode settings under display." into main 2025-03-11 14:50:35 -07:00
Shivangi Dubey
4038a20ed3 Merge "Create new device state auto rotate setting manager" into main 2025-03-11 05:18:21 -07:00
Jacky Wang
84f84ca8c0 [Catalyst] Use KeyValueStoreDelegate
NO_IFTTT=Catalyst only

Bug: 388167106
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I3d04e1bf2620fe7f910fe63f22c17da290e9172d
2025-03-11 09:39:28 +08:00
Will Leshner
417b667be4 Move hub mode settings under display.
And add a "when to show" setting.

Bug: 401001786
Test: manually
Flag: com.android.systemui.glanceable_hub_v2

Change-Id: I5f660a1be4bdbb5ab5bb14aa070bfa81b31da6b4
2025-03-10 11:08:57 -07:00
Jacky Wang
7867f29788 [Catalyst] Remove PreferenceScreenBinding
By removing PreferenceScreenBinding, PreferenceScreenMetadata with not
Preference entry point is greatly simplified.

NO_IFTTT=Catalyst only

Bug: 388167106
Flag: EXEMPT refactor
Test: manual
Change-Id: Ie62313c9c6737a4aad8e363f947a68eada4393f5
2025-03-10 18:25:15 +08:00
Sunny Shao
7f5e1f6e8b Customize Max Screen Timeout
Make it possible to customize the maximum screen timeout.
Added a configurable max timeout value which, if provided, will
limit the predefined timeout values.
Leverage code from aosp.

Flag: EXEMPT bugfix
Bug: 309512299
Test: atest ScreenTimeoutSettingsTest
Change-Id: Ibb180c89489fe890f1929bdefd5ced87a9566f07
2025-03-10 06:52:28 +00:00
Jacky Wang
0da0270ff7 [MainSwitchPreference] Remove OnCheckedChangeListener from NightDisplayActivationPreferenceController
Bug: 400335057
Flag: EXEMPT refactor
Test: manual
Change-Id: I97506685a9a188755297c90d15ead738667c8d5c
2025-03-07 19:44:59 +08:00
Jacky Wang
9eb7cd95b4 [MainSwitchPreference] Use OnPreferenceChangeListener for DarkModeActivationPreferenceController
Bug: 400335057
Flag: EXEMPT refactor
Test: manual
Change-Id: I6c6a053b64a0a10773bf9d51c44387a3597e91ad
2025-03-07 19:44:59 +08:00
Jacky Wang
1684b4387e [MainSwitchPreference] Deprecate SettingsMainSwitchPreferenceController
Bug: 401406987
Flag: EXEMPT refactor
Test: manual
Change-Id: Icdef50d0da777751f37b9d0d1984db636c7086f1
2025-03-07 19:44:59 +08:00
Shivangi Dubey
e077c9632b Create new device state auto rotate setting manager
As part of auto-rotate setting refactor, create a new manager to be used between sysui and settings.
This manager will replace the current DeviceStateRotationLockManager.
Next CL: Integrate this manager to be used when auto-rotate refactor flag is ON.
For more info:go/auto-rotate-refactor
Bug: 394303723
Flag: com.android.window.flags.enable_device_state_auto_rotate_setting_refactor
Test: atest DeviceStateAutoRotateSettingManagerImplTest

Change-Id: Id1e09174fa3fb094f3aaf635b622b4bb9610f7f2
2025-03-07 09:56:17 +00:00
Oleg Petšjonkin
f1d0ce612b Merge "Updating NightLight Intensity slider to SliderPreference component" into main 2025-03-05 08:03:34 -08:00
Oleg Petšjonkin
d82f6583fb Merge "Fixing resolution announced by Talkback" into main 2025-03-04 02:37:03 -08:00
Santos Cordon
43e0a04580 Merge "Remove EvenDimmer Toggle" into main 2025-03-03 07:19:04 -08:00
Treehugger Robot
c794912537 Merge "[Expressive design] Apply colors to homepage icons" into main 2025-03-03 02:21:05 -08:00
Jason Chiu
9c16e94552 [Expressive design] Apply colors to homepage icons
Bug: 396944193
Test: visual, robotest
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: I6ec24bdf8cb9a6f8454bd837daffe743b3b01526
2025-03-03 00:45:08 -08:00
petsjonkin
df5313a06d Fixing resolution announced by Talkback
Bug: b/386030131
Test: manual testing
Flag: EXEMPT bugfix
Change-Id: I83beab2cfdc25d163c657c89193c0d463f86dbb1
2025-02-28 19:27:59 +00:00
Oleg Petšjonkin
b1066b1348 Merge "Talkback should not announce Selected when changing screen resolution" into main 2025-02-27 15:07:14 -08:00
Daniel Norman
551534959c Merge "Update the dark theme and EDT description" into main 2025-02-27 11:26:10 -08:00
petsjonkin
20786fdc6f Talkback should not announce Selected when changing screen resolution
Bug: b/386029188
Test: manual testing
Flag: EXEMPT bugfix
Change-Id: I13a4ef58711a25549dc02c37a2a9911b1dfebf82
2025-02-26 22:40:16 +00:00
Candice
4a97b31f42 Update the dark theme and EDT description
Bug: 315012822
Test: Manually. See screenshot in the bug
Test: atest DarkModeTopIntroPreferenceControllerTest
Flag: android.view.accessibility.force_invert_color
Change-Id: I94ba1af4e49c461978fc6b31e82e44c88ba19109
2025-02-26 15:56:44 +00:00
Vadym Omelnytskyi
cc96950d12 Display: make Colors settings entry preference reactive
Added `display_color_mode` listener to Colors preference. As a result,
it becomes reactive and updates its color mode value summary.

Flag: EXEMPT minor change
Bug: 397659800
Test: changed color mode using `adb` commands and verify that Colors
summary reacts and print correct color mode

Change-Id: I963768e3dbb43b547ec53e6445b2791ec0f57cff
2025-02-24 10:39:19 +00:00
Vadym Omelnytskyi
a8f1da6994 Display: refactor Color Mode settings
1. Refactor Color Mode by moving color summary functionality to the ColorModeUtils
class.
2. Migrated `ColorModeUtils` from Java to Kotlin.
3. Changed ColorModePreferenceControllerTest according to changes

Bug: 390644464
Flag: EXEMPT refactoring
Test: atest com.android.settings.display
Test: atest -c packages/apps/Settings/tests/robotests/src/com/android/settings/display/colors/ColorModePreferenceControllerTest.kt
Test: atest -c packages/apps/Settings/tests/unit/src/com/android/settings/display/ColorModePreferenceFragmentTest.java

Change-Id: I55ac6129b93e4e35bd58f0313215b711ce954c0a
2025-02-24 10:36:23 +00:00
Santos Cordon
5ac75884f8 Remove EvenDimmer Toggle
Bug: 372342802
Test: Manually verify toggle is gone
Flag: com.android.server.display.feature.flags.even_dimmer
Change-Id: I15583fda2bc164627a5ef9b60f09f66bdb95cddd
2025-02-14 15:47:40 +00:00
Jacky Wang
a2e663dadd [Catalyst] Move PreferenceRestrictionMixin
NO_IFTTT=Catalyst only

Bug: 377600992
Flag: EXEMPT refactor
Test: atest
Change-Id: I3c26a5a56d8fd6e887e4ff4d38d8e8eb97844672
2025-02-11 20:18:43 +08:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
Sunny Shao
e9f0fdcd66 [Catalyst] Implement metrics/tags for Settings Catalyst
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: Ia879883c3f29cd7ac286b431680d66ab52e87db0
2025-02-08 08:37:35 +00:00
Jacky Wang
089e6378b5 [Catalyst] Take write permit into account for SettingsPreferenceMetadata.writable
NO_IFTTT=Catalyst only

Fix: 394973168
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I4c09ab50d3a08ab50f4fced29ea70bb50b14e5d7
2025-02-08 10:12:45 +08:00
Treehugger Robot
cbecb7e5b8 Merge "[Catalyst] Introduce the Tags for Get/Set APIs" into main 2025-02-07 04:06:32 -08:00
Treehugger Robot
ad9576aacf Merge "[Catalyst] Implement metrics/tags for "Screen attention"" into main 2025-02-07 02:51:23 -08:00
Sunny Shao
8397f1056b [Catalyst] Introduce the Tags for Get/Set APIs
NO_IFTTT=Catalyst only

Test: atest ExternalSettingsProviderTest
Bug: 394002861
Flag: EXEMPT bugfix
Change-Id: I630a9f5ffbaaeed16e13674efa507f3a7b681839
2025-02-07 10:29:49 +00:00
Sunny Shao
d5915b775a [Catalyst] Implement metrics/tags for "Screen attention"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: I1ed0d0113d7efac4c6cfa9b95ea130b8edd04407
2025-02-07 09:03:44 +00:00
Sunny Shao
ea89c3ebfc [Catalyst] Implement metrics/tags for "Adaptive brightness"
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: Ida22810a8e3335eeff3632a989885fa7b6da433d
2025-02-07 08:50:35 +00:00
petsjonkin
0ec34ce1d7 Updating NightLight Intensity slider to SliderPreference component
Bug: b/349670337
Test: manual verification
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: If0946271e2ea274f1ecb3a57a1978f733dbcada8
2025-02-06 15:43:20 +00:00
Chris Antol
5015b5c549 Update permission for accessing Brightness Level
Bug: 388372939
Flag: com.android.settings.flags.catalyst_display_settings_screen
Test: atest PreferenceServiceTest
NO_IFTTT=Not applicable to preference controller

Change-Id: I7126ca56eb19fd113ad64eed1417651758711f3f
2025-01-27 13:30:24 -08:00
Treehugger Robot
d49287f08e Merge "fix(brightness suw): Hide brightness preference in the suw." into main 2025-01-21 00:03:42 -08:00
Menghan Li
47550d4c8a fix(brightness suw): Hide brightness preference in the suw.
Root cause: there's a mismatch in how visibility is determined for
the AutoBrightnessPreferenceControllerForSetupWizard. The
getAvailabilityStatus method and the displayPreference method
(specifically the preference.setVisible call) use different
conditions for showing the preference.
Solution: To ensure consistency, I propose aligning these conditions
by incorporating an aconfig flag check in both places. This will
prevent unexpected behavior and make the logic clearer.

Bug: 389011125
Flag: com.android.settings.accessibility.add_brightness_settings_in_suw
Test: atest AutoBrightnessPreferenceControllerForSetupWizardTest
            BrightnessLevelPreferenceControllerForSetupWizardTest
Change-Id: I004bfe8b1e039734356715c971f0bfbe56ffa9db
2025-01-21 05:25:21 +00:00
Jacky Wang
041bc113eb Remove MainSwitchPreference.updateStatus
NO_IFTTT=Update API

Bug: 391092187
Flag: EXEMPT library
Test: atest&manual
Change-Id: I6e31857d8ca7084c737fd69f63b33f6a58cf3022
2025-01-21 07:44:43 +08:00