Commit Graph

5679 Commits

Author SHA1 Message Date
Fabrice Di Meglio
b7390ba585 Fix missing summary for CheckBoxPreference
- "summaryOn" and "summaryOff" were parsed but we were missing
also "summary"

Repro case: search for "adt" (from Developer options)

Change-Id: Ifa829ec6c6f86cb426432f716c2d28df8550f9ea
2014-04-21 16:40:48 -07:00
Fabrice Di Meglio
63609c58a0 Rename SettingsUtils to PrintSettingsUtils
Change-Id: I67e9222265f6326b399de3779f2210e202777ecd
2014-04-21 15:58:41 -07:00
Fabrice Di Meglio
6d7bb92b38 Fix bug #14228591 NPE in settings app when it is launched by UiAutomator
- test for null references

Change-Id: Iff6efc92cc16ada9f6e8f057ba9c23a241e62000
2014-04-21 15:32:28 -07:00
Fabrice Di Meglio
7e920da656 Code cleaning
- remove duplicate semicolon

Change-Id: I807ce89dfa6b46c415a95a9c6cdc71fd3e9a2502
2014-04-21 13:46:39 -07:00
Fabrice Di Meglio
bb26141ddf Enable Search result highlight for Accessibility and IME settings
- add missing keys
- update Database version to force re-indexing (because the keys
were missing)

Change-Id: I7533d86b0f9d79d838e5c16d4bc51b7b09dffae5
2014-04-21 13:27:23 -07:00
Fabrice Di Meglio
23ae00c1d8 Fix bug #14158603 Stability: NPE in Settings: Attempt to invoke...
...interface method 'boolean android.view.MenuItem.collapseActionView()'
...on a null object reference

- fix cases where mSearchMenuItem or mSearchView could be null

Change-Id: I2b0256fe2c8c1b426d4e0799881dd2f13480a00a
2014-04-21 12:43:20 -07:00
Fabrice Di Meglio
829c8fb2bc Fix NPE java.lang.IllegalStateException: Observer com.android.settings.SettingsPreferenceFragment$1@373ee1aa is already registered.
- propertly register / unregister the DataSetObserver

Change-Id: I04de3c7ec14e71591edc174ebafabe9a1fb165c2
2014-04-21 11:49:36 -07:00
Fabrice Di Meglio
131f49feea Better decoupling of Index updates in Bluetooth Settings
- use a Handler
- force rebuilding

Change-Id: I474fa98ea0e0758abcc46d4812f744dff24fd455
2014-04-21 11:32:39 -07:00
Fabrice Di Meglio
da0e6ff8c2 Force Search Index rebuilding for Wifi remembered networks
... when the WiFi swich will be toggled on/off

Change-Id: Iea93819e4c473aafc6aaedf6abb723969dbc9e52
2014-04-21 11:24:33 -07:00
Fabrice Di Meglio
784f266cbd Better decoupling of Index updates in WiFi Settings
- use a Handler

Change-Id: I1e35f2e437021001900468d0df2b75e53b8c62f6
2014-04-21 10:57:07 -07:00
Fabrice Di Meglio
f2dee29d66 Remove non needed code for HeaderAdapter
- before, we were showing a Swich for WiFi and Bluetooth entries
in the Headers. As this is no more the case, remove the code
that is no more usefull.

- as a side effect, we are also removing the call to update the
Search Index that was running when the Settings app was resuming
or pausing.

Change-Id: I26b40df5c7a664d196a249840638d89909b6bc24
2014-04-21 10:52:34 -07:00
Fabrice Di Meglio
5cda21b449 Search - optimize when updating the Index is done - part 2
- well, fix a regression when launching WiFi / Bluetooth settings
from the Quick Settings: we can only get the Intent properties
after the call to super.onCreate(...)

Change-Id: I21abbee610ad53dd0022c645268e55a6ba31a7b0
2014-04-21 10:14:28 -07:00
Fabrice Di Meglio
5ebabfcd35 Search - optimize when updating the Index is done
- we should only try to update the index when the Settings app is launched

Change-Id: I0543d518ea3e06804ce6fb09c987ea722bcc87cd
2014-04-21 09:42:41 -07:00
Fabrice Di Meglio
1f4140684e Make highlithing delay consistent
- set it to 400ms for HighlightingFragment as it was also 400ms
for SettingsPreferenceFragment

Change-Id: I52b910246ee557c98565dacd2bbcf57a812ea7eb
2014-04-21 09:31:36 -07:00
Fabrice Di Meglio
c853a4282d Enable highlighting of Print services
- add to SettingsPreferenceFragment to know when the associated
RootAdapter is changing and thus being able to find the highlighted
Preference
- also, add the correct Search key during indexing. She should
match the one created when adding dynamically the Preference
- last, increase to 400ms the delay to do the highlight

Change-Id: I3a1a81fdf5c8ab5f3aaab29f16ea9879ab6df056
2014-04-21 09:28:17 -07:00
Fabrice Di Meglio
7476f5b904 Fix Print title name in search results
- use R.string.print_settings

Change-Id: I3a945aed9efbc323e865db1cdbcfd8ceeb6b2558
2014-04-18 17:14:39 -07:00
Fabrice Di Meglio
ede1435518 Make all the Settings Switches appear again
- use the ActionBar Theme context when creating the Switch for
getting the correct Theming

Change-Id: Ic3701c53662b0f245c7149b119de8bb5cbaae232
2014-04-18 16:49:35 -07:00
Fabrice Di Meglio
255743990c Make the WiFi switch appear again
- use the ActionBar Theme context when creating the Switch for
getting the correct Theming

Change-Id: I1c44e1b1c28bf02af4c2ac9912295106d93a60e8
2014-04-18 16:18:26 -07:00
Fabrice Di Meglio
2169c88a14 Code cleaning
- use constants where needed for the tag/key
- remove wrong tag

Change-Id: I32578ce6a3a604dc0ea7168206a5d84391e2cce7
2014-04-18 15:18:40 -07:00
Fabrice Di Meglio
b63eddc240 Merge "Improve Preference highlighting" 2014-04-18 20:46:53 +00:00
Fabrice Di Meglio
f2a5226c1e Improve Preference highlighting
- use PreferenceFragment.onBindPreferences() to launch  highlighting
- improve SettingsPreferenceFragment code for highlighting: now we can
find the View to highlight thru its Tag if there is no ListAdapter available
- add HighlightingFragment for highlighting a View from its tag/key. This
is dealing with cases when the content is custom and not relying on
SettingsPreferenceFragment (like DataUsageSummary)

Also:

- improve DataUsageSummary so that onResume() is not recreating the
Tabs all the time
- add missing "android:keys" on some Security Settings preference files

Change-Id: Ib1dd8238fe2fb57c151d584c0810a0e0a5ad97c4
2014-04-18 13:42:46 -07:00
Adrian Roos
b05a065a09 Remove the lockscreen widget setting
Bug: 14087729
Change-Id: Ia276411f7622fe1211528ab779a7099bb20800d4
2014-04-17 14:48:38 +02:00
Fabrice Di Meglio
03ae0fdc6d Merge "Fix potential NPE with Preference highlighting" 2014-04-17 01:26:48 +00:00
Fabrice Di Meglio
5035ec6944 Fix potential NPE with Preference highlighting
- there are some cases where the ListView adapter is null

Change-Id: I9dcd171f57d9ca7b8032d890f5a18c3a01fd38cf
2014-04-16 18:26:19 -07:00
Fabrice Di Meglio
03006d2df2 Merge "Improve Preference highlight effect" 2014-04-17 01:19:13 +00:00
Fabrice Di Meglio
906ff6fdf9 Improve Preference highlight effect
- restrict the effect to the Preference View itself

Change-Id: I3ab04433e1acecb906d0a458b31314f97b9bda03
2014-04-16 18:18:41 -07:00
Fabrice Di Meglio
0527fd182a Merge "Fix bug #14118555 NPE in settings app when it is launched by UiAutomator" 2014-04-17 00:19:35 +00:00
Fabrice Di Meglio
0bae067a99 Fix bug #14118555 NPE in settings app when it is launched by UiAutomator
- prevent the potential NPE

Change-Id: I428f49c4ee55fb1e8fe121b27dd12e21eced4dad
2014-04-16 17:18:24 -07:00
Fabrice Di Meglio
477299cfa2 Merge "Search - add "live" search results" 2014-04-16 23:58:56 +00:00
Fabrice Di Meglio
a32707664f Search - add "live" search results
- now it is possible to have Search results directly when
you are typing (and not only when you press on the Search button
in the IME)
- implement onQueryTextChange(...)
- take care about re-runnin the saved query when the app is resumed

Change-Id: I021c8a9a95b50dce69ab6dace81eecb2fb188f18
2014-04-16 16:54:56 -07:00
Fabrice Di Meglio
cd22f27f73 Merge "Improve Preference highlighting from a Search result" 2014-04-16 23:22:44 +00:00
Fabrice Di Meglio
6602d02f57 Improve Preference highlighting from a Search result
- fix computation of the Preference position in its PreferenceScreen
- use "highlight" (scrolling and Ripple effect) for showing the result
- "highlight" is only done once

Change-Id: I232d79d795b0983beac5a9fec3dfbe9da329c98f
2014-04-16 16:16:45 -07:00
Wink Saville
1583a41f83 am d5b8ee9b: am 242184ca: Merge "Allow tablets to send SMS if enabled in device overlays (1/2)"
* commit 'd5b8ee9ba48f6b22135abc7ab59b3b971f0d85e0':
  Allow tablets to send SMS if enabled in device overlays (1/2)
2014-04-16 20:30:14 +00:00
Wink Saville
d5b8ee9ba4 am 242184ca: Merge "Allow tablets to send SMS if enabled in device overlays (1/2)"
* commit '242184ca23b8ef70f5347874ac9b5c59cce36208':
  Allow tablets to send SMS if enabled in device overlays (1/2)
2014-04-16 20:26:53 +00:00
Wink Saville
242184ca23 Merge "Allow tablets to send SMS if enabled in device overlays (1/2)" 2014-04-16 20:21:57 +00:00
Wink Saville
7c878831b3 Merge "Add displaying DataConnectionRealTimeInfo." 2014-04-16 19:45:43 +00:00
Andres Morales
a298f077c8 Merge "Write wifi config to NFC tag" 2014-04-16 17:19:05 +00:00
Wink Saville
4f0d881871 Add displaying DataConnectionRealTimeInfo.
Change-Id: Iadcbf9765af57c125bcdf74e3fc652ed6c8f7d42
2014-04-15 22:05:24 -07:00
Alan Viverette
c42600c215 Merge "Use action bar widget context for accessibility toggle switches" 2014-04-16 00:27:34 +00:00
Alan Viverette
f6cbcdebbd Use action bar widget context for accessibility toggle switches
Change-Id: I078968b3f4f59439743356e9fe241cdf385deef6
2014-04-15 17:08:47 -07:00
Fabrice Di Meglio
8f5c65fd01 Search results - just show the first item of ListPreference entries
- need to increment the database model version to force re-indexing
- change entries separator from SPACE to PIPE
- just show the first entries value in the Search results

Change-Id: I747218ff3528c3231c0209f8870c12f65e036070
2014-04-15 14:09:25 -07:00
Fabrice Di Meglio
7a6bfd132c Update DynamicIndexableContentMonitor
- use factory for creating Intents
- add missing case in handlePackageUnavailable() for IMEs
- move DynamicIndexableContentMonitor to the "search" package

Change-Id: I8d74b28fb9183827db50c6de4b4543b4ff21acc0
2014-04-15 13:31:38 -07:00
Fabrice Di Meglio
71a2ef3e7c Update UI for Search results
- put the icon on the left
- just use the "summaryOn" ellipsized instead of the list
of values

Change-Id: I7250ff5b7c882b873cfe6bb0ec550a8eaf052d16
2014-04-14 19:44:31 -07:00
Svetoslav
990159abaa Adding search for dynamic accessibility settings.
The language and input settings are highly dynamic and this change adds search
support for that. This category depends on installed IMEs, input devices, user
dictionary configuration, etc. We not only compute the right preferences to be
indexed but also track related system state in the settings app to rebuild the
index if needed.

bug:14066763

Change-Id: Ia89d9e35bd79abf8d74614691aedf4ca9b11b6f2
2014-04-14 17:31:23 -07:00
Svetoslav
853e47181d Rebuild search index if dynamic setting packages change.
We have some settings that are dynamically generated based on what packages are
installed. For example, accessibility services, etc. We now update the index when
the relevant installed packages change.

bug:14056852

Change-Id: I6143382bf2c7399d3c80abea0835d717935a9200
2014-04-14 17:13:02 -07:00
Fabrice Di Meglio
09e13da6a7 Some code cleaning
- use MatrixCursor var as in the other cases

Change-Id: Iba1163a851e62de9a0dd6e7c1c5d28f06452bdba
2014-04-14 17:01:02 -07:00
Fabrice Di Meglio
490099b135 Allow partial Index rebuilding thru updateFromClassNameResource(...)
- add a new boolean parameter to ask for Index rebuilding:
passing "true" will delete first all the data corresponding to the
"className" and then apply the update.

Change-Id: Ifc42fc560a14f5470b466cf6982915d9207fa3c7
2014-04-14 13:31:14 -07:00
Fabrice Di Meglio
724b702a86 Search - add support for deleting all preferences for a class name
- modify SQL delete query for passing any column in the DELETE statement
- modify deleteIndexableData(...) for passing a SearchIndexableData

Change-Id: I4c58e38422e67b1d464b0e51201520ce8717a14d
2014-04-14 11:24:16 -07:00
Fabrice Di Meglio
df278aa959 Update SettingsSearchIndexablesProvider for supporting queryNonIndexableKeys(...)
- add the new requested method "queryNonIndexableKeys" from the contract

Change-Id: I72be47851a7e19e3f14960f4e2b60c3e952f1fac
2014-04-14 10:54:58 -07:00
Fabrice Di Meglio
210bb8694a Merge "Search - add indexing of SecuritySettings" 2014-04-12 00:54:55 +00:00