Commit Graph

52726 Commits

Author SHA1 Message Date
Chaohui Wang
83aeb45f3c Fix default mode for AlarmsAndRemindersAppList
When app ops permission's app ops mode is default, should check if
permission is grant.

Fix: 339846642
Test: manual - on AlarmsAndRemindersAppList
Test: unit test
Change-Id: Ia0f05211f5774637304502ead79dd98a1cf89886
2024-05-21 03:37:47 +00:00
Chaohui Wang
7a8d8fd091 Reapply "Migrate AppOps"
This reverts commit 19b01bd68b.

Bug: 341016088
Test: manual - on Special app access
Change-Id: I000274ae9c725f848e1c8910120ba886fcc5be95
Merged-In: I000274ae9c725f848e1c8910120ba886fcc5be95
2024-05-21 03:20:04 +00:00
Faye Yan
a7065f4d36 Revert "Add Voice activation apps into Settings->Apps->Special a..."
Revert submission 25108596-va-special-access

Reason for revert: voice activation is not going in V

Reverted changes: /q/submissionid:25108596-va-special-access

Bug: 306447565
Bug: 393727896

Test: presubmit

Change-Id: I4977e7d543cb800fc9fb6962bba3afebb9480dcc
Merged-In: I4977e7d543cb800fc9fb6962bba3afebb9480dcc
2024-05-20 11:56:48 +08:00
Faye Yan
f6b5904511 Revert "Add Voice activation apps into Settings->Apps->Specific app->AppInfo->Voice activation apps"
This reverts commit 7f2fbc2e4c.

Reason for revert: voice activation is not going in V

Test: manual - on Special app access
Change-Id: Idfabfd48f45d2ace7de9f8498181f281ad0358a1
Merged-In: Idfabfd48f45d2ace7de9f8498181f281ad0358a1
2024-05-20 11:56:47 +08:00
Chris Antol
c4c5ad5642 Merge "Fix NPE in AudioSwitchPreferenceController" into 24D1-dev 2024-05-17 16:19:32 +00:00
ELIYAZ MOMIN
19b01bd68b Revert "Migrate AppOps"
Revert submission 27392016-cherrypick-AppOpsController-AppOps-w48m53c1or

Reason for revert: <Potential culprit for b/341210811- verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Reverted changes: /q/submissionid:27392016-cherrypick-AppOpsController-AppOps-w48m53c1or

Change-Id: Ib9813a48170f4ef38de9eee811c677ad75f5401e
2024-05-17 10:48:57 +00:00
Chaohui Wang
4573df2aaf Migrate AppOps
Bug: 339846642
Test: manual - on Special app access
Change-Id: I988bdf85036478d8e6d87a3b5a1a46a35df38422
2024-05-17 02:57:31 +00:00
Treehugger Robot
47ce042cf3 Merge "Update battery settings page loading text" into 24D1-dev 2024-05-15 15:09:26 +00:00
Wesley Wang
3ceffc39f9 Update battery settings page loading text
- Update the loading text into empty space text to prevent layout flaky before info loaded

Bug: N/A
Test: atest SettingsRoboTests
Change-Id: I272405f5045a682533a4e9405a9fd91f6c507f7e
2024-05-15 10:53:52 +00:00
songferngwang
7489c93347 Fix the BasePreferenceController.createInstance's IllegalStateException
When the settings search do BasePreferenceController.createInstance,
it get the the IllegalStateException, and then the search ignore this
controller. It causes the indexing can not filter this controller via
the PreferenceController's getAvailabilityStatus.

Bug: 335509130
Test: Build pass. Do search and no crash
Change-Id: Icaff8ca690ca3e3a46c2f21a5fbde0bbd99fd92e
2024-05-15 09:26:44 +00:00
Chaohui Wang
381638f284 Merge changes If41d957f,I5c49d195 into 24D1-dev
* changes:
  Fix empty network scan result
  Create NetworkScanRepository
2024-05-15 07:50:58 +00:00
Chaohui Wang
99b09df4a8 Fix empty network scan result
Settings use TelephonyScanManager.NetworkScanCallback to scan, and its
onComplete() could happens before onResults().

We will change Settings to fix.

Fix: 338986191
Test: manual - on NetworkSelectSettings
Test: unit test
Change-Id: If41d957f916a99eacc1becb6b460e58722a4dca7
Merged-In: If41d957f916a99eacc1becb6b460e58722a4dca7
2024-05-15 15:29:55 +08:00
Chaohui Wang
12158eb1fe Create NetworkScanRepository
And migrate network scan to flow for better maintenance and prevent ANR.

Fix: 323105271
Test: manual - Choose network
Test: unit test
Change-Id: I5c49d195fc202143c0131ffd78bc3adc168b119c
Merged-In: I5c49d195fc202143c0131ffd78bc3adc168b119c
2024-05-15 14:09:03 +08:00
Chris Antol
f5cc663a8a Fix NPE in AudioSwitchPreferenceController
Test: Unit Test to verify nullness
Bug: 338892614
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7ac80f0a0a69e99ec3603e9157cd5a2b20509e85)
Merged-In: Ic97d1a6269a6d98ffd15a9b512f6ae24ff1c5b5e
Change-Id: Ic97d1a6269a6d98ffd15a9b512f6ae24ff1c5b5e
2024-05-14 16:19:59 +00:00
songferngwang
6f8cc6f0b6 Fix search indexed the item from the invisible sim
When search start to index and run to MobileNetworkSettings.java, the
TelephonyBasePreferenceController will find which subId can be the
"AVAILABLE" from the active subscriptionInfo list. This active subscriptionInfo
list does not be filtered, so the search uses the invisibile sim's item for user.

Bug: 335509130
Test: atest MobileNetworkUtilsTest (pass)
Change-Id: I2840e7de344347643197592e125f5524d27a068e
2024-05-14 15:04:02 +00:00
Tom Hsu
580ef265ce Merge "Expose SatelliteWarningDialogActivity" into 24D1-dev 2024-05-10 06:46:57 +00:00
tomhsu
180b2d9561 Expose SatelliteWarningDialogActivity
Bug: 337154438
Test: Manual test
Test: Build pass
Change-Id: I530c554433d99b4732416b8f1b83677ddc0ff6d8
Merged-In: I530c554433d99b4732416b8f1b83677ddc0ff6d8
2024-05-09 09:56:30 +00:00
tomhsu
1f440aacec Show dialog on BT entries in Settings
- When satellite mode is switched on BT entries shall show the warning dialog and avoid user uses these functions.

Bug: 337154438
Test: Manual test.
Test: atest pass
Change-Id: Ic9b6d44731684d1cfba87570d72dcacb905a66d2
(cherry picked from commit c8f52f816c)
Merged-In: Ic9b6d44731684d1cfba87570d72dcacb905a66d2
2024-05-09 06:55:02 +00:00
Treehugger Robot
eb729f283c Merge "Fix flicker of "App data usage"" into 24D1-dev 2024-05-09 05:50:55 +00:00
Tom Hsu
864122b8b7 Fix build break
Bug:339348046
Test: Build pass locally
Change-Id: I98db39d696617fc81fdad4e73419b34f5265b0ad
Merged-In: I45cd92a8688e7a619613361ea4a8d58a0984d99f
2024-05-08 08:56:44 +00:00
Chaohui Wang
bb90a2c5c8 Merge "Fix data usage when policy has no cycle" into 24D1-dev 2024-05-08 08:33:18 +00:00
tomhsu
c0b39601bf Show dialog on Wifi, and APM' entries in Settings
- When satellite mode is switched on Wifi, and APM entry shall show the warning dialog and avoid user uses these functions.

Bug: 337154438
Test: Manual test.
Test: atest pass
Change-Id: I45cd92a8688e7a619613361ea4a8d58a0984d99f
(cherry picked from commit 29b2f16edf)
Merged-In: I45cd92a8688e7a619613361ea4a8d58a0984d99f
2024-05-08 05:40:36 +00:00
Chaohui Wang
9e5b389de3 Fix flicker of "App data usage"
Use placeholder to hold the place.

Fix: 323466366
Test: manual - on Mobile Settings
Test: unit test
Change-Id: I3c4d9ff6538a79500318869f01f4b88b55bd9475
(cherry picked from commit 74fe516e09)
Merged-In: I3c4d9ff6538a79500318869f01f4b88b55bd9475
2024-05-08 05:29:27 +00:00
SongFerng Wang
bc4293cb4e Merge "Refacotr mobile data observer for repository" into 24D1-dev 2024-05-08 03:59:47 +00:00
Chaohui Wang
107cca7a77 Fix data usage when policy has no cycle
Fallback to four weeks, as the same as no policy.

Fix: 336108815
Test: manual - on DataUsageList
Test: unit test
Change-Id: I63140a13ea3f3ee790cc911432fbdfd6247f7318
2024-05-07 14:22:35 +00:00
Chaohui Wang
c63f06d4c8 Fix isInCallFlow when no active subscription
Direct emit false in this case to fix.

Fix: 338484668
Test: manual - on SIMs
Test: unit test
Change-Id: I5286701160d95b1c06e577db6232f7e70f040cdb
2024-05-07 10:57:24 +00:00
Mengjun Leng
0a9e7046cc Refacotr mobile data observer for repository
In current design, the mobile data observer might be removed due to
SIM absence after registered so that mobile data network info can't
be updated to clients.

To fix it, migrate it to use API TelephonyCallback.onUserMobileDataStateChanged

Change-Id: I26c8f946823abb7505f0227c8dd8ab0700d0c5f2
Merged-In: I26c8f946823abb7505f0227c8dd8ab0700d0c5f2
2024-05-07 09:05:25 +00:00
Chaohui Wang
bbc3a352e3 Merge "Reapply "Create CallStateRepository.isInCallFlow"" into 24D1-dev 2024-04-30 07:47:30 +00:00
Tom Hsu
0a8d830616 Merge "Revert^2 "Add a new warning dialog for Satellite mode"" into 24D1-dev 2024-04-30 07:05:49 +00:00
Chaohui Wang
7bbd8fa4e3 Reapply "Create CallStateRepository.isInCallFlow"
This reverts commit 93e4c65d3d.

Fixed the test by cherry-pick change
I7a3d27cb53c930a56ab0f0896b545807bf4f9dc0.

Bug: 336209156
Test: manual - on MobileNetworkSwitchController
Test: atest SubscriptionInfoListViewModelTest
Change-Id: Id606d6ee90acd8a98de706d8533fed0aac96bff4
2024-04-30 12:33:54 +08:00
Tom Hsu
1b308f5df8 Revert^2 "Add a new warning dialog for Satellite mode"
This reverts commit 15c90207e2.

Reason for revert: ag/27138142 shall fix the crash instead of reverted one.

Change-Id: Icf46fda7af9c9bb6921bc10de0f9c93926f42fac
2024-04-30 02:17:15 +00:00
Treehugger Robot
c81e0cb16a Merge "When erasing an eSIM, verify the device screen PIN lock if one is set." into 24D1-dev 2024-04-29 22:24:00 +00:00
Priyanka Advani
134635786f Merge "Revert "Create CallStateRepository.isInCallFlow"" into 24D1-dev 2024-04-29 22:13:31 +00:00
Priyanka Advani
93e4c65d3d Revert "Create CallStateRepository.isInCallFlow"
This reverts commit 6142ad927e.

Reason for revert: Droid-monitor created revert due to Build breakage in b/337914519. Will be verifying through ABTD before submission.

Change-Id: I300d5397de156fd0815965cfd99f0814f1365ffc
2024-04-29 20:31:15 +00:00
Chaohui Wang
ac55241fc5 Merge "Create CallStateRepository.isInCallFlow" into 24D1-dev 2024-04-29 12:37:44 +00:00
Tom Hsu
45549d928b Merge "Revert "Add a new warning dialog for Satellite mode"" into 24D1-dev 2024-04-29 12:34:55 +00:00
SongFerng Wang
33f5aa3897 Merge "Fix the Java crash in Settings : java.lang.IndexOutOfBoundsException" into 24D1-dev 2024-04-29 11:39:12 +00:00
ELIYAZ MOMIN
15c90207e2 Revert "Add a new warning dialog for Satellite mode"
This reverts commit 680d062c77.

Reason for revert: <Potential culprit for b/337796129  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
>

Change-Id: I6fbb7a0587fbb474012e1a97a75c036420500f99
2024-04-29 11:37:35 +00:00
Tom Hsu
cec2f402a9 Merge "Add a new warning dialog for Satellite mode" into 24D1-dev 2024-04-29 10:57:55 +00:00
Chaohui Wang
6142ad927e Create CallStateRepository.isInCallFlow
Which will emit true if any active sub is in call.

And also create SubscriptionActivationRepository to use isInCallFlow.

Bug: 336209156
Test: manual - on MobileNetworkSwitchController
Test: unit test
Change-Id: I75460bf17961349557ac1e19e7f6b15249f3d7b0
2024-04-29 10:15:13 +00:00
SongFerng Wang
e2dcee3aec Fix the Java crash in Settings : java.lang.IndexOutOfBoundsException
Bug: 329293848
Change-Id: Id775f6db2a90a59278f9b522b60680695d75c4a4
Test: build pass
2024-04-29 09:28:32 +00:00
tomhsu
680d062c77 Add a new warning dialog for Satellite mode
Bug: 337154438
Test: atest pass.
Test: Maunal test pass.
Change-Id: I33dbf3502c780cedd5422e2b44678ecb9a22a662
2024-04-29 08:37:28 +00:00
Meng Wang
bcf91ee6a7 When erasing an eSIM, verify the device screen PIN lock if one is set.
SIM PIN lock existence isn't checked anymore.

Bug: 335672518
Test: b/335672518#comment6
Merged-In: Iff40c1fb9a2463311768d24d09dfc3aeeee128f9
Change-Id: Iff40c1fb9a2463311768d24d09dfc3aeeee128f9
2024-04-26 21:28:58 +00:00
Samuel Huang
4f454b43c6 Fix the "Use this SIM" switch does not disable during phone calls
If the registration failed (e.g., device doesn't support satellite), SatelliteManager will not emit the current state by callback. We send `false` value by ourself to make sure the flow has initial value.

Bug: 315928920
Test: atest, manual
Change-Id: Ic87f71bc576cfb1f8e4053c5784fca401adaec08
2024-04-26 05:54:40 +00:00
Samuel Huang
fea80bf236 Merge "Ignore ACTION_PRIMARY_SUBSCRIPTION_LIST_CHANGED event if satellite session is started" into 24D1-dev 2024-04-26 03:08:53 +00:00
Samuel Huang
faa640e8fc Ignore ACTION_PRIMARY_SUBSCRIPTION_LIST_CHANGED event if satellite session is started
When satellite session is started, we need to suppress the 'Choose SIM for mobile data' and 'Update preferred SIM' dialogs to prevent user turn on SIM.

Bug: 334139957
Test: atest, manual
Change-Id: Id56a98f3d1cfd38875173a643c992393d3dbeec8
2024-04-25 13:34:43 +00:00
Rafael Higuera Silva
36d99e8b09 Extract and fix logic for showing rac dialog.
Added tests to make sure the logic makes sense.

Bug: 335745726
Test: make, manual, atest SubscriptionUtilRoboTest, atest SubscriptionUtilTest, atest ResetNetworkTest
Change-Id: I7092f2747f1ca1f9ef4dc99275a916b9e24d8b28
2024-04-25 01:34:47 +00:00
Thomas Nguyen
c6005fb22a Disable SIM On/Off operation when device is in a Satellite session
Bug: 330585109
Test: SatelliteManagerTestOnMockService SatelliteSessionControllerTest SatelliteControllerTest
Manual test with demo and real mode

Change-Id: Iade6426981f76a0b9b71828e0c86d3088c3e974e
2024-04-24 16:35:13 +00:00
Jason Chang
0c61a9662c Fix Talkback announcement for SFPS enrollment issues
Remove the redundant "enrolled %" string when talkback announcement.

Bug: 324488176

Flag: NONE

Test: manually do SFPS enrolling then hearing the sounds to check.
Change-Id: I00d1f885bca2609cd954817943a1d4f5625a95b3
2024-04-22 13:38:30 +00:00
Chaohui Wang
4f5920c3f5 Not include user input in regex
Check prefix and remove prefix first, to avoid include user input in
the regex to fix.

Fix: 335136289
Test: manual - on SIMs
Test: unit test
Change-Id: Iff4dcfc3662c744d00b586d05e64b4f5fe33a0d8
2024-04-22 04:56:57 +00:00