Commit Graph

9 Commits

Author SHA1 Message Date
Fan Zhang
07207c0113 Misc ui tweaks.
- Update conditional card layout
  - move action button from right side to bottom.
  - Get rid of the forking between small/big screens.

- Update a few icons

Fixes: 121189136
Fixes: 124315564
Fixes: 124316920

Test: visual
Change-Id: I205d9995a2d7ed06ad9d32f3cea74f2840a28aed
2019-02-12 16:14:21 -08:00
Mill Chen
d973776112 Fix distortion in conditional cards
When setting device font and display size to largest, conditional cards
will get distorted. The fix is to add a different layout for screens that
have smaller than 360dp available width.

Change-Id: I8b61c9d8a568e79045e4a490aa387c801a57f9a7
Fixes: 119505249
Test: visual
2018-12-26 14:39:22 +08:00
Fan Zhang
2fa4b1f7b8 Tweak padding for conditional card layout.
Overall goal is to push button to the left:
- Make a linear layout that contain content, and button
- Apply existing padding to the content only
- Apply a smaller padding to button.

Change-Id: I8f1c586c59be21ff73dd6d08675f76c8ff7addda
Fixes: 120669058
Test: visual
2018-12-14 14:03:08 -08:00
Mill Chen
6020a3da1e Disable scrollbar of the button in conditional card
The scrollbar of the button will be enabled if changing font size
to large or above. It is fixed by disabling scrollbar of the button.

Change-Id: Ia66afac962c7b0d431007382dc6a2c7456fc915d
Fixes: 120085679
Test: visual, rebuild
2018-12-05 21:36:22 +08:00
Fan Zhang
a60652a973 Visual update: remove card elevation for homepage cards.
- Replace CardView with MaterialCardView
- Add strokeColor and strokeWidth to MaterialCardView
- Set cardElevation to 0dp.

And remove a few unused layout, clean up color lint whitelist.

Test: rebuild, visual
Change-Id: I34a4b9a985cb85c212e123b8af5353d8c548923a
2018-11-28 10:42:00 -08:00
TreeHugger Robot
74f3077729 Merge "Update new UI layout of Conditional cards" 2018-11-09 17:49:25 +00:00
Mill Chen
c89c4ceabb Update new UI layout of Conditional cards
Bug: 113451905
Test: visual
Change-Id: I20ec526bd2b5b2679cd7e0e4388a2a897fe6a24d
2018-11-09 11:21:58 +08:00
Fan Zhang
2a98c843e8 Loading suggestions via legacy SuggestionService sometimes
When legacy_suggestion flag is turned on, load Suggestions from
SuggestionService instead of contextual homepage, because contextual
homepage infrastructure might not be availble on all devices.

Bug: 118842099
Test: robo
Change-Id: I91710c005e11be5a9b3dd39ceff670106e7f80c3
2018-11-07 11:55:09 -08:00
Mill Chen
0ca7130403 Update new UI of conditional cards
- Add half-width and full-width layouts for conditional cards
- Keep origin strings of conditional cards, that could make conditional
cards truncate its title and summary in half-width card.
- Add default value of isHalfWidth to each condition controller.

Bug: 113451905
Test: robotests, visual
Change-Id: Ib0055f32c4ab9e73c0e0a57c6b0ef586d52942e0
2018-11-07 16:06:31 +08:00