Commit Graph

2225 Commits

Author SHA1 Message Date
tmfang
7b2529d142 Clean up LayoutPreference
- There is no any custom preference uses R.id.all_details,
  so clean up some code.

Test: robotest
Bug: 120005054
Change-Id: Ib40483934cd6d6c0bbaa2864d40dbf09483d98aa
2018-11-27 03:33:49 +00:00
tmfang
012b089a91 Allow below divider for all EntityHeader
- Create an method in LayoutPreference let other class can
  set divider status.
- EntityHeaderController will allow to have a below divider
  by default.

Test: visual, robotest
Bug: 116346008
Change-Id: Ic041b8fef8d22ce1b7ea48eedfbe97c708c41ce7
2018-11-20 11:52:29 +08:00
Raff Tsai
d9d57be243 Merge "Fix Settings crash when clicking search bar" 2018-11-16 15:45:26 +00:00
TreeHugger Robot
3704899fc9 Merge changes from topic "settings-action-button"
* changes:
  Remove setButtonPositive method
  Apply new action button visual design
  Create a new visual design for action buttons
2018-11-16 10:45:29 +00:00
tmfang
5c7f4de999 Remove setButtonPositive method
Since new UI design only exist two button in layout,
we don't need these methods anymore.

Test: robotest
Bug: 116346008
Change-Id: If2e8f7dddb9c13e480438f36fe3c5d6affa4e9ff
2018-11-16 14:33:16 +08:00
tmfang
3adb74ea60 Apply new action button visual design
- Add some icon resources.
- Add icon for each button in action button preference.
- Update "Enable" and "Disable" string to "Install" and "uninstall".
- Remove unused string.
- Add divider between entity header and action buttons.

Test: visual, robotest
Fixes: 119203074
Bug: 116346008
Change-Id: Ib8d7aeb2943d39d257e977b84f165f002bf47559
2018-11-16 14:33:03 +08:00
Raff Tsai
6c731f4631 Merge "Fix crash on AppInfoDashboardFragment" 2018-11-16 02:14:23 +00:00
Raff Tsai
a75a724bdd Fix Settings crash when clicking search bar
- When user disable settings suggestion in App Settings, click
search button without leaving settings app. The search button is
still existed.
- Doesn't allow user to disable app in App Settings
- Add check before start search intent

Change-Id: Ifbc4615914678d8df734e14d63bb626403313d1e
Fixes: 118805907
Test: manual
2018-11-15 18:08:40 +08:00
tmfang
5659fc6ac9 Fix crash on AppInfoDashboardFragment
When AppInfoDashboardFragment launch a new page,
it sets SUB_INFO_FRAGMENT(1) as request code.

This request code is same as REQUEST_REMOVE_DEVICE_ADMIN(1).
So, when AppInfoDashboardFragment got onActivityResult callback,
it will handle the event about REQUEST_REMOVE_DEVICE_ADMIN.

So, we change REQUEST_REMOVE_DEVICE_ADMIN to a unique value.

Test: manual test, robotest
Fixes: 118841475

Change-Id: Idabd62c5062ccfbf4b8acee82df7401fc9ce7484
2018-11-15 16:58:29 +08:00
TreeHugger Robot
6f93c8bb31 Merge "Fix App permission doesn't show summary" 2018-11-15 04:10:40 +00:00
tmfang
057539f186 Fix App permission doesn't show summary
Since AppPermissionsPreferenceController assigns
a fixed preference key in constructor, so it can't
be used by same controller in Privacy page.

So, we change contructor directly, let controller
read preference key from xml file.

- Also remove unused imports.

Test: visual
Bug: 116628158
Change-Id: I42d6e978e91f0a2fe796d290cb9f34db596aa1f4
2018-11-14 16:25:48 +08:00
Fan Zhang
a6c7db1888 Update logging: switch a bunch of action() logging calls.
Use generic action(int, int, int, String, int) instead of
action(Context, int, string, Pair...) when possible.

Bug: 117860032
Test: robotests
Change-Id: I5213b52b2b10d80a3c488c37718df81b3b0a428f
2018-11-13 21:50:34 -08:00
Fan Zhang
ff47b303c4 Remove call to actionWithSource.
Switch to generic action logging call.

Bug: 117860032
Test: robotests
Change-Id: Ibd7c59ac0ec8a9fa1b368b40f0453a1b42071377
2018-11-12 05:32:13 +00:00
tmfang
bbca29b6f4 Do not show installation status on Q
Test: robotest, visual
Bug: 116340579
Change-Id: I0b414f3faffe8a96cccb310abca74c585c9ac1f2
2018-11-09 10:17:54 +08:00
TreeHugger Robot
0f82fe6ed5 Merge "Delete Directory access Settings." 2018-11-08 02:14:23 +00:00
Amin Shaikh
57eb049bec Delete Directory access Settings.
Bug: 111892460
Test: m RunSettingsRoboTests
Change-Id: I6ffa5a4b69fa7b3ee9d9a058fa075b60fbd2b0a3
2018-11-02 13:55:15 -04:00
Vadim Tryshev
27a76c3988 Using intent action for DWB properties exposed as an API
The intent opens digital wellbeing properties for an app.

Bug: 118319143
Test: Building Android
Change-Id: I0921ba5e8a6cb357ba12a08cafcab64503417dc9
2018-10-26 10:45:40 -07:00
Doris Ling
87df629dbb Merge "Get app info with correct user id." 2018-10-15 23:23:23 +00:00
Philip P. Moltmann
b9a83d584d Merge "Use SYSTEM_... window manager flags" 2018-10-15 16:28:39 +00:00
Doris Ling
b9ff5892ca Get app info with correct user id.
- when querying app info from package manager, we should use the methods
that takes the user id so that it will work properly with managed
profile.

Change-Id: Ifc84d3a29aaf7b2c1acfa096596a53f1715cc908
Fixes: 117222623
Test: make RunSettingsRoboTests
2018-10-11 16:47:03 -07:00
TreeHugger Robot
94017b543f Merge "Fix problem on filter widget in memory page" 2018-10-11 16:46:17 +00:00
tmfang
0d2faf31c1 Fix problem on filter widget in memory page
We need to use SettingsSpinnerAdapater
with settings style item.

Test: visual
Bug: 117568930
Change-Id: Ia60b7d08c11a270e029e6b673a12d838f454eccf
Fixes: 117541499
2018-10-11 13:41:53 +08:00
Adam He
585ab7490d Merge "Use AFM.getAutofillServiceComponentName() in Settings's AutofillPickerTrampolineActivity" 2018-10-10 19:54:50 +00:00
Philip P. Moltmann
fc9951091f Use SYSTEM_... window manager flags
Test: Built
Bug: 116798569
Change-Id: Iac0728b348b6105b843d83415f0abde2de3cb074
2018-10-09 13:45:10 -07:00
tmfang
0d07dd19d0 Use custom drop-down filter widget
This CL is just a example how to use this SettingsSpinner.

Change-Id: Ie0d104ce5f3e4c6b852fe7c051253b1567c6c4cd
Fixes: 112706966
Test: robotests
2018-10-08 16:23:52 +08:00
TreeHugger Robot
5cb7e3c0ab Merge "Use the new loader to show app data usage summary." 2018-10-03 01:30:40 +00:00
TreeHugger Robot
3f45adfeb1 Merge "Check instance before casting" 2018-10-02 23:41:35 +00:00
Doris Ling
b758e2b473 Use the new loader to show app data usage summary.
- this is for getting the summary text for Apps & notifications ->
(select an app) -> Mobile data & Wi-Fi

Bug: 111751694
Test: make RunSettingsRoboTests
Change-Id: Ib4d8e7308ea8a782b9af3bbb99db2b1235e0aca2
2018-10-02 16:21:14 -07:00
Fan Zhang
53bdd9961c Check instance before casting
Change-Id: I1917b2d8e045904145ea833abf35fa1d008fa224
Fixes: 116855783
Test: robotests
2018-10-02 15:15:38 -07:00
TreeHugger Robot
b021f3285b Merge "Settings change for device-wide unknown sources block." 2018-10-02 13:07:24 +00:00
TreeHugger Robot
bf9562b21b Merge "Do not resolve permission in settings." 2018-10-01 22:00:30 +00:00
Philip P. Moltmann
cf809c34b7 Do not resolve permission in settings.
Settings already uses the RuntimePermissionPresenter to resolve
permissions for an app. This code must be the previous implementation.

It can be removed without any issues.

Test: Built
Change-Id: Ie1375de1e23f4c9bb882a13ef7ade9adc543c82a
2018-10-01 13:48:43 -07:00
Doris Ling
863c60ffcf Add version 2 of AppDataUsagePreferenceController.
- a simple copy of AppDataUsagePreferenceController to
AppDataUsagePreferenceControllerV2, so that future modification can
be compared more easily.

Bug: 111751694
Test: make RunSettingsRoboTests
Change-Id: Ibeed7775a223794bf50f36b3b933e270a55e3b39
2018-10-01 11:47:21 -07:00
Irina Dumitrescu
e9c8a0f264 Settings change for device-wide unknown sources block.
Update the "Install unknown apps" preferences to display the option is
disabled if the global user restriction for unknown apps is turned on.

Test: Manual test, disallowing installs in TestDPC disables installing
unknown sources apps. Also:
atest packages/apps/Settings/tests/robotests/src/com/android/settings/applications/appinfo/ExternalSourcesDetailsTest.java
Bug: 111335021
Change-Id: I235e5fd110e296ed43aa89d7a5ec0d48470c4023
2018-10-01 12:15:00 +01:00
Adam He
a8192e1cb8 Use AFM.getAutofillServiceComponentName() in Settings's AutofillPickerTrampolineActivity
Fixes: 80189659
Test: m -j Settings && adb sync && adb shell kill `pid com.android.settings` && adb shell am start com.android.settings

Change-Id: I3dc4ebd1a8ffb26b131905c3fc4ed59567049925
2018-09-26 02:16:51 +00:00
TreeHugger Robot
25d95e0dec Merge "Add 'notificaton blocked' filter to notifications" 2018-09-25 22:34:37 +00:00
Fan Zhang
394ea1cde5 Merge "Move AppPreference to settingslib, and change imports." 2018-09-25 19:15:19 +00:00
Fan Zhang
754f737c2c Move AppPreference to settingslib, and change imports.
Bug: 116364655
Test: robotests
Change-Id: I313272737dc7c068c47abf8ea021de7d2bea0a25
2018-09-25 09:51:19 -07:00
Julia Reynolds
a4e51b5238 Add 'notificaton blocked' filter to notifications
Test: robotests
Change-Id: I5c0cd9a2f73b6a22d66df7669e944bbe1473539c
Fixes: 112576746
2018-09-25 09:05:10 -04:00
TreeHugger Robot
d747cff993 Merge "Disable recently used apps in battery saver mode." 2018-09-22 00:06:00 +00:00
Fan Zhang
2a1e59063d Disable recently used apps in battery saver mode.
UsageStats query is too slow.

Change-Id: I53fa13924514e71221d3a6407139ff00ae5eb378
Fixes: 114788699
Test: robotests
2018-09-21 14:14:16 -07:00
Fan Zhang
104ee2e423 Add intent filter to launch usage access for app.
Change-Id: Ide8aa590f9b4218d0f4affe65a7daec384480798
Fixes: 110200770
Test: adb shell am start -a android.settings.USAGE_ACCESS_SETTINGS -d package:com.android.settings
2018-09-20 16:44:54 -07:00
Julia Reynolds
56966ce8f5 Add checks before casting entry.extraInfo.
Test: make, flash
Change-Id: I1a9d6a51b1f236e711fdb49d9c2f795e7023cfce
Fixes: 113309404
2018-09-19 15:43:08 -04:00
Julia Reynolds
d5ddae8fc4 Reset all notification settings on clear app prefs
Not just the app level 'are these notifications blocked?'
field.

Test: manual
Change-Id: Id77366d0d71e1f0d2507f1a30123d61aa11db252
Fixes: 65476259
2018-09-19 12:18:13 -04:00
Doris Ling
f7b8505948 Move hasReadyMobileRadio() to DataUsageUtils.
- move the method from DataUsageList to DataUsageUtils where other
utility methods are.

Bug: 111751694
Test: make RunSettingsRoboTests
Change-Id: If7176cb4278d568f890a0c94437c4483bbd472f9
2018-09-18 11:21:59 -07:00
Ben Lin
f66f042009 Merge "Follow up comments to 0cdc103e8287d3bd01944cdd2afb5c11897998fe." 2018-09-15 01:25:02 +00:00
Ben Lin
30ed7c7c72 Follow up comments to 0cdc103e82.
Bug: 74763823
Test: Manually check; sending an Intent with package:// scheme works, if
originated from app of same cert.

Change-Id: I8206197c2147cc91ef72ad89f330320781428bb9
2018-09-14 16:27:24 -07:00
TreeHugger Robot
75e2bdbcc9 Merge "Do not include disabled activity in Default Browser." 2018-09-13 01:57:53 +00:00
Doris Ling
dfe663879d Do not include disabled activity in Default Browser.
- query the intent activites with flags 0, so that only
enabled activities will be returned.

Change-Id: I6ec4e3f3fdff850228a723bcb2d2bdc5721b41eb
Fixes: 111796304
Test: make RunSettingsRoboTests
2018-09-12 15:34:49 -07:00
Fan Zhang
d67668a1c3 Merge "Fix a crash when launching app detail for bad package name" am: ada1a39ffb am: 2e2e1e243d
am: 59cd5abb96

Change-Id: I746d5c959761306d463a934e7c01f4155934fd93
2018-09-11 18:53:09 -07:00