Commit Graph

2152 Commits

Author SHA1 Message Date
Jacky Wang
6f684c73e0 [MainSwitchPreference] Remove SettingsMainSwitchPreferenceController
NO_IFTTT=Update base class

Bug: 401406987
Flag: EXEMPT refactor
Test: manual
Change-Id: I68093366f63fa5b4184aa7b3dde8bc2609f17dfb
2025-03-11 00:35:01 +08:00
Michael Mikhail
aec68e2372 [catalyst] migrate media controls settings
Flag: com.android.settings.flags.catalyst_media_controls
Fixes: 337243570
Fixes: 389133530
Fixes: 389133114
Test: atest MediaControlsLockScreenSwitchPreferenceTest
Test: atest MediaControlsSwitchPreferenceTest
Change-Id: Ibe8fed064cd6223085764f5125cff45a9bea734d
2025-03-03 22:50:05 +00:00
Treehugger Robot
c794912537 Merge "[Expressive design] Apply colors to homepage icons" into main 2025-03-03 02:21:05 -08:00
Jason Chiu
9c16e94552 [Expressive design] Apply colors to homepage icons
Bug: 396944193
Test: visual, robotest
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: I6ec24bdf8cb9a6f8454bd837daffe743b3b01526
2025-03-03 00:45:08 -08:00
Alex Li
619e6c8c78 Uses ThemeHelper#trySetSuwTheme to apply theme for Radactioninterstitial screen.
Screenshot: https://hsv.googleplex.com/6310318165721088

Bug: 399237091
Test: manual test on device.
Flag: EXEMPT flag by PartnerConfigHelper.isGlifExpressiveEnabled
Change-Id: I0f1d8a6ea1cbe8bce79c32b4c039656648f5a99a
2025-02-26 22:51:38 -08:00
Julia Reynolds
0762b81bcf Add ability to exclude apps from adjustments
Specifically bundling and summarization

Test: BundleManageAppsPreferenceControllerTest
Test: AdjustmentExcludedAppsPreferenceControllerTest
Test: SummarizationManageAppsPreferenceControllerTest
Flag: android.app.nm_summarization
Flag: android.app.notification_classification_ui
Bug: 390415383
Bug: 377697346
Change-Id: Ica4b77212f4660624bfe12be7e6c9c584cd2c812
2025-02-25 07:06:46 -08:00
Yuri Lin
f64677e095 Merge "Call super.updateState() to set checked status of work profile switch" into main 2025-02-19 14:30:49 -08:00
Yuri Lin
21327c6e41 Call super.updateState() to set checked status of work profile switch
The switch preference was not correctly reflecting the state of the cooldown setting because the checked state of the switch is set in the parent class's updateState() method.

Fixes: 397554453
Flag: EXEMPT bugfix
Test: manual
Change-Id: I2ce6fe71ac6ed0249c0ad39e99ff5929659d6b5a
2025-02-19 15:30:51 -05:00
Matías Hernández
13bb8e714d Hide ZenMode.getRule() - Settings
Bug: 393321037
Test: atest com.android.settings.notification.modes
Flag: EXEMPT Unflaggable refactoring
Change-Id: Ia9b43146f687ebee29eee0328a92e59c0c6d574a
2025-02-18 14:27:58 +01:00
Treehugger Robot
63e919d927 Merge "Inline MODES_API flag" into main 2025-02-13 09:43:04 -08:00
Yuri Lin
c6675e5452 Merge "Update ZenModeAddBypassingApps to not binder call for every app" into main 2025-02-12 08:05:39 -08:00
Yuri Lin
1500f3ecc0 Update ZenModeAddBypassingApps to not binder call for every app
This update already happened for ZenModeAllBypassingApps to use the new single binder call to get all packages bypassing DND. This change uses that method for bypassing apps as well as collecting the set of all apps with a nonzero number of channels.

Bug: 368623163
Bug: 394614704
Test: ZenModeAddBypassingAppsPreferenceControllerTest, manual to confirm correct behavior
Flag: android.app.nm_binder_perf_get_apps_with_channels
Change-Id: I72a1edcb07d18f5707591a5341d7a7338c23f42b
2025-02-11 17:20:46 -05:00
Matías Hernández
7235474792 Inline MODES_API flag
Bug: 310620812
Test: Preexisting
Flag: EXEMPT Inlining flag
Change-Id: I54ad81d87ea4ce85940400b0e8680a1bac0ca342
2025-02-11 15:14:24 +01:00
Jacky Wang
a2e663dadd [Catalyst] Move PreferenceRestrictionMixin
NO_IFTTT=Catalyst only

Bug: 377600992
Flag: EXEMPT refactor
Test: atest
Change-Id: I3c26a5a56d8fd6e887e4ff4d38d8e8eb97844672
2025-02-11 20:18:43 +08:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
Jacky Wang
e9afa7c7c6 [Catalyst] Fix restriction issue on sound settings
After ag/31443354, sliders on sound settings are not disabled when
"no_adjust_volume" restriction is set. The root cause is that
`SeekBarVolumizer.setSeekBar` updates the SeekBar enabled state.

Bug: 386162594
Flag: EXEMPT bugfix
Test: atest&manual
Change-Id: I5d37c9958a693a26717a8e2d9a62ec5ef225e28f
2025-02-11 12:26:23 +08:00
Sunny Shao
e9f0fdcd66 [Catalyst] Implement metrics/tags for Settings Catalyst
NO_IFTTT=Catalyst only

Bug: 394002861
Flag: com.android.settings.flags.catalyst
Test: devtool
Change-Id: Ia879883c3f29cd7ac286b431680d66ab52e87db0
2025-02-08 08:37:35 +00:00
Ronald Braunstein
72a5fdd400 Merge "[owners] Remove aroederer@google.com from src/com/android/settings/notification/OWNERS" into main am: 85107f0fb4 am: f4b70bd0a1
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3465863

Change-Id: I890fae6722c688a43aaac3bf2edd012ee9e70d60
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-05 21:38:35 -08:00
Yining Liu
b602e4b0fc Merge "Fix the toggle status for show sensitive content switches" into main 2025-02-04 15:26:44 -08:00
Yining Liu
ed4e9d6c92 Merge "Notification on lockscreen settings: default unseen setting value" into main 2025-02-04 15:25:25 -08:00
Justin Weir
5851927407 Merge "Add super call to onCreateView" into main 2025-02-04 15:08:12 -08:00
Justin Weir
bd5eefb017 Add super call to onCreateView
Bug: 392487897
Test: Ran LockscreenWithOverSixDigitPIN with and without this change
Flag: EXEMPT small bug fix
Change-Id: Ieaba6222f9751d4e87040a5cb59d0364fe153700
2025-02-04 16:02:05 -05:00
Julia Reynolds
55441003d3 Add app level settings for classification and summarization
Test: AdjustmentKeyPreferenceControllerTest
Flag: android.app.nm_summarization
Flag: android.app.notification_classification_ui
Flag: android.app.nm_summarization_ui
Bug: 377697346
Bug: 390412878
Change-Id: I85b67b5c0376ee4cd962e26bf178aae6fa712212
2025-02-04 10:53:57 -08:00
Jacky Wang
402e5bb38b Fix IntentReceiver leaked on Sound & vibration
The root cause is that PreferenceController migrated to Catalyst will be
removed by DashboardFragment and VolumeSeekBarPreferenceController
onPause() is not invoked.

NO_IFTTT=Controller only

Fix: 386162594
Flag: EXEMPT bugfix
Test: atest&manual
Change-Id: I13f8588c8259ed4ddb9895ffc60e209c99c05269
2025-02-04 15:08:38 +08:00
Jacky Wang
a7fa6efe8f Get rid of VolumeSeekBarPreferenceController.setCallback
Set the callback to VolumeSeekBarPreference directly and simplify
SoundSettings.

Bug: 386162594
Flag: EXEMPT refactor
Test: atest&manual
Change-Id: Ic114c15c236da9f3ea3754408adbfa9c841befd0
2025-02-04 15:08:38 +08:00
Yining Liu
d3a855b62f Notification on lockscreen settings: default unseen setting value
Make sure the default setting of
NOTIFICATION_SHOW_ONLY_UNSEEN_NOTIFICATIONS is off.

Fix: 391889319
Flag: com.android.server.notification.notification_lock_screen_settings
Test: manual
Change-Id: Ib7ad3e19ec2196829fef9410f5b306b3fa712d8c
2025-01-31 10:46:53 -08:00
Yining Liu
1436bcff72 Fix the toggle status for show sensitive content switches
We need to make the show sensitive content switch checked by default.
The old implementation misses calling to super.updateState(), which
caused lacking of UI refreshment.
This change also added validation to the preference id that is used
to construct the LockScreenNotificationShowSensitiveController, which
avoids misusage.
Added unit tests to verify that the UI is also updated upon Settings
change, and the preference IDs are verified.

Fix: 392621932
Flag: com.android.server.notification.notification_lock_screen_settings
Test: manual
Change-Id: I31fe602d5b5439515e5fdf5c706b420edaf79042
2025-01-29 12:59:53 -08:00
Guojing Yuan
f5ed187ffb [CDM] Checks NLS component name instead of package name
Bug: 386216637
Change-Id: I1be52fcb3d52b8b84353ea00fd57d8360ddd966c
Flag: EXEMPT bugfix
Test: CTS
2025-01-28 11:57:16 -08:00
Treehugger Robot
ff58281ac6 Merge "Quick fix to Modes Special Access page titles" into main 2025-01-27 08:44:09 -08:00
Matías Hernández
df3e6a1572 Quick fix to Modes Special Access page titles
Fixes: 392594926
Test: manual
Flag: EXEMPT Minor fix
Change-Id: Id5294c41a3c515ce9ae7fef768c1693ade0f8191
2025-01-27 16:41:01 +01:00
Julia Reynolds
50e720b03b Add initial settings for summarization
Test: SummarizationGlobalPreferenceControllerTest
Test: SummarizationPreferenceControllerTest
Flag: android.app.nm_summarization
Bug: 390415383
Change-Id: I773d69c707ae5f902860196fb44821ede15261f5
2025-01-27 05:54:01 -08:00
Owner Cleanup Bot
3aee441d2c [owners] Remove aroederer@google.com from src/com/android/settings/notification/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/aroederer@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Ifa12fa8e045776b6351530a5f1341311046e9a1c
2025-01-26 08:24:44 -08:00
Matías Hernández
a588f3ebc4 Fix missing mode title and menu
By moving these from onStart to onResume. Looks like a recent change to Settings broke this.

Bug: 391543900
Test: manual
Flag: EXEMPT Trivial bugfix
Change-Id: Ie9b8bd08e8513e7c6c2f1baeab4801af2fbe1cae
2025-01-22 14:57:48 +01:00
Jacky Wang
041bc113eb Remove MainSwitchPreference.updateStatus
NO_IFTTT=Update API

Bug: 391092187
Flag: EXEMPT library
Test: atest&manual
Change-Id: I6e31857d8ca7084c737fd69f63b33f6a58cf3022
2025-01-21 07:44:43 +08:00
Fan Wu
8d318b21d8 [Catalyst] Update RangeValue usages to IntRangeValuePreference
Bug: 388167302

Test: atest and manual

Flag: EXEMPT refactor

NO_IFTTT=refactor

Change-Id: If7412da90a5b5c1b4e3c31ea36361eae9e8bb8b9
2025-01-20 03:23:57 +00:00
Fan Wu
297941ba2f [Catalyst] Remove PreferenceMetadata usages
Classes that implement PersistentPreference don't need to implement PreferenceMetadata

Bug: 388167302
Test: atest and manual
Flag: EXEMPT refactor
NO_IFTTT=refactor

Change-Id: Icf7d5eb4bbd426eb7e8dd562eda3c0a775457a3e
2025-01-16 17:46:28 -08:00
Yining Liu
8b94618dd8 Merge "Notification on lockscreen settings: add WhatToShowController" into main 2025-01-16 15:38:58 -08:00
Ioana Alexandru
878f860fd3 Merge "Rename SettingsEnableZenModeDialog to EnableDndDialogFragment" into main 2025-01-16 08:39:36 -08:00
Yining Liu
50577a6c36 Notification on lockscreen settings: add WhatToShowController
Add WhatToShowController to handle the visibility change of the
preference category when the global setting changes.

Bug: 367455695
Flag: com.android.server.notification.notification_lock_screen_settings
Test: manual
Change-Id: I432e4c865402ac8bee32f0f79b3cf2bdce7cc882
2025-01-16 16:11:33 +00:00
Ioana Alexandru
07534f76a9 Rename SettingsEnableZenModeDialog to EnableDndDialogFragment
We also renamed the base EnableZenModeDialog to
EnableDndDialogFactory, see other CL in topic.

Flag: EXEMPT trivial rename
Test: builds
Bug: 388261320
Change-Id: Iaa2043bbb8d1f62482d0c38d0951da4025676f27
2025-01-15 17:42:23 +01:00
Julia Reynolds
e5359b283e Align history styling with Settings
Fixes: 335717550
Bug: 349652992
Test: manual- view history in all states with new styling enabled and disabled
Flag: EXEMPT bug fix
Change-Id: I8ccf5d848691f954cb1b0a79c773ad76ab6c371a
2025-01-14 16:05:25 -08:00
Julia Reynolds
41896428ea Layout improvements for notification pages
Changes for upcoming theming changes in Settings:
- replacing some margins with padding
- merging some (switch pref + info pref) combos into a single preference.
I flagged the one that was already launched, but changed the other directly
- added some section headers (unflagged)
- moved all app wide notification settings to a single section (unflagged)
- changed two plain text prefs into TopIntroPreference, the dedicated pref
type for that sort of UI
- fixed some UI issues with 'Show more categories' appearing too often
- removed a duplicate notifcation channel label (unflagged)
- replaced a button layout preference with ButtonPreference (unflagged)

Test: manual review with is_expressive_design_enabled on and off
Test: atest com.android.settings.notification.app
Flag: EXEMPT this feature is not using aconfig for flagging
Bug: 349652992
Change-Id: I2acd7b2eb9dbcf6929143bfde99cd67163f1f95d
2025-01-09 17:07:53 -05:00
Treehugger Robot
be203ea17d Merge "Fix NPE on modes page when schedule has no days" into main 2025-01-08 11:17:09 -08:00
Matías Hernández
5098df9b6c Fix NPE on modes page when schedule has no days
Fixes: 387088843
Test: atest ZenModeTriggerUpdatePreferenceControllerTest
Flag: EXEMPT trivial bugfix
Change-Id: I3b845784f5923521d7f3f6cae9d6d27a21f55361
2025-01-08 19:14:40 +01:00
Yuri Lin
5979b88c7c Merge "Send APP_NOTIFICATION_PROMOTION_SETTINGS intent to the preference" into main 2025-01-06 10:59:50 -08:00
Matías Hernández
837a3477ab Merge "Remove incorrect call to Window.addFlags with a system flag" into main 2025-01-06 07:16:05 -08:00
Matías Hernández
e0510a62eb Remove incorrect call to Window.addFlags with a system flag
The same flag is being (correctly) added in onCreate, so on top of being wrong this was also completely unnecessary.

Bug: 368579654
Test: atest NotificationAccessConfirmationActivityTest
Flag: EXEMPT bugfix

Change-Id: I539fca77a1d136bdd0e4892993020884430b8a4e
2025-01-03 14:54:52 +01:00
Yining Liu
9d200f1f38 Merge changes I1dffab01,I6e34ef9b,Ia8d472ea,Icf4e7003 into main
* changes:
  Notification on lockscreen settings: adapt text view for large font
  Inverse toggles on the notifications on locks screen settings page
  Update appearance of notifications on locks screen settings page
  Remove description from notifications on locks screen settings page
2025-01-02 16:11:51 -08:00
Yuri Lin
023509c895 Send APP_NOTIFICATION_PROMOTION_SETTINGS intent to the preference
This adds APP_NOTIFICATION_PROMOTION_SETTINGS to the set of intents that can go to AppNotificationSettings, and additionally adds the appropriate highlight key when the fragment is started with that intent action.

Flag: android.app.ui_rich_ongoing
Test: manual with flag on & off via sending intents over adb; AppNotificationSettingsTest
Bug: 369150427
Change-Id: I1c48fdae161979f1a221f7c57e83e94f6aadc306
2025-01-02 11:04:22 -05:00
Treehugger Robot
e095ce3124 Merge "[Catalyst] Provide screen key to @ProvidePreferenceScreen" into main 2024-12-27 05:33:47 -08:00