Graciela Putri
c97131b90b
Merge "[4/n] Add fullscreen option in user aspect ratio settings" into udc-qpr-dev am: 1f1c2a7db9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24213103
Change-Id: Ie0f2338c707cc45dd1cbe57931102bf22df4184a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-28 18:24:45 +00:00
Graciela Putri
e5e57a8d9e
Merge "[3/n] Add aspect ratio app info page" into udc-qpr-dev am: 386b02e906
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23819685
Change-Id: I5f187502bc04d21629bdc1b434f74497f9def14a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-28 18:21:45 +00:00
Graciela Wissen Putri
fa945cc808
[4/n] Add fullscreen option in user aspect ratio settings
...
Apps > App Info > Advanced > Aspect ratio
Adds fullscreen option to aspect ratio settings gated by fullscreen
build time and runtime flags. If fullscreen option is disabled, return
app default option.
To enable feature:
adb shell device_config put window_manager
enable_app_compat_user_aspect_ratio_settings true
adb shell am force-stop com.android.settings
Bug: 291900454
Test: All Settings CUJs passed
atest SettingsUnitTests:UserAspectRatioManagerTest
Change-Id: I8f8d0c08ac81f088d6c25e8dfb3550f807f336b6
2023-07-28 10:09:56 +00:00
Graciela Wissen Putri
57984f02d5
[3/n] Add aspect ratio app info page
...
Apps > App Info > Advanced > Aspect ratio
Adds link from aspect ratio app list page to app info. Stops activity if
user chooses a different aspect ratio override.
To enable feature:
adb shell device_config put window_manager enable_app_compat_user_aspect_ratio_settings true
adb shell am force-stop com.android.settings
Bug: 287448187
Test: Manual
All Settings CUJs passed
atest SettingsRoboTests:UserAspectRatioDetailsTest
atest SettingsSpaUnitTests:UserAspectRatioAppPreferenceTest
Change-Id: Id47f291459e62267bf15d629c163dde73d96928a
2023-07-28 09:53:11 +00:00
Graciela Putri
dc86dbe24b
Merge "[2/n] Add aspect ratio app list page under apps" into udc-qpr-dev am: 4e86d0d6b3
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23819684
Change-Id: Iac8fc9b4d80e287a84e4a7d2917e76954ae64a9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-21 22:13:34 +00:00
Graciela Wissen Putri
b4c4f6cbe6
[2/n] Add aspect ratio app list page under apps
...
Apps > General > Screen Size
To enable feature:
adb shell device_config put window_manager enable_app_compat_user_aspect_ratio_settings true
adb shell am force-stop com.android.settings
Fix: 287448088
Test: Manual
atest AspectRatioAppsPageProviderTest
atest AspectRatioUtilsTest
All CUJs passed in go/settings-cujs
Change-Id: I4de6c3cbdbdfbc79ed839ec149fb633344dcd3a7
2023-07-21 08:02:09 +00:00
Matías Hernández
281c4b631c
Merge "Settings: don't try to allow NLSes with too-long component names" into udc-dev am: 4d34eb2c7a am: aaddfd88e9 am: e20f52a05a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23726247
Change-Id: I2bcd0934af1e0e4d6679e04293f04bbebcadab4c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-28 18:44:07 +00:00
Matías Hernández
e20f52a05a
Merge "Settings: don't try to allow NLSes with too-long component names" into udc-dev am: 4d34eb2c7a am: aaddfd88e9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23726247
Change-Id: I8fc3a7b239ce0545b34eafc860df72a42cfd2e05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-28 18:39:16 +00:00
Matías Hernández
027f0a46ae
Settings: don't try to allow NLSes with too-long component names
...
* NotificationAccessConfirmationActivity (triggered through CompanionDeviceManager) -> Don't show the dialog, bail out early similarly to other invalid inputs.
* NotificationAccessSettings (from Special App Access) -> No changes, but use the canonical constant now.
* ApprovalPreferenceController (used in NotificationAccessDetails) -> Disable the toggle, unless the NLS was previously approved (in which case it can still be removed).
Fixes: 260570119
Fixes: 286043036
Test: atest + manually
Change-Id: Ifc048311746c027e3683cdcf65f1079d04cf7c56
2023-06-21 17:02:32 +02:00
Chaohui Wang
5d847e0207
Merge "Call onViewCreated in DashboardFragment" into udc-qpr-dev am: 8617f63823
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23659924
Change-Id: I71e428a2a332e4ed6f3d4719c28cb5408aeaeb51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-15 03:59:56 +00:00
Chaohui Wang
eb4fea1a36
Call onViewCreated in DashboardFragment
...
To let fragment's view lifecycle owner passed in to controllers.
For UI usage, view lifecycle owner is the best choice, controller could
use this lifecycle owner to observe events and do UI related works.
Usage DataSaverController as first example.
Bug: 287005021
Test: Manually for DataSaverController
Change-Id: Id965ea3a24d61f4d0ec6735632944f41f72ba06a
2023-06-14 12:22:12 +08:00
Taran Singh
5552c412c8
DO NOT MERGE: Prevent non-system IME from becoming device admin am: 9260c67352 am: 4a5e1a4d3f am: 6484a7f640
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23545057
Change-Id: I8d65342899d69e875b725a638317162f5f38c9a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-12 22:01:00 +00:00
Taran Singh
7e1d083e05
DO NOT MERGE: Prevent non-system IME from becoming device admin am: 9260c67352 am: 4a5e1a4d3f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23545057
Change-Id: I6c689260a1ce82baee992262c0ea32512d758c37
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-12 21:14:57 +00:00
Taran Singh
6484a7f640
DO NOT MERGE: Prevent non-system IME from becoming device admin am: 9260c67352 am: 4a5e1a4d3f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23545057
Change-Id: I444194ab1c57d376de954f3cbed4ba3d3b0cb3d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-12 21:12:56 +00:00
Joanne Chung
802cb9f24e
Merge "Update OWNER file to new owner" am: 6c84f9128d am: e7b01f0ce8 am: 16a3800902 am: 89c82f5894 am: bba1da3581
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2618630
Change-Id: I699a4f8354d88381b4a3be7ddcc090b51beaf377
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-08 10:13:23 +00:00
Joanne Chung
89c82f5894
Merge "Update OWNER file to new owner" am: 6c84f9128d am: e7b01f0ce8 am: 16a3800902
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2618630
Change-Id: Ica9e62112a10211e4ed6a7dd2633ff86050df231
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-08 08:53:40 +00:00
Joanne Chung
e7b01f0ce8
Merge "Update OWNER file to new owner" am: 6c84f9128d
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2618630
Change-Id: Ie7ac04781ba486dd74af1df57a995636453eb21a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-08 07:23:35 +00:00
Joanne Chung
674ae4ae93
Update OWNER file to new owner
...
Bug: 177641730
Change-Id: I68e9986338e04bb81a11a495f6de1657399b5742
Test: n/a. Only update owner
2023-06-08 06:40:41 +00:00
Taran Singh
9260c67352
DO NOT MERGE: Prevent non-system IME from becoming device admin
...
Currently selected IME can inject KeyEvent on DeviceAdminAdd screen to
activate itself as device admin and cause various DoS attacks.
This CL ensures KeyEvent on "Activate" button can only come from system
apps.
Bug: 280793427
Test: atest DeviceAdminActivationTest
Change-Id: I6470d1684d707f4b1e86f8b456be0b4e0af5f188
(cherry picked from commit 70a501d02e )
2023-06-02 22:20:30 +00:00
Chaohui Wang
6a6e3b848b
Merge "Move unrestricted data summary to DataSaverController" into udc-qpr-dev am: 97963e8389
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23442437
Change-Id: Ic6338fc2c629944f4c8baf560becec13e63db03f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-26 07:55:20 +00:00
Chaohui Wang
3e35cff7ba
Move unrestricted data summary to DataSaverController
...
DataSaverController currently used in 2 pages,
- Network & internet > Data Saver
- Apps > Special app access
This helps unify the logic, and instead of showing on "Special app
access", this summary shows on "Unrestricted data" is make more sense.
Bug: 280280596
Test: Manually on above pages
Test: Unit test
Change-Id: Ia151ed8179a250f8f20cc5041f9383fffebdab10
2023-05-26 13:05:48 +08:00
Himanshu Gupta
4af03a6f78
Merge "Clearing obsolete cloneUserId from CloneBackend." into udc-dev am: 4740720948 am: af793d86f2 am: 783069217f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23262239
Change-Id: Ie7f04734dbac25664efb106bbd6ba47bb1fca2de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 22:22:39 +00:00
Himanshu Gupta
40dd0958d6
Merge "Clearing obsolete cloneUserId from CloneBackend." into udc-dev am: 4740720948 am: af793d86f2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23262239
Change-Id: I6a6b1f0824fefb1ec12cc61dda3c2b550d8fb072
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 21:56:28 +00:00
Himanshu Gupta
783069217f
Merge "Clearing obsolete cloneUserId from CloneBackend." into udc-dev am: 4740720948 am: af793d86f2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23262239
Change-Id: Id0c01cecf1b24afea3f07a7395217b656a91a512
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 21:54:28 +00:00
Himanshu Gupta
59651f68af
Merge "Clearing obsolete cloneUserId from CloneBackend." into udc-dev am: 4740720948
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23262239
Change-Id: Ie4a5bcf554ab4bc20acc00e868c79ac5a54320c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 21:15:21 +00:00
Himanshu Gupta
4740720948
Merge "Clearing obsolete cloneUserId from CloneBackend." into udc-dev
2023-05-19 20:28:36 +00:00
Nicolas Sleiman
d8efa40d2c
Merge "Remove GET_ACTIVITIES in InteractAcrossProfiles in Settings" into udc-dev am: 03e8dbca58 am: 123fa6ae78 am: 122806ad50
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23347979
Change-Id: Ief3c1ed6340528399883ab09567e2fbe6fd9ee10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 16:20:24 +00:00
Ankita Vyas
fbb0a74bd3
Merge "Remove GET_ACTIVITIES flag while fetching installed apps from package manager." into udc-dev am: 96cff64862 am: 8053e9da26 am: 01fca127fb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23343098
Change-Id: I512cd9e19bab6c4fb08344a4f27bc776b18fe473
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 16:20:09 +00:00
Nicolas Sleiman
122806ad50
Merge "Remove GET_ACTIVITIES in InteractAcrossProfiles in Settings" into udc-dev am: 03e8dbca58 am: 123fa6ae78
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23347979
Change-Id: I617fc20bb9ba0c1f2476e3d81acaf8797fb3a15c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 16:17:45 +00:00
Ankita Vyas
01fca127fb
Merge "Remove GET_ACTIVITIES flag while fetching installed apps from package manager." into udc-dev am: 96cff64862 am: 8053e9da26
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23343098
Change-Id: I8843d39553a68330c6fa69900892ff5fff539e16
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 16:17:39 +00:00
Nicolas Sleiman
60e25e30e1
Merge "Remove GET_ACTIVITIES in InteractAcrossProfiles in Settings" into udc-dev am: 03e8dbca58 am: 123fa6ae78
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23347979
Change-Id: I616281d105e7c5792b515501970526689bc104ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 16:13:52 +00:00
Ankita Vyas
2af208be41
Merge "Remove GET_ACTIVITIES flag while fetching installed apps from package manager." into udc-dev am: 96cff64862 am: 8053e9da26
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23343098
Change-Id: I77f0b8361c02d61941b5cc1c34ffdc79ecef43d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 16:13:27 +00:00
Nicolas Sleiman
008a5b24b5
Merge "Remove GET_ACTIVITIES in InteractAcrossProfiles in Settings" into udc-dev am: 03e8dbca58
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23347979
Change-Id: I78483e25ac6fd54ee99295c68a1d1e76a59bad48
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 15:37:13 +00:00
Ankita Vyas
915741a00d
Merge "Remove GET_ACTIVITIES flag while fetching installed apps from package manager." into udc-dev am: 96cff64862
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23343098
Change-Id: I642beff62fac8c46054c0d35cf2ba95b63dccce6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-19 15:36:17 +00:00
Nicolas Sleiman
03e8dbca58
Merge "Remove GET_ACTIVITIES in InteractAcrossProfiles in Settings" into udc-dev
2023-05-19 15:08:35 +00:00
Ankita Vyas
96cff64862
Merge "Remove GET_ACTIVITIES flag while fetching installed apps from package manager." into udc-dev
2023-05-19 15:06:39 +00:00
nsl
f3241ee339
Remove GET_ACTIVITIES in InteractAcrossProfiles in Settings
...
Remove the GET_ACTIVITIES flag in InteractAcrossProfiles in Settings to
follow ag/23343098
Bug: 283407612
Test: InteractAcrossProfilesSettingsTest
Change-Id: I299a4a40af3e59f729027b964e938d7783eb7d92
2023-05-19 12:31:27 +00:00
Ankita Vyas
46b106c487
Remove GET_ACTIVITIES flag while fetching installed apps from package
...
manager.
This flag adds more info in return data(not required for this usecase) which increases parcel size.
Bug: 278294334
Test: manual
Change-Id: Ifba7a184aa8c3f5a70d85ddd3910f17bf91f9444
2023-05-19 05:50:39 +00:00
Himanshu Gupta
d9f60d9a1a
Clearing obsolete cloneUserId from CloneBackend.
...
When cloned user is removed from device, the previous clonedUserId
present with the CloneBackend instance becomes obsolete, and does
not update to reflect the new clonedUserId, when the cloned user is
re-created.
To fix this we set cloneUserId to -1 when cloned user is removed,
causing CloneBackend#installCloneApp to update clonedUserId when
the cloned profile is re-created.
Bug: 280431074, 275062025
Test: Manual by flashing the local build.
Change-Id: If0d7960998865b4081502e84d0d4125b3b05c69c
2023-05-17 12:22:01 +00:00
Treehugger Robot
8d265f34fb
Merge "Hide "Long Background Tasks" page from Settings." into udc-dev am: b272dbc613 am: dbf7472854 am: 1b61fee893
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23252718
Change-Id: If3f03a724c223c218fd5f02b6cc1b4e3718103b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-16 20:10:05 +00:00
Treehugger Robot
50260c19d2
Merge "Hide "Long Background Tasks" page from Settings." into udc-dev am: b272dbc613 am: dbf7472854
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23252718
Change-Id: I623996d146f0ebab242e34ec82318e8df91b453e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-16 18:42:45 +00:00
Treehugger Robot
1b61fee893
Merge "Hide "Long Background Tasks" page from Settings." into udc-dev am: b272dbc613 am: dbf7472854
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23252718
Change-Id: Iaa73048171065b9d2816e38eca5eb2bfaf97f27a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-16 18:40:43 +00:00
Treehugger Robot
3c2aa8843e
Merge "Hide "Long Background Tasks" page from Settings." into udc-dev am: b272dbc613
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23252718
Change-Id: Ie9099059b0af1947c2c9659e1c85012a5b90240d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-16 18:01:40 +00:00
Treehugger Robot
b272dbc613
Merge "Hide "Long Background Tasks" page from Settings." into udc-dev
2023-05-16 17:31:12 +00:00
Varun Shah
82dc52376a
Hide "Long Background Tasks" page from Settings.
...
Since the RUN_USER_INITIATED_JOBS permission is no longer a special
permission, the related page in Settings should be hidden.
Bug: 282824927
Test: page hidden from Special App Access screen.
Change-Id: I51d681f97247be45654dd2eb12df08f429a43938
2023-05-16 01:53:33 +00:00
Ankita Vyas
84f8456a80
Merge "Fetch summary only if feature is available" into udc-dev am: 44a613438b am: 837adaafd8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23240819
Change-Id: I65734ccca5650342a9eb9b5a33f8980a9c79676b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-15 23:10:34 +00:00
Ankita Vyas
a32a3f0322
Merge "Fetch summary only if feature is available" into udc-dev am: 44a613438b am: a988b414bd am: 4e40d8a92b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23240819
Change-Id: I075b5789013fd85deaf5955b5ea85a674d3e6f12
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-15 18:59:36 +00:00
Ankita Vyas
a988b414bd
Merge "Fetch summary only if feature is available" into udc-dev am: 44a613438b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23240819
Change-Id: Iec1502a51e7a96073aaaba2691cc41943bf0ae69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-15 17:37:23 +00:00
Ankita Vyas
98e4d7bf16
Fetch summary only if feature is available
...
onResume(loads summary) of controller seems to be invoked even when availabilty status
is unspported.
Bug: 278294334
Test: manual
Change-Id: I2486a7d61bea1b981ae56f0ff32b9d411be2ad14
2023-05-15 13:31:38 +00:00
Becca Hughes
eaf7f58c5f
Merge "Add extra null checks" into udc-dev am: 598ff21b78 am: 93c340780f am: 557b140873
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23214089
Change-Id: Ie39fa1d478e46fae1dd07156faae5fbd0951536d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-12 22:32:52 +00:00