ag/32322018 reverts storage_summary string for default locale but other
languages might be still using stale translations and cause
MissingFormatArgumentException crash.
As a quick fix, change the string id to make it as a new string. The
side-effect is that storage summary is not localized for a while.
Fix: 404116634
Flag: EXEMPT bugfix
Test: Verified with zh_TW locale
Change-Id: I5d7d6be2c1eb524622f1013120cb44403b1f6f29
The SIM EID field was already not being shown if the
PackageManger.FEATURE_TELEPHONY_DATA feature flag was not set, per the
check in getIsAvailableAndUpdateEid().
The async availability update was introduced in the context of bug
304560734, because the UI could block until the EID value was ready.
The config_show_sim_info check was left in getAvailabilityStatus() as
that cannot block.
This change moves to getAvailabilityStatus() the availability check
based on the PackageManager feature flags (which are set on system
boot and not changed during runtime) and also based on whether the
user is admin or not, as with any other telephony related setting.
None of these two checks would lead to ANR state.
Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimEidPreferenceControllerTest
Change-Id: I3447091670345285132a2acaf45cd129c2b84c00
storage_summary is passed as a single string of format "32 GB".
Spliting the phrase to allow TC to remove whitespace in case of iw
translations.
Old Translation : <free_space>
New Translation: <free_space_value> <free_space_unit>
Bug: 387197875
Test: manual
Flag: EXEMPT bugfix
Change-Id: I91abf58df472650a6278b08e4daa5d32e7f90da9
This suggested change is automatically generated based on group
memberships and affiliations.
Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy. We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain. It can always be
reverted if needed.
If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.
See the owner's recent review activity for context:
https://android-review.googlesource.com/q/bonianchen@google.com
To report an issue, file a bug in the Infra>Codereview component.
Change-Id: I7dd96429039695468c84a638d37c7eca754ffc9d
The correct return when checking for the SIM status field availability
for non-admin users is DISABLED_FOR_USER.
UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.
Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimStatusPreferenceControllerTest
Change-Id: I9bd290f1bdd73909be383a24f2c762d295089ff6
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.
Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimStatusPreferenceControllerTest
Change-Id: I0735c949a590190cdc177cbca835444691c50faa
The correct return when checking for the IMEI field availability
for non-admin users is DISABLED_FOR_USER.
UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.
Bug: 395714454
Flag: EXEMPT bugfix
Test: atest ImeiInfoPreferenceControllerTest
Test: atest MobileNetworkImeiPreferenceControllerTest
Change-Id: I4ee89a84953993daad539d33d3a2e576540c580f
Historically, this activity fragment had a "Format SD card for portable
storage" title string and the body text linked to
https://support.google.com/android/answer/12153449 which discusses
portable versus internal storage for SD cards.
For desktop Android, it is increasingly common to insert USB drives
instead of SD cards and the "portable versus internal" user decision is
less relevant here. This commit drops that link when not formatting an
SD card.
It also affects the title string, selecting between "Format SD card for
portable storage" and "Format USB drive". Some StorageWizardFoo activity
fragments' strings already made the SD card / USB drive distinction.
This commit makes it a little more consistent.
Bug: 373737145
Flag: EXEMPT minor fix
Test: manual
Change-Id: I3cf4b192e30566d5acb722b1d45cf14c5041706c
The loading of private volume UI items is async, these private volume UI items should not be displayed if user has switched to public volume.
Limit private volume UI items only visible for private volume.
Bug: 396043608
(cherry picked from https://android-review.googlesource.com/q/commit:1bfb959c1f14226231145a24624731650278af3a)
Merged-In: I5ea5cfb5d73f74cae33d780ed1f7f04fba870e32
Change-Id: I5ea5cfb5d73f74cae33d780ed1f7f04fba870e32
Flag: EXEMPT bug fix
* changes:
Phone number only available if telephony capable
Phone number only available for admin users
Added unit test for MobileNetworkPhoneNumberPreferenceController visibility
Added unit tests for PhoneNumberPreferenceController visibility
The Phone Number field in either the about or network details pages
should not be shown if the device does not have telephony
capabilities.
Bug: 392808943
Flag: EXEMPT bugfix
Test: atest PhoneNumberPreferenceControllerTest
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest
Change-Id: I04f682cc829d5dc7879e6cdacdaebc55a3b6fd2c
The phone number is hidden to non-admin users, following the same
reasoning that exists for other telephony-specific fields like the
baseband IMEI.
Bug: 392808943
Flag: EXEMPT bugfix
Test: atest PhoneNumberPreferenceControllerTest
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest
Change-Id: I4e612219d0c7439930e91b3e1d6e368a0dfd073e
Telephony callback may be removed in onPause during sim hotswap, but they are not re-registered in onResume for sub info still null.
Listen sub info change and re-register telephony callback when need.
Test: function test pass and SimStatusDialogControllerTest unit test pass.
Change-Id: I17e60c9e3441fc593107048494f830408c37ae61
Bug: 384643359
Formatter#formatBytes returns file size in units B/KB/MB/GB.
Talkback cannot handle unit size B. Use TtsSpan to return a CharSequence
for Talkback to announce this correctly in the Storage Settings page.
BUG: 317747133
Test: manual - open Storage settings page with Talkback feature on
Flag: EXEMPT bugfix
Change-Id: I65d0abb5a9ea358c116f84a85f0e42187998fd17
Phone type may be changed to CDMA if no SIM is in this sub and will not
show GSM settings in current design, so remove sub info check for
showing GSM settings.
Show GSM settings if the current radio can support both 3GPP and 3GPP2
radio technologies at the same time.
Bug: 278178437
Test: Manaul
Change-Id: I4f8cbfcdcff8f74944e2ba9a79b0945be6dd6ebd
Add the skeleton of About phone
Bug: 373001670
Test: atest MyDeviceInfoScreenTest
Flag: com.android.settings.flags.catalyst_my_device_info_pref_screen
Change-Id: I7799fa5fb82f9dd96959f1419108d15e7e4f7bb9
To align with SIM status, if no sim in this slot, show "Not available"
and disable instead.
Fix: 333386151
Flag: EXEMPT bug fix
Test: manual - on about phone
Test: unit test
Change-Id: I5053863cc69ff468036df87a8c87447ab0c2aaed
Add an error dialog to help user recover from biometric error for
for identity check while trying to factory reset
Flag: android.hardware.biometrics.flag.mandatory_biometrics
Bug: 358641110
Bug: 358179610
Test: atest MainClearTest
Change-Id: Ia20389a3146aa45ad42bdc4d31f1bd9488f2dc42
Which is not used after Change I37c7b3a4b5860323cb55581b23a90f583f4af216
Fix: 364129275
Flag: EXEMPT clean up
Test: robotests
Change-Id: I0db29c77a1dd938bff53df9e5f33c95cc0fbaad4
1. For biometric settings, request biometric prompt only after
successful credential verification and no auth request after
enrollment
2. Differentiate between mandatory biometrics ineffective error and
other biometric errors
Flag: android.hardware.biometrics.flags.mandatory_biometrics
Bug: 358176202
Bug: 358179610
Test: atest UtilsTest DevelopmentSettingsDashboardFragmentTest MainClearTest BuildNumberPreferenceControllerTest CombinedBiometricProfileSettingsTest
Change-Id: I778dd5403dd5ab64d8cc39bd88b22c4d39182e94
