'Start SettingsDumpService after the MobileNetworkRepository is
created' sends the intent every single time the
NetworkDashboardFragment is instantiated (basically every time user
opens the network dashboard in Settings).
SettingsDumpService's lifecycle never finishes, since it's context is
passed to the MobileNetworkRepository for singleton instance creation
which then proceeds to holding a reference to that context thus keeping
the entire service alive along with the application process, which
prevents the static singleton from being garbage collected creating an
indirect retention cycle. All that over time grows into a solid memory
leak.
SettingsDumpService (as well as MobileNetworkRepository instance,
obviously) proceed to dangling until the app process gets eventually
killed by the lmkd (which is unlikely to happen but still was observed
on several devices running stock ROM) or manually terminated by user,
but based on the observation, maximum time of dangling could be
perfectly equal to global system uptime.
This issue still remains all the way up to latest AOSP tags and betas,
although some vendors stock ROMs seem to have sorted it out.
Since we don't really care about dumping mobile network info
(especially in production builds), do the minimum changes required to
remove the dumping feature and avoid future AOSP merge conflicts.
This partially reverts commit d6f3ad9178.
Change-Id: Ifd7ded6cebd5f247cbdeb88035fdeb21cf060412
mIsInSetupWizard was moved to top of NetworkProviderSetting's onCreate
so it is available for addPreferences().
Change-Id: I9299c3033e96bcd30450ec239f14fb5daa800d63
- SatelliteManager#requestIsSupported only can be used in Manual
conneciton type. Hence add a type check with this API for the
condition check
Flag: EXEMPT bug fix
Fix: b/395811260
Test: atest pass
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d033f603b819c5b1264d116648c9f6f00b061320)
Merged-In: Ia9fed86a63dd8fa87cc20a83888b3cabbf28ddd8
Change-Id: Ia9fed86a63dd8fa87cc20a83888b3cabbf28ddd8
- When user clicks preference UI, show a dialog to nofity user
satellite session.
Flag: EXEMPT bug fix
Fix: b/402544816
Test: atest pass
Test: Manual test
Change-Id: Ifeff9368fed906bc56abcc8eb23748a71f79ee4d
- When satellite entitlement is unsupported, it shall show the category of Your data plan with Manual connection type.
Flag: EXEMPT bug fix
Fix: b/405250203
Test: atest pass
Change-Id: I91c5be123d59753d93db37226d0ae17ebb5ea1f5
If there is no active esim and the active esim slot, then enabling esim
uses the active esim slot's port.
Bug: 394758842
Test: manual test
Flag: EXEMPT bugfix
Change-Id: Icd478a92662584d433e16b129da98204e9e2f5f3
- Use SatelliteManager#getSatelliteDataSupportMode() to check data
restricted or not.
Flag: EXEMPT bug fix
Bug: b/401043401
Test: atest pass
Test: Manual test
Change-Id: I6f3e25610717eca0f6e871a9e1158422659058ea
- Use controller base design instead of current
Flag: EXEMPT bug fix
Bug: b/401648126
Fix: b/402037025
Test: Manual test
Test: atest pass
Change-Id: Icb3fd6a1c5340e554593fc57cb238bf98d3ed0e3
Adds IPAddress, Mac address, RX/TX Speed and Metering options to the
settings sub page.
Flag: com.android.settings.connectivity.ethernet_settings
Test: atest SettingsRoboTests:
com.android.settings.network.NetworkProviderSettingsTest
Bug: 390709492
Change-Id: I9a310f94037e089f3d57ff36f77b88edbb0ee1f1
By removing PreferenceScreenBinding, PreferenceScreenMetadata with not
Preference entry point is greatly simplified.
NO_IFTTT=Catalyst only
Bug: 388167106
Flag: EXEMPT refactor
Test: manual
Change-Id: Ie62313c9c6737a4aad8e363f947a68eada4393f5
The entry is hidden either via the build-time
config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag.
Bug: 399208058
Test: mm && atest NetworkResetPreferenceControllerTest
Flag: EXEMPT bugfix
Change-Id: I178a0cae9d4ffd1ea4492a6b1feca697373d6e20
If the phone process has died, Settings cannot make calls to
TelephonyManager. Update the handling of this case to new best
practices.
Bug: b/394077023
Test: m & atest CellularSecurityPreferenceController
Flag: EXEMPT bugfix
Change-Id: I64ecb143d0830873b590ce4a397c398d8b41943f
The UI flicker is because preference change is notified twice after
onActivityResult calls setBoolean: 1) Catalyst framework registers a
common listener on each preference's storage to update UI when
preference value is changed. 2) The PhoneStateListener in
AirplaneModeStorage. Remove the second listener fixes the issue.
NO_IFTTT=Catalyst only
Fix: 395774878
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I9f93faf1da87d52a82d9019361b17b4b500d79fe
