Commit Graph

1758 Commits

Author SHA1 Message Date
TreeHugger Robot
8caac569be Merge "Fix broken links in @ChangeId javadoc." 2020-01-17 12:49:49 +00:00
Mathew Inwood
5800245d1b Fix broken links in @ChangeId javadoc.
We will soon have javadoc generated from the doc comments on all
@ChangeId annotated constants. Since the link target referred to
here is a @hide constant, it cannot be resolved as part of DAC doc
generation. Replace it with {@code} specifying the constants value
instead.

Bug: 144927670
Test: In follow up CLs
Change-Id: I9947e722dca228705190e8f2c49e47104c04dea6
2020-01-17 11:22:52 +00:00
Betty Chang
af2e3afb04 Merge "[Mainline] Copy the findBestComponent method from EuiccConnector to Settings" 2020-01-17 03:27:32 +00:00
Bonian Chen
66349e21c3 Merge "[Mainline] Use @SystemApi constants in SmsManager instead of in SmsUsageMonitor" 2020-01-16 20:13:37 +00:00
changbetty
bbc757e01a [Mainline] Copy the findBestComponent method from EuiccConnector to Settings
Make a copy of EuiccConnector#findBestComponent() into local method findEuiccService().

Bug: 147275124
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ApplicationFeatureProviderImplTest
Change-Id: Ie81569d940fc354053469570e1506b1954d9f24d
2020-01-16 20:46:06 +08:00
Edgar Wang
e19ee9a01f Revert "Settings search - Navigate user to exact page"
This reverts commit 08f2a58459.

Reason for revert: design changed, we decide to take the user to
the entry after clicking on a search result.
It's opposite with what we did, so we revert related CL first.

Test: robotest

Change-Id: Iadb9a94a7ef7838be34a54499e2d934d6396c336
2020-01-16 14:07:38 +08:00
changbetty
64b8981502 [Mainline] Use @SystemApi constants in SmsManager instead of in SmsUsageMonitor
Bug: 146808981
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PremiumSmsAccessTest
Change-Id: I7dd74a390e9a69ad71d83a0db07bef979fab7f1d
2020-01-16 11:27:22 +08:00
Betty Chang
d60c780c0d Merge "[Mainline] Use SmsManager method instead of ISms" 2020-01-14 03:51:34 +00:00
changbetty
04a3ef6e67 [Mainline] Use SmsManager method instead of ISms
Bug: 146808981
Test: make
Change-Id: I388f9e9979ce9d83d7e3daf510c9dcb3303cc5c7
2020-01-13 16:15:03 +08:00
Raff Tsai
4536fae5b7 Fix work tab app doesn't launch correct user intent
- Pass user.getIndentifier() to intent

Fixes: 147357696
Test: 1. go to Settings -> Storage -> Music&Audio
      2. switch to work tab
      3. tab "Audio files"
      4. should display work profile files

Change-Id: I0d2883c45eb7b883adbaf034c0a49c5e52ba82f6
2020-01-11 09:16:24 +08:00
Shafik Nassar
2751c43f1d Merge "Add settings UI for MANAGE_EXTERNAL_STORAGE" 2020-01-08 11:54:18 +00:00
shafik
430b94bbc1 Add settings UI for MANAGE_EXTERNAL_STORAGE
Adds a Special App Access setting for the app-op
OP_MANAGE_EXTERNAL_STORAGE. All apps requesting the corresponding
permission will be displayed in the settings page. Toggling the
preference switch for an app will grant/revoke the app-op.

All of the external references to the permission, app-op and their
corresponding activities and logic use the name "Manage External
Storage". All of the external displays and strings use the name "All
files access"

Test: * Install app with uses-permission MANAGE_EXTERNAL_STORAGE
      * Observe it appearing the All files access page
      * Toggle the switch and observe the change in
        'adb shell dumpsys appops'
Bug: 146425146

Change-Id: If5c9c5daa3616a3310c090283acfda933bf9df26
2020-01-08 09:24:25 +00:00
Jason Chiu
2d609759cd Add preference click metric logs for some special cases
Bug: 137559984
Test: visual, robotest
Change-Id: If8624b49abcd0000487065160ce4a7ba861f234c
2020-01-02 17:45:23 +08:00
Edgar Wang
08f2a58459 Settings search - Navigate user to exact page
- remove duplicate index preference
- default set searchable = false when the preference has fragment
- make some fragments indexable

Bug: 143057584
Test: robotest & manual

Change-Id: I4d64f6106d2f92f0a45e8c7e26388677f593f412
2019-12-24 21:04:11 +08:00
Philip P. Moltmann
b4e5b0bd78 Merge "Adjust to changed internal API" 2019-12-20 03:04:55 +00:00
Bernardo Rufino
9e32620854 Report if app-specific SAW intent
Log using PlatformCompat framework if the app tried to deep-link into
the app-specific screen for managing SAW permission.

Bug: 146327570
Bug: 135920175
Test: 1. adb shell am start -a
android.settings.action.MANAGE_OVERLAY_PERMISSION -d package:com.foo.bar
      2. adb logcat -s -v color CompatibilityChangeReporter:*
      3. Verify compat change id reported 135920175 and state LOGGED

Change-Id: I1d6c571d524d70c11156aeea27a8800d2a0ba42b
2019-12-17 14:49:00 +00:00
Raff Tsai
1e5d8146b5 Change ProfileType definition
Bug: 141601408
Test: rebuild
Change-Id: Ia4d4fabe8a4daad4ce54c243748fa3c29bf944ba
2019-12-12 13:44:35 +08:00
Raff Tsai
c75aea1552 Change tab text to sentense text
- Also remove duplicated string

Bug: 141601408
Test: manual
Change-Id: I840bdf4c12ca6d815d7c54092aa32a40c80d95e0
2019-12-11 15:38:12 +08:00
Philip P. Moltmann
cdc8c101eb Adjust to changed internal API
Test: Built
Bug: 144997947
Change-Id: Ib988b85992800223c81e2f729150150ea195a98b
2019-12-08 19:26:51 -08:00
TreeHugger Robot
7e117fba33 Merge "Reorganize notification Settings classes" 2019-12-02 13:54:05 +00:00
TreeHugger Robot
09abaa93dd Merge "Hide PIP related preference when device didn't support this feature" 2019-12-02 08:01:28 +00:00
Edgar Wang
334c5b36ad Hide PIP related preference when device didn't support this feature
Fixes: 79945310
Test: atest & manual
Change-Id: I24b9de06ec94a008656cbbc016a50a4e217fece1
2019-12-02 15:01:32 +08:00
Julia Reynolds
aceccce75c Reorganize notification Settings classes
The notification package was getting too big.

Test: make -j64 RunSettingsRoboTests
Fixes: 145224451
Change-Id: I25ba82f42f7a137d8adcce72dcf8089d0e018bdc
2019-11-27 10:02:13 -05:00
Raff Tsai
84327f6aa3 Add storage_summary_donut above ProfileSelectStorageFragment
- Modify ProfileSelectFragment to support add preference xml in the
top, and tabLayout below the preferences. Base preference layout is
dummy_preference_screen.xml which contains no preference.
ProfileSelectStorageFragment contains StorageSummaryDonutPreference
above the tabLayout.
- Make StorageSummaryDonutPreferenceController self workable without
StorageDashboardFragment dependence.
- Rename inactive_apps.xml to dummy_preference_screen.xml
- Move ShadowPrivateStorageInfo from LowStorageSliceTest

Bug: 141601408
Test: manual
Change-Id: Ide12840dc81bb104f328e230ecda5d35bba01d7a
2019-11-18 18:18:29 +08:00
Julia Reynolds
9540929cfe Merge "Add NLS specific screens for notification listener approval" 2019-11-13 14:02:39 +00:00
Raff Tsai
16a81eb3f6 Sync lastest lifecycle interface
Bug: 142938506
Test: rebuild
Change-Id: I6a8d75e5a3ba8564cfb400a88d6582c962c965ee
2019-11-11 16:19:07 +08:00
Jay Aliomer
b499cc5643 Merge "Don't disable DND permission settings for apps that have disabled NLS" 2019-11-08 16:38:12 +00:00
Jay Aliomer
8754d40124 Don't disable DND permission settings for apps that have disabled NLS
ZenAccessController.getPackagesRequestingNotificationPolicyAccess
was including disabled packages.
We change this behavior to exclude any disabled package

Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.applications.specialaccess.zenaccess.ZenAccessControllerTest"
Change-Id: I354b8f0bdbf602d1f35233d5003ce09f01df3cb2
Fix: 141318822
2019-11-08 16:21:15 +00:00
Julia Reynolds
31dc1fd806 Add NLS specific screens for notification listener approval
Fixes: 141689199
Fixes: 143639217
Test: atest

Change-Id: I4ead087e0015ad33d6be4f9357de50a4298b3347
2019-11-08 14:13:24 +00:00
Edgar Wang
44187c0bb3 Restrict user to clear app defaults when DISALLOW_APPS_CONTROL policy is enabled.
- In App Info -> Open by defult -> Other defaults -> Clear defaults
   User should not able to clear app defaults when DISALLOW_APPS_CONTROL
   policy is enabled

Fixes: 140934406
Test: manual & robotest
Change-Id: Ia1aea3846d96b6faf9a1953101bafa4d2992322b
2019-10-30 14:18:51 +08:00
Tsung-Mao Fang
327dba2488 Fix UI janky in privacy settings
Set a summary holder for initial preference at the biginning.
If there is no any permission granted, then set a string for it.

Test: Rebuild, visual
Fixes: 140783222
Change-Id: Ic5f2730123110bad5fbc08fcd22b1df564b8637d
2019-10-28 18:39:11 +08:00
TreeHugger Robot
5f1a837af5 Merge "Add work/personal profile tab for storage page" 2019-10-25 11:02:01 +00:00
Raff Tsai
539ab8ace4 Add work/personal profile tab for storage page
- Add ProfileSelectStorageFragment
- Check featureFlag in SecondaryUserController to decide show/hide
workprofile item StorageDashboardFragment

Bug: 141601408
Test: manual
Change-Id: I97762d3b1a4985e2b186b34fc37c7976c2f69224
2019-10-25 16:57:24 +08:00
Raff Tsai
52ee4888be Modify Running Services layout
- Also remove some unused resource

Fixes: 139911198
Test: manual
Change-Id: I70447255df822c5b2a940ecbc3f2fa27707c660b
Screenshot: https://screenshot.googleplex.com/jBEdhunufTb
2019-10-25 10:42:35 +08:00
Raff Tsai
062baadf4e Merge "Add personal/work tab for ManageApplications" 2019-10-22 23:47:32 +00:00
Philip P. Moltmann
0b0a500833 Switch to new internal API
Test: atest RunSettingsRoboTests
Change-Id: I2ecfa651031bcb431f28d55512cf93c442686d71
2019-10-17 09:01:24 -07:00
Raff Tsai
afd494d335 Add personal/work tab for ManageApplications
- Add ProfileSelectManageApplications containing tabLayout
- Modify StorageItemPreferenceController to display only personal
or work profile data
- Add getTargetFragment in Utils to handle fragment selection

Bug: 141601408
Test: manual
Change-Id: Ie4db1ce2e77f60a82018e5a3e1f2fccb812502dc
2019-10-16 17:08:31 +08:00
Raff Tsai
6ff13962a3 Fix talkback issue
Fixes: 141226569
Test: manual
Change-Id: I631554ab33d6cc77f3d3f2e4625d359a802dd5b5
2019-10-04 11:59:56 +08:00
Raff Tsai
129c98bba1 Remove summary loader in some fragments
- Summary Loader only works in injected items, but those fragments
are not injected to Settings UI. The SummaryLoader class them are
useless.

Bug: 141653158
Test: robolectric
Change-Id: I1ca0bf5a1f417b7fe86b28e96aff7d4aee2cf2d3
2019-10-01 10:02:26 +08:00
Raff Tsai
966fa01423 Use SettingsLib Indexable
- Use SettingsLib Indexable
- Directly use resource id in getPreferenceScreenResId

Bug: 135053028
Test: roboletric
Change-Id: I05f493b55e8b6e2091301e9231ba5615215618e6
2019-09-25 18:24:56 +08:00
Raff Tsai
ac3e0d0988 Directly use BaseIndexableProvider
- Add function getXmlResourceId, Fragments don't need to write
xml resource id twice.
- Remove getPreferenceControllers from Indexable.java. Because it will
move to SettingsLib later for other apps which don't need this function

Bug: 135053028
Test: robolectric
Change-Id: I1e74519aecdea3dde64a5aea79f08d766dbc0003
2019-09-24 00:35:52 +08:00
Raff Tsai
1f30b1cd67 Merge similar BaseSearchIndexProvider code together
Bug: 135053028
Test: robolectric, check search_index.db contains the same items
Change-Id: If3c18a170b0e671690df1fdf26e59a421d2c48cd
2019-09-12 11:09:09 +08:00
TreeHugger Robot
cea963b4ab Merge "Add RoleControllerManager.isApplicationVisibleForRole()." 2019-08-28 11:19:51 +00:00
Sunny Shao
b47cccf6a0 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the DeviceAdminSettings page.

Fixes: 140015273
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.applications
Change-Id: I91c10946ae35f9a5cde30399e231dbc8a1481b23
2019-08-27 10:41:13 +08:00
Hai Zhang
51b76855f9 Add RoleControllerManager.isApplicationVisibleForRole().
Settings doesn't actually need to know whether an application
qualifies for a role, but only whether the default app setting should
be visible for an application. Qualification and visibility differs in
cases such as FallbackHome inside Settings which is a qualifying home
activity but should never be shown in default apps UI.

Fixes: 138636320
Test: manual
Change-Id: I2995b6fa5c7920d14fa644748db9c41b442ce53b
2019-08-26 14:23:44 -07:00
Sunny Shao
6e21c76111 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ManageAssist page.

Fixes: 139457944
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.applications
Change-Id: I89b6cac21e924774a1fcfe790863d8eaab8d6da7
2019-08-15 15:56:10 +08:00
TreeHugger Robot
e69ef50ba2 Merge "Make EuiccService un-disable-able." 2019-08-06 14:56:22 +00:00
Yi-Ling Chuang
7e2978ab58 Make EuiccService un-disable-able.
Disabling the eSIM Manager could leave the device in a bad state, unable
to address the eSIM, and possibly crash due to EuiccConnector failing to
find an LPA to implement EuiccService. So here we do not allow users to
disable this component.

Fixes: 135644632
Test: robotest
Change-Id: Ia4ea48b449f121edaff10531b7c975b09432a8f8
2019-08-06 17:58:08 +08:00
Stanley Wang
2862e79478 Merge "Revert "Fix app uninstalling/stopping possible in screen pinning mode"" 2019-08-06 06:17:11 +00:00
Stanley Wang
064b21e0b6 Revert "Fix app uninstalling/stopping possible in screen pinning mode"
This reverts commit 161c359508.

Reason for revert: This solution has a bug.

Change-Id: I925dab9b1a8d50de538a4fc652f722744fe3fadf
2019-08-06 03:44:02 +00:00